[INFO] updating cached repository udel-cbcb/iptmnet_api [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/udel-cbcb/iptmnet_api [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/udel-cbcb/iptmnet_api" "work/ex/clippy-test-run/sources/stable/gh/udel-cbcb/iptmnet_api"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/udel-cbcb/iptmnet_api'... [INFO] [stderr] done. [INFO] [stderr] Checking out files: 25% (18/70) Checking out files: 27% (19/70) Checking out files: 28% (20/70) Checking out files: 30% (21/70) Checking out files: 31% (22/70) Checking out files: 32% (23/70) Checking out files: 34% (24/70) Checking out files: 35% (25/70) Checking out files: 37% (26/70) Checking out files: 38% (27/70) Checking out files: 40% (28/70) Checking out files: 41% (29/70) Checking out files: 42% (30/70) Checking out files: 44% (31/70) Checking out files: 45% (32/70) Checking out files: 47% (33/70) Checking out files: 48% (34/70) Checking out files: 50% (35/70) Checking out files: 51% (36/70) Checking out files: 52% (37/70) Checking out files: 54% (38/70) Checking out files: 55% (39/70) Checking out files: 57% (40/70) Checking out files: 58% (41/70) Checking out files: 60% (42/70) Checking out files: 61% (43/70) Checking out files: 62% (44/70) Checking out files: 64% (45/70) Checking out files: 65% (46/70) Checking out files: 67% (47/70) Checking out files: 68% (48/70) Checking out files: 70% (49/70) Checking out files: 71% (50/70) Checking out files: 72% (51/70) Checking out files: 74% (52/70) Checking out files: 75% (53/70) Checking out files: 77% (54/70) Checking out files: 78% (55/70) Checking out files: 80% (56/70) Checking out files: 81% (57/70) Checking out files: 82% (58/70) Checking out files: 84% (59/70) Checking out files: 85% (60/70) Checking out files: 87% (61/70) Checking out files: 88% (62/70) Checking out files: 90% (63/70) Checking out files: 91% (64/70) Checking out files: 92% (65/70) Checking out files: 94% (66/70) Checking out files: 95% (67/70) Checking out files: 97% (68/70) Checking out files: 98% (69/70) Checking out files: 100% (70/70) Checking out files: 100% (70/70), done. [INFO] running `"git" "clone" "work/cache/sources/gh/udel-cbcb/iptmnet_api" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udel-cbcb/iptmnet_api"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udel-cbcb/iptmnet_api'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 29fdf0cb9f0516dfb5874e41e889c9a1da15db8a [INFO] sha for GitHub repo udel-cbcb/iptmnet_api: 29fdf0cb9f0516dfb5874e41e889c9a1da15db8a [INFO] validating manifest of udel-cbcb/iptmnet_api on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of udel-cbcb/iptmnet_api on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing udel-cbcb/iptmnet_api [INFO] finished frobbing udel-cbcb/iptmnet_api [INFO] frobbed toml for udel-cbcb/iptmnet_api written to work/ex/clippy-test-run/sources/stable/gh/udel-cbcb/iptmnet_api/Cargo.toml [INFO] started frobbing udel-cbcb/iptmnet_api [INFO] finished frobbing udel-cbcb/iptmnet_api [INFO] frobbed toml for udel-cbcb/iptmnet_api written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udel-cbcb/iptmnet_api/Cargo.toml [INFO] crate udel-cbcb/iptmnet_api has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting udel-cbcb/iptmnet_api against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/udel-cbcb/iptmnet_api:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 21addb48837c6b3d2b624a2ca5d6f107964aeb0c35a38c76ad4e031057d42cd3 [INFO] running `"docker" "start" "-a" "21addb48837c6b3d2b624a2ca5d6f107964aeb0c35a38c76ad4e031057d42cd3"` [INFO] [stderr] Compiling nodrop v0.1.12 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Compiling libc v0.2.39 [INFO] [stderr] Compiling lazy_static v0.2.11 [INFO] [stderr] Compiling memoffset v0.2.1 [INFO] [stderr] Compiling rustc-demangle v0.1.7 [INFO] [stderr] Compiling lazy_static v1.0.0 [INFO] [stderr] Compiling itoa v0.4.1 [INFO] [stderr] Compiling same-file v0.1.3 [INFO] [stderr] Compiling remove_dir_all v0.5.0 [INFO] [stderr] Checking arrayref v0.3.4 [INFO] [stderr] Compiling bytecount v0.2.0 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking constant_time_eq v0.1.3 [INFO] [stderr] Checking memoffset v0.1.0 [INFO] [stderr] Checking fallible-iterator v0.1.4 [INFO] [stderr] Checking untrusted v0.5.1 [INFO] [stderr] Compiling bv v0.7.4 [INFO] [stderr] Compiling ndarray v0.9.1 [INFO] [stderr] Checking hex v0.2.0 [INFO] [stderr] Checking indexmap v1.0.0 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking http-range v0.1.1 [INFO] [stderr] Checking try_from v0.2.2 [INFO] [stderr] Checking termcolor v0.3.5 [INFO] [stderr] Checking bytecount v0.3.1 [INFO] [stderr] Checking rust-ini v0.10.3 [INFO] [stderr] Checking inner v0.1.1 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling oracle v0.0.8 [INFO] [stderr] Checking hostname v0.1.4 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Compiling actix_derive v0.2.0 [INFO] [stderr] Checking socket2 v0.3.4 [INFO] [stderr] Compiling crossbeam-utils v0.2.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking tokio-executor v0.1.0 [INFO] [stderr] Compiling arrayvec v0.4.7 [INFO] [stderr] Compiling walkdir v1.0.7 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Checking bit-set v0.4.0 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking resolv-conf v0.6.0 [INFO] [stderr] Checking crossbeam-epoch v0.2.0 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling newtype_derive v0.1.6 [INFO] [stderr] Compiling crossbeam-epoch v0.3.0 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking http v0.1.5 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking mio-uds v0.6.4 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Compiling serde_derive_internals v0.21.0 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling backtrace v0.3.5 [INFO] [stderr] Checking tokio-threadpool v0.1.0 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking itertools-num v0.1.1 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Checking tokio-reactor v0.1.0 [INFO] [stderr] Checking env_logger v0.5.6 [INFO] [stderr] Checking crossbeam-channel v0.1.2 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking digest v0.7.2 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.33 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking tokio v0.1.3 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Checking sha2 v0.7.0 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking h2 v0.1.2 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking tokio-core v0.1.15 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Compiling failure_derive v0.1.1 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Compiling serde v1.0.33 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking postgres-shared v0.4.1 [INFO] [stderr] Checking trust-dns-proto v0.3.2 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking trust-dns-resolver v0.8.1 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Compiling serde_json v1.0.13 [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking multimap v0.4.0 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Checking bio v0.21.0 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Compiling actix v0.5.5 [INFO] [stderr] Compiling actix-web v0.5.1 [INFO] [stderr] Checking iptmnet_api v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:392:9 [INFO] [stderr] | [INFO] [stderr] 392 | organism: organism, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `organism` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:393:9 [INFO] [stderr] | [INFO] [stderr] 393 | pro: pro, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pro` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:826:9 [INFO] [stderr] | [INFO] [stderr] 826 | residue: residue, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `residue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:827:9 [INFO] [stderr] | [INFO] [stderr] 827 | site: site, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:828:9 [INFO] [stderr] | [INFO] [stderr] 828 | ptm_type: ptm_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ptm_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:830:9 [INFO] [stderr] | [INFO] [stderr] 830 | sources: sources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sources` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:831:9 [INFO] [stderr] | [INFO] [stderr] 831 | enzymes: enzymes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `enzymes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:832:9 [INFO] [stderr] | [INFO] [stderr] 832 | pmids: pmids [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:903:13 [INFO] [stderr] | [INFO] [stderr] 903 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:904:13 [INFO] [stderr] | [INFO] [stderr] 904 | pmids: pmids [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:961:13 [INFO] [stderr] | [INFO] [stderr] 961 | relation: relation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `relation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:963:13 [INFO] [stderr] | [INFO] [stderr] 963 | pmids: pmids, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1129:13 [INFO] [stderr] | [INFO] [stderr] 1129 | pmids: pmids, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1130:13 [INFO] [stderr] | [INFO] [stderr] 1130 | score: score [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1221:9 [INFO] [stderr] | [INFO] [stderr] 1221 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1256:13 [INFO] [stderr] | [INFO] [stderr] 1256 | is_conserved: is_conserved [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_conserved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1285:9 [INFO] [stderr] | [INFO] [stderr] 1285 | is_conserved: is_conserved [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_conserved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | ptm_enzyme_id: ptm_enzyme_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ptm_enzyme_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | ptm_enzyme_label: ptm_enzyme_label, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ptm_enzyme_label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | protein_1_pro_id: protein_1_pro_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protein_1_pro_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | protein_1_label: protein_1_label, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protein_1_label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | protein_2_pro_id: protein_2_pro_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protein_2_pro_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:392:9 [INFO] [stderr] | [INFO] [stderr] 392 | organism: organism, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `organism` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:393:9 [INFO] [stderr] | [INFO] [stderr] 393 | pro: pro, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pro` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:826:9 [INFO] [stderr] | [INFO] [stderr] 826 | residue: residue, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `residue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:827:9 [INFO] [stderr] | [INFO] [stderr] 827 | site: site, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:828:9 [INFO] [stderr] | [INFO] [stderr] 828 | ptm_type: ptm_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ptm_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:830:9 [INFO] [stderr] | [INFO] [stderr] 830 | sources: sources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sources` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:831:9 [INFO] [stderr] | [INFO] [stderr] 831 | enzymes: enzymes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `enzymes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/flatten.rs:229:13 [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/database.rs:832:9 [INFO] [stderr] 229 | protein_2_label: protein_2_label, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protein_2_label` [INFO] [stderr] 832 | pmids: pmids [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:903:13 [INFO] [stderr] | [INFO] [stderr] 903 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:904:13 [INFO] [stderr] | [INFO] [stderr] 904 | pmids: pmids [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:961:13 [INFO] [stderr] | [INFO] [stderr] 961 | relation: relation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `relation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:963:13 [INFO] [stderr] | [INFO] [stderr] 963 | pmids: pmids, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1129:13 [INFO] [stderr] | [INFO] [stderr] 1129 | pmids: pmids, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1130:13 [INFO] [stderr] | [INFO] [stderr] 1130 | score: score [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | substrate_uniprot_id: substrate_uniprot_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substrate_uniprot_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | substrate_name: substrate_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substrate_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | interactant_uniprot_id: interactant_uniprot_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactant_uniprot_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | interactant_name: interactant_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactant_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | enz_id: enz_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `enz_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | enz_name: enz_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `enz_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | sub_id: sub_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sub_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | sub_name: sub_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:411:13 [INFO] [stderr] | [INFO] [stderr] 411 | interactant_name: interactant_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactant_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | substrate_name: substrate_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substrate_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msa.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | site: site, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msa.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msa.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | decorations: decorations [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `decorations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1221:9 [INFO] [stderr] | [INFO] [stderr] 1221 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1256:13 [INFO] [stderr] | [INFO] [stderr] 1256 | is_conserved: is_conserved [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_conserved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:1285:9 [INFO] [stderr] | [INFO] [stderr] 1285 | is_conserved: is_conserved [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_conserved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | ptm_enzyme_id: ptm_enzyme_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ptm_enzyme_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | ptm_enzyme_label: ptm_enzyme_label, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ptm_enzyme_label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | protein_1_pro_id: protein_1_pro_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protein_1_pro_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | protein_1_label: protein_1_label, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protein_1_label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | protein_2_pro_id: protein_2_pro_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protein_2_pro_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | protein_2_label: protein_2_label, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protein_2_label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | substrate_uniprot_id: substrate_uniprot_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substrate_uniprot_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | substrate_name: substrate_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substrate_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | interactant_uniprot_id: interactant_uniprot_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactant_uniprot_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | interactant_name: interactant_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactant_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | enz_id: enz_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `enz_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | enz_name: enz_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `enz_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | sub_id: sub_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sub_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | sub_name: sub_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:411:13 [INFO] [stderr] | [INFO] [stderr] 411 | interactant_name: interactant_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactant_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flatten.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | substrate_name: substrate_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substrate_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msa.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | site: site, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msa.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msa.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | decorations: decorations [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `decorations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return HttpResponse::Ok().force_close().body(status_serialized); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().body(status_serialized)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:327:29 [INFO] [stderr] | [INFO] [stderr] 327 | / return HttpResponse::Ok() [INFO] [stderr] 328 | | .force_close() [INFO] [stderr] 329 | | .header(http::header::CONTENT_TYPE, "text/csv") [INFO] [stderr] 330 | | .header("count", count.to_string()) [INFO] [stderr] 331 | | .body(data); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 327 | HttpResponse::Ok() [INFO] [stderr] 328 | .force_close() [INFO] [stderr] 329 | .header(http::header::CONTENT_TYPE, "text/csv") [INFO] [stderr] 330 | .header("count", count.to_string()) [INFO] [stderr] 331 | .body(data) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:335:29 [INFO] [stderr] | [INFO] [stderr] 335 | / return HttpResponse::InternalServerError() [INFO] [stderr] 336 | | .force_close() [INFO] [stderr] 337 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 338 | | .body(format!("{}",error)); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 335 | HttpResponse::InternalServerError() [INFO] [stderr] 336 | .force_close() [INFO] [stderr] 337 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 338 | .body(format!("{}",error)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | / return HttpResponse::BadRequest() [INFO] [stderr] 343 | | .force_close() [INFO] [stderr] 344 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 345 | | .body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 342 | HttpResponse::BadRequest() [INFO] [stderr] 343 | .force_close() [INFO] [stderr] 344 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 345 | .body(format!("Invalid ACCEPT header - {}",content_header)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:571:29 [INFO] [stderr] | [INFO] [stderr] 571 | / return HttpResponse::Ok() [INFO] [stderr] 572 | | .force_close() [INFO] [stderr] 573 | | .header(http::header::CONTENT_TYPE, "text/csv") [INFO] [stderr] 574 | | .header("count", count.to_string()) [INFO] [stderr] 575 | | .body(data); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 571 | HttpResponse::Ok() [INFO] [stderr] 572 | .force_close() [INFO] [stderr] 573 | .header(http::header::CONTENT_TYPE, "text/csv") [INFO] [stderr] 574 | .header("count", count.to_string()) [INFO] [stderr] 575 | .body(data) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:579:29 [INFO] [stderr] | [INFO] [stderr] 579 | / return HttpResponse::InternalServerError() [INFO] [stderr] 580 | | .force_close() [INFO] [stderr] 581 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 582 | | .body(format!("{}",error)); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 579 | HttpResponse::InternalServerError() [INFO] [stderr] 580 | .force_close() [INFO] [stderr] 581 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 582 | .body(format!("{}",error)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:586:17 [INFO] [stderr] | [INFO] [stderr] 586 | / return HttpResponse::BadRequest() [INFO] [stderr] 587 | | .force_close() [INFO] [stderr] 588 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 589 | | .body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 586 | HttpResponse::BadRequest() [INFO] [stderr] 587 | .force_close() [INFO] [stderr] 588 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 589 | .body(format!("Invalid ACCEPT header - {}",content_header)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:645:25 [INFO] [stderr] | [INFO] [stderr] 645 | / return HttpResponse::InternalServerError() [INFO] [stderr] 646 | | .force_close() [INFO] [stderr] 647 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 648 | | .body(format!("{}",error)); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 645 | HttpResponse::InternalServerError() [INFO] [stderr] 646 | .force_close() [INFO] [stderr] 647 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 648 | .body(format!("{}",error)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:688:25 [INFO] [stderr] | [INFO] [stderr] 688 | return HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/csv").body(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/csv").body(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:692:25 [INFO] [stderr] | [INFO] [stderr] 692 | / return HttpResponse::InternalServerError() [INFO] [stderr] 693 | | .force_close() [INFO] [stderr] 694 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 695 | | .body(format!("{}",error)); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 692 | HttpResponse::InternalServerError() [INFO] [stderr] 693 | .force_close() [INFO] [stderr] 694 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 695 | .body(format!("{}",error)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | return HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:746:25 [INFO] [stderr] | [INFO] [stderr] 746 | return HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:780:25 [INFO] [stderr] | [INFO] [stderr] 780 | return HttpResponse::Ok().force_close().body(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().body(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:784:25 [INFO] [stderr] | [INFO] [stderr] 784 | return HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:788:17 [INFO] [stderr] | [INFO] [stderr] 788 | return HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:868:25 [INFO] [stderr] | [INFO] [stderr] 868 | return HttpResponse::Ok().force_close().body(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().body(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:872:25 [INFO] [stderr] | [INFO] [stderr] 872 | return HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:876:17 [INFO] [stderr] | [INFO] [stderr] 876 | return HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:954:29 [INFO] [stderr] | [INFO] [stderr] 954 | return HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:958:29 [INFO] [stderr] | [INFO] [stderr] 958 | return HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:962:17 [INFO] [stderr] | [INFO] [stderr] 962 | return HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1027:33 [INFO] [stderr] | [INFO] [stderr] 1027 | return Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "application/json").body(ptm_enzymes_serialized)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "application/json").body(ptm_enzymes_serialized))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1030:33 [INFO] [stderr] | [INFO] [stderr] 1030 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1063:37 [INFO] [stderr] | [INFO] [stderr] 1063 | return Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1067:37 [INFO] [stderr] | [INFO] [stderr] 1067 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1071:25 [INFO] [stderr] | [INFO] [stderr] 1071 | return Ok(HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1075:21 [INFO] [stderr] | [INFO] [stderr] 1075 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1126:33 [INFO] [stderr] | [INFO] [stderr] 1126 | return Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "application/json").body(ptm_ppis_serialized)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "application/json").body(ptm_ppis_serialized))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1129:33 [INFO] [stderr] | [INFO] [stderr] 1129 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1162:37 [INFO] [stderr] | [INFO] [stderr] 1162 | return Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1166:37 [INFO] [stderr] | [INFO] [stderr] 1166 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1170:25 [INFO] [stderr] | [INFO] [stderr] 1170 | return Ok(HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1174:21 [INFO] [stderr] | [INFO] [stderr] 1174 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1205:5 [INFO] [stderr] | [INFO] [stderr] 1205 | return HttpResponse::Ok().force_close().body(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().body(contents)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1233:37 [INFO] [stderr] | [INFO] [stderr] 1233 | / return HttpResponse::Ok() [INFO] [stderr] 1234 | | .force_close() [INFO] [stderr] 1235 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1236 | | .body(alignment_serialized); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1233 | HttpResponse::Ok() [INFO] [stderr] 1234 | .force_close() [INFO] [stderr] 1235 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1236 | .body(alignment_serialized) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1240:37 [INFO] [stderr] | [INFO] [stderr] 1240 | / return HttpResponse::Ok() [INFO] [stderr] 1241 | | .force_close() [INFO] [stderr] 1242 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1243 | | .body(error_msg); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1240 | HttpResponse::Ok() [INFO] [stderr] 1241 | .force_close() [INFO] [stderr] 1242 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1243 | .body(error_msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1249:29 [INFO] [stderr] | [INFO] [stderr] 1249 | / return HttpResponse::Ok() [INFO] [stderr] 1250 | | .force_close() [INFO] [stderr] 1251 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1252 | | .body(error_msg); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1249 | HttpResponse::Ok() [INFO] [stderr] 1250 | .force_close() [INFO] [stderr] 1251 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1252 | .body(error_msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1258:21 [INFO] [stderr] | [INFO] [stderr] 1258 | / return HttpResponse::InternalServerError() [INFO] [stderr] 1259 | | .force_close() [INFO] [stderr] 1260 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1261 | | .body(error_msg); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1258 | HttpResponse::InternalServerError() [INFO] [stderr] 1259 | .force_close() [INFO] [stderr] 1260 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1261 | .body(error_msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1268:13 [INFO] [stderr] | [INFO] [stderr] 1268 | / return HttpResponse::InternalServerError() [INFO] [stderr] 1269 | | .force_close() [INFO] [stderr] 1270 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1271 | | .body(error_msg); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1268 | HttpResponse::InternalServerError() [INFO] [stderr] 1269 | .force_close() [INFO] [stderr] 1270 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1271 | .body(error_msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/router.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | / return Cors::for_app(application) [INFO] [stderr] 7 | | .send_wildcard() [INFO] [stderr] 8 | | .resource("/",|r| r.method(http::Method::GET).f(controller::get_status_controller)) [INFO] [stderr] 9 | | .resource("/{id}/info", |r| r.method(http::Method::GET).f(controller::get_info_controller)) [INFO] [stderr] ... | [INFO] [stderr] 19 | | .resource("/{id}/msa",|r|r.method(http::Method::GET).f(controller::get_msa_controller)) [INFO] [stderr] 20 | | .register(); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | Cors::for_app(application) [INFO] [stderr] 7 | .send_wildcard() [INFO] [stderr] 8 | .resource("/",|r| r.method(http::Method::GET).f(controller::get_status_controller)) [INFO] [stderr] 9 | .resource("/{id}/info", |r| r.method(http::Method::GET).f(controller::get_info_controller)) [INFO] [stderr] 10 | .resource("/search",|r|r.method(http::Method::GET).f(controller::search_controller)) [INFO] [stderr] 11 | .resource("/browse",|r|r.method(http::Method::GET).f(controller::browse_controller)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return self.get(column_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get(column_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return self.get(column_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get(column_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return value; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self.get(column_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get(column_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | return Some(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | return Some(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | return Some(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | return Ok(connection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(connection)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | return Err(format!("{}",error).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("{}",error).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | return Ok(connection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(connection)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | return Err(format!("{}",error).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("{}",error).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | return build_info(id, conn, row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_info(id, conn, row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | return Ok(info); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(info)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:419:5 [INFO] [stderr] | [INFO] [stderr] 419 | return Ok(pro); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(pro)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:477:9 [INFO] [stderr] | [INFO] [stderr] 477 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((count.clone(),search_results.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((count.clone(),search_results.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((count.clone(),search_results.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:485:9 [INFO] [stderr] | [INFO] [stderr] 485 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((count.clone(),search_results.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:512:5 [INFO] [stderr] | [INFO] [stderr] 512 | return Ok(count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:541:5 [INFO] [stderr] | [INFO] [stderr] 541 | return Some(search_result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(search_result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:596:6 [INFO] [stderr] | [INFO] [stderr] 596 | return Ok(substrate_events); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(substrate_events)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:606:5 [INFO] [stderr] | [INFO] [stderr] 606 | return Ok(sub_forms); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sub_forms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:623:5 [INFO] [stderr] | [INFO] [stderr] 623 | return Ok(sub_form_code); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sub_form_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:697:5 [INFO] [stderr] | [INFO] [stderr] 697 | return Ok((events,pmid_stats)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((events,pmid_stats))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:835:5 [INFO] [stderr] | [INFO] [stderr] 835 | return event; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:877:5 [INFO] [stderr] | [INFO] [stderr] 877 | return Ok(proteoforms); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(proteoforms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:907:9 [INFO] [stderr] | [INFO] [stderr] 907 | return Ok(proteoform); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(proteoform)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:930:5 [INFO] [stderr] | [INFO] [stderr] 930 | return Ok(proteoformsppi); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(proteoformsppi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:965:9 [INFO] [stderr] | [INFO] [stderr] 965 | return Ok(proteoformppi); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(proteoformppi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:976:5 [INFO] [stderr] | [INFO] [stderr] 976 | return Ok(ptmppis); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ptmppis)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1025:9 [INFO] [stderr] | [INFO] [stderr] 1025 | return Ok(ptmppi); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ptmppi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1133:9 [INFO] [stderr] | [INFO] [stderr] 1133 | return Ok(ptm_enzyme); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ptm_enzyme)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1203:9 [INFO] [stderr] | [INFO] [stderr] 1203 | return Ok(ptm_ppi); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ptm_ppi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1213:5 [INFO] [stderr] | [INFO] [stderr] 1213 | return Ok(sequences); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sequences)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1225:5 [INFO] [stderr] | [INFO] [stderr] 1225 | return Ok(sequence); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sequence)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1261:5 [INFO] [stderr] | [INFO] [stderr] 1261 | return Ok(decorations); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(decorations)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1288:5 [INFO] [stderr] | [INFO] [stderr] 1288 | return Ok(decoration); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(decoration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1299:17 [INFO] [stderr] | [INFO] [stderr] 1299 | return Ok(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1302:17 [INFO] [stderr] | [INFO] [stderr] 1302 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | return db_params; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `db_params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | return values; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(values); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(values)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | return pmids; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/misc.rs:257:18 [INFO] [stderr] | [INFO] [stderr] 257 | }else{ [INFO] [stderr] | __________________^ [INFO] [stderr] 258 | | if !value.is_empty() { [INFO] [stderr] 259 | | pmids.push(value); [INFO] [stderr] 260 | | } [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 257 | }elseif !value.is_empty() { [INFO] [stderr] 258 | pmids.push(value); [INFO] [stderr] 259 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return unique_items; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unique_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | return items_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `items_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | return items_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `items_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | return taxons_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `taxons_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | return value == "T" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value == "T"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:408:5 [INFO] [stderr] | [INFO] [stderr] 408 | return ptm_labels; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptm_labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | return query_substrates_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_substrates_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:445:5 [INFO] [stderr] | [INFO] [stderr] 445 | return score; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:481:5 [INFO] [stderr] | [INFO] [stderr] 481 | return sn + sq + sp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sn + sq + sp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:493:5 [INFO] [stderr] | [INFO] [stderr] 493 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:513:5 [INFO] [stderr] | [INFO] [stderr] 513 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:539:5 [INFO] [stderr] | [INFO] [stderr] 539 | return String::from(content_header); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(content_header)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | return search_results_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `search_results_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return substrate_events_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `substrate_events_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | return proteoforms_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `proteoforms_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:238:5 [INFO] [stderr] | [INFO] [stderr] 238 | return proteoforms_ppi_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `proteoforms_ppi_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:300:5 [INFO] [stderr] | [INFO] [stderr] 300 | return ptm_ppis_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptm_ppis_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | return batch_ptm_enzymes_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `batch_ptm_enzymes_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | return batch_ptm_ppis_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `batch_ptm_ppis_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:445:5 [INFO] [stderr] | [INFO] [stderr] 445 | return sources_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sources_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | return String::from("SELECT * FROM MV_ENTRY where iptm_entry_code = $1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_ENTRY where iptm_entry_code = $1")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | return String::from("SELECT * FROM MV_ENTRY where iptm_entry_code = :1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_ENTRY where iptm_entry_code = :1")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | return query_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | return query_str.replace("$",":"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str.replace("$",":")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | return query_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | return query_str.replace("$",":"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str.replace("$",":")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME != 'Interaction'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME != 'Interaction'")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | return String::from("SELECT * FROM MV_PROTEO where regexp_like(SUB_XREF,:1,'i') AND EVENT_NAME != 'Interaction'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_PROTEO where regexp_like(SUB_XREF,:1,'i') AND EVENT_NAME != 'Interaction'")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME = 'Interaction'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME = 'Interaction'")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | return String::from("SELECT * FROM MV_PROTEO where regexp_like(SUB_XREF,:1,'i') AND EVENT_NAME = 'Interaction'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_PROTEO where regexp_like(SUB_XREF,:1,'i') AND EVENT_NAME = 'Interaction'")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | return query_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | return query_str.replace("$",":"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str.replace("$",":")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | return String::from("SELECT * FROM SEQUENCE where ID ILIKE $1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM SEQUENCE where ID ILIKE $1")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | return String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | return String::from("select event_name,string_agg(source_label, ', ') as source_labels ,string_agg(pmids, ', ') as pmids from mv_event where sub_form_code = $1 and position = $2 and residue = $3 AND position is not null group by event_name"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("select event_name,string_agg(source_label, ', ') as source_labels ,string_agg(pmids, ', ') as pmids from mv_event where sub_form_code = $1 and position = $2 and residue = $3 AND position is not null group by event_name")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | return String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | return String::from(r#"select count(*) as "count" from mv_event where sub_code = $1 and position = $2 and residue = $3 AND position is not null"#); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(r#"select count(*) as "count" from mv_event where sub_code = $1 and position = $2 and residue = $3 AND position is not null"#)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | return String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return fasta_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fasta_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Ok(alignment_str); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(alignment_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return Err(error_str.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error_str.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(alignments); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(alignments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return Ok(alignment_item); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(alignment_item)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | return router::init_routes(app); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `router::init_routes(app)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return HttpResponse::Ok().force_close().body(status_serialized); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().body(status_serialized)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:327:29 [INFO] [stderr] | [INFO] [stderr] 327 | / return HttpResponse::Ok() [INFO] [stderr] 328 | | .force_close() [INFO] [stderr] 329 | | .header(http::header::CONTENT_TYPE, "text/csv") [INFO] [stderr] 330 | | .header("count", count.to_string()) [INFO] [stderr] 331 | | .body(data); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 327 | HttpResponse::Ok() [INFO] [stderr] 328 | .force_close() [INFO] [stderr] 329 | .header(http::header::CONTENT_TYPE, "text/csv") [INFO] [stderr] 330 | .header("count", count.to_string()) [INFO] [stderr] 331 | .body(data) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:335:29 [INFO] [stderr] | [INFO] [stderr] 335 | / return HttpResponse::InternalServerError() [INFO] [stderr] 336 | | .force_close() [INFO] [stderr] 337 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 338 | | .body(format!("{}",error)); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 335 | HttpResponse::InternalServerError() [INFO] [stderr] 336 | .force_close() [INFO] [stderr] 337 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 338 | .body(format!("{}",error)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | / return HttpResponse::BadRequest() [INFO] [stderr] 343 | | .force_close() [INFO] [stderr] 344 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 345 | | .body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 342 | HttpResponse::BadRequest() [INFO] [stderr] 343 | .force_close() [INFO] [stderr] 344 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 345 | .body(format!("Invalid ACCEPT header - {}",content_header)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:571:29 [INFO] [stderr] | [INFO] [stderr] 571 | / return HttpResponse::Ok() [INFO] [stderr] 572 | | .force_close() [INFO] [stderr] 573 | | .header(http::header::CONTENT_TYPE, "text/csv") [INFO] [stderr] 574 | | .header("count", count.to_string()) [INFO] [stderr] 575 | | .body(data); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 571 | HttpResponse::Ok() [INFO] [stderr] 572 | .force_close() [INFO] [stderr] 573 | .header(http::header::CONTENT_TYPE, "text/csv") [INFO] [stderr] 574 | .header("count", count.to_string()) [INFO] [stderr] 575 | .body(data) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:579:29 [INFO] [stderr] | [INFO] [stderr] 579 | / return HttpResponse::InternalServerError() [INFO] [stderr] 580 | | .force_close() [INFO] [stderr] 581 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 582 | | .body(format!("{}",error)); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 579 | HttpResponse::InternalServerError() [INFO] [stderr] 580 | .force_close() [INFO] [stderr] 581 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 582 | .body(format!("{}",error)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:586:17 [INFO] [stderr] | [INFO] [stderr] 586 | / return HttpResponse::BadRequest() [INFO] [stderr] 587 | | .force_close() [INFO] [stderr] 588 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 589 | | .body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 586 | HttpResponse::BadRequest() [INFO] [stderr] 587 | .force_close() [INFO] [stderr] 588 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 589 | .body(format!("Invalid ACCEPT header - {}",content_header)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:645:25 [INFO] [stderr] | [INFO] [stderr] 645 | / return HttpResponse::InternalServerError() [INFO] [stderr] 646 | | .force_close() [INFO] [stderr] 647 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 648 | | .body(format!("{}",error)); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 645 | HttpResponse::InternalServerError() [INFO] [stderr] 646 | .force_close() [INFO] [stderr] 647 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 648 | .body(format!("{}",error)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:688:25 [INFO] [stderr] | [INFO] [stderr] 688 | return HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/csv").body(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/csv").body(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:692:25 [INFO] [stderr] | [INFO] [stderr] 692 | / return HttpResponse::InternalServerError() [INFO] [stderr] 693 | | .force_close() [INFO] [stderr] 694 | | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 695 | | .body(format!("{}",error)); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 692 | HttpResponse::InternalServerError() [INFO] [stderr] 693 | .force_close() [INFO] [stderr] 694 | .header(http::header::CONTENT_TYPE, "text/plain") [INFO] [stderr] 695 | .body(format!("{}",error)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | return HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:746:25 [INFO] [stderr] | [INFO] [stderr] 746 | return HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:780:25 [INFO] [stderr] | [INFO] [stderr] 780 | return HttpResponse::Ok().force_close().body(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().body(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:784:25 [INFO] [stderr] | [INFO] [stderr] 784 | return HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:788:17 [INFO] [stderr] | [INFO] [stderr] 788 | return HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:868:25 [INFO] [stderr] | [INFO] [stderr] 868 | return HttpResponse::Ok().force_close().body(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().body(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:872:25 [INFO] [stderr] | [INFO] [stderr] 872 | return HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:876:17 [INFO] [stderr] | [INFO] [stderr] 876 | return HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:954:29 [INFO] [stderr] | [INFO] [stderr] 954 | return HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:958:29 [INFO] [stderr] | [INFO] [stderr] 958 | return HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:962:17 [INFO] [stderr] | [INFO] [stderr] 962 | return HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1027:33 [INFO] [stderr] | [INFO] [stderr] 1027 | return Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "application/json").body(ptm_enzymes_serialized)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "application/json").body(ptm_enzymes_serialized))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1030:33 [INFO] [stderr] | [INFO] [stderr] 1030 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1063:37 [INFO] [stderr] | [INFO] [stderr] 1063 | return Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1067:37 [INFO] [stderr] | [INFO] [stderr] 1067 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1071:25 [INFO] [stderr] | [INFO] [stderr] 1071 | return Ok(HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1075:21 [INFO] [stderr] | [INFO] [stderr] 1075 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1126:33 [INFO] [stderr] | [INFO] [stderr] 1126 | return Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "application/json").body(ptm_ppis_serialized)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "application/json").body(ptm_ppis_serialized))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1129:33 [INFO] [stderr] | [INFO] [stderr] 1129 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1162:37 [INFO] [stderr] | [INFO] [stderr] 1162 | return Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(data))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1166:37 [INFO] [stderr] | [INFO] [stderr] 1166 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1170:25 [INFO] [stderr] | [INFO] [stderr] 1170 | return Ok(HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::BadRequest().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("Invalid ACCEPT header - {}",content_header)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1174:21 [INFO] [stderr] | [INFO] [stderr] 1174 | return Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::InternalServerError().force_close().header(http::header::CONTENT_TYPE, "text/plain").body(format!("{}",error)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1205:5 [INFO] [stderr] | [INFO] [stderr] 1205 | return HttpResponse::Ok().force_close().body(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::Ok().force_close().body(contents)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1233:37 [INFO] [stderr] | [INFO] [stderr] 1233 | / return HttpResponse::Ok() [INFO] [stderr] 1234 | | .force_close() [INFO] [stderr] 1235 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1236 | | .body(alignment_serialized); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1233 | HttpResponse::Ok() [INFO] [stderr] 1234 | .force_close() [INFO] [stderr] 1235 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1236 | .body(alignment_serialized) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1240:37 [INFO] [stderr] | [INFO] [stderr] 1240 | / return HttpResponse::Ok() [INFO] [stderr] 1241 | | .force_close() [INFO] [stderr] 1242 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1243 | | .body(error_msg); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1240 | HttpResponse::Ok() [INFO] [stderr] 1241 | .force_close() [INFO] [stderr] 1242 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1243 | .body(error_msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1249:29 [INFO] [stderr] | [INFO] [stderr] 1249 | / return HttpResponse::Ok() [INFO] [stderr] 1250 | | .force_close() [INFO] [stderr] 1251 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1252 | | .body(error_msg); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1249 | HttpResponse::Ok() [INFO] [stderr] 1250 | .force_close() [INFO] [stderr] 1251 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1252 | .body(error_msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1258:21 [INFO] [stderr] | [INFO] [stderr] 1258 | / return HttpResponse::InternalServerError() [INFO] [stderr] 1259 | | .force_close() [INFO] [stderr] 1260 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1261 | | .body(error_msg); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1258 | HttpResponse::InternalServerError() [INFO] [stderr] 1259 | .force_close() [INFO] [stderr] 1260 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1261 | .body(error_msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/controller.rs:1268:13 [INFO] [stderr] | [INFO] [stderr] 1268 | / return HttpResponse::InternalServerError() [INFO] [stderr] 1269 | | .force_close() [INFO] [stderr] 1270 | | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1271 | | .body(error_msg); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1268 | HttpResponse::InternalServerError() [INFO] [stderr] 1269 | .force_close() [INFO] [stderr] 1270 | .header(http::header::CONTENT_TYPE, "application/json") [INFO] [stderr] 1271 | .body(error_msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/router.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | / return Cors::for_app(application) [INFO] [stderr] 7 | | .send_wildcard() [INFO] [stderr] 8 | | .resource("/",|r| r.method(http::Method::GET).f(controller::get_status_controller)) [INFO] [stderr] 9 | | .resource("/{id}/info", |r| r.method(http::Method::GET).f(controller::get_info_controller)) [INFO] [stderr] ... | [INFO] [stderr] 19 | | .resource("/{id}/msa",|r|r.method(http::Method::GET).f(controller::get_msa_controller)) [INFO] [stderr] 20 | | .register(); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | Cors::for_app(application) [INFO] [stderr] 7 | .send_wildcard() [INFO] [stderr] 8 | .resource("/",|r| r.method(http::Method::GET).f(controller::get_status_controller)) [INFO] [stderr] 9 | .resource("/{id}/info", |r| r.method(http::Method::GET).f(controller::get_info_controller)) [INFO] [stderr] 10 | .resource("/search",|r|r.method(http::Method::GET).f(controller::search_controller)) [INFO] [stderr] 11 | .resource("/browse",|r|r.method(http::Method::GET).f(controller::browse_controller)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return self.get(column_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get(column_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return self.get(column_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get(column_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return value; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self.get(column_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get(column_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | return Some(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | return Some(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | return Some(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | return Ok(connection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(connection)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | return Err(format!("{}",error).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("{}",error).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | return Ok(connection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(connection)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | return Err(format!("{}",error).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("{}",error).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | return build_info(id, conn, row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_info(id, conn, row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | return Ok(info); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(info)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:419:5 [INFO] [stderr] | [INFO] [stderr] 419 | return Ok(pro); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(pro)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:477:9 [INFO] [stderr] | [INFO] [stderr] 477 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((count.clone(),search_results.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((count.clone(),search_results.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((count.clone(),search_results.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:485:9 [INFO] [stderr] | [INFO] [stderr] 485 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((count.clone(),search_results.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:512:5 [INFO] [stderr] | [INFO] [stderr] 512 | return Ok(count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:541:5 [INFO] [stderr] | [INFO] [stderr] 541 | return Some(search_result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(search_result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:596:6 [INFO] [stderr] | [INFO] [stderr] 596 | return Ok(substrate_events); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(substrate_events)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:606:5 [INFO] [stderr] | [INFO] [stderr] 606 | return Ok(sub_forms); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sub_forms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:623:5 [INFO] [stderr] | [INFO] [stderr] 623 | return Ok(sub_form_code); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sub_form_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:697:5 [INFO] [stderr] | [INFO] [stderr] 697 | return Ok((events,pmid_stats)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((events,pmid_stats))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:835:5 [INFO] [stderr] | [INFO] [stderr] 835 | return event; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:877:5 [INFO] [stderr] | [INFO] [stderr] 877 | return Ok(proteoforms); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(proteoforms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:907:9 [INFO] [stderr] | [INFO] [stderr] 907 | return Ok(proteoform); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(proteoform)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:930:5 [INFO] [stderr] | [INFO] [stderr] 930 | return Ok(proteoformsppi); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(proteoformsppi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:965:9 [INFO] [stderr] | [INFO] [stderr] 965 | return Ok(proteoformppi); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(proteoformppi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:976:5 [INFO] [stderr] | [INFO] [stderr] 976 | return Ok(ptmppis); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ptmppis)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1025:9 [INFO] [stderr] | [INFO] [stderr] 1025 | return Ok(ptmppi); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ptmppi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1133:9 [INFO] [stderr] | [INFO] [stderr] 1133 | return Ok(ptm_enzyme); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ptm_enzyme)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1203:9 [INFO] [stderr] | [INFO] [stderr] 1203 | return Ok(ptm_ppi); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ptm_ppi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1213:5 [INFO] [stderr] | [INFO] [stderr] 1213 | return Ok(sequences); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sequences)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1225:5 [INFO] [stderr] | [INFO] [stderr] 1225 | return Ok(sequence); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sequence)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1261:5 [INFO] [stderr] | [INFO] [stderr] 1261 | return Ok(decorations); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(decorations)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1288:5 [INFO] [stderr] | [INFO] [stderr] 1288 | return Ok(decoration); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(decoration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1299:17 [INFO] [stderr] | [INFO] [stderr] 1299 | return Ok(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:1302:17 [INFO] [stderr] | [INFO] [stderr] 1302 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | return db_params; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `db_params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | return values; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(values); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(values)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | return pmids; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `pmids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/misc.rs:257:18 [INFO] [stderr] | [INFO] [stderr] 257 | }else{ [INFO] [stderr] | __________________^ [INFO] [stderr] 258 | | if !value.is_empty() { [INFO] [stderr] 259 | | pmids.push(value); [INFO] [stderr] 260 | | } [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 257 | }elseif !value.is_empty() { [INFO] [stderr] 258 | pmids.push(value); [INFO] [stderr] 259 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return unique_items; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unique_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | return items_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `items_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | return items_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `items_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | return taxons_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `taxons_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | return value == "T" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value == "T"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:408:5 [INFO] [stderr] | [INFO] [stderr] 408 | return ptm_labels; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptm_labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | return query_substrates_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_substrates_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:445:5 [INFO] [stderr] | [INFO] [stderr] 445 | return score; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:481:5 [INFO] [stderr] | [INFO] [stderr] 481 | return sn + sq + sp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sn + sq + sp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:493:5 [INFO] [stderr] | [INFO] [stderr] 493 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:513:5 [INFO] [stderr] | [INFO] [stderr] 513 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/misc.rs:539:5 [INFO] [stderr] | [INFO] [stderr] 539 | return String::from(content_header); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(content_header)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | return search_results_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `search_results_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return substrate_events_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `substrate_events_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | return proteoforms_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `proteoforms_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:238:5 [INFO] [stderr] | [INFO] [stderr] 238 | return proteoforms_ppi_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `proteoforms_ppi_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:300:5 [INFO] [stderr] | [INFO] [stderr] 300 | return ptm_ppis_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptm_ppis_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | return batch_ptm_enzymes_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `batch_ptm_enzymes_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | return batch_ptm_ppis_flat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `batch_ptm_ppis_flat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flatten.rs:445:5 [INFO] [stderr] | [INFO] [stderr] 445 | return sources_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sources_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | return String::from("SELECT * FROM MV_ENTRY where iptm_entry_code = $1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_ENTRY where iptm_entry_code = $1")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | return String::from("SELECT * FROM MV_ENTRY where iptm_entry_code = :1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_ENTRY where iptm_entry_code = :1")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | return query_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | return query_str.replace("$",":"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str.replace("$",":")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | return query_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | return query_str.replace("$",":"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str.replace("$",":")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME != 'Interaction'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME != 'Interaction'")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | return String::from("SELECT * FROM MV_PROTEO where regexp_like(SUB_XREF,:1,'i') AND EVENT_NAME != 'Interaction'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_PROTEO where regexp_like(SUB_XREF,:1,'i') AND EVENT_NAME != 'Interaction'")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME = 'Interaction'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME = 'Interaction'")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | return String::from("SELECT * FROM MV_PROTEO where regexp_like(SUB_XREF,:1,'i') AND EVENT_NAME = 'Interaction'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM MV_PROTEO where regexp_like(SUB_XREF,:1,'i') AND EVENT_NAME = 'Interaction'")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | return query_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | return query_str.replace("$",":"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_str.replace("$",":")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | return String::from("SELECT * FROM SEQUENCE where ID ILIKE $1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM SEQUENCE where ID ILIKE $1")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | return String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | return String::from("select event_name,string_agg(source_label, ', ') as source_labels ,string_agg(pmids, ', ') as pmids from mv_event where sub_form_code = $1 and position = $2 and residue = $3 AND position is not null group by event_name"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("select event_name,string_agg(source_label, ', ') as source_labels ,string_agg(pmids, ', ') as pmids from mv_event where sub_form_code = $1 and position = $2 and residue = $3 AND position is not null group by event_name")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | return String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | return String::from(r#"select count(*) as "count" from mv_event where sub_code = $1 and position = $2 and residue = $3 AND position is not null"#); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(r#"select count(*) as "count" from mv_event where sub_code = $1 and position = $2 and residue = $3 AND position is not null"#)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_builder.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | return String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("SELECT * FROM SEQUENCE where regexp_like(ID,:1,'i')")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return fasta_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fasta_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Ok(alignment_str); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(alignment_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return Err(error_str.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error_str.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(alignments); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(alignments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msa.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return Ok(alignment_item); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(alignment_item)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | return router::init_routes(app); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `router::init_routes(app)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/controller.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn search_controller(req: HttpRequest) -> HttpResponse { [INFO] [stderr] 76 | | [INFO] [stderr] 77 | | //get the connection from pool [INFO] [stderr] 78 | | let conn; [INFO] [stderr] ... | [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 367 | return execute_query!(closure,conn,query_str,&[&String::from(id)]); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 407 | return execute_query!(build_pro_info,conn,query_str,&[&pro_id]) [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:426:26 [INFO] [stderr] | [INFO] [stderr] 426 | ptm_types: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:427:32 [INFO] [stderr] | [INFO] [stderr] 427 | organism_taxons: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/database.rs:423:1 [INFO] [stderr] | [INFO] [stderr] 423 | / pub fn search(search_term: &str, [INFO] [stderr] 424 | | term_type: &str, [INFO] [stderr] 425 | | role: &str, [INFO] [stderr] 426 | | ptm_types: &Vec, [INFO] [stderr] ... | [INFO] [stderr] 486 | | } [INFO] [stderr] 487 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | / match search_result_opt { [INFO] [stderr] 443 | | Some(value) => { [INFO] [stderr] 444 | | search_results.borrow_mut().push(value); [INFO] [stderr] 445 | | }, [INFO] [stderr] 446 | | None => { [INFO] [stderr] 447 | | } [INFO] [stderr] 448 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 442 | if let Some(value) = search_result_opt { [INFO] [stderr] 443 | search_results.borrow_mut().push(value); [INFO] [stderr] 444 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/database.rs:477:20 [INFO] [stderr] | [INFO] [stderr] 477 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/database.rs:480:20 [INFO] [stderr] | [INFO] [stderr] 480 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/database.rs:483:20 [INFO] [stderr] | [INFO] [stderr] 483 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/database.rs:485:20 [INFO] [stderr] | [INFO] [stderr] 485 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:492:26 [INFO] [stderr] | [INFO] [stderr] 492 | ptm_types: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:493:32 [INFO] [stderr] | [INFO] [stderr] 493 | organism_taxons: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 64 [INFO] [stderr] --> src/database.rs:489:1 [INFO] [stderr] | [INFO] [stderr] 489 | / fn get_search_count(search_term_formatted: String, [INFO] [stderr] 490 | | term_type: &str, [INFO] [stderr] 491 | | role: &str, [INFO] [stderr] 492 | | ptm_types: &Vec, [INFO] [stderr] ... | [INFO] [stderr] 507 | | [INFO] [stderr] 508 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 499 | return execute_query!(build_search_count,conn,count_query_str,&[&search_term_formatted,&search_term_formatted,&search_term_formatted]); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 501 | return execute_query!(build_search_count,conn,count_query_str,&[&search_term_formatted,&search_term_formatted,&search_term_formatted]); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 503 | return execute_query!(build_search_count,conn,count_query_str,&[&search_term_formatted,&search_term_formatted,&search_term_formatted]); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 505 | return execute_query!(build_search_count,conn,count_query_str,&[&search_term_formatted,&search_term_formatted,&search_term_formatted]); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/database.rs:708:30 [INFO] [stderr] | [INFO] [stderr] 708 | let previous_event = event_clone.get(events_count - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `event_clone[events_count - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/database.rs:719:43 [INFO] [stderr] | [INFO] [stderr] 719 | let previous_event_mut = &mut events.get_mut(events_count - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `events[events_count - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/database.rs:763:5 [INFO] [stderr] | [INFO] [stderr] 763 | / match &residue { [INFO] [stderr] 764 | | &Some(ref residue_value) => { [INFO] [stderr] 765 | | let position = row.get_i64("position"); [INFO] [stderr] 766 | | match position { [INFO] [stderr] ... | [INFO] [stderr] 780 | | } [INFO] [stderr] 781 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 763 | match residue { [INFO] [stderr] 764 | Some(ref residue_value) => { [INFO] [stderr] 765 | let position = row.get_i64("position"); [INFO] [stderr] 766 | match position { [INFO] [stderr] 767 | Some(pos_value) => { [INFO] [stderr] 768 | site = Some(format!("{residue}{position}",residue=residue_value,position=pos_value)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:784:5 [INFO] [stderr] | [INFO] [stderr] 784 | / match enzyme_id { [INFO] [stderr] 785 | | Some(value) => { [INFO] [stderr] 786 | | let enzyme = Enzyme { [INFO] [stderr] 787 | | id: Some(value), [INFO] [stderr] ... | [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 784 | if let Some(value) = enzyme_id { [INFO] [stderr] 785 | let enzyme = Enzyme { [INFO] [stderr] 786 | id: Some(value), [INFO] [stderr] 787 | enz_type: row.get_string("enz_type"), [INFO] [stderr] 788 | name: row.get_string("enz_symbol"), [INFO] [stderr] 789 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/database.rs:795:24 [INFO] [stderr] | [INFO] [stderr] 795 | if val.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:812:5 [INFO] [stderr] | [INFO] [stderr] 812 | / match source { [INFO] [stderr] 813 | | Some(value) => { [INFO] [stderr] 814 | | sources.push(value); [INFO] [stderr] 815 | | }, [INFO] [stderr] ... | [INFO] [stderr] 818 | | } [INFO] [stderr] 819 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 812 | if let Some(value) = source { [INFO] [stderr] 813 | sources.push(value); [INFO] [stderr] 814 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:839:41 [INFO] [stderr] | [INFO] [stderr] 839 | fn update_pmid_stats(row: &MyRow,pmids: &Vec,pmid_stats: &mut HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/database.rs:854:8 [INFO] [stderr] | [INFO] [stderr] 854 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:1030:42 [INFO] [stderr] | [INFO] [stderr] 1030 | pub fn get_ptm_enzymes(query_substrates: &Vec, conn: &Connection) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[QuerySubstrate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:1085:13 [INFO] [stderr] | [INFO] [stderr] 1085 | / match source { [INFO] [stderr] 1086 | | Some(val) => {sources.push(val)}, [INFO] [stderr] 1087 | | None => {} [INFO] [stderr] 1088 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(val) = source {sources.push(val)}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:1137:38 [INFO] [stderr] | [INFO] [stderr] 1137 | pub fn get_ptm_ppi(query_substrates: &Vec, conn: &Connection) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[QuerySubstrate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/database.rs:1251:24 [INFO] [stderr] | [INFO] [stderr] 1251 | if is_conserved && decorations.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `decorations.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:1271:9 [INFO] [stderr] | [INFO] [stderr] 1271 | / match source { [INFO] [stderr] 1272 | | Some(value) => { [INFO] [stderr] 1273 | | sources.push(value); [INFO] [stderr] 1274 | | }, [INFO] [stderr] ... | [INFO] [stderr] 1277 | | } [INFO] [stderr] 1278 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1271 | if let Some(value) = source { [INFO] [stderr] 1272 | sources.push(value); [INFO] [stderr] 1273 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 1307 | return execute_query!(closure,conn,query_str,&[&id,&position,&residue]); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/controller.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn search_controller(req: HttpRequest) -> HttpResponse { [INFO] [stderr] 76 | | [INFO] [stderr] 77 | | //get the connection from pool [INFO] [stderr] 78 | | let conn; [INFO] [stderr] ... | [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 367 | return execute_query!(closure,conn,query_str,&[&String::from(id)]); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 407 | return execute_query!(build_pro_info,conn,query_str,&[&pro_id]) [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:426:26 [INFO] [stderr] | [INFO] [stderr] 426 | ptm_types: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:427:32 [INFO] [stderr] | [INFO] [stderr] 427 | organism_taxons: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/database.rs:423:1 [INFO] [stderr] | [INFO] [stderr] 423 | / pub fn search(search_term: &str, [INFO] [stderr] 424 | | term_type: &str, [INFO] [stderr] 425 | | role: &str, [INFO] [stderr] 426 | | ptm_types: &Vec, [INFO] [stderr] ... | [INFO] [stderr] 486 | | } [INFO] [stderr] 487 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | / match search_result_opt { [INFO] [stderr] 443 | | Some(value) => { [INFO] [stderr] 444 | | search_results.borrow_mut().push(value); [INFO] [stderr] 445 | | }, [INFO] [stderr] 446 | | None => { [INFO] [stderr] 447 | | } [INFO] [stderr] 448 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 442 | if let Some(value) = search_result_opt { [INFO] [stderr] 443 | search_results.borrow_mut().push(value); [INFO] [stderr] 444 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/database.rs:477:20 [INFO] [stderr] | [INFO] [stderr] 477 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/database.rs:480:20 [INFO] [stderr] | [INFO] [stderr] 480 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/database.rs:483:20 [INFO] [stderr] | [INFO] [stderr] 483 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/database.rs:485:20 [INFO] [stderr] | [INFO] [stderr] 485 | return Ok((count.clone(),search_results.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:492:26 [INFO] [stderr] | [INFO] [stderr] 492 | ptm_types: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:493:32 [INFO] [stderr] | [INFO] [stderr] 493 | organism_taxons: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 64 [INFO] [stderr] --> src/database.rs:489:1 [INFO] [stderr] | [INFO] [stderr] 489 | / fn get_search_count(search_term_formatted: String, [INFO] [stderr] 490 | | term_type: &str, [INFO] [stderr] 491 | | role: &str, [INFO] [stderr] 492 | | ptm_types: &Vec, [INFO] [stderr] ... | [INFO] [stderr] 507 | | [INFO] [stderr] 508 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 499 | return execute_query!(build_search_count,conn,count_query_str,&[&search_term_formatted,&search_term_formatted,&search_term_formatted]); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 501 | return execute_query!(build_search_count,conn,count_query_str,&[&search_term_formatted,&search_term_formatted,&search_term_formatted]); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 503 | return execute_query!(build_search_count,conn,count_query_str,&[&search_term_formatted,&search_term_formatted,&search_term_formatted]); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 505 | return execute_query!(build_search_count,conn,count_query_str,&[&search_term_formatted,&search_term_formatted,&search_term_formatted]); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/database.rs:708:30 [INFO] [stderr] | [INFO] [stderr] 708 | let previous_event = event_clone.get(events_count - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `event_clone[events_count - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/database.rs:719:43 [INFO] [stderr] | [INFO] [stderr] 719 | let previous_event_mut = &mut events.get_mut(events_count - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `events[events_count - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/database.rs:763:5 [INFO] [stderr] | [INFO] [stderr] 763 | / match &residue { [INFO] [stderr] 764 | | &Some(ref residue_value) => { [INFO] [stderr] 765 | | let position = row.get_i64("position"); [INFO] [stderr] 766 | | match position { [INFO] [stderr] ... | [INFO] [stderr] 780 | | } [INFO] [stderr] 781 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 763 | match residue { [INFO] [stderr] 764 | Some(ref residue_value) => { [INFO] [stderr] 765 | let position = row.get_i64("position"); [INFO] [stderr] 766 | match position { [INFO] [stderr] 767 | Some(pos_value) => { [INFO] [stderr] 768 | site = Some(format!("{residue}{position}",residue=residue_value,position=pos_value)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:784:5 [INFO] [stderr] | [INFO] [stderr] 784 | / match enzyme_id { [INFO] [stderr] 785 | | Some(value) => { [INFO] [stderr] 786 | | let enzyme = Enzyme { [INFO] [stderr] 787 | | id: Some(value), [INFO] [stderr] ... | [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 784 | if let Some(value) = enzyme_id { [INFO] [stderr] 785 | let enzyme = Enzyme { [INFO] [stderr] 786 | id: Some(value), [INFO] [stderr] 787 | enz_type: row.get_string("enz_type"), [INFO] [stderr] 788 | name: row.get_string("enz_symbol"), [INFO] [stderr] 789 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/database.rs:795:24 [INFO] [stderr] | [INFO] [stderr] 795 | if val.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:812:5 [INFO] [stderr] | [INFO] [stderr] 812 | / match source { [INFO] [stderr] 813 | | Some(value) => { [INFO] [stderr] 814 | | sources.push(value); [INFO] [stderr] 815 | | }, [INFO] [stderr] ... | [INFO] [stderr] 818 | | } [INFO] [stderr] 819 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 812 | if let Some(value) = source { [INFO] [stderr] 813 | sources.push(value); [INFO] [stderr] 814 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:839:41 [INFO] [stderr] | [INFO] [stderr] 839 | fn update_pmid_stats(row: &MyRow,pmids: &Vec,pmid_stats: &mut HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/database.rs:854:8 [INFO] [stderr] | [INFO] [stderr] 854 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:1030:42 [INFO] [stderr] | [INFO] [stderr] 1030 | pub fn get_ptm_enzymes(query_substrates: &Vec, conn: &Connection) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[QuerySubstrate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:1085:13 [INFO] [stderr] | [INFO] [stderr] 1085 | / match source { [INFO] [stderr] 1086 | | Some(val) => {sources.push(val)}, [INFO] [stderr] 1087 | | None => {} [INFO] [stderr] 1088 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(val) = source {sources.push(val)}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:1137:38 [INFO] [stderr] | [INFO] [stderr] 1137 | pub fn get_ptm_ppi(query_substrates: &Vec, conn: &Connection) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[QuerySubstrate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/database.rs:1251:24 [INFO] [stderr] | [INFO] [stderr] 1251 | if is_conserved && decorations.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `decorations.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database.rs:1271:9 [INFO] [stderr] | [INFO] [stderr] 1271 | / match source { [INFO] [stderr] 1272 | | Some(value) => { [INFO] [stderr] 1273 | | sources.push(value); [INFO] [stderr] 1274 | | }, [INFO] [stderr] ... | [INFO] [stderr] 1277 | | } [INFO] [stderr] 1278 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1271 | if let Some(value) = source { [INFO] [stderr] 1272 | sources.push(value); [INFO] [stderr] 1273 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/database.rs:194:37 [INFO] [stderr] | [INFO] [stderr] 194 | / for row_result in rows_result { [INFO] [stderr] 195 | | match row_result { [INFO] [stderr] 196 | | Ok(row) => { [INFO] [stderr] 197 | | let info = $builder_func(&row)?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] ... [INFO] [stderr] 1307 | return execute_query!(closure,conn,query_str,&[&id,&position,&residue]); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/misc.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn parse_configs(conf: &ini::Ini) -> DBParams { [INFO] [stderr] 12 | | let engine; [INFO] [stderr] 13 | | let mut host = &String::new();; [INFO] [stderr] 14 | | let mut port = &String::new();; [INFO] [stderr] ... | [INFO] [stderr] 163 | | return db_params; [INFO] [stderr] 164 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match conf.section(Some("POSTGRES".to_owned())) { [INFO] [stderr] 39 | | Some(section) => { [INFO] [stderr] 40 | | //host [INFO] [stderr] 41 | | match section.get("host") { [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(section) = conf.section(Some("POSTGRES".to_owned())) { [INFO] [stderr] 39 | //host [INFO] [stderr] 40 | match section.get("host") { [INFO] [stderr] 41 | Some(value) => { [INFO] [stderr] 42 | host=value; [INFO] [stderr] 43 | } None => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match conf.section(Some("ORACLE".to_owned())) { [INFO] [stderr] 97 | | Some(section) => { [INFO] [stderr] 98 | | //host [INFO] [stderr] 99 | | match section.get("host") { [INFO] [stderr] ... | [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(section) = conf.section(Some("ORACLE".to_owned())) { [INFO] [stderr] 97 | //host [INFO] [stderr] 98 | match section.get("host") { [INFO] [stderr] 99 | Some(value) => { [INFO] [stderr] 100 | host=value; [INFO] [stderr] 101 | } None => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/misc.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / match data_str { [INFO] [stderr] 168 | | &Some(ref data) => { [INFO] [stderr] 169 | | let split = data.split(seperator); [INFO] [stderr] 170 | | let mut vec: Vec = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *data_str { [INFO] [stderr] 168 | Some(ref data) => { [INFO] [stderr] 169 | let split = data.split(seperator); [INFO] [stderr] 170 | let mut vec: Vec = Vec::new(); [INFO] [stderr] 171 | for s in split { [INFO] [stderr] 172 | if s.len() != 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/misc.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | if s.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/misc.rs:215:5 [INFO] [stderr] | [INFO] [stderr] 215 | / match data_str { [INFO] [stderr] 216 | | &Some(ref data) => { [INFO] [stderr] 217 | | let split = data.split(seperator); [INFO] [stderr] 218 | | let mut vec: Vec = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 215 | match *data_str { [INFO] [stderr] 216 | Some(ref data) => { [INFO] [stderr] 217 | let split = data.split(seperator); [INFO] [stderr] 218 | let mut vec: Vec = Vec::new(); [INFO] [stderr] 219 | for s in split { [INFO] [stderr] 220 | if s.len() != 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/misc.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | if s.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:244:6 [INFO] [stderr] | [INFO] [stderr] 244 | / match pmid_option { [INFO] [stderr] 245 | | Some(value) => { [INFO] [stderr] 246 | | //check if this pmid is joined or seperate [INFO] [stderr] 247 | | if value.contains(","){ [INFO] [stderr] ... | [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 244 | if let Some(value) = pmid_option { [INFO] [stderr] 245 | //check if this pmid is joined or seperate [INFO] [stderr] 246 | if value.contains(","){ [INFO] [stderr] 247 | //split pmid into subsequent strings [INFO] [stderr] 248 | let split_pmids = value.split(","); [INFO] [stderr] 249 | for pmid in split_pmids { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/misc.rs:247:31 [INFO] [stderr] | [INFO] [stderr] 247 | if value.contains(","){ [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/misc.rs:249:47 [INFO] [stderr] | [INFO] [stderr] 249 | let split_pmids = value.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:270:33 [INFO] [stderr] | [INFO] [stderr] 270 | pub fn remove_duplicates(items: &Vec) -> Vec{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:280:30 [INFO] [stderr] | [INFO] [stderr] 280 | pub fn str_vec_to_str(items: &Vec) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:294:39 [INFO] [stderr] | [INFO] [stderr] 294 | pub fn str_vec_to_str_with_sep(items: &Vec,seperator: String) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:308:36 [INFO] [stderr] | [INFO] [stderr] 308 | pub fn taxons_to_tuple_str(taxons: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:332:37 [INFO] [stderr] | [INFO] [stderr] 332 | pub fn to_postgres_array_str(items: &Vec) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:411:56 [INFO] [stderr] | [INFO] [stderr] 411 | pub fn query_substrates_to_tuple_str(query_substrates: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[QuerySubstrate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:426:76 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn calculate_score_batch_ptm_enzymes(num_substrates: Vec,sources: &Vec,pmids: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:426:96 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn calculate_score_batch_ptm_enzymes(num_substrates: Vec,sources: &Vec,pmids: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:449:64 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn calculate_score(pmid_stats: &HashMap,pmids: &Vec, sources: &Vec ) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:449:87 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn calculate_score(pmid_stats: &HashMap,pmids: &Vec, sources: &Vec ) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/misc.rs:451:5 [INFO] [stderr] | [INFO] [stderr] 451 | / let sn; [INFO] [stderr] 452 | | if sources.len() >= 2 { [INFO] [stderr] 453 | | sn = 1; [INFO] [stderr] 454 | | }else{ [INFO] [stderr] 455 | | sn = 0; [INFO] [stderr] 456 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sn = if sources.len() >= 2 { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:484:35 [INFO] [stderr] | [INFO] [stderr] 484 | fn has_preferred_sources(sources: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:497:31 [INFO] [stderr] | [INFO] [stderr] 497 | fn has_non_large_scale(pmids: &Vec, pmid_stats: &HashMap) -> bool{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/misc.rs:502:20 [INFO] [stderr] | [INFO] [stderr] 502 | if count <= &threshold { [INFO] [stderr] | ^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `threshold` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:5:39 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn search_results(search_results: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[SearchResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match &search_result.organism { [INFO] [stderr] 15 | | &Some(ref organism) => { [INFO] [stderr] 16 | | taxon_code = organism.taxon_code.clone(); [INFO] [stderr] 17 | | species = organism.species.clone(); [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | match search_result.organism { [INFO] [stderr] 15 | Some(ref organism) => { [INFO] [stderr] 16 | taxon_code = organism.taxon_code.clone(); [INFO] [stderr] 17 | species = organism.species.clone(); [INFO] [stderr] 18 | common_name = organism.common_name.clone(); [INFO] [stderr] 19 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | substrate_role: search_result.substrate_role.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.substrate_role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | substrate_num: search_result.substrate_num.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.substrate_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | enzyme_role: search_result.enzyme_role.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.enzyme_role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | enzyme_num: search_result.enzyme_num.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.enzyme_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:43:38 [INFO] [stderr] | [INFO] [stderr] 43 | ptm_dependent_ppi_role : search_result.ptm_dependent_ppi_role.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.ptm_dependent_ppi_role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | ptm_dependent_ppi_num : search_result.ptm_dependent_ppi_num.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.ptm_dependent_ppi_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | sites: search_result.sites.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.sites` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | isoforms: search_result.isoforms.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.isoforms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/flatten.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | / match enzyme.name { [INFO] [stderr] 75 | | Some(ref value) => { [INFO] [stderr] 76 | | enzyme_name = value.clone(); [INFO] [stderr] 77 | | }, [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let Some(ref value) = enzyme.name { [INFO] [stderr] 75 | enzyme_name = value.clone(); [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/flatten.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / match enzyme.id { [INFO] [stderr] 84 | | Some(ref value) => { [INFO] [stderr] 85 | | enzyme_id = value.clone(); [INFO] [stderr] 86 | | }, [INFO] [stderr] ... | [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let Some(ref value) = enzyme.id { [INFO] [stderr] 84 | enzyme_id = value.clone(); [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/flatten.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match enzyme.enz_type { [INFO] [stderr] 93 | | Some(ref value) => { [INFO] [stderr] 94 | | enzyme_type = value.clone(); [INFO] [stderr] 95 | | }, [INFO] [stderr] ... | [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(ref value) = enzyme.enz_type { [INFO] [stderr] 93 | enzyme_type = value.clone(); [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | score: event.score.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `event.score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:129:32 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn proteoform(proteoforms: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Proteoform]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match &proteoform.ptm_enzyme { [INFO] [stderr] 137 | | &Some(ref ptm_enzyme) => { [INFO] [stderr] 138 | | ptm_enzyme_id = ptm_enzyme.pro_id.clone(); [INFO] [stderr] 139 | | ptm_enzyme_label = ptm_enzyme.label.clone(); [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 136 | match proteoform.ptm_enzyme { [INFO] [stderr] 137 | Some(ref ptm_enzyme) => { [INFO] [stderr] 138 | ptm_enzyme_id = ptm_enzyme.pro_id.clone(); [INFO] [stderr] 139 | ptm_enzyme_label = ptm_enzyme.label.clone(); [INFO] [stderr] 140 | }, [INFO] [stderr] 141 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / match &proteoform.source { [INFO] [stderr] 150 | | &Some(ref source) => { [INFO] [stderr] 151 | | source_name = source.name.clone(); [INFO] [stderr] 152 | | }, [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | match proteoform.source { [INFO] [stderr] 150 | Some(ref source) => { [INFO] [stderr] 151 | source_name = source.name.clone(); [INFO] [stderr] 152 | }, [INFO] [stderr] 153 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:176:41 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn proteoform_ppis(proteoforms_ppi: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ProteoformPPI]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / match &proteoform_ppi.protein_1 { [INFO] [stderr] 184 | | &Some(ref protein_1) => { [INFO] [stderr] 185 | | protein_1_pro_id = protein_1.pro_id.clone(); [INFO] [stderr] 186 | | protein_1_label = protein_1.label.clone(); [INFO] [stderr] ... | [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 183 | match proteoform_ppi.protein_1 { [INFO] [stderr] 184 | Some(ref protein_1) => { [INFO] [stderr] 185 | protein_1_pro_id = protein_1.pro_id.clone(); [INFO] [stderr] 186 | protein_1_label = protein_1.label.clone(); [INFO] [stderr] 187 | }, [INFO] [stderr] 188 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | / match &proteoform_ppi.protein_2 { [INFO] [stderr] 198 | | &Some(ref protein_2) => { [INFO] [stderr] 199 | | protein_2_pro_id = protein_2.pro_id.clone(); [INFO] [stderr] 200 | | protein_2_label = protein_2.label.clone(); [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 197 | match proteoform_ppi.protein_2 { [INFO] [stderr] 198 | Some(ref protein_2) => { [INFO] [stderr] 199 | protein_2_pro_id = protein_2.pro_id.clone(); [INFO] [stderr] 200 | protein_2_label = protein_2.label.clone(); [INFO] [stderr] 201 | }, [INFO] [stderr] 202 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | / match &proteoform_ppi.source { [INFO] [stderr] 216 | | &Some(ref source) => { [INFO] [stderr] 217 | | source_name = source.name.clone(); [INFO] [stderr] 218 | | }, [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 215 | match proteoform_ppi.source { [INFO] [stderr] 216 | Some(ref source) => { [INFO] [stderr] 217 | source_name = source.name.clone(); [INFO] [stderr] 218 | }, [INFO] [stderr] 219 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:241:26 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn ptm_ppi(ptm_ppis: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[PTMPPI]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | / match &ptm_ppi.substrate { [INFO] [stderr] 248 | | &Some(ref substrate) => { [INFO] [stderr] 249 | | substrate_uniprot_id = substrate.uniprot_id.clone(); [INFO] [stderr] 250 | | substrate_name = substrate.name.clone(); [INFO] [stderr] ... | [INFO] [stderr] 255 | | } [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 247 | match ptm_ppi.substrate { [INFO] [stderr] 248 | Some(ref substrate) => { [INFO] [stderr] 249 | substrate_uniprot_id = substrate.uniprot_id.clone(); [INFO] [stderr] 250 | substrate_name = substrate.name.clone(); [INFO] [stderr] 251 | }, [INFO] [stderr] 252 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | / match &ptm_ppi.interactant { [INFO] [stderr] 262 | | &Some(ref interactant) => { [INFO] [stderr] 263 | | interactant_uniprot_id = interactant.uniprot_id.clone(); [INFO] [stderr] 264 | | interactant_name = interactant.name.clone(); [INFO] [stderr] ... | [INFO] [stderr] 269 | | } [INFO] [stderr] 270 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 261 | match ptm_ppi.interactant { [INFO] [stderr] 262 | Some(ref interactant) => { [INFO] [stderr] 263 | interactant_uniprot_id = interactant.uniprot_id.clone(); [INFO] [stderr] 264 | interactant_name = interactant.name.clone(); [INFO] [stderr] 265 | }, [INFO] [stderr] 266 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | / match &ptm_ppi.source { [INFO] [stderr] 275 | | &Some(ref source) => { [INFO] [stderr] 276 | | source_name = source.name.clone(); [INFO] [stderr] 277 | | }, [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 274 | match ptm_ppi.source { [INFO] [stderr] 275 | Some(ref source) => { [INFO] [stderr] 276 | source_name = source.name.clone(); [INFO] [stderr] 277 | }, [INFO] [stderr] 278 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:303:45 [INFO] [stderr] | [INFO] [stderr] 303 | pub fn batch_ptm_enzymes(batch_ptm_enzymes: &Vec) -> Vec{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[BatchPTMEnzyme]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | / match &batch_ptm_enzyme.enzyme { [INFO] [stderr] 312 | | &Some(ref enzyme) => { [INFO] [stderr] 313 | | enz_name = enzyme.name.clone(); [INFO] [stderr] 314 | | enz_id = enzyme.uniprot_id.clone(); [INFO] [stderr] ... | [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 311 | match batch_ptm_enzyme.enzyme { [INFO] [stderr] 312 | Some(ref enzyme) => { [INFO] [stderr] 313 | enz_name = enzyme.name.clone(); [INFO] [stderr] 314 | enz_id = enzyme.uniprot_id.clone(); [INFO] [stderr] 315 | }, [INFO] [stderr] 316 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | / match &batch_ptm_enzyme.substrate { [INFO] [stderr] 326 | | &Some(ref substrate) => { [INFO] [stderr] 327 | | sub_name = substrate.name.clone(); [INFO] [stderr] 328 | | sub_id = substrate.uniprot_id.clone(); [INFO] [stderr] ... | [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | match batch_ptm_enzyme.substrate { [INFO] [stderr] 326 | Some(ref substrate) => { [INFO] [stderr] 327 | sub_name = substrate.name.clone(); [INFO] [stderr] 328 | sub_id = substrate.uniprot_id.clone(); [INFO] [stderr] 329 | }, [INFO] [stderr] 330 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:347:28 [INFO] [stderr] | [INFO] [stderr] 347 | site_position: batch_ptm_enzyme.site_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `batch_ptm_enzyme.site_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:348:20 [INFO] [stderr] | [INFO] [stderr] 348 | score: batch_ptm_enzyme.score.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `batch_ptm_enzyme.score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:361:38 [INFO] [stderr] | [INFO] [stderr] 361 | pub fn batch_ptm_ppi(batch_ptm_ppis: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[BatchPTMPPI]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:368:9 [INFO] [stderr] | [INFO] [stderr] 368 | / match &batch_ptm_ppi.interactant { [INFO] [stderr] 369 | | &Some(ref interactant) => { [INFO] [stderr] 370 | | interactant_uniprot_id = interactant.uniprot_id.clone(); [INFO] [stderr] 371 | | interactant_name = interactant.name.clone(); [INFO] [stderr] ... | [INFO] [stderr] 376 | | } [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 368 | match batch_ptm_ppi.interactant { [INFO] [stderr] 369 | Some(ref interactant) => { [INFO] [stderr] 370 | interactant_uniprot_id = interactant.uniprot_id.clone(); [INFO] [stderr] 371 | interactant_name = interactant.name.clone(); [INFO] [stderr] 372 | }, [INFO] [stderr] 373 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | / match &batch_ptm_ppi.substrate { [INFO] [stderr] 383 | | &Some(ref substrate) => { [INFO] [stderr] 384 | | substrate_uniprot_id = substrate.uniprot_id.clone(); [INFO] [stderr] 385 | | substrate_name = substrate.name.clone(); [INFO] [stderr] ... | [INFO] [stderr] 390 | | } [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 382 | match batch_ptm_ppi.substrate { [INFO] [stderr] 383 | Some(ref substrate) => { [INFO] [stderr] 384 | substrate_uniprot_id = substrate.uniprot_id.clone(); [INFO] [stderr] 385 | substrate_name = substrate.name.clone(); [INFO] [stderr] 386 | }, [INFO] [stderr] 387 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | / match &batch_ptm_ppi.source { [INFO] [stderr] 396 | | &Some(ref source) => { [INFO] [stderr] 397 | | source_name = source.name.clone(); [INFO] [stderr] 398 | | }, [INFO] [stderr] ... | [INFO] [stderr] 401 | | } [INFO] [stderr] 402 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 395 | match batch_ptm_ppi.source { [INFO] [stderr] 396 | Some(ref source) => { [INFO] [stderr] 397 | source_name = source.name.clone(); [INFO] [stderr] 398 | }, [INFO] [stderr] 399 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:408:28 [INFO] [stderr] | [INFO] [stderr] 408 | site_position: batch_ptm_ppi.site_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `batch_ptm_ppi.site_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:426:25 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn sources(sources: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Source]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | / match &source.name { [INFO] [stderr] 432 | | &Some(ref name) => {sources_str = name.clone()}, [INFO] [stderr] 433 | | &None => {} [INFO] [stderr] 434 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 431 | match source.name { [INFO] [stderr] 432 | Some(ref name) => {sources_str = name.clone()}, [INFO] [stderr] 433 | None => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | / match &source.name { [INFO] [stderr] 437 | | &Some(ref name) => { [INFO] [stderr] 438 | | sources_str = format!("{prev_str},{curr_str}",prev_str=sources_str,curr_str=name); [INFO] [stderr] 439 | | }, [INFO] [stderr] 440 | | &None => {} [INFO] [stderr] 441 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 436 | match source.name { [INFO] [stderr] 437 | Some(ref name) => { [INFO] [stderr] 438 | sources_str = format!("{prev_str},{curr_str}",prev_str=sources_str,curr_str=name); [INFO] [stderr] 439 | }, [INFO] [stderr] 440 | None => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:15:54 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn search(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:15:84 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn search(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/query_builder.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn search(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] 16 | | let search_clause = search_clause(term_type, role,ptm_types,organism_taxons, paginate, offset, limit, engine); [INFO] [stderr] 17 | | return format!("SELECT * FROM {search_clause}",search_clause=search_clause); [INFO] [stderr] 18 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:20:60 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn search_count(term_type: &str, role: &str,ptm_types: &Vec, organism_taxons: &Vec,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:20:91 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn search_count(term_type: &str, role: &str,ptm_types: &Vec, organism_taxons: &Vec,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:25:57 [INFO] [stderr] | [INFO] [stderr] 25 | fn search_clause(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:25:87 [INFO] [stderr] | [INFO] [stderr] 25 | fn search_clause(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/query_builder.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / fn search_clause(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] 26 | | // build the search term matching clause [INFO] [stderr] 27 | | let mut search_term_clause = String::new(); [INFO] [stderr] 28 | | [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match engine { [INFO] [stderr] 31 | | &Engine::Postgres => { [INFO] [stderr] 32 | | search_term_clause = String::from("uniprot_id ILIKE $1 OR protein_name ILIKE $2 OR gene_name ILIKE $3"); [INFO] [stderr] 33 | | }, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *engine { [INFO] [stderr] 31 | Engine::Postgres => { [INFO] [stderr] 32 | search_term_clause = String::from("uniprot_id ILIKE $1 OR protein_name ILIKE $2 OR gene_name ILIKE $3"); [INFO] [stderr] 33 | }, [INFO] [stderr] 34 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / match engine { [INFO] [stderr] 41 | | &Engine::Postgres => { [INFO] [stderr] 42 | | search_term_clause = String::from("uniprot_id ILIKE $1") [INFO] [stderr] 43 | | }, [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *engine { [INFO] [stderr] 41 | Engine::Postgres => { [INFO] [stderr] 42 | search_term_clause = String::from("uniprot_id ILIKE $1") [INFO] [stderr] 43 | }, [INFO] [stderr] 44 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match engine { [INFO] [stderr] 51 | | &Engine::Postgres => { [INFO] [stderr] 52 | | search_term_clause = String::from("uniprot_id ILIKE $1 OR gene_name ILIKE $2") [INFO] [stderr] 53 | | }, [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *engine { [INFO] [stderr] 51 | Engine::Postgres => { [INFO] [stderr] 52 | search_term_clause = String::from("uniprot_id ILIKE $1 OR gene_name ILIKE $2") [INFO] [stderr] 53 | }, [INFO] [stderr] 54 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / match engine { [INFO] [stderr] 141 | | &Engine::Postgres => { [INFO] [stderr] 142 | | return query_str; [INFO] [stderr] 143 | | }, [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 140 | match *engine { [INFO] [stderr] 141 | Engine::Postgres => { [INFO] [stderr] 142 | return query_str; [INFO] [stderr] 143 | }, [INFO] [stderr] 144 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / match engine { [INFO] [stderr] 153 | | &Engine::Postgres => { [INFO] [stderr] 154 | | return query_str; [INFO] [stderr] 155 | | }, [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | match *engine { [INFO] [stderr] 153 | Engine::Postgres => { [INFO] [stderr] 154 | return query_str; [INFO] [stderr] 155 | }, [INFO] [stderr] 156 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / match engine { [INFO] [stderr] 164 | | &Engine::Postgres => { [INFO] [stderr] 165 | | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME != 'Interaction'"); [INFO] [stderr] 166 | | }, [INFO] [stderr] ... | [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 163 | match *engine { [INFO] [stderr] 164 | Engine::Postgres => { [INFO] [stderr] 165 | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME != 'Interaction'"); [INFO] [stderr] 166 | }, [INFO] [stderr] 167 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / match engine { [INFO] [stderr] 175 | | &Engine::Postgres => { [INFO] [stderr] 176 | | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME = 'Interaction'"); [INFO] [stderr] 177 | | }, [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 174 | match *engine { [INFO] [stderr] 175 | Engine::Postgres => { [INFO] [stderr] 176 | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME = 'Interaction'"); [INFO] [stderr] 177 | }, [INFO] [stderr] 178 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / match engine { [INFO] [stderr] 187 | | &Engine::Postgres => { [INFO] [stderr] 188 | | return query_str; [INFO] [stderr] 189 | | }, [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | match *engine { [INFO] [stderr] 187 | Engine::Postgres => { [INFO] [stderr] 188 | return query_str; [INFO] [stderr] 189 | }, [INFO] [stderr] 190 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/msa.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | fn to_fasta(sequences: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Sequence]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/msa.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn align(sequences: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Sequence]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/msa.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | position = position + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `position += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msa.rs:94:62 [INFO] [stderr] | [INFO] [stderr] 94 | let decorations = database::get_decorations(&id,&form_id,position as i64,&site,&conn)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(position)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `iptmnet_api`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/misc.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn parse_configs(conf: &ini::Ini) -> DBParams { [INFO] [stderr] 12 | | let engine; [INFO] [stderr] 13 | | let mut host = &String::new();; [INFO] [stderr] 14 | | let mut port = &String::new();; [INFO] [stderr] ... | [INFO] [stderr] 163 | | return db_params; [INFO] [stderr] 164 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match conf.section(Some("POSTGRES".to_owned())) { [INFO] [stderr] 39 | | Some(section) => { [INFO] [stderr] 40 | | //host [INFO] [stderr] 41 | | match section.get("host") { [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(section) = conf.section(Some("POSTGRES".to_owned())) { [INFO] [stderr] 39 | //host [INFO] [stderr] 40 | match section.get("host") { [INFO] [stderr] 41 | Some(value) => { [INFO] [stderr] 42 | host=value; [INFO] [stderr] 43 | } None => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match conf.section(Some("ORACLE".to_owned())) { [INFO] [stderr] 97 | | Some(section) => { [INFO] [stderr] 98 | | //host [INFO] [stderr] 99 | | match section.get("host") { [INFO] [stderr] ... | [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(section) = conf.section(Some("ORACLE".to_owned())) { [INFO] [stderr] 97 | //host [INFO] [stderr] 98 | match section.get("host") { [INFO] [stderr] 99 | Some(value) => { [INFO] [stderr] 100 | host=value; [INFO] [stderr] 101 | } None => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/misc.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / match data_str { [INFO] [stderr] 168 | | &Some(ref data) => { [INFO] [stderr] 169 | | let split = data.split(seperator); [INFO] [stderr] 170 | | let mut vec: Vec = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *data_str { [INFO] [stderr] 168 | Some(ref data) => { [INFO] [stderr] 169 | let split = data.split(seperator); [INFO] [stderr] 170 | let mut vec: Vec = Vec::new(); [INFO] [stderr] 171 | for s in split { [INFO] [stderr] 172 | if s.len() != 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/misc.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | if s.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/misc.rs:215:5 [INFO] [stderr] | [INFO] [stderr] 215 | / match data_str { [INFO] [stderr] 216 | | &Some(ref data) => { [INFO] [stderr] 217 | | let split = data.split(seperator); [INFO] [stderr] 218 | | let mut vec: Vec = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 215 | match *data_str { [INFO] [stderr] 216 | Some(ref data) => { [INFO] [stderr] 217 | let split = data.split(seperator); [INFO] [stderr] 218 | let mut vec: Vec = Vec::new(); [INFO] [stderr] 219 | for s in split { [INFO] [stderr] 220 | if s.len() != 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/misc.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | if s.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:244:6 [INFO] [stderr] | [INFO] [stderr] 244 | / match pmid_option { [INFO] [stderr] 245 | | Some(value) => { [INFO] [stderr] 246 | | //check if this pmid is joined or seperate [INFO] [stderr] 247 | | if value.contains(","){ [INFO] [stderr] ... | [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 244 | if let Some(value) = pmid_option { [INFO] [stderr] 245 | //check if this pmid is joined or seperate [INFO] [stderr] 246 | if value.contains(","){ [INFO] [stderr] 247 | //split pmid into subsequent strings [INFO] [stderr] 248 | let split_pmids = value.split(","); [INFO] [stderr] 249 | for pmid in split_pmids { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/misc.rs:247:31 [INFO] [stderr] | [INFO] [stderr] 247 | if value.contains(","){ [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/misc.rs:249:47 [INFO] [stderr] | [INFO] [stderr] 249 | let split_pmids = value.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:270:33 [INFO] [stderr] | [INFO] [stderr] 270 | pub fn remove_duplicates(items: &Vec) -> Vec{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:280:30 [INFO] [stderr] | [INFO] [stderr] 280 | pub fn str_vec_to_str(items: &Vec) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:294:39 [INFO] [stderr] | [INFO] [stderr] 294 | pub fn str_vec_to_str_with_sep(items: &Vec,seperator: String) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:308:36 [INFO] [stderr] | [INFO] [stderr] 308 | pub fn taxons_to_tuple_str(taxons: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:332:37 [INFO] [stderr] | [INFO] [stderr] 332 | pub fn to_postgres_array_str(items: &Vec) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:411:56 [INFO] [stderr] | [INFO] [stderr] 411 | pub fn query_substrates_to_tuple_str(query_substrates: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[QuerySubstrate]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:426:76 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn calculate_score_batch_ptm_enzymes(num_substrates: Vec,sources: &Vec,pmids: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:426:96 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn calculate_score_batch_ptm_enzymes(num_substrates: Vec,sources: &Vec,pmids: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:449:64 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn calculate_score(pmid_stats: &HashMap,pmids: &Vec, sources: &Vec ) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:449:87 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn calculate_score(pmid_stats: &HashMap,pmids: &Vec, sources: &Vec ) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/misc.rs:451:5 [INFO] [stderr] | [INFO] [stderr] 451 | / let sn; [INFO] [stderr] 452 | | if sources.len() >= 2 { [INFO] [stderr] 453 | | sn = 1; [INFO] [stderr] 454 | | }else{ [INFO] [stderr] 455 | | sn = 0; [INFO] [stderr] 456 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sn = if sources.len() >= 2 { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:484:35 [INFO] [stderr] | [INFO] [stderr] 484 | fn has_preferred_sources(sources: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc.rs:497:31 [INFO] [stderr] | [INFO] [stderr] 497 | fn has_non_large_scale(pmids: &Vec, pmid_stats: &HashMap) -> bool{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/misc.rs:502:20 [INFO] [stderr] | [INFO] [stderr] 502 | if count <= &threshold { [INFO] [stderr] | ^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `threshold` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:5:39 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn search_results(search_results: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[SearchResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match &search_result.organism { [INFO] [stderr] 15 | | &Some(ref organism) => { [INFO] [stderr] 16 | | taxon_code = organism.taxon_code.clone(); [INFO] [stderr] 17 | | species = organism.species.clone(); [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | match search_result.organism { [INFO] [stderr] 15 | Some(ref organism) => { [INFO] [stderr] 16 | taxon_code = organism.taxon_code.clone(); [INFO] [stderr] 17 | species = organism.species.clone(); [INFO] [stderr] 18 | common_name = organism.common_name.clone(); [INFO] [stderr] 19 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | substrate_role: search_result.substrate_role.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.substrate_role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | substrate_num: search_result.substrate_num.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.substrate_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | enzyme_role: search_result.enzyme_role.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.enzyme_role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | enzyme_num: search_result.enzyme_num.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.enzyme_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:43:38 [INFO] [stderr] | [INFO] [stderr] 43 | ptm_dependent_ppi_role : search_result.ptm_dependent_ppi_role.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.ptm_dependent_ppi_role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | ptm_dependent_ppi_num : search_result.ptm_dependent_ppi_num.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.ptm_dependent_ppi_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | sites: search_result.sites.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.sites` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | isoforms: search_result.isoforms.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.isoforms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/flatten.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | / match enzyme.name { [INFO] [stderr] 75 | | Some(ref value) => { [INFO] [stderr] 76 | | enzyme_name = value.clone(); [INFO] [stderr] 77 | | }, [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let Some(ref value) = enzyme.name { [INFO] [stderr] 75 | enzyme_name = value.clone(); [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/flatten.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / match enzyme.id { [INFO] [stderr] 84 | | Some(ref value) => { [INFO] [stderr] 85 | | enzyme_id = value.clone(); [INFO] [stderr] 86 | | }, [INFO] [stderr] ... | [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let Some(ref value) = enzyme.id { [INFO] [stderr] 84 | enzyme_id = value.clone(); [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/flatten.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match enzyme.enz_type { [INFO] [stderr] 93 | | Some(ref value) => { [INFO] [stderr] 94 | | enzyme_type = value.clone(); [INFO] [stderr] 95 | | }, [INFO] [stderr] ... | [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(ref value) = enzyme.enz_type { [INFO] [stderr] 93 | enzyme_type = value.clone(); [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | score: event.score.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `event.score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:129:32 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn proteoform(proteoforms: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Proteoform]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match &proteoform.ptm_enzyme { [INFO] [stderr] 137 | | &Some(ref ptm_enzyme) => { [INFO] [stderr] 138 | | ptm_enzyme_id = ptm_enzyme.pro_id.clone(); [INFO] [stderr] 139 | | ptm_enzyme_label = ptm_enzyme.label.clone(); [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 136 | match proteoform.ptm_enzyme { [INFO] [stderr] 137 | Some(ref ptm_enzyme) => { [INFO] [stderr] 138 | ptm_enzyme_id = ptm_enzyme.pro_id.clone(); [INFO] [stderr] 139 | ptm_enzyme_label = ptm_enzyme.label.clone(); [INFO] [stderr] 140 | }, [INFO] [stderr] 141 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / match &proteoform.source { [INFO] [stderr] 150 | | &Some(ref source) => { [INFO] [stderr] 151 | | source_name = source.name.clone(); [INFO] [stderr] 152 | | }, [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | match proteoform.source { [INFO] [stderr] 150 | Some(ref source) => { [INFO] [stderr] 151 | source_name = source.name.clone(); [INFO] [stderr] 152 | }, [INFO] [stderr] 153 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:176:41 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn proteoform_ppis(proteoforms_ppi: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ProteoformPPI]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / match &proteoform_ppi.protein_1 { [INFO] [stderr] 184 | | &Some(ref protein_1) => { [INFO] [stderr] 185 | | protein_1_pro_id = protein_1.pro_id.clone(); [INFO] [stderr] 186 | | protein_1_label = protein_1.label.clone(); [INFO] [stderr] ... | [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 183 | match proteoform_ppi.protein_1 { [INFO] [stderr] 184 | Some(ref protein_1) => { [INFO] [stderr] 185 | protein_1_pro_id = protein_1.pro_id.clone(); [INFO] [stderr] 186 | protein_1_label = protein_1.label.clone(); [INFO] [stderr] 187 | }, [INFO] [stderr] 188 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | / match &proteoform_ppi.protein_2 { [INFO] [stderr] 198 | | &Some(ref protein_2) => { [INFO] [stderr] 199 | | protein_2_pro_id = protein_2.pro_id.clone(); [INFO] [stderr] 200 | | protein_2_label = protein_2.label.clone(); [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 197 | match proteoform_ppi.protein_2 { [INFO] [stderr] 198 | Some(ref protein_2) => { [INFO] [stderr] 199 | protein_2_pro_id = protein_2.pro_id.clone(); [INFO] [stderr] 200 | protein_2_label = protein_2.label.clone(); [INFO] [stderr] 201 | }, [INFO] [stderr] 202 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | / match &proteoform_ppi.source { [INFO] [stderr] 216 | | &Some(ref source) => { [INFO] [stderr] 217 | | source_name = source.name.clone(); [INFO] [stderr] 218 | | }, [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 215 | match proteoform_ppi.source { [INFO] [stderr] 216 | Some(ref source) => { [INFO] [stderr] 217 | source_name = source.name.clone(); [INFO] [stderr] 218 | }, [INFO] [stderr] 219 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:241:26 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn ptm_ppi(ptm_ppis: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[PTMPPI]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | / match &ptm_ppi.substrate { [INFO] [stderr] 248 | | &Some(ref substrate) => { [INFO] [stderr] 249 | | substrate_uniprot_id = substrate.uniprot_id.clone(); [INFO] [stderr] 250 | | substrate_name = substrate.name.clone(); [INFO] [stderr] ... | [INFO] [stderr] 255 | | } [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 247 | match ptm_ppi.substrate { [INFO] [stderr] 248 | Some(ref substrate) => { [INFO] [stderr] 249 | substrate_uniprot_id = substrate.uniprot_id.clone(); [INFO] [stderr] 250 | substrate_name = substrate.name.clone(); [INFO] [stderr] 251 | }, [INFO] [stderr] 252 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | / match &ptm_ppi.interactant { [INFO] [stderr] 262 | | &Some(ref interactant) => { [INFO] [stderr] 263 | | interactant_uniprot_id = interactant.uniprot_id.clone(); [INFO] [stderr] 264 | | interactant_name = interactant.name.clone(); [INFO] [stderr] ... | [INFO] [stderr] 269 | | } [INFO] [stderr] 270 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 261 | match ptm_ppi.interactant { [INFO] [stderr] 262 | Some(ref interactant) => { [INFO] [stderr] 263 | interactant_uniprot_id = interactant.uniprot_id.clone(); [INFO] [stderr] 264 | interactant_name = interactant.name.clone(); [INFO] [stderr] 265 | }, [INFO] [stderr] 266 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | / match &ptm_ppi.source { [INFO] [stderr] 275 | | &Some(ref source) => { [INFO] [stderr] 276 | | source_name = source.name.clone(); [INFO] [stderr] 277 | | }, [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 274 | match ptm_ppi.source { [INFO] [stderr] 275 | Some(ref source) => { [INFO] [stderr] 276 | source_name = source.name.clone(); [INFO] [stderr] 277 | }, [INFO] [stderr] 278 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:303:45 [INFO] [stderr] | [INFO] [stderr] 303 | pub fn batch_ptm_enzymes(batch_ptm_enzymes: &Vec) -> Vec{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[BatchPTMEnzyme]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | / match &batch_ptm_enzyme.enzyme { [INFO] [stderr] 312 | | &Some(ref enzyme) => { [INFO] [stderr] 313 | | enz_name = enzyme.name.clone(); [INFO] [stderr] 314 | | enz_id = enzyme.uniprot_id.clone(); [INFO] [stderr] ... | [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 311 | match batch_ptm_enzyme.enzyme { [INFO] [stderr] 312 | Some(ref enzyme) => { [INFO] [stderr] 313 | enz_name = enzyme.name.clone(); [INFO] [stderr] 314 | enz_id = enzyme.uniprot_id.clone(); [INFO] [stderr] 315 | }, [INFO] [stderr] 316 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | / match &batch_ptm_enzyme.substrate { [INFO] [stderr] 326 | | &Some(ref substrate) => { [INFO] [stderr] 327 | | sub_name = substrate.name.clone(); [INFO] [stderr] 328 | | sub_id = substrate.uniprot_id.clone(); [INFO] [stderr] ... | [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | match batch_ptm_enzyme.substrate { [INFO] [stderr] 326 | Some(ref substrate) => { [INFO] [stderr] 327 | sub_name = substrate.name.clone(); [INFO] [stderr] 328 | sub_id = substrate.uniprot_id.clone(); [INFO] [stderr] 329 | }, [INFO] [stderr] 330 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:347:28 [INFO] [stderr] | [INFO] [stderr] 347 | site_position: batch_ptm_enzyme.site_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `batch_ptm_enzyme.site_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:348:20 [INFO] [stderr] | [INFO] [stderr] 348 | score: batch_ptm_enzyme.score.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `batch_ptm_enzyme.score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:361:38 [INFO] [stderr] | [INFO] [stderr] 361 | pub fn batch_ptm_ppi(batch_ptm_ppis: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[BatchPTMPPI]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:368:9 [INFO] [stderr] | [INFO] [stderr] 368 | / match &batch_ptm_ppi.interactant { [INFO] [stderr] 369 | | &Some(ref interactant) => { [INFO] [stderr] 370 | | interactant_uniprot_id = interactant.uniprot_id.clone(); [INFO] [stderr] 371 | | interactant_name = interactant.name.clone(); [INFO] [stderr] ... | [INFO] [stderr] 376 | | } [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 368 | match batch_ptm_ppi.interactant { [INFO] [stderr] 369 | Some(ref interactant) => { [INFO] [stderr] 370 | interactant_uniprot_id = interactant.uniprot_id.clone(); [INFO] [stderr] 371 | interactant_name = interactant.name.clone(); [INFO] [stderr] 372 | }, [INFO] [stderr] 373 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | / match &batch_ptm_ppi.substrate { [INFO] [stderr] 383 | | &Some(ref substrate) => { [INFO] [stderr] 384 | | substrate_uniprot_id = substrate.uniprot_id.clone(); [INFO] [stderr] 385 | | substrate_name = substrate.name.clone(); [INFO] [stderr] ... | [INFO] [stderr] 390 | | } [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 382 | match batch_ptm_ppi.substrate { [INFO] [stderr] 383 | Some(ref substrate) => { [INFO] [stderr] 384 | substrate_uniprot_id = substrate.uniprot_id.clone(); [INFO] [stderr] 385 | substrate_name = substrate.name.clone(); [INFO] [stderr] 386 | }, [INFO] [stderr] 387 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | / match &batch_ptm_ppi.source { [INFO] [stderr] 396 | | &Some(ref source) => { [INFO] [stderr] 397 | | source_name = source.name.clone(); [INFO] [stderr] 398 | | }, [INFO] [stderr] ... | [INFO] [stderr] 401 | | } [INFO] [stderr] 402 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 395 | match batch_ptm_ppi.source { [INFO] [stderr] 396 | Some(ref source) => { [INFO] [stderr] 397 | source_name = source.name.clone(); [INFO] [stderr] 398 | }, [INFO] [stderr] 399 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flatten.rs:408:28 [INFO] [stderr] | [INFO] [stderr] 408 | site_position: batch_ptm_ppi.site_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `batch_ptm_ppi.site_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/flatten.rs:426:25 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn sources(sources: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Source]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | / match &source.name { [INFO] [stderr] 432 | | &Some(ref name) => {sources_str = name.clone()}, [INFO] [stderr] 433 | | &None => {} [INFO] [stderr] 434 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 431 | match source.name { [INFO] [stderr] 432 | Some(ref name) => {sources_str = name.clone()}, [INFO] [stderr] 433 | None => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flatten.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | / match &source.name { [INFO] [stderr] 437 | | &Some(ref name) => { [INFO] [stderr] 438 | | sources_str = format!("{prev_str},{curr_str}",prev_str=sources_str,curr_str=name); [INFO] [stderr] 439 | | }, [INFO] [stderr] 440 | | &None => {} [INFO] [stderr] 441 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 436 | match source.name { [INFO] [stderr] 437 | Some(ref name) => { [INFO] [stderr] 438 | sources_str = format!("{prev_str},{curr_str}",prev_str=sources_str,curr_str=name); [INFO] [stderr] 439 | }, [INFO] [stderr] 440 | None => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:15:54 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn search(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:15:84 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn search(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/query_builder.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn search(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] 16 | | let search_clause = search_clause(term_type, role,ptm_types,organism_taxons, paginate, offset, limit, engine); [INFO] [stderr] 17 | | return format!("SELECT * FROM {search_clause}",search_clause=search_clause); [INFO] [stderr] 18 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:20:60 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn search_count(term_type: &str, role: &str,ptm_types: &Vec, organism_taxons: &Vec,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:20:91 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn search_count(term_type: &str, role: &str,ptm_types: &Vec, organism_taxons: &Vec,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:25:57 [INFO] [stderr] | [INFO] [stderr] 25 | fn search_clause(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/query_builder.rs:25:87 [INFO] [stderr] | [INFO] [stderr] 25 | fn search_clause(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/query_builder.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / fn search_clause(term_type: &str, role: &str,ptm_types: &Vec,organism_taxons: &Vec,paginate: bool,offset: i32, limit: i32,engine: &Engine) -> String { [INFO] [stderr] 26 | | // build the search term matching clause [INFO] [stderr] 27 | | let mut search_term_clause = String::new(); [INFO] [stderr] 28 | | [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match engine { [INFO] [stderr] 31 | | &Engine::Postgres => { [INFO] [stderr] 32 | | search_term_clause = String::from("uniprot_id ILIKE $1 OR protein_name ILIKE $2 OR gene_name ILIKE $3"); [INFO] [stderr] 33 | | }, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *engine { [INFO] [stderr] 31 | Engine::Postgres => { [INFO] [stderr] 32 | search_term_clause = String::from("uniprot_id ILIKE $1 OR protein_name ILIKE $2 OR gene_name ILIKE $3"); [INFO] [stderr] 33 | }, [INFO] [stderr] 34 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / match engine { [INFO] [stderr] 41 | | &Engine::Postgres => { [INFO] [stderr] 42 | | search_term_clause = String::from("uniprot_id ILIKE $1") [INFO] [stderr] 43 | | }, [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *engine { [INFO] [stderr] 41 | Engine::Postgres => { [INFO] [stderr] 42 | search_term_clause = String::from("uniprot_id ILIKE $1") [INFO] [stderr] 43 | }, [INFO] [stderr] 44 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match engine { [INFO] [stderr] 51 | | &Engine::Postgres => { [INFO] [stderr] 52 | | search_term_clause = String::from("uniprot_id ILIKE $1 OR gene_name ILIKE $2") [INFO] [stderr] 53 | | }, [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *engine { [INFO] [stderr] 51 | Engine::Postgres => { [INFO] [stderr] 52 | search_term_clause = String::from("uniprot_id ILIKE $1 OR gene_name ILIKE $2") [INFO] [stderr] 53 | }, [INFO] [stderr] 54 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / match engine { [INFO] [stderr] 141 | | &Engine::Postgres => { [INFO] [stderr] 142 | | return query_str; [INFO] [stderr] 143 | | }, [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 140 | match *engine { [INFO] [stderr] 141 | Engine::Postgres => { [INFO] [stderr] 142 | return query_str; [INFO] [stderr] 143 | }, [INFO] [stderr] 144 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / match engine { [INFO] [stderr] 153 | | &Engine::Postgres => { [INFO] [stderr] 154 | | return query_str; [INFO] [stderr] 155 | | }, [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | match *engine { [INFO] [stderr] 153 | Engine::Postgres => { [INFO] [stderr] 154 | return query_str; [INFO] [stderr] 155 | }, [INFO] [stderr] 156 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / match engine { [INFO] [stderr] 164 | | &Engine::Postgres => { [INFO] [stderr] 165 | | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME != 'Interaction'"); [INFO] [stderr] 166 | | }, [INFO] [stderr] ... | [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 163 | match *engine { [INFO] [stderr] 164 | Engine::Postgres => { [INFO] [stderr] 165 | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME != 'Interaction'"); [INFO] [stderr] 166 | }, [INFO] [stderr] 167 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / match engine { [INFO] [stderr] 175 | | &Engine::Postgres => { [INFO] [stderr] 176 | | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME = 'Interaction'"); [INFO] [stderr] 177 | | }, [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 174 | match *engine { [INFO] [stderr] 175 | Engine::Postgres => { [INFO] [stderr] 176 | return String::from("SELECT * FROM MV_PROTEO where SUB_XREF ILIKE $1 AND EVENT_NAME = 'Interaction'"); [INFO] [stderr] 177 | }, [INFO] [stderr] 178 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query_builder.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / match engine { [INFO] [stderr] 187 | | &Engine::Postgres => { [INFO] [stderr] 188 | | return query_str; [INFO] [stderr] 189 | | }, [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | match *engine { [INFO] [stderr] 187 | Engine::Postgres => { [INFO] [stderr] 188 | return query_str; [INFO] [stderr] 189 | }, [INFO] [stderr] 190 | Engine::Oracle => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/msa.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | fn to_fasta(sequences: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Sequence]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/msa.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn align(sequences: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Sequence]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/msa.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | position = position + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `position += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/msa.rs:94:62 [INFO] [stderr] | [INFO] [stderr] 94 | let decorations = database::get_decorations(&id,&form_id,position as i64,&site,&conn)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(position)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `iptmnet_api`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "21addb48837c6b3d2b624a2ca5d6f107964aeb0c35a38c76ad4e031057d42cd3"` [INFO] running `"docker" "rm" "-f" "21addb48837c6b3d2b624a2ca5d6f107964aeb0c35a38c76ad4e031057d42cd3"` [INFO] [stdout] 21addb48837c6b3d2b624a2ca5d6f107964aeb0c35a38c76ad4e031057d42cd3