[INFO] updating cached repository ubsan/z80 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ubsan/z80 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ubsan/z80" "work/ex/clippy-test-run/sources/stable/gh/ubsan/z80"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ubsan/z80'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ubsan/z80" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ubsan/z80"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ubsan/z80'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6feaeac2aaae11e9353caf6688cc993cd3568fee [INFO] sha for GitHub repo ubsan/z80: 6feaeac2aaae11e9353caf6688cc993cd3568fee [INFO] validating manifest of ubsan/z80 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ubsan/z80 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ubsan/z80 [INFO] finished frobbing ubsan/z80 [INFO] frobbed toml for ubsan/z80 written to work/ex/clippy-test-run/sources/stable/gh/ubsan/z80/Cargo.toml [INFO] started frobbing ubsan/z80 [INFO] finished frobbing ubsan/z80 [INFO] frobbed toml for ubsan/z80 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ubsan/z80/Cargo.toml [INFO] crate ubsan/z80 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ubsan/z80 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ubsan/z80:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b3c1b9434725e6716aac3a99c777239443cd6bf18392da90d947a4c08dfe515c [INFO] running `"docker" "start" "-a" "b3c1b9434725e6716aac3a99c777239443cd6bf18392da90d947a4c08dfe515c"` [INFO] [stderr] Checking vec_map v0.7.0 [INFO] [stderr] Checking encode_unicode v0.1.3 [INFO] [stderr] Checking bitflags v0.8.2 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking clap v2.23.3 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking retro v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | (Self::single_arg((n & 0b111000) >> 3), Self::single_arg(n & 0b111)) [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | let r1 = match (n & 0b110000) >> 4 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:122:30 [INFO] [stderr] | [INFO] [stderr] 122 | let (arg0, arg1) = ((n & 0b111000) >> 3, n & 0b111); [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | match (n & 0b11000000) >> 6 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | 0x0 => Self::misc_block(n & 0b111111), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:194:35 [INFO] [stderr] | [INFO] [stderr] 194 | 0x1 => Self::load_block(n & 0b111111), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:195:36 [INFO] [stderr] | [INFO] [stderr] 195 | 0x2 => Self::arith_block(n & 0b111111), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:196:34 [INFO] [stderr] | [INFO] [stderr] 196 | 0x3 => Self::jmp_block(n & 0b111111), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | (Self::single_arg((n & 0b111000) >> 3), Self::single_arg(n & 0b111)) [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | let r1 = match (n & 0b110000) >> 4 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:122:30 [INFO] [stderr] | [INFO] [stderr] 122 | let (arg0, arg1) = ((n & 0b111000) >> 3, n & 0b111); [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | match (n & 0b11000000) >> 6 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | 0x0 => Self::misc_block(n & 0b111111), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:194:35 [INFO] [stderr] | [INFO] [stderr] 194 | 0x1 => Self::load_block(n & 0b111111), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:195:36 [INFO] [stderr] | [INFO] [stderr] 195 | 0x2 => Self::arith_block(n & 0b111111), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip/ops.rs:196:34 [INFO] [stderr] | [INFO] [stderr] 196 | 0x3 => Self::jmp_block(n & 0b111111), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: a method with this name may be added to the standard library in the future [INFO] [stderr] --> src/chip/mod.rs:58:33 [INFO] [stderr] | [INFO] [stderr] 58 | (res, false, false, res.count_ones() % 2 == 0) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unstable_name_collisions)] on by default [INFO] [stderr] = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stderr] = note: for more information, see issue #48919 [INFO] [stderr] = help: call with fully qualified syntax `wrapping::Extensions::count_ones(...)` to keep using the current method [INFO] [stderr] [INFO] [stderr] warning: a method with this name may be added to the standard library in the future [INFO] [stderr] --> src/chip/mod.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | (res, false, false, res.count_ones() % 2 == 0) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stderr] = note: for more information, see issue #48919 [INFO] [stderr] = help: call with fully qualified syntax `wrapping::Extensions::count_ones(...)` to keep using the current method [INFO] [stderr] [INFO] [stderr] warning: a method with this name may be added to the standard library in the future [INFO] [stderr] --> src/chip/mod.rs:66:33 [INFO] [stderr] | [INFO] [stderr] 66 | (res, false, false, res.count_ones() % 2 == 0) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stderr] = note: for more information, see issue #48919 [INFO] [stderr] = help: call with fully qualified syntax `wrapping::Extensions::count_ones(...)` to keep using the current method [INFO] [stderr] [INFO] [stderr] warning: a method with this name may be added to the standard library in the future [INFO] [stderr] --> src/chip/mod.rs:58:33 [INFO] [stderr] | [INFO] [stderr] 58 | (res, false, false, res.count_ones() % 2 == 0) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unstable_name_collisions)] on by default [INFO] [stderr] = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stderr] = note: for more information, see issue #48919 [INFO] [stderr] = help: call with fully qualified syntax `wrapping::Extensions::count_ones(...)` to keep using the current method [INFO] [stderr] [INFO] [stderr] warning: a method with this name may be added to the standard library in the future [INFO] [stderr] --> src/chip/mod.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | (res, false, false, res.count_ones() % 2 == 0) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stderr] = note: for more information, see issue #48919 [INFO] [stderr] = help: call with fully qualified syntax `wrapping::Extensions::count_ones(...)` to keep using the current method [INFO] [stderr] [INFO] [stderr] warning: a method with this name may be added to the standard library in the future [INFO] [stderr] --> src/chip/mod.rs:66:33 [INFO] [stderr] | [INFO] [stderr] 66 | (res, false, false, res.count_ones() % 2 == 0) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stderr] = note: for more information, see issue #48919 [INFO] [stderr] = help: call with fully qualified syntax `wrapping::Extensions::count_ones(...)` to keep using the current method [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/wrapping.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | self as u16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/chip/mod.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | let data = w(pins.data as i8 as i16 as u16); // use sign-extension [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(pins.data as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip/mod.rs:168:24 [INFO] [stderr] | [INFO] [stderr] 168 | pins.address = addr as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/wrapping.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | self as u16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/chip/mod.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | let data = w(pins.data as i8 as i16 as u16); // use sign-extension [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(pins.data as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip/mod.rs:168:24 [INFO] [stderr] | [INFO] [stderr] 168 | pins.address = addr as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.82s [INFO] running `"docker" "inspect" "b3c1b9434725e6716aac3a99c777239443cd6bf18392da90d947a4c08dfe515c"` [INFO] running `"docker" "rm" "-f" "b3c1b9434725e6716aac3a99c777239443cd6bf18392da90d947a4c08dfe515c"` [INFO] [stdout] b3c1b9434725e6716aac3a99c777239443cd6bf18392da90d947a4c08dfe515c