[INFO] updating cached repository tylerwhall/insomniad-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tylerwhall/insomniad-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tylerwhall/insomniad-rs" "work/ex/clippy-test-run/sources/stable/gh/tylerwhall/insomniad-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tylerwhall/insomniad-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tylerwhall/insomniad-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerwhall/insomniad-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerwhall/insomniad-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 62cae28b9a4d0b8cf648ce298dfcdacf1f3f1586
[INFO] sha for GitHub repo tylerwhall/insomniad-rs: 62cae28b9a4d0b8cf648ce298dfcdacf1f3f1586
[INFO] validating manifest of tylerwhall/insomniad-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tylerwhall/insomniad-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tylerwhall/insomniad-rs
[INFO] finished frobbing tylerwhall/insomniad-rs
[INFO] frobbed toml for tylerwhall/insomniad-rs written to work/ex/clippy-test-run/sources/stable/gh/tylerwhall/insomniad-rs/Cargo.toml
[INFO] started frobbing tylerwhall/insomniad-rs
[INFO] finished frobbing tylerwhall/insomniad-rs
[INFO] frobbed toml for tylerwhall/insomniad-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerwhall/insomniad-rs/Cargo.toml
[INFO] crate tylerwhall/insomniad-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tylerwhall/insomniad-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tylerwhall/insomniad-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 241322f6c0921bf942dca17349ea79f6f2ab510cec44765431d4809f8cd2093e
[INFO] running `"docker" "start" "-a" "241322f6c0921bf942dca17349ea79f6f2ab510cec44765431d4809f8cd2093e"`
[INFO] [stderr]     Checking winapi v0.2.8
[INFO] [stderr]     Checking libc v0.2.19
[INFO] [stderr]     Checking utf8-ranges v0.1.3
[INFO] [stderr]     Checking regex-syntax v0.3.9
[INFO] [stderr]     Checking log v0.3.6
[INFO] [stderr]     Checking getopts v0.2.14
[INFO] [stderr]     Checking kernel32-sys v0.2.2
[INFO] [stderr]     Checking thread-id v2.0.0
[INFO] [stderr]     Checking memchr v0.1.11
[INFO] [stderr]     Checking thread_local v0.2.7
[INFO] [stderr]     Checking aho-corasick v0.5.3
[INFO] [stderr]     Checking regex v0.1.80
[INFO] [stderr]     Checking env_logger v0.3.5
[INFO] [stderr]     Checking insomniad v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             state: state,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |             file: file,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:111:13
[INFO] [stderr]     |
[INFO] [stderr] 111 |             count: count,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `count`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/wakeup_sources.rs:63:20
[INFO] [stderr]    |
[INFO] [stderr] 63 |     const HEADER: &'static str = concat!("name\t\t",
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/wakeup_sources.rs:86:32
[INFO] [stderr]    |
[INFO] [stderr] 86 |     assert_eq!(ws.last_change, 2229000u64.into());
[INFO] [stderr]    |                                ^^^^^^^^^^ help: consider: `2_229_000u64`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:47:16
[INFO] [stderr]    |
[INFO] [stderr] 47 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 48 | |             if let Some(state) = states.split_whitespace()
[INFO] [stderr] 49 | |                 .find(|kstate| *kstate == "mem") {
[INFO] [stderr] 50 | |                 // Prefer mem
[INFO] [stderr] ...  |
[INFO] [stderr] 61 | |             }
[INFO] [stderr] 62 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 47 |         } else if let Some(state) = states.split_whitespace()
[INFO] [stderr] 48 |     .find(|kstate| *kstate == "mem") {
[INFO] [stderr] 49 |     // Prefer mem
[INFO] [stderr] 50 |     state.to_string()
[INFO] [stderr] 51 | } else if let Some(state) = states.split_whitespace()
[INFO] [stderr] 52 |     .find(|kstate| *kstate == "freeze") {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/wakeup_sources.rs:29:54
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let mut fields = line.split('\t').filter(|field| field.len() > 0);
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!field.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/wakeup_sources.rs:50:34
[INFO] [stderr]    |
[INFO] [stderr] 50 |                    active_count: 0u64.into(),
[INFO] [stderr]    |                                  ^^^^^^^^^^^ help: consider removing `.into()`: `0u64`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/wakeup_sources.rs:51:33
[INFO] [stderr]    |
[INFO] [stderr] 51 |                    event_count: 0u64.into(),
[INFO] [stderr]    |                                 ^^^^^^^^^^^ help: consider removing `.into()`: `0u64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/wakeup_sources.rs:52:34
[INFO] [stderr]    |
[INFO] [stderr] 52 |                    wakeup_count: 0u64.into(),
[INFO] [stderr]    |                                  ^^^^^^^^^^^ help: consider removing `.into()`: `0u64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/wakeup_sources.rs:53:34
[INFO] [stderr]    |
[INFO] [stderr] 53 |                    expire_count: 0u64.into(),
[INFO] [stderr]    |                                  ^^^^^^^^^^^ help: consider removing `.into()`: `0u64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             state: state,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |             file: file,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:111:13
[INFO] [stderr]     |
[INFO] [stderr] 111 |             count: count,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `count`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/wakeup_sources.rs:63:20
[INFO] [stderr]    |
[INFO] [stderr] 63 |     const HEADER: &'static str = concat!("name\t\t",
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:47:16
[INFO] [stderr]    |
[INFO] [stderr] 47 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 48 | |             if let Some(state) = states.split_whitespace()
[INFO] [stderr] 49 | |                 .find(|kstate| *kstate == "mem") {
[INFO] [stderr] 50 | |                 // Prefer mem
[INFO] [stderr] ...  |
[INFO] [stderr] 61 | |             }
[INFO] [stderr] 62 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 47 |         } else if let Some(state) = states.split_whitespace()
[INFO] [stderr] 48 |     .find(|kstate| *kstate == "mem") {
[INFO] [stderr] 49 |     // Prefer mem
[INFO] [stderr] 50 |     state.to_string()
[INFO] [stderr] 51 | } else if let Some(state) = states.split_whitespace()
[INFO] [stderr] 52 |     .find(|kstate| *kstate == "freeze") {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/wakeup_sources.rs:29:54
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let mut fields = line.split('\t').filter(|field| field.len() > 0);
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!field.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.60s
[INFO] running `"docker" "inspect" "241322f6c0921bf942dca17349ea79f6f2ab510cec44765431d4809f8cd2093e"`
[INFO] running `"docker" "rm" "-f" "241322f6c0921bf942dca17349ea79f6f2ab510cec44765431d4809f8cd2093e"`
[INFO] [stdout] 241322f6c0921bf942dca17349ea79f6f2ab510cec44765431d4809f8cd2093e