[INFO] updating cached repository tylerreisinger/rust-fractal-generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tylerreisinger/rust-fractal-generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tylerreisinger/rust-fractal-generator" "work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/rust-fractal-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/rust-fractal-generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tylerreisinger/rust-fractal-generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/rust-fractal-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/rust-fractal-generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6bde03e8e8e31b9e2b75ab4424ce480e2f401ce0 [INFO] sha for GitHub repo tylerreisinger/rust-fractal-generator: 6bde03e8e8e31b9e2b75ab4424ce480e2f401ce0 [INFO] validating manifest of tylerreisinger/rust-fractal-generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tylerreisinger/rust-fractal-generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tylerreisinger/rust-fractal-generator [INFO] finished frobbing tylerreisinger/rust-fractal-generator [INFO] frobbed toml for tylerreisinger/rust-fractal-generator written to work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/rust-fractal-generator/Cargo.toml [INFO] started frobbing tylerreisinger/rust-fractal-generator [INFO] finished frobbing tylerreisinger/rust-fractal-generator [INFO] frobbed toml for tylerreisinger/rust-fractal-generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/rust-fractal-generator/Cargo.toml [INFO] crate tylerreisinger/rust-fractal-generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tylerreisinger/rust-fractal-generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/rust-fractal-generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a53ec9de2d1f34feea0236f72b05fff36e0de2efe01382c1e5eafc93055b33a [INFO] running `"docker" "start" "-a" "6a53ec9de2d1f34feea0236f72b05fff36e0de2efe01382c1e5eafc93055b33a"` [INFO] [stderr] Compiling gcc v0.3.40 [INFO] [stderr] Checking inflate v0.1.1 [INFO] [stderr] Checking num_cpus v1.2.0 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking gif v0.9.0 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking rayon v0.5.0 [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking jpeg-decoder v0.1.9 [INFO] [stderr] Checking enum_primitive v0.1.0 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking fractal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | Grid{left: left, top: top, right: right, bottom: bottom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | Grid{left: left, top: top, right: right, bottom: bottom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | Grid{left: left, top: top, right: right, bottom: bottom, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:50 [INFO] [stderr] | [INFO] [stderr] 44 | Grid{left: left, top: top, right: right, bottom: bottom, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bottom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | cells_x: cells_x, cells_y: cells_y} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cells_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | cells_x: cells_x, cells_y: cells_y} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cells_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | GridIter{grid: grid, x: first_cell.0, y: first_cell.1} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:110:18 [INFO] [stderr] | [INFO] [stderr] 110 | GridIter{grid: grid, x: x, y: y} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:110:30 [INFO] [stderr] | [INFO] [stderr] 110 | GridIter{grid: grid, x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | GridIter{grid: grid, x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:142:19 [INFO] [stderr] | [INFO] [stderr] 142 | GridStrip{start: start, height: height} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:142:33 [INFO] [stderr] | [INFO] [stderr] 142 | GridStrip{start: start, height: height} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | GridStripIter{grid: grid, grid_strip: strip, grid_iter: grid_iter} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:157:54 [INFO] [stderr] | [INFO] [stderr] 157 | GridStripIter{grid: grid, grid_strip: strip, grid_iter: grid_iter} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `grid_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:184:19 [INFO] [stderr] | [INFO] [stderr] 184 | StripIter{grid: grid, strip_height: strip_height, cur_pos: start_pos} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:184:31 [INFO] [stderr] | [INFO] [stderr] 184 | StripIter{grid: grid, strip_height: strip_height, cur_pos: start_pos} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `strip_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandelbrot.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | Mandelbrot{iter_limit: iter_limit} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iter_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fractal.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | FractalExecutor{fractal_impl: fractal_impl, cycle_detector: cycle_detector} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fractal_impl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fractal.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | FractalExecutor{fractal_impl: fractal_impl, cycle_detector: cycle_detector} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cycle_detector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner.rs:88:31 [INFO] [stderr] | [INFO] [stderr] 88 | SyncronousRunner::{fractal: fractal} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fractal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner.rs:110:29 [INFO] [stderr] | [INFO] [stderr] 110 | MultiThreadedRunner{fractal: fractal, num_threads: num_threads} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fractal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner.rs:110:47 [INFO] [stderr] | [INFO] [stderr] 110 | MultiThreadedRunner{fractal: fractal, num_threads: num_threads} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/grayscale.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | GrayscaleFractalRenderer{mapper: mapper} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | LinearMapper{max_iter: max_iter} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | MappingResult{values: vals, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:59:51 [INFO] [stderr] | [INFO] [stderr] 59 | MappingResult{values: vals, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | HistogramLinearMapper{max_iter: max_iter} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:105:39 [INFO] [stderr] | [INFO] [stderr] 105 | MappingResult{values: output, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:105:53 [INFO] [stderr] | [INFO] [stderr] 105 | MappingResult{values: output, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | LogarithmicMapper{max_iter: max_iter, strength: strength} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:111:47 [INFO] [stderr] | [INFO] [stderr] 111 | LogarithmicMapper{max_iter: max_iter, strength: strength} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `strength` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:134:37 [INFO] [stderr] | [INFO] [stderr] 134 | MappingResult{values: vals, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:134:51 [INFO] [stderr] | [INFO] [stderr] 134 | MappingResult{values: vals, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:140:25 [INFO] [stderr] | [INFO] [stderr] 140 | AntialiasMapper{aa_level: aa_level, mapper: mapper} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `aa_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:140:45 [INFO] [stderr] | [INFO] [stderr] 140 | AntialiasMapper{aa_level: aa_level, mapper: mapper} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | Grid{left: left, top: top, right: right, bottom: bottom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | Grid{left: left, top: top, right: right, bottom: bottom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | Grid{left: left, top: top, right: right, bottom: bottom, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:50 [INFO] [stderr] | [INFO] [stderr] 44 | Grid{left: left, top: top, right: right, bottom: bottom, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bottom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | cells_x: cells_x, cells_y: cells_y} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cells_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | cells_x: cells_x, cells_y: cells_y} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cells_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | GridIter{grid: grid, x: first_cell.0, y: first_cell.1} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:110:18 [INFO] [stderr] | [INFO] [stderr] 110 | GridIter{grid: grid, x: x, y: y} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:110:30 [INFO] [stderr] | [INFO] [stderr] 110 | GridIter{grid: grid, x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | GridIter{grid: grid, x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:142:19 [INFO] [stderr] | [INFO] [stderr] 142 | GridStrip{start: start, height: height} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:142:33 [INFO] [stderr] | [INFO] [stderr] 142 | GridStrip{start: start, height: height} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | GridStripIter{grid: grid, grid_strip: strip, grid_iter: grid_iter} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:157:54 [INFO] [stderr] | [INFO] [stderr] 157 | GridStripIter{grid: grid, grid_strip: strip, grid_iter: grid_iter} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `grid_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:184:19 [INFO] [stderr] | [INFO] [stderr] 184 | StripIter{grid: grid, strip_height: strip_height, cur_pos: start_pos} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:184:31 [INFO] [stderr] | [INFO] [stderr] 184 | StripIter{grid: grid, strip_height: strip_height, cur_pos: start_pos} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `strip_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mandelbrot.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | Mandelbrot{iter_limit: iter_limit} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iter_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fractal.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | FractalExecutor{fractal_impl: fractal_impl, cycle_detector: cycle_detector} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fractal_impl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fractal.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | FractalExecutor{fractal_impl: fractal_impl, cycle_detector: cycle_detector} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cycle_detector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner.rs:88:31 [INFO] [stderr] | [INFO] [stderr] 88 | SyncronousRunner::{fractal: fractal} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fractal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner.rs:110:29 [INFO] [stderr] | [INFO] [stderr] 110 | MultiThreadedRunner{fractal: fractal, num_threads: num_threads} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fractal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner.rs:110:47 [INFO] [stderr] | [INFO] [stderr] 110 | MultiThreadedRunner{fractal: fractal, num_threads: num_threads} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/grayscale.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | GrayscaleFractalRenderer{mapper: mapper} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | LinearMapper{max_iter: max_iter} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | MappingResult{values: vals, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:59:51 [INFO] [stderr] | [INFO] [stderr] 59 | MappingResult{values: vals, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | HistogramLinearMapper{max_iter: max_iter} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:105:39 [INFO] [stderr] | [INFO] [stderr] 105 | MappingResult{values: output, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:105:53 [INFO] [stderr] | [INFO] [stderr] 105 | MappingResult{values: output, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | LogarithmicMapper{max_iter: max_iter, strength: strength} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:111:47 [INFO] [stderr] | [INFO] [stderr] 111 | LogarithmicMapper{max_iter: max_iter, strength: strength} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `strength` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:134:37 [INFO] [stderr] | [INFO] [stderr] 134 | MappingResult{values: vals, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:134:51 [INFO] [stderr] | [INFO] [stderr] 134 | MappingResult{values: vals, width: width, height: height} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:140:25 [INFO] [stderr] | [INFO] [stderr] 140 | AntialiasMapper{aa_level: aa_level, mapper: mapper} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `aa_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/map.rs:140:45 [INFO] [stderr] | [INFO] [stderr] 140 | AntialiasMapper{aa_level: aa_level, mapper: mapper} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/runner.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | return thread_worker(fractal, grid_copy, rx, row_sender); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `thread_worker(fractal, grid_copy, rx, row_sender)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/runner.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | values [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/runner.rs:195:22 [INFO] [stderr] | [INFO] [stderr] 195 | let values = self.execute_workers(grid); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/runner.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | return thread_worker(fractal, grid_copy, rx, row_sender); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `thread_worker(fractal, grid_copy, rx, row_sender)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/runner.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | values [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/runner.rs:195:22 [INFO] [stderr] | [INFO] [stderr] 195 | let values = self.execute_workers(grid); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/grid.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn iter<'a>(&'a self) -> GridIter<'a> { [INFO] [stderr] 93 | | GridIter::new(self) [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mandelbrot.rs:20:68 [INFO] [stderr] | [INFO] [stderr] 20 | } else if (c.re + 1.0)*(c.re + 1.0) + c.im*c.im < 1.0/16.0 { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 21 | | return true; [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mandelbrot.rs:18:51 [INFO] [stderr] | [INFO] [stderr] 18 | if q*(q + c.re - 0.25) < 0.25 * c.im*c.im { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 19 | | return true; [INFO] [stderr] 20 | | } else if (c.re + 1.0)*(c.re + 1.0) + c.im*c.im < 1.0/16.0 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/grayscale.rs:36:47 [INFO] [stderr] | [INFO] [stderr] 36 | let pixel_val = val * (u8::max_value() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/render/map.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 65 | let mut hist = Vec::with_capacity(max_iter); [INFO] [stderr] | ---------------------------- help: consider replace allocation with: `vec![0; max_iter]` [INFO] [stderr] 66 | hist.resize(max_iter, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/map.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | *state += *item as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*item)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/map.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | let flt_reduction_factor = (1 << self.aa_level) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << self.aa_level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/render/map.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | if final_value == 1.0*denom { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(final_value - 1.0*denom).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/render/map.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | if final_value == 1.0*denom { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fractal`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/grid.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn iter<'a>(&'a self) -> GridIter<'a> { [INFO] [stderr] 93 | | GridIter::new(self) [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mandelbrot.rs:20:68 [INFO] [stderr] | [INFO] [stderr] 20 | } else if (c.re + 1.0)*(c.re + 1.0) + c.im*c.im < 1.0/16.0 { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 21 | | return true; [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mandelbrot.rs:18:51 [INFO] [stderr] | [INFO] [stderr] 18 | if q*(q + c.re - 0.25) < 0.25 * c.im*c.im { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 19 | | return true; [INFO] [stderr] 20 | | } else if (c.re + 1.0)*(c.re + 1.0) + c.im*c.im < 1.0/16.0 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/grayscale.rs:36:47 [INFO] [stderr] | [INFO] [stderr] 36 | let pixel_val = val * (u8::max_value() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/render/map.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 65 | let mut hist = Vec::with_capacity(max_iter); [INFO] [stderr] | ---------------------------- help: consider replace allocation with: `vec![0; max_iter]` [INFO] [stderr] 66 | hist.resize(max_iter, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/map.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | *state += *item as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*item)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/map.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | let flt_reduction_factor = (1 << self.aa_level) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << self.aa_level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/render/map.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | if final_value == 1.0*denom { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(final_value - 1.0*denom).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/render/map.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | if final_value == 1.0*denom { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fractal`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6a53ec9de2d1f34feea0236f72b05fff36e0de2efe01382c1e5eafc93055b33a"` [INFO] running `"docker" "rm" "-f" "6a53ec9de2d1f34feea0236f72b05fff36e0de2efe01382c1e5eafc93055b33a"` [INFO] [stdout] 6a53ec9de2d1f34feea0236f72b05fff36e0de2efe01382c1e5eafc93055b33a