[INFO] updating cached repository twitter/rpc-perf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/twitter/rpc-perf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/twitter/rpc-perf" "work/ex/clippy-test-run/sources/stable/gh/twitter/rpc-perf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/twitter/rpc-perf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/twitter/rpc-perf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twitter/rpc-perf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twitter/rpc-perf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fdc24b5f3e6675b5384fd508f47c5aca1055f9b5 [INFO] sha for GitHub repo twitter/rpc-perf: fdc24b5f3e6675b5384fd508f47c5aca1055f9b5 [INFO] validating manifest of twitter/rpc-perf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of twitter/rpc-perf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing twitter/rpc-perf [INFO] finished frobbing twitter/rpc-perf [INFO] frobbed toml for twitter/rpc-perf written to work/ex/clippy-test-run/sources/stable/gh/twitter/rpc-perf/Cargo.toml [INFO] started frobbing twitter/rpc-perf [INFO] finished frobbing twitter/rpc-perf [INFO] frobbed toml for twitter/rpc-perf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twitter/rpc-perf/Cargo.toml [INFO] crate twitter/rpc-perf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting twitter/rpc-perf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/twitter/rpc-perf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d70f5897539ede8fed7fdba6c69f0fff2999cba041c8f999bb8c6ac3423c19c [INFO] running `"docker" "start" "-a" "1d70f5897539ede8fed7fdba6c69f0fff2999cba041c8f999bb8c6ac3423c19c"` [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Checking odds v0.2.26 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking cfg-if v0.1.4 [INFO] [stderr] Checking byteorder v1.1.0 [INFO] [stderr] Checking byteorder v0.4.2 [INFO] [stderr] Compiling serde v1.0.70 [INFO] [stderr] Checking matches v0.1.7 [INFO] [stderr] Checking inflate v0.2.0 [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Compiling crc-core v0.1.2 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking histogram v0.6.9 [INFO] [stderr] Checking chunked_transfer v0.3.1 [INFO] [stderr] Checking hsl v0.1.1 [INFO] [stderr] Checking lazycell v0.5.1 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Checking ascii v0.7.1 [INFO] [stderr] Checking mpmc v0.1.2 [INFO] [stderr] Checking getopts v0.2.15 [INFO] [stderr] Checking allan v0.2.4 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking bytes v0.3.0 [INFO] [stderr] Checking ratelimit v0.4.2 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking stb_truetype v0.1.2 [INFO] [stderr] Checking arrayvec v0.3.25 [INFO] [stderr] Compiling crc v1.5.0 [INFO] [stderr] Checking rand v0.3.17 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking clocksource v0.2.4 [INFO] [stderr] Checking shuteye v0.3.2 [INFO] [stderr] Checking pad v0.1.4 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking rusttype v0.1.2 [INFO] [stderr] Checking heatmap v0.6.6 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Checking log-panics v1.1.0 [INFO] [stderr] Checking simple_logger v0.4.0 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Checking url v0.2.38 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking waterfall v0.7.1 [INFO] [stderr] Checking tiny_http v0.5.9 [INFO] [stderr] Checking tic v0.2.4 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking rpc-perf v2.1.0-pre (/opt/crater/workdir) [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | #[allow(unknown_lints, useless_attribute)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | rate: rate, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | gen: gen, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | regenerate: regenerate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `regenerate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/echo/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/memcache/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/memcache/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/memcache/mod.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | protocol: protocol, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_inline/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_inline/mod.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_inline/mod.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | database: database, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_resp/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_resp/mod.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_resp/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | database: database, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/buffer.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | Buffer { buffer: buffer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | regenerate: regenerate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `regenerate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/testutil.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | protocol: protocol, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | ratelimit: ratelimit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ratelimit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | stats: stats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | clocksource: clocksource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clocksource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | #[allow(unknown_lints, useless_attribute)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | rate: rate, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | gen: gen, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `gen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | regenerate: regenerate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `regenerate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfgtypes/mod.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/echo/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/memcache/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/memcache/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/memcache/mod.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | protocol: protocol, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_inline/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_inline/mod.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_inline/mod.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | database: database, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_resp/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_resp/mod.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/redis_resp/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | database: database, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/buffer.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | Buffer { buffer: buffer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | regenerate: regenerate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `regenerate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/config.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/thrift/testutil.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | protocol: protocol, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | ratelimit: ratelimit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ratelimit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | stats: stats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/workload.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | clocksource: clocksource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clocksource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | #[allow(unknown_lints, useless_attribute)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: lint name `result_unwrap_used` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:21:43 [INFO] [stderr] | [INFO] [stderr] 21 | #[cfg_attr(feature = "cargo-clippy", deny(result_unwrap_used))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::result_unwrap_used` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | #[allow(unknown_lints, useless_attribute)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: lint name `result_unwrap_used` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:21:43 [INFO] [stderr] | [INFO] [stderr] 21 | #[cfg_attr(feature = "cargo-clippy", deny(result_unwrap_used))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::result_unwrap_used` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/client/mod.rs:195:20 [INFO] [stderr] | [INFO] [stderr] 195 | if !self.poll.deregister(io).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.poll.deregister(io).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/codec/echo/parse.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | if !(crc.len() == 4) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `crc.len() != 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/echo/mod.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / fn new(&self) -> Box { [INFO] [stderr] 83 | | Box::new(EchoParser) [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/client/mod.rs:195:20 [INFO] [stderr] | [INFO] [stderr] 195 | if !self.poll.deregister(io).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.poll.deregister(io).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/codec/memcache/parse.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | if tokens.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/memcache/mod.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / fn new(&self) -> Box { [INFO] [stderr] 76 | | Box::new(MemcacheParser) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/codec/echo/parse.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | if !(crc.len() == 4) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `crc.len() != 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/echo/mod.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / fn new(&self) -> Box { [INFO] [stderr] 83 | | Box::new(EchoParser) [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/ping/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / fn new(&self) -> Box { [INFO] [stderr] 45 | | Box::new(Ping) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/codec/memcache/parse.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | if tokens.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/memcache/mod.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / fn new(&self) -> Box { [INFO] [stderr] 76 | | Box::new(MemcacheParser) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codec/redis_inline/gen.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn select(database: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/ping/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / fn new(&self) -> Box { [INFO] [stderr] 45 | | Box::new(Ping) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codec/redis_inline/gen.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn select(database: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/redis_inline/mod.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | / fn new(&self) -> Box { [INFO] [stderr] 166 | | Box::new(RedisParse) [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/redis_inline/mod.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | / fn new(&self) -> Box { [INFO] [stderr] 166 | | Box::new(RedisParse) [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codec/redis_resp/gen.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | pub fn select(database: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/redis_resp/mod.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | / fn new(&self) -> Box { [INFO] [stderr] 158 | | Box::new(RedisParse) [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codec/redis_resp/gen.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | pub fn select(database: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/thrift/config.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / fn new(&self) -> Box { [INFO] [stderr] 54 | | Box::new(ThriftParse) [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/redis_resp/mod.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | / fn new(&self) -> Box { [INFO] [stderr] 158 | | Box::new(RedisParse) [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/codec/thrift/buffer.rs:164:19 [INFO] [stderr] | [INFO] [stderr] 164 | test_buff(&vec![0, 0, 0, 0, 0], |b| { b.stop(); }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 0, 0, 0, 0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/codec/thrift/config.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / fn new(&self) -> Box { [INFO] [stderr] 54 | | Box::new(ThriftParse) [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn main() { [INFO] [stderr] 61 | | let args: Vec = env::args().collect(); [INFO] [stderr] 62 | | let program = &args[0]; [INFO] [stderr] 63 | | let opts = options::opts(); [INFO] [stderr] ... | [INFO] [stderr] 219 | | stats::run(stats_receiver, windows, matches.opt_present("service")); [INFO] [stderr] 220 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:156:45 [INFO] [stderr] | [INFO] [stderr] 156 | let _ = thread::Builder::new().name(format!("limiter")).spawn( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"limiter".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn main() { [INFO] [stderr] 61 | | let args: Vec = env::args().collect(); [INFO] [stderr] 62 | | let program = &args[0]; [INFO] [stderr] 63 | | let opts = options::opts(); [INFO] [stderr] ... | [INFO] [stderr] 219 | | stats::run(stats_receiver, windows, matches.opt_present("service")); [INFO] [stderr] 220 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:156:45 [INFO] [stderr] | [INFO] [stderr] 156 | let _ = thread::Builder::new().name(format!("limiter")).spawn( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"limiter".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.11s [INFO] running `"docker" "inspect" "1d70f5897539ede8fed7fdba6c69f0fff2999cba041c8f999bb8c6ac3423c19c"` [INFO] running `"docker" "rm" "-f" "1d70f5897539ede8fed7fdba6c69f0fff2999cba041c8f999bb8c6ac3423c19c"` [INFO] [stdout] 1d70f5897539ede8fed7fdba6c69f0fff2999cba041c8f999bb8c6ac3423c19c