[INFO] updating cached repository twe4ked/rs8080
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/twe4ked/rs8080
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/twe4ked/rs8080" "work/ex/clippy-test-run/sources/stable/gh/twe4ked/rs8080"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/twe4ked/rs8080'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/twe4ked/rs8080" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twe4ked/rs8080"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twe4ked/rs8080'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 03a2457297d71a5fd494952dc8488470da77c38c
[INFO] sha for GitHub repo twe4ked/rs8080: 03a2457297d71a5fd494952dc8488470da77c38c
[INFO] validating manifest of twe4ked/rs8080 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of twe4ked/rs8080 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing twe4ked/rs8080
[INFO] finished frobbing twe4ked/rs8080
[INFO] frobbed toml for twe4ked/rs8080 written to work/ex/clippy-test-run/sources/stable/gh/twe4ked/rs8080/Cargo.toml
[INFO] started frobbing twe4ked/rs8080
[INFO] finished frobbing twe4ked/rs8080
[INFO] frobbed toml for twe4ked/rs8080 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twe4ked/rs8080/Cargo.toml
[INFO] crate twe4ked/rs8080 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting twe4ked/rs8080 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/twe4ked/rs8080:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 65e49fe95b41a4b776adfada2e1b4534e1ce4b9bb254b9e9c34a8fa74139555a
[INFO] running `"docker" "start" "-a" "65e49fe95b41a4b776adfada2e1b4534e1ce4b9bb254b9e9c34a8fa74139555a"`
[INFO] [stderr]     Checking rs8080 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/main.rs:308:5
[INFO] [stderr]     |
[INFO] [stderr] 308 |     op_bytes
[INFO] [stderr]     |     ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/main.rs:48:20
[INFO] [stderr]     |
[INFO] [stderr] 48  |       let op_bytes = match byte_1 {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 49  | |         0x00 => { disassemble_1("NOP") },
[INFO] [stderr] 50  | |         0x01 => { disassemble_3("LXI B", byte_2, byte_3) },
[INFO] [stderr] 51  | |         0x02 => { disassemble_1("STAX B") },
[INFO] [stderr] ...   |
[INFO] [stderr] 305 | |            _ => unreachable!()
[INFO] [stderr] 306 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/main.rs:308:5
[INFO] [stderr]     |
[INFO] [stderr] 308 |     op_bytes
[INFO] [stderr]     |     ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/main.rs:48:20
[INFO] [stderr]     |
[INFO] [stderr] 48  |       let op_bytes = match byte_1 {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 49  | |         0x00 => { disassemble_1("NOP") },
[INFO] [stderr] 50  | |         0x01 => { disassemble_3("LXI B", byte_2, byte_3) },
[INFO] [stderr] 51  | |         0x02 => { disassemble_1("STAX B") },
[INFO] [stderr] ...   |
[INFO] [stderr] 305 | |            _ => unreachable!()
[INFO] [stderr] 306 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:312:6
[INFO] [stderr]     |
[INFO] [stderr] 312 |     ((buffer[pc + 2] as u16) << 8) | (buffer[pc + 1] as u16)
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buffer[pc + 2])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:312:38
[INFO] [stderr]     |
[INFO] [stderr] 312 |     ((buffer[pc + 2] as u16) << 8) | (buffer[pc + 1] as u16)
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buffer[pc + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:312:6
[INFO] [stderr]     |
[INFO] [stderr] 312 |     ((buffer[pc + 2] as u16) << 8) | (buffer[pc + 1] as u16)
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buffer[pc + 2])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:312:38
[INFO] [stderr]     |
[INFO] [stderr] 312 |     ((buffer[pc + 2] as u16) << 8) | (buffer[pc + 1] as u16)
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buffer[pc + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.29s
[INFO] running `"docker" "inspect" "65e49fe95b41a4b776adfada2e1b4534e1ce4b9bb254b9e9c34a8fa74139555a"`
[INFO] running `"docker" "rm" "-f" "65e49fe95b41a4b776adfada2e1b4534e1ce4b9bb254b9e9c34a8fa74139555a"`
[INFO] [stdout] 65e49fe95b41a4b776adfada2e1b4534e1ce4b9bb254b9e9c34a8fa74139555a