[INFO] updating cached repository tuzz/superpermutation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tuzz/superpermutation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tuzz/superpermutation" "work/ex/clippy-test-run/sources/stable/gh/tuzz/superpermutation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tuzz/superpermutation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tuzz/superpermutation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tuzz/superpermutation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tuzz/superpermutation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a1aa58ba2495c24f7a85608e1fe4ad28efc375e3 [INFO] sha for GitHub repo tuzz/superpermutation: a1aa58ba2495c24f7a85608e1fe4ad28efc375e3 [INFO] validating manifest of tuzz/superpermutation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tuzz/superpermutation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tuzz/superpermutation [INFO] finished frobbing tuzz/superpermutation [INFO] frobbed toml for tuzz/superpermutation written to work/ex/clippy-test-run/sources/stable/gh/tuzz/superpermutation/Cargo.toml [INFO] started frobbing tuzz/superpermutation [INFO] finished frobbing tuzz/superpermutation [INFO] frobbed toml for tuzz/superpermutation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tuzz/superpermutation/Cargo.toml [INFO] crate tuzz/superpermutation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tuzz/superpermutation against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tuzz/superpermutation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f8fa3371be04febed868c3cdba0ea24dc8b47315bed98443eeb232072d8d17d1 [INFO] running `"docker" "start" "-a" "f8fa3371be04febed868c3cdba0ea24dc8b47315bed98443eeb232072d8d17d1"` [INFO] [stderr] Checking bit-vec v0.5.0 [INFO] [stderr] Checking lehmer v2.0.0 [INFO] [stderr] Checking bucket_queue v2.0.0 [INFO] [stderr] Checking miniz-sys v0.1.11 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking serde_bytes v0.10.4 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking flate2 v1.0.5 [INFO] [stderr] Checking bit-set v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking leaps-and-bounds v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/candidate/mod.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | tail_of_string: tail_of_string, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tail_of_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/candidate/mod.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | tail_of_string: tail_of_string, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tail_of_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/frontier/mod.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / if self.disabled.remove(bucket_id) { [INFO] [stderr] 119 | | if Self::bucket_len(&self.disabled_queue, bucket_id) > 0 { [INFO] [stderr] 120 | | if self.verbose { [INFO] [stderr] 121 | | println!(" unpruning {:?} from memory ... queue: {}", bucket_id, self.len()); [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 118 | if self.disabled.remove(bucket_id) && Self::bucket_len(&self.disabled_queue, bucket_id) > 0 { [INFO] [stderr] 119 | if self.verbose { [INFO] [stderr] 120 | println!(" unpruning {:?} from memory ... queue: {}", bucket_id, self.len()); [INFO] [stderr] 121 | } [INFO] [stderr] 122 | [INFO] [stderr] 123 | Self::swap(&mut self.disabled_queue, &mut self.enabled_queue, bucket_id); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/disk/test.rs:8:14 [INFO] [stderr] | [INFO] [stderr] 8 | const PATH: &'static str = "/tmp/superpermutation-test"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/frontier/mod.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / if self.disabled.remove(bucket_id) { [INFO] [stderr] 119 | | if Self::bucket_len(&self.disabled_queue, bucket_id) > 0 { [INFO] [stderr] 120 | | if self.verbose { [INFO] [stderr] 121 | | println!(" unpruning {:?} from memory ... queue: {}", bucket_id, self.len()); [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 118 | if self.disabled.remove(bucket_id) && Self::bucket_len(&self.disabled_queue, bucket_id) > 0 { [INFO] [stderr] 119 | if self.verbose { [INFO] [stderr] 120 | println!(" unpruning {:?} from memory ... queue: {}", bucket_id, self.len()); [INFO] [stderr] 121 | } [INFO] [stderr] 122 | [INFO] [stderr] 123 | Self::swap(&mut self.disabled_queue, &mut self.enabled_queue, bucket_id); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/candidate/mod.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | let penalty = match self.seen_next_tail_as_well(&tail_of_string, n) { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 73 | | false => 1, [INFO] [stderr] 74 | | true => 2, [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.seen_next_tail_as_well(&tail_of_string, n) { 2 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/candidate/mod.rs:109:27 [INFO] [stderr] | [INFO] [stderr] 109 | let permutation = tail_of_string [INFO] [stderr] | ___________________________^ [INFO] [stderr] 110 | | .iter() [INFO] [stderr] 111 | | .map(|&e| e) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 109 | let permutation = tail_of_string [INFO] [stderr] 110 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/candidate/mod.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | None => match Self::less_than_full(head, n) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 124 | | true => 0, [INFO] [stderr] 125 | | false => 1, [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if Self::less_than_full(head, n) { 0 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/candidate/mod.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | slice.iter().map(|&e| e).chain(once(symbol)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `slice.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/disk/mod.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | index: Arc>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/disk/mod.rs:22:31 [INFO] [stderr] | [INFO] [stderr] 22 | create_dir_all(&path).expect(&format!("Failed to create {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to create {}", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/disk/mod.rs:30:42 [INFO] [stderr] | [INFO] [stderr] 30 | let file = File::open(&filename).expect(&format!("Failed to open {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/disk/mod.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | remove_file(&filename).expect(&format!("Failed to remove {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to remove {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/disk/mod.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let file = File::create(&filename).expect(&format!("Failed to create {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to create {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/disk/mod.rs:119:30 [INFO] [stderr] | [INFO] [stderr] 119 | let gzip_component = match self.gzip { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 120 | | true => ".gz", [INFO] [stderr] 121 | | false => "", [INFO] [stderr] 122 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.gzip { ".gz" } else { "" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/frontier/mod.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | let max = match eager { [INFO] [stderr] | ___________________^ [INFO] [stderr] 55 | | true => self.max_waste()?, [INFO] [stderr] 56 | | false => wasted_symbols, [INFO] [stderr] 57 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if eager { self.max_waste()? } else { wasted_symbols }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ui/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / match input.trim().is_empty() { [INFO] [stderr] 111 | | true => default.to_string(), [INFO] [stderr] 112 | | false => input, [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if input.trim().is_empty() { default.to_string() } else { input }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/ui/mod.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | stdout().flush().ok().expect("Failed to flush stdout."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/candidate/mod.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | let penalty = match self.seen_next_tail_as_well(&tail_of_string, n) { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 73 | | false => 1, [INFO] [stderr] 74 | | true => 2, [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.seen_next_tail_as_well(&tail_of_string, n) { 2 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/candidate/mod.rs:109:27 [INFO] [stderr] | [INFO] [stderr] 109 | let permutation = tail_of_string [INFO] [stderr] | ___________________________^ [INFO] [stderr] 110 | | .iter() [INFO] [stderr] 111 | | .map(|&e| e) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 109 | let permutation = tail_of_string [INFO] [stderr] 110 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/candidate/mod.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | None => match Self::less_than_full(head, n) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 124 | | true => 0, [INFO] [stderr] 125 | | false => 1, [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if Self::less_than_full(head, n) { 0 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/candidate/mod.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | slice.iter().map(|&e| e).chain(once(symbol)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `slice.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/disk/mod.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | index: Arc>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/disk/mod.rs:22:31 [INFO] [stderr] | [INFO] [stderr] 22 | create_dir_all(&path).expect(&format!("Failed to create {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to create {}", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/disk/mod.rs:30:42 [INFO] [stderr] | [INFO] [stderr] 30 | let file = File::open(&filename).expect(&format!("Failed to open {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/disk/mod.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | remove_file(&filename).expect(&format!("Failed to remove {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to remove {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/disk/mod.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let file = File::create(&filename).expect(&format!("Failed to create {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to create {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/disk/mod.rs:119:30 [INFO] [stderr] | [INFO] [stderr] 119 | let gzip_component = match self.gzip { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 120 | | true => ".gz", [INFO] [stderr] 121 | | false => "", [INFO] [stderr] 122 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.gzip { ".gz" } else { "" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/frontier/mod.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | let max = match eager { [INFO] [stderr] | ___________________^ [INFO] [stderr] 55 | | true => self.max_waste()?, [INFO] [stderr] 56 | | false => wasted_symbols, [INFO] [stderr] 57 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if eager { self.max_waste()? } else { wasted_symbols }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ui/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / match input.trim().is_empty() { [INFO] [stderr] 111 | | true => default.to_string(), [INFO] [stderr] 112 | | false => input, [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if input.trim().is_empty() { default.to_string() } else { input }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/ui/mod.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | stdout().flush().ok().expect("Failed to flush stdout."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.87s [INFO] running `"docker" "inspect" "f8fa3371be04febed868c3cdba0ea24dc8b47315bed98443eeb232072d8d17d1"` [INFO] running `"docker" "rm" "-f" "f8fa3371be04febed868c3cdba0ea24dc8b47315bed98443eeb232072d8d17d1"` [INFO] [stdout] f8fa3371be04febed868c3cdba0ea24dc8b47315bed98443eeb232072d8d17d1