[INFO] updating cached repository tummychow/git-absorb [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tummychow/git-absorb [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tummychow/git-absorb" "work/ex/clippy-test-run/sources/stable/gh/tummychow/git-absorb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tummychow/git-absorb'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tummychow/git-absorb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tummychow/git-absorb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tummychow/git-absorb'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 53a7bdbbe0d1b038b0e03b69290f69431813c8d2 [INFO] sha for GitHub repo tummychow/git-absorb: 53a7bdbbe0d1b038b0e03b69290f69431813c8d2 [INFO] validating manifest of tummychow/git-absorb on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tummychow/git-absorb on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tummychow/git-absorb [INFO] finished frobbing tummychow/git-absorb [INFO] frobbed toml for tummychow/git-absorb written to work/ex/clippy-test-run/sources/stable/gh/tummychow/git-absorb/Cargo.toml [INFO] started frobbing tummychow/git-absorb [INFO] finished frobbing tummychow/git-absorb [INFO] frobbed toml for tummychow/git-absorb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tummychow/git-absorb/Cargo.toml [INFO] crate tummychow/git-absorb has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tummychow/git-absorb against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tummychow/git-absorb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0beb1cbacf4439fb2a010f05d18462952b7aea43d91b7e378ed4b3908db7c7f2 [INFO] running `"docker" "start" "-a" "0beb1cbacf4439fb2a010f05d18462952b7aea43d91b7e378ed4b3908db7c7f2"` [INFO] [stderr] Checking num-traits v0.2.0 [INFO] [stderr] Checking take_mut v0.2.0 [INFO] [stderr] Checking slog v2.1.1 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking isatty v0.1.6 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking clap v2.30.0 [INFO] [stderr] Checking slog-async v2.2.0 [INFO] [stderr] Checking remove_dir_all v0.3.0 [INFO] [stderr] Checking tempdir v0.3.6 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking slog-term v2.3.0 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking git-absorb v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: method is never used: `by_old` [INFO] [stderr] --> src/owned.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn by_old(&self, path: &[u8]) -> Option<&Patch> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/commute.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | / { [INFO] [stderr] 50 | | // TODO: added start positions probably need to be [INFO] [stderr] 51 | | // tweaked here [INFO] [stderr] 52 | | return Some((second.clone(), first.clone())); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/commute.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / { [INFO] [stderr] 43 | | // TODO: removed start positions probably need to be [INFO] [stderr] 44 | | // tweaked here [INFO] [stderr] 45 | | return Some((second.clone(), first.clone())); [INFO] [stderr] 46 | | } else if first.removed.lines.is_empty() [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: method is never used: `by_old` [INFO] [stderr] --> src/owned.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn by_old(&self, path: &[u8]) -> Option<&Patch> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/lib.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn run(config: &Config) -> Result<(), failure::Error> { [INFO] [stderr] 21 | | let repo = git2::Repository::open_from_env()?; [INFO] [stderr] 22 | | debug!(config.logger, "repository found"; "path" => repo.path().to_str()); [INFO] [stderr] 23 | | [INFO] [stderr] ... | [INFO] [stderr] 198 | | Ok(()) [INFO] [stderr] 199 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/commute.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | / { [INFO] [stderr] 50 | | // TODO: added start positions probably need to be [INFO] [stderr] 51 | | // tweaked here [INFO] [stderr] 52 | | return Some((second.clone(), first.clone())); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/commute.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / { [INFO] [stderr] 43 | | // TODO: removed start positions probably need to be [INFO] [stderr] 44 | | // tweaked here [INFO] [stderr] 45 | | return Some((second.clone(), first.clone())); [INFO] [stderr] 46 | | } else if first.removed.lines.is_empty() [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `git-absorb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/lib.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn run(config: &Config) -> Result<(), failure::Error> { [INFO] [stderr] 21 | | let repo = git2::Repository::open_from_env()?; [INFO] [stderr] 22 | | debug!(config.logger, "repository found"; "path" => repo.path().to_str()); [INFO] [stderr] 23 | | [INFO] [stderr] ... | [INFO] [stderr] 198 | | Ok(()) [INFO] [stderr] 199 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `git-absorb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0beb1cbacf4439fb2a010f05d18462952b7aea43d91b7e378ed4b3908db7c7f2"` [INFO] running `"docker" "rm" "-f" "0beb1cbacf4439fb2a010f05d18462952b7aea43d91b7e378ed4b3908db7c7f2"` [INFO] [stdout] 0beb1cbacf4439fb2a010f05d18462952b7aea43d91b7e378ed4b3908db7c7f2