[INFO] updating cached repository ttaubert/tlc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ttaubert/tlc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ttaubert/tlc" "work/ex/clippy-test-run/sources/stable/gh/ttaubert/tlc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ttaubert/tlc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ttaubert/tlc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ttaubert/tlc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ttaubert/tlc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 67c247b16841078e16816362e96ef579b37f68ab [INFO] sha for GitHub repo ttaubert/tlc: 67c247b16841078e16816362e96ef579b37f68ab [INFO] validating manifest of ttaubert/tlc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ttaubert/tlc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ttaubert/tlc [INFO] finished frobbing ttaubert/tlc [INFO] frobbed toml for ttaubert/tlc written to work/ex/clippy-test-run/sources/stable/gh/ttaubert/tlc/Cargo.toml [INFO] started frobbing ttaubert/tlc [INFO] finished frobbing ttaubert/tlc [INFO] frobbed toml for ttaubert/tlc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ttaubert/tlc/Cargo.toml [INFO] crate ttaubert/tlc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ttaubert/tlc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ttaubert/tlc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36ebfb93f3c4dc15ed8bbb2ecf8df9bc52a1de335023022944ed14dd6c1fde8c [INFO] running `"docker" "start" "-a" "36ebfb93f3c4dc15ed8bbb2ecf8df9bc52a1de335023022944ed14dd6c1fde8c"` [INFO] [stderr] Checking libc v0.2.33 [INFO] [stderr] Checking itertools v0.7.2 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking tlc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/atom.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / if !lhs.is_identifier_without_value(state) { [INFO] [stderr] 147 | | if rhs.is_identifier_without_value(state) { [INFO] [stderr] 148 | | mem::swap(&mut lhs, &mut rhs); [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | if !lhs.is_identifier_without_value(state) && rhs.is_identifier_without_value(state) { [INFO] [stderr] 147 | mem::swap(&mut lhs, &mut rhs); [INFO] [stderr] 148 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/atom.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / if !lhs.is_next_state_identifier_without_value(state) { [INFO] [stderr] 175 | | if rhs.is_next_state_identifier_without_value(state) { [INFO] [stderr] 176 | | mem::swap(&mut lhs, &mut rhs); [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | if !lhs.is_next_state_identifier_without_value(state) && rhs.is_next_state_identifier_without_value(state) { [INFO] [stderr] 175 | mem::swap(&mut lhs, &mut rhs); [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/atom.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / if !lhs.is_identifier_without_value(state) { [INFO] [stderr] 147 | | if rhs.is_identifier_without_value(state) { [INFO] [stderr] 148 | | mem::swap(&mut lhs, &mut rhs); [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | if !lhs.is_identifier_without_value(state) && rhs.is_identifier_without_value(state) { [INFO] [stderr] 147 | mem::swap(&mut lhs, &mut rhs); [INFO] [stderr] 148 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/atom.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / if !lhs.is_next_state_identifier_without_value(state) { [INFO] [stderr] 175 | | if rhs.is_next_state_identifier_without_value(state) { [INFO] [stderr] 176 | | mem::swap(&mut lhs, &mut rhs); [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | if !lhs.is_next_state_identifier_without_value(state) && rhs.is_next_state_identifier_without_value(state) { [INFO] [stderr] 175 | mem::swap(&mut lhs, &mut rhs); [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/atom.rs:40:54 [INFO] [stderr] | [INFO] [stderr] 40 | Atom::Identifier(ref id) => id.ends_with("'"), [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/atom.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | .expect(&format!("identifier {} must have a value", id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("identifier {} must have a value", id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | |n| AST::Number(n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AST::Number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `state::State` [INFO] [stderr] --> src/state.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Self { vars: BTreeMap::new() } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/state.rs:18:27 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn has(&self, id: &Ident) -> bool { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/state.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn get(&self, id: &Ident) -> Option<&Value> { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/value.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Clone, Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/value.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56| / impl PartialEq for Value { [INFO] [stderr] 57| | fn eq(&self, other: &Value) -> bool { [INFO] [stderr] 58| | match (self, other) { [INFO] [stderr] 59| | (&Value::Boolean(lhs), &Value::Boolean(rhs)) => lhs == rhs, [INFO] [stderr] ... | [INFO] [stderr] 65| | } [INFO] [stderr] 66| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tlc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/atom.rs:40:54 [INFO] [stderr] | [INFO] [stderr] 40 | Atom::Identifier(ref id) => id.ends_with("'"), [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/atom.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | .expect(&format!("identifier {} must have a value", id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("identifier {} must have a value", id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | |n| AST::Number(n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AST::Number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `state::State` [INFO] [stderr] --> src/state.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Self { vars: BTreeMap::new() } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/state.rs:18:27 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn has(&self, id: &Ident) -> bool { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/state.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn get(&self, id: &Ident) -> Option<&Value> { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/value.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Clone, Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/value.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56| / impl PartialEq for Value { [INFO] [stderr] 57| | fn eq(&self, other: &Value) -> bool { [INFO] [stderr] 58| | match (self, other) { [INFO] [stderr] 59| | (&Value::Boolean(lhs), &Value::Boolean(rhs)) => lhs == rhs, [INFO] [stderr] ... | [INFO] [stderr] 65| | } [INFO] [stderr] 66| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tlc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "36ebfb93f3c4dc15ed8bbb2ecf8df9bc52a1de335023022944ed14dd6c1fde8c"` [INFO] running `"docker" "rm" "-f" "36ebfb93f3c4dc15ed8bbb2ecf8df9bc52a1de335023022944ed14dd6c1fde8c"` [INFO] [stdout] 36ebfb93f3c4dc15ed8bbb2ecf8df9bc52a1de335023022944ed14dd6c1fde8c