[INFO] updating cached repository tsuyoshiwada/rs-monkey-lang [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tsuyoshiwada/rs-monkey-lang [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tsuyoshiwada/rs-monkey-lang" "work/ex/clippy-test-run/sources/stable/gh/tsuyoshiwada/rs-monkey-lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tsuyoshiwada/rs-monkey-lang'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tsuyoshiwada/rs-monkey-lang" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsuyoshiwada/rs-monkey-lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsuyoshiwada/rs-monkey-lang'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2189321538e58416708bea361b1c080a3f9c7c49 [INFO] sha for GitHub repo tsuyoshiwada/rs-monkey-lang: 2189321538e58416708bea361b1c080a3f9c7c49 [INFO] validating manifest of tsuyoshiwada/rs-monkey-lang on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tsuyoshiwada/rs-monkey-lang on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tsuyoshiwada/rs-monkey-lang [INFO] finished frobbing tsuyoshiwada/rs-monkey-lang [INFO] frobbed toml for tsuyoshiwada/rs-monkey-lang written to work/ex/clippy-test-run/sources/stable/gh/tsuyoshiwada/rs-monkey-lang/Cargo.toml [INFO] started frobbing tsuyoshiwada/rs-monkey-lang [INFO] finished frobbing tsuyoshiwada/rs-monkey-lang [INFO] frobbed toml for tsuyoshiwada/rs-monkey-lang written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsuyoshiwada/rs-monkey-lang/Cargo.toml [INFO] crate tsuyoshiwada/rs-monkey-lang has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tsuyoshiwada/rs-monkey-lang against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tsuyoshiwada/rs-monkey-lang:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ac7c4ab44e250b8f69ad96b3d2493262be3feeec4ee9251b432fa9a261518c6 [INFO] running `"docker" "start" "-a" "5ac7c4ab44e250b8f69ad96b3d2493262be3feeec4ee9251b432fa9a261518c6"` [INFO] [stderr] Checking monkey v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/formatter/mod.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | &Expr::If { [INFO] [stderr] | ______________^ [INFO] [stderr] 39 | | cond: _, [INFO] [stderr] 40 | | consequence: _, [INFO] [stderr] 41 | | alternative: _, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `If { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/formatter/mod.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | | &Expr::Func { params: _, body: _ } => true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Func { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/formatter/mod.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 213 | | if i > 0 { [INFO] [stderr] 214 | | result.push_str(&format!(", {}", expr_str)); [INFO] [stderr] 215 | | } else { [INFO] [stderr] 216 | | result.push_str(&expr_str); [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 212 | } else if i > 0 { [INFO] [stderr] 213 | result.push_str(&format!(", {}", expr_str)); [INFO] [stderr] 214 | } else { [INFO] [stderr] 215 | result.push_str(&expr_str); [INFO] [stderr] 216 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return lexer; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `lexer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer/mod.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | return self.input.as_bytes()[self.next_pos]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.input.as_bytes()[self.next_pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer/mod.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return tok; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/formatter/mod.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | &Expr::If { [INFO] [stderr] | ______________^ [INFO] [stderr] 39 | | cond: _, [INFO] [stderr] 40 | | consequence: _, [INFO] [stderr] 41 | | alternative: _, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `If { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/formatter/mod.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | | &Expr::Func { params: _, body: _ } => true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Func { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/formatter/mod.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 213 | | if i > 0 { [INFO] [stderr] 214 | | result.push_str(&format!(", {}", expr_str)); [INFO] [stderr] 215 | | } else { [INFO] [stderr] 216 | | result.push_str(&expr_str); [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 212 | } else if i > 0 { [INFO] [stderr] 213 | result.push_str(&format!(", {}", expr_str)); [INFO] [stderr] 214 | } else { [INFO] [stderr] 215 | result.push_str(&expr_str); [INFO] [stderr] 216 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return lexer; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `lexer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer/mod.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | return self.input.as_bytes()[self.next_pos]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.input.as_bytes()[self.next_pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer/mod.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return tok; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:641:48 [INFO] [stderr] | [INFO] [stderr] 641 | Expr::Literal(Literal::Int(838383)), [INFO] [stderr] | ^^^^^^ help: consider: `838_383` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:664:57 [INFO] [stderr] | [INFO] [stderr] 664 | Stmt::Return(Expr::Literal(Literal::Int(993322))), [INFO] [stderr] | ^^^^^^ help: consider: `993_322` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/evaluator/builtins.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | Object::Array(o) => if o.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!o.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `evaluator::env::Env` [INFO] [stderr] --> src/evaluator/env.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Env { [INFO] [stderr] 15 | | store: HashMap::new(), [INFO] [stderr] 16 | | outer: None, [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/evaluator/object.rs:57:42 [INFO] [stderr] | [INFO] [stderr] 57 | result.push_str(&format!("{}", s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/evaluator/object.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | / impl Hash for Object { [INFO] [stderr] 75 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 76 | | match *self { [INFO] [stderr] 77 | | Object::Int(ref i) => i.hash(state), [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/evaluator/object.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(PartialEq, Clone, Debug)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evaluator/mod.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | None => Object::Error(String::from(format!("identifier not found: {}", name))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("identifier not found: {}", name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evaluator/mod.rs:250:32 [INFO] [stderr] | [INFO] [stderr] 250 | _ => Object::Error(String::from(format!( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 251 | | "unknown operator: {} {} {}", [INFO] [stderr] 252 | | left, infix, right [INFO] [stderr] 253 | | ))), [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 250 | _ => Object::Error(format!( [INFO] [stderr] 251 | "unknown operator: {} {} {}", [INFO] [stderr] 252 | left, infix, right [INFO] [stderr] 253 | )), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/evaluator/mod.rs:316:34 [INFO] [stderr] | [INFO] [stderr] 316 | fn eval_call_expr(&mut self, func: Box, args: Vec) -> Object { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `formatter::Formatter` [INFO] [stderr] --> src/formatter/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Formatter { [INFO] [stderr] 17 | | indent: 0, [INFO] [stderr] 18 | | column: 1, [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for formatter::Formatter { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter/mod.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match expr { [INFO] [stderr] 38 | | &Expr::If { [INFO] [stderr] 39 | | cond: _, [INFO] [stderr] 40 | | consequence: _, [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => false, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *expr { [INFO] [stderr] 38 | Expr::If { [INFO] [stderr] 39 | cond: _, [INFO] [stderr] 40 | consequence: _, [INFO] [stderr] 41 | alternative: _, [INFO] [stderr] 42 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/formatter/mod.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | } else if i + 1 == stmts.len() && *x == Stmt::Blank { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 67 | | None [INFO] [stderr] 68 | | } else if i > 0 && *x == Stmt::Blank && stmts.get(i - 1) == Some(&Stmt::Blank) { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/formatter/mod.rs:64:48 [INFO] [stderr] | [INFO] [stderr] 64 | if i == 0 && *x == Stmt::Blank { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 65 | | None [INFO] [stderr] 66 | | } else if i + 1 == stmts.len() && *x == Stmt::Blank { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/formatter/mod.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | let result = String::from(format!("let {} = ", ident_str)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("let {} = ", ident_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | right: Box, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | left: Box, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:301:54 [INFO] [stderr] | [INFO] [stderr] 301 | fn format_prefix_expr(&mut self, prefix: Prefix, right: Box) -> String { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:307:54 [INFO] [stderr] | [INFO] [stderr] 307 | fn format_index_expr(&mut self, left: Box, index: Box) -> String { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:307:37 [INFO] [stderr] | [INFO] [stderr] 307 | fn format_index_expr(&mut self, left: Box, index: Box) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | cond: Box, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:374:36 [INFO] [stderr] | [INFO] [stderr] 374 | fn format_call_expr(&mut self, func: Box, args: Vec) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer/mod.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | / loop { [INFO] [stderr] 166 | | match self.ch { [INFO] [stderr] 167 | | b'0'...b'9' => { [INFO] [stderr] 168 | | self.read_char(); [INFO] [stderr] ... | [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ help: try: `while let b'0'...b'9' = self.ch { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/mod.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / match self.parse_stmt() { [INFO] [stderr] 134 | | Some(stmt) => program.push(stmt), [INFO] [stderr] 135 | | None => {} [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(stmt) = self.parse_stmt() { program.push(stmt) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/mod.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | / match self.parse_stmt() { [INFO] [stderr] 150 | | Some(stmt) => block.push(stmt), [INFO] [stderr] 151 | | None => {} [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(stmt) = self.parse_stmt() { block.push(stmt) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/mod.rs:290:72 [INFO] [stderr] | [INFO] [stderr] 290 | Token::Int(ref mut int) => Some(Expr::Literal(Literal::Int(int.clone()))), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*int` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/parser/mod.rs:304:68 [INFO] [stderr] | [INFO] [stderr] 304 | Token::Bool(value) => Some(Expr::Literal(Literal::Bool(value == true))), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/mod.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | / let mut alternative = None; [INFO] [stderr] 470 | | [INFO] [stderr] 471 | | if self.next_token_is(&Token::Else) { [INFO] [stderr] 472 | | self.bump(); [INFO] [stderr] ... | [INFO] [stderr] 478 | | alternative = Some(self.parse_block_stmt()); [INFO] [stderr] 479 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let alternative = if self.next_token_is(&Token::Else) { ..; Some(self.parse_block_stmt()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `monkey`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/evaluator/builtins.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | Object::Array(o) => if o.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!o.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `evaluator::env::Env` [INFO] [stderr] --> src/evaluator/env.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Env { [INFO] [stderr] 15 | | store: HashMap::new(), [INFO] [stderr] 16 | | outer: None, [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/evaluator/object.rs:57:42 [INFO] [stderr] | [INFO] [stderr] 57 | result.push_str(&format!("{}", s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/evaluator/object.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | / impl Hash for Object { [INFO] [stderr] 75 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 76 | | match *self { [INFO] [stderr] 77 | | Object::Int(ref i) => i.hash(state), [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/evaluator/object.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(PartialEq, Clone, Debug)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evaluator/mod.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | None => Object::Error(String::from(format!("identifier not found: {}", name))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("identifier not found: {}", name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evaluator/mod.rs:250:32 [INFO] [stderr] | [INFO] [stderr] 250 | _ => Object::Error(String::from(format!( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 251 | | "unknown operator: {} {} {}", [INFO] [stderr] 252 | | left, infix, right [INFO] [stderr] 253 | | ))), [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 250 | _ => Object::Error(format!( [INFO] [stderr] 251 | "unknown operator: {} {} {}", [INFO] [stderr] 252 | left, infix, right [INFO] [stderr] 253 | )), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/evaluator/mod.rs:316:34 [INFO] [stderr] | [INFO] [stderr] 316 | fn eval_call_expr(&mut self, func: Box, args: Vec) -> Object { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `formatter::Formatter` [INFO] [stderr] --> src/formatter/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Formatter { [INFO] [stderr] 17 | | indent: 0, [INFO] [stderr] 18 | | column: 1, [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for formatter::Formatter { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter/mod.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match expr { [INFO] [stderr] 38 | | &Expr::If { [INFO] [stderr] 39 | | cond: _, [INFO] [stderr] 40 | | consequence: _, [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => false, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *expr { [INFO] [stderr] 38 | Expr::If { [INFO] [stderr] 39 | cond: _, [INFO] [stderr] 40 | consequence: _, [INFO] [stderr] 41 | alternative: _, [INFO] [stderr] 42 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/formatter/mod.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | } else if i + 1 == stmts.len() && *x == Stmt::Blank { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 67 | | None [INFO] [stderr] 68 | | } else if i > 0 && *x == Stmt::Blank && stmts.get(i - 1) == Some(&Stmt::Blank) { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/formatter/mod.rs:64:48 [INFO] [stderr] | [INFO] [stderr] 64 | if i == 0 && *x == Stmt::Blank { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 65 | | None [INFO] [stderr] 66 | | } else if i + 1 == stmts.len() && *x == Stmt::Blank { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/formatter/mod.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | let result = String::from(format!("let {} = ", ident_str)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("let {} = ", ident_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | right: Box, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | left: Box, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:301:54 [INFO] [stderr] | [INFO] [stderr] 301 | fn format_prefix_expr(&mut self, prefix: Prefix, right: Box) -> String { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:307:54 [INFO] [stderr] | [INFO] [stderr] 307 | fn format_index_expr(&mut self, left: Box, index: Box) -> String { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:307:37 [INFO] [stderr] | [INFO] [stderr] 307 | fn format_index_expr(&mut self, left: Box, index: Box) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | cond: Box, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/formatter/mod.rs:374:36 [INFO] [stderr] | [INFO] [stderr] 374 | fn format_call_expr(&mut self, func: Box, args: Vec) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer/mod.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | / loop { [INFO] [stderr] 166 | | match self.ch { [INFO] [stderr] 167 | | b'0'...b'9' => { [INFO] [stderr] 168 | | self.read_char(); [INFO] [stderr] ... | [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ help: try: `while let b'0'...b'9' = self.ch { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/mod.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / match self.parse_stmt() { [INFO] [stderr] 134 | | Some(stmt) => program.push(stmt), [INFO] [stderr] 135 | | None => {} [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(stmt) = self.parse_stmt() { program.push(stmt) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/mod.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | / match self.parse_stmt() { [INFO] [stderr] 150 | | Some(stmt) => block.push(stmt), [INFO] [stderr] 151 | | None => {} [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(stmt) = self.parse_stmt() { block.push(stmt) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/mod.rs:290:72 [INFO] [stderr] | [INFO] [stderr] 290 | Token::Int(ref mut int) => Some(Expr::Literal(Literal::Int(int.clone()))), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*int` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/parser/mod.rs:304:68 [INFO] [stderr] | [INFO] [stderr] 304 | Token::Bool(value) => Some(Expr::Literal(Literal::Bool(value == true))), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/mod.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | / let mut alternative = None; [INFO] [stderr] 470 | | [INFO] [stderr] 471 | | if self.next_token_is(&Token::Else) { [INFO] [stderr] 472 | | self.bump(); [INFO] [stderr] ... | [INFO] [stderr] 478 | | alternative = Some(self.parse_block_stmt()); [INFO] [stderr] 479 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let alternative = if self.next_token_is(&Token::Else) { ..; Some(self.parse_block_stmt()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/mod.rs:562:12 [INFO] [stderr] | [INFO] [stderr] 562 | if errors.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `monkey`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5ac7c4ab44e250b8f69ad96b3d2493262be3feeec4ee9251b432fa9a261518c6"` [INFO] running `"docker" "rm" "-f" "5ac7c4ab44e250b8f69ad96b3d2493262be3feeec4ee9251b432fa9a261518c6"` [INFO] [stdout] 5ac7c4ab44e250b8f69ad96b3d2493262be3feeec4ee9251b432fa9a261518c6