[INFO] updating cached repository tsullens/arc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tsullens/arc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tsullens/arc" "work/ex/clippy-test-run/sources/stable/gh/tsullens/arc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tsullens/arc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tsullens/arc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsullens/arc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsullens/arc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dd8a8a6cdb2ffe7c7b67f65b9a302a8232f09a18 [INFO] sha for GitHub repo tsullens/arc: dd8a8a6cdb2ffe7c7b67f65b9a302a8232f09a18 [INFO] validating manifest of tsullens/arc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tsullens/arc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tsullens/arc [INFO] finished frobbing tsullens/arc [INFO] frobbed toml for tsullens/arc written to work/ex/clippy-test-run/sources/stable/gh/tsullens/arc/Cargo.toml [INFO] started frobbing tsullens/arc [INFO] finished frobbing tsullens/arc [INFO] frobbed toml for tsullens/arc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsullens/arc/Cargo.toml [INFO] crate tsullens/arc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tsullens/arc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tsullens/arc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b3608a242d815c0ad6c0cfb06e11fe2e461da67a83f4da7b98e9e9134fa512b [INFO] running `"docker" "start" "-a" "2b3608a242d815c0ad6c0cfb06e11fe2e461da67a83f4da7b98e9e9134fa512b"` [INFO] [stderr] Compiling serde v1.0.59 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking rand v0.5.0 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking serde-hjson v0.8.1 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking config v0.8.0 [INFO] [stderr] Checking arc v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | pub const ARC_CRLF: &'static str = "\r\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | pub const ARC_OK: &'static str = "+OK"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub const ARC_ERR: &'static str = "-ERR"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/server.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | fn tear_down(mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/server.rs:108:64 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn write_response(&mut self, response: ClientResponse) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return "Invalid configuration" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Invalid configuration"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/server.rs:159:33 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn inc_key_count(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/server.rs:163:33 [INFO] [stderr] | [INFO] [stderr] 163 | pub fn dec_key_count(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return "Invalid command" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Invalid command"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/commands.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | resp [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/commands.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | let resp = match server.config.get(key) { [INFO] [stderr] | ________________^ [INFO] [stderr] 86 | | Some(val) => ClientResponse::Ok(val), [INFO] [stderr] 87 | | None => ClientResponse::Err("unknown config key".to_string()), [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return ClientResponse::Ok(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ClientResponse::Ok(String::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return ClientResponse::Ok(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ClientResponse::Ok(String::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | const DEFAULT_CONFIG_FILE: &'static str = "./settings.conf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:5:30 [INFO] [stderr] | [INFO] [stderr] 5 | const DEFAULT_BIND_ADDRESS: &'static str = "127.0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | const DEFAULT_BIND_PORT: &'static str = "7878"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return config; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:65:32 [INFO] [stderr] | [INFO] [stderr] 65 | &"bind_address" => return Some(self.bind_address.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.bind_address.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | &"port" => return Some(self.port.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.port.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | &"cache_write_through" => return Some(self.cache_write_through.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.cache_write_through.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | &"debug" => return Some(self.debug.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.debug.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:21:59 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn update(&mut self, key: &str, val: DatabaseVal) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:25:59 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn update_string(&mut self, key: &str, val: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:38:73 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn update_or_insert_set(&mut self, key: &str, vals: &Vec<&str>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return "Database error" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Database error"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:156:45 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn add(&mut self, vals: &Vec<&str>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/database.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | ret_string [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/database.rs:166:26 [INFO] [stderr] | [INFO] [stderr] 166 | let ret_string = iter_2.fold( [INFO] [stderr] | __________________________^ [INFO] [stderr] 167 | | String::with_capacity(t_size), [INFO] [stderr] 168 | | |mut acc, s| { [INFO] [stderr] 169 | | acc.push_str(&" "); [INFO] [stderr] ... | [INFO] [stderr] 172 | | } [INFO] [stderr] 173 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | pub const ARC_CRLF: &'static str = "\r\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | pub const ARC_OK: &'static str = "+OK"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub const ARC_ERR: &'static str = "-ERR"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/server.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | fn tear_down(mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/server.rs:108:64 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn write_response(&mut self, response: ClientResponse) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return "Invalid configuration" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Invalid configuration"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/server.rs:159:33 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn inc_key_count(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/server.rs:163:33 [INFO] [stderr] | [INFO] [stderr] 163 | pub fn dec_key_count(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return "Invalid command" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Invalid command"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/commands.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | resp [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/commands.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | let resp = match server.config.get(key) { [INFO] [stderr] | ________________^ [INFO] [stderr] 86 | | Some(val) => ClientResponse::Ok(val), [INFO] [stderr] 87 | | None => ClientResponse::Err("unknown config key".to_string()), [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return ClientResponse::Ok(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ClientResponse::Ok(String::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return ClientResponse::Ok(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ClientResponse::Ok(String::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | const DEFAULT_CONFIG_FILE: &'static str = "./settings.conf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:5:30 [INFO] [stderr] | [INFO] [stderr] 5 | const DEFAULT_BIND_ADDRESS: &'static str = "127.0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | const DEFAULT_BIND_PORT: &'static str = "7878"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return config; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:65:32 [INFO] [stderr] | [INFO] [stderr] 65 | &"bind_address" => return Some(self.bind_address.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.bind_address.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | &"port" => return Some(self.port.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.port.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | &"cache_write_through" => return Some(self.cache_write_through.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.cache_write_through.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | &"debug" => return Some(self.debug.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.debug.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:21:59 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn update(&mut self, key: &str, val: DatabaseVal) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:25:59 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn update_string(&mut self, key: &str, val: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:38:73 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn update_or_insert_set(&mut self, key: &str, vals: &Vec<&str>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return "Database error" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Database error"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:156:45 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn add(&mut self, vals: &Vec<&str>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/database.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | ret_string [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/database.rs:166:26 [INFO] [stderr] | [INFO] [stderr] 166 | let ret_string = iter_2.fold( [INFO] [stderr] | __________________________^ [INFO] [stderr] 167 | | String::with_capacity(t_size), [INFO] [stderr] 168 | | |mut acc, s| { [INFO] [stderr] 169 | | acc.push_str(&" "); [INFO] [stderr] ... | [INFO] [stderr] 172 | | } [INFO] [stderr] 173 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inc_key_count` [INFO] [stderr] --> src/server.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn inc_key_count(&self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match stream.shutdown(Shutdown::Both) { [INFO] [stderr] 103 | | Err(err) => println!("Error shutting down client {}: {}", self.id, err), [INFO] [stderr] 104 | | _ => (), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = stream.shutdown(Shutdown::Both) { println!("Error shutting down client {}: {}", self.id, err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | self.stream_writer.write(formatted_response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:72:58 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn ping_command(_server: &mut Arc, _args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:76:58 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn config_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:95:55 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn set_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:102:55 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn get_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:116:55 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn del_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:129:56 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn sadd_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:36:37 [INFO] [stderr] | [INFO] [stderr] 36 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/config.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match &key.to_lowercase().as_str() { [INFO] [stderr] 65 | | &"bind_address" => return Some(self.bind_address.clone()), [INFO] [stderr] 66 | | &"port" => return Some(self.port.clone()), [INFO] [stderr] 67 | | &"cache_write_through" => return Some(self.cache_write_through.to_string()), [INFO] [stderr] 68 | | &"debug" => return Some(self.debug.to_string()), [INFO] [stderr] 69 | | _ => None, [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | match key.to_lowercase().as_str() { [INFO] [stderr] 65 | "bind_address" => return Some(self.bind_address.clone()), [INFO] [stderr] 66 | "port" => return Some(self.port.clone()), [INFO] [stderr] 67 | "cache_write_through" => return Some(self.cache_write_through.to_string()), [INFO] [stderr] 68 | "debug" => return Some(self.debug.to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:38:61 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn update_or_insert_set(&mut self, key: &str, vals: &Vec<&str>) -> () { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:47:51 [INFO] [stderr] | [INFO] [stderr] 47 | fn try_update_set(&mut self, key: &str, vals: &Vec<&str>) -> Result<(), ()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn from(vals: &Vec<&str>) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:156:33 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn add(&mut self, vals: &Vec<&str>) -> () { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `inc_key_count` [INFO] [stderr] --> src/server.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn inc_key_count(&self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match stream.shutdown(Shutdown::Both) { [INFO] [stderr] 103 | | Err(err) => println!("Error shutting down client {}: {}", self.id, err), [INFO] [stderr] 104 | | _ => (), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = stream.shutdown(Shutdown::Both) { println!("Error shutting down client {}: {}", self.id, err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | self.stream_writer.write(formatted_response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:72:58 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn ping_command(_server: &mut Arc, _args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:76:58 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn config_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:95:55 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn set_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:102:55 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn get_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:116:55 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn del_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:129:56 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn sadd_command(server: &mut Arc, args: &Vec<&str>) -> ClientResponse { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:36:37 [INFO] [stderr] | [INFO] [stderr] 36 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/config.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match &key.to_lowercase().as_str() { [INFO] [stderr] 65 | | &"bind_address" => return Some(self.bind_address.clone()), [INFO] [stderr] 66 | | &"port" => return Some(self.port.clone()), [INFO] [stderr] 67 | | &"cache_write_through" => return Some(self.cache_write_through.to_string()), [INFO] [stderr] 68 | | &"debug" => return Some(self.debug.to_string()), [INFO] [stderr] 69 | | _ => None, [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | match key.to_lowercase().as_str() { [INFO] [stderr] 65 | "bind_address" => return Some(self.bind_address.clone()), [INFO] [stderr] 66 | "port" => return Some(self.port.clone()), [INFO] [stderr] 67 | "cache_write_through" => return Some(self.cache_write_through.to_string()), [INFO] [stderr] 68 | "debug" => return Some(self.debug.to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:38:61 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn update_or_insert_set(&mut self, key: &str, vals: &Vec<&str>) -> () { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:47:51 [INFO] [stderr] | [INFO] [stderr] 47 | fn try_update_set(&mut self, key: &str, vals: &Vec<&str>) -> Result<(), ()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn from(vals: &Vec<&str>) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/database.rs:156:33 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn add(&mut self, vals: &Vec<&str>) -> () { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2b3608a242d815c0ad6c0cfb06e11fe2e461da67a83f4da7b98e9e9134fa512b"` [INFO] running `"docker" "rm" "-f" "2b3608a242d815c0ad6c0cfb06e11fe2e461da67a83f4da7b98e9e9134fa512b"` [INFO] [stdout] 2b3608a242d815c0ad6c0cfb06e11fe2e461da67a83f4da7b98e9e9134fa512b