[INFO] updating cached repository tstullich/rust-pt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tstullich/rust-pt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tstullich/rust-pt" "work/ex/clippy-test-run/sources/stable/gh/tstullich/rust-pt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tstullich/rust-pt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tstullich/rust-pt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tstullich/rust-pt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tstullich/rust-pt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 98c489c9f3f4f5cf136b6349437ea73129b25988 [INFO] sha for GitHub repo tstullich/rust-pt: 98c489c9f3f4f5cf136b6349437ea73129b25988 [INFO] validating manifest of tstullich/rust-pt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tstullich/rust-pt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tstullich/rust-pt [INFO] finished frobbing tstullich/rust-pt [INFO] frobbed toml for tstullich/rust-pt written to work/ex/clippy-test-run/sources/stable/gh/tstullich/rust-pt/Cargo.toml [INFO] started frobbing tstullich/rust-pt [INFO] finished frobbing tstullich/rust-pt [INFO] frobbed toml for tstullich/rust-pt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tstullich/rust-pt/Cargo.toml [INFO] crate tstullich/rust-pt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tstullich/rust-pt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tstullich/rust-pt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2f25cebd0847fc7ec5a93a8b2a8698b61efab59f11b357f2f9ce7aa448d2ed1e [INFO] running `"docker" "start" "-a" "2f25cebd0847fc7ec5a93a8b2a8698b61efab59f11b357f2f9ce7aa448d2ed1e"` [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking pathtracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let s = r.origin() - self.v0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let u = f * (s.dot(&h)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let q = s.cross(&edge1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | let v = f * r.direction().dot(&q); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let t = f * edge2.dot(&q); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let s = r.origin() - self.v0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let u = f * (s.dot(&h)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let q = s.cross(&edge1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | let v = f * r.direction().dot(&q); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/triangle.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let t = f * edge2.dot(&q); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bvh_node.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return NodeId { index: next_index }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeId { index: next_index }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bvh_node.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return NodeId { index: next_index }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeId { index: next_index }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | Vec3::new(-2.6787124, -2.692856, 0.80644226) [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.678_712_4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:114:32 [INFO] [stderr] | [INFO] [stderr] 114 | Vec3::new(-2.6787124, -2.692856, 0.80644226) [INFO] [stderr] | ^^^^^^^^ help: consider: `2.692_856` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:114:42 [INFO] [stderr] | [INFO] [stderr] 114 | Vec3::new(-2.6787124, -2.692856, 0.80644226) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.806_442_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:116:42 [INFO] [stderr] | [INFO] [stderr] 116 | assert_eq!(cam.horizontal, Vec3::new(5.464072, -0.0, -0.5464072)); [INFO] [stderr] | ^^^^^^^^ help: consider: `5.464_072` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:116:59 [INFO] [stderr] | [INFO] [stderr] 116 | assert_eq!(cam.horizontal, Vec3::new(5.464072, -0.0, -0.5464072)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.546_407_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:117:41 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(cam.vertical, Vec3::new(-0.10664777, 5.385712, -1.0664777)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.106_647_77` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:117:53 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(cam.vertical, Vec3::new(-0.10664777, 5.385712, -1.0664777)); [INFO] [stderr] | ^^^^^^^^ help: consider: `5.385_712` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:117:64 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(cam.vertical, Vec3::new(-0.10664777, 5.385712, -1.0664777)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.066_477_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:119:33 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(cam.u, Vec3::new(0.9950372, -0.0, -0.09950372)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.995_037_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:119:51 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(cam.u, Vec3::new(0.9950372, -0.0, -0.09950372)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.099_503_72` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:120:34 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(cam.v, Vec3::new(-0.019421138, 0.9807674, -0.19421138)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.019_421_138` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:120:47 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(cam.v, Vec3::new(-0.019421138, 0.9807674, -0.19421138)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.980_767_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:120:59 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(cam.v, Vec3::new(-0.019421138, 0.9807674, -0.19421138)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.194_211_38` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable_list.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return bb; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `bb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / return if scattered.direction().dot(&rec.normal) > 0.0 { [INFO] [stderr] 53 | | Some(scattered) [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | None [INFO] [stderr] 56 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | if scattered.direction().dot(&rec.normal) > 0.0 { [INFO] [stderr] 53 | Some(scattered) [INFO] [stderr] 54 | } else { [INFO] [stderr] 55 | None [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / return if discriminant > 0.0 { [INFO] [stderr] 115 | | let r = (uv - *normal * dt) * ni_over_nt - (*normal * discriminant.sqrt()); [INFO] [stderr] 116 | | Some(r) [INFO] [stderr] 117 | | } else { [INFO] [stderr] 118 | | None [INFO] [stderr] 119 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 114 | if discriminant > 0.0 { [INFO] [stderr] 115 | let r = (uv - *normal * dt) * ni_over_nt - (*normal * discriminant.sqrt()); [INFO] [stderr] 116 | Some(r) [INFO] [stderr] 117 | } else { [INFO] [stderr] 118 | None [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/triangle.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | let epsilon = 0.0000001; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vector.rs:273:29 [INFO] [stderr] | [INFO] [stderr] 273 | assert_eq!(v1.length(), 1.4142135); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.414_213_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vector.rs:275:46 [INFO] [stderr] | [INFO] [stderr] 275 | assert_eq!(Vec3::unit_vec(v1), Vec3::new(0.70710677, 0.0, 0.70710677)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.707_106_77` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vector.rs:275:63 [INFO] [stderr] | [INFO] [stderr] 275 | assert_eq!(Vec3::unit_vec(v1), Vec3::new(0.70710677, 0.0, 0.70710677)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.707_106_77` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error[E0204]: the trait `Copy` may not be implemented for this type [INFO] [stderr] --> src/material.rs:7:10 [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] 8 | pub enum Material { [INFO] [stderr] 9 | Lambertian(Texture), [INFO] [stderr] | ------- this field does not implement `Copy` [INFO] [stderr] [INFO] [stderr] error[E0204]: the trait `Copy` may not be implemented for this type [INFO] [stderr] --> src/texture.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] 25 | pub struct Checker { [INFO] [stderr] 26 | odd: Box, [INFO] [stderr] | ----------------- this field does not implement `Copy` [INFO] [stderr] 27 | even: Box, [INFO] [stderr] | ------------------ this field does not implement `Copy` [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0204`. [INFO] [stderr] error: Could not compile `pathtracer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bvh_node.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return NodeId { index: next_index }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeId { index: next_index }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bvh_node.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return NodeId { index: next_index }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeId { index: next_index }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `material::Material` [INFO] [stderr] --> src/hitable_list.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use material::Material; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MovingSphere`, `Sphere` [INFO] [stderr] --> src/hitable_list.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | use sphere::{MovingSphere, Sphere}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `vector::Vec3` [INFO] [stderr] --> src/hitable_list.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use vector::Vec3; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable_list.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return bb; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `bb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / return if scattered.direction().dot(&rec.normal) > 0.0 { [INFO] [stderr] 53 | | Some(scattered) [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | None [INFO] [stderr] 56 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | if scattered.direction().dot(&rec.normal) > 0.0 { [INFO] [stderr] 53 | Some(scattered) [INFO] [stderr] 54 | } else { [INFO] [stderr] 55 | None [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / return if discriminant > 0.0 { [INFO] [stderr] 115 | | let r = (uv - *normal * dt) * ni_over_nt - (*normal * discriminant.sqrt()); [INFO] [stderr] 116 | | Some(r) [INFO] [stderr] 117 | | } else { [INFO] [stderr] 118 | | None [INFO] [stderr] 119 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 114 | if discriminant > 0.0 { [INFO] [stderr] 115 | let r = (uv - *normal * dt) * ni_over_nt - (*normal * discriminant.sqrt()); [INFO] [stderr] 116 | Some(r) [INFO] [stderr] 117 | } else { [INFO] [stderr] 118 | None [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `material::Material` [INFO] [stderr] --> src/renderer.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use material::Material; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `sphere::Sphere` [INFO] [stderr] --> src/renderer.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use sphere::Sphere; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/triangle.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | let epsilon = 0.0000001; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error[E0204]: the trait `Copy` may not be implemented for this type [INFO] [stderr] --> src/material.rs:7:10 [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] 8 | pub enum Material { [INFO] [stderr] 9 | Lambertian(Texture), [INFO] [stderr] | ------- this field does not implement `Copy` [INFO] [stderr] [INFO] [stderr] error[E0204]: the trait `Copy` may not be implemented for this type [INFO] [stderr] --> src/texture.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Copy, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] 25 | pub struct Checker { [INFO] [stderr] 26 | odd: Box, [INFO] [stderr] | ----------------- this field does not implement `Copy` [INFO] [stderr] 27 | even: Box, [INFO] [stderr] | ------------------ this field does not implement `Copy` [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0204`. [INFO] [stderr] error: Could not compile `pathtracer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2f25cebd0847fc7ec5a93a8b2a8698b61efab59f11b357f2f9ce7aa448d2ed1e"` [INFO] running `"docker" "rm" "-f" "2f25cebd0847fc7ec5a93a8b2a8698b61efab59f11b357f2f9ce7aa448d2ed1e"` [INFO] [stdout] 2f25cebd0847fc7ec5a93a8b2a8698b61efab59f11b357f2f9ce7aa448d2ed1e