[INFO] updating cached repository tsloughter/erls
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tsloughter/erls
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tsloughter/erls" "work/ex/clippy-test-run/sources/stable/gh/tsloughter/erls"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tsloughter/erls'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tsloughter/erls" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsloughter/erls"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsloughter/erls'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 26c48001bbdd3b88888f9729d763cf544dc3e510
[INFO] sha for GitHub repo tsloughter/erls: 26c48001bbdd3b88888f9729d763cf544dc3e510
[INFO] validating manifest of tsloughter/erls on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tsloughter/erls on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tsloughter/erls
[INFO] finished frobbing tsloughter/erls
[INFO] frobbed toml for tsloughter/erls written to work/ex/clippy-test-run/sources/stable/gh/tsloughter/erls/Cargo.toml
[INFO] started frobbing tsloughter/erls
[INFO] finished frobbing tsloughter/erls
[INFO] frobbed toml for tsloughter/erls written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsloughter/erls/Cargo.toml
[INFO] crate tsloughter/erls has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tsloughter/erls against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tsloughter/erls:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 136ec596cc68c92b7a6740d80e392ae26845539e5e4a05c4da6b148a7db36e19
[INFO] running `"docker" "start" "-a" "136ec596cc68c92b7a6740d80e392ae26845539e5e4a05c4da6b148a7db36e19"`
[INFO] [stderr]     Checking winapi v0.2.6
[INFO] [stderr]     Checking libc v0.2.10
[INFO] [stderr]     Checking regex-syntax v0.3.1
[INFO] [stderr]     Checking utf8-ranges v0.1.3
[INFO] [stderr]     Checking ansi_term v0.7.2
[INFO] [stderr]     Checking yaml-rust v0.3.2
[INFO] [stderr]     Checking strsim v0.4.1
[INFO] [stderr]     Checking bitflags v0.5.0
[INFO] [stderr]     Checking rust-ini v0.9.4
[INFO] [stderr]     Checking memchr v0.1.11
[INFO] [stderr]     Checking filetime v0.1.10
[INFO] [stderr]     Checking rand v0.3.14
[INFO] [stderr]     Checking kernel32-sys v0.2.2
[INFO] [stderr]     Checking aho-corasick v0.5.1
[INFO] [stderr]     Checking thread-id v2.0.0
[INFO] [stderr]     Checking tar v0.4.5
[INFO] [stderr]     Checking thread_local v0.2.3
[INFO] [stderr]     Checking clap v2.3.0
[INFO] [stderr]     Checking tempdir v0.3.4
[INFO] [stderr]     Checking regex v0.1.66
[INFO] [stderr]     Checking env_logger v0.3.3
[INFO] [stderr]     Checking erls v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/build.rs:21:19
[INFO] [stderr]    |
[INFO] [stderr] 21 | pub const BINS: [&'static str; 21] = ["bin/ct_run",
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/config.rs:11:26
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let base_dir = match env::home_dir() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:25:26
[INFO] [stderr]    |
[INFO] [stderr] 25 |     let base_dir = match env::home_dir() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/build.rs:21:19
[INFO] [stderr]    |
[INFO] [stderr] 21 | pub const BINS: [&'static str; 21] = ["bin/ct_run",
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/config.rs:11:26
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let base_dir = match env::home_dir() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:25:26
[INFO] [stderr]    |
[INFO] [stderr] 25 |     let base_dir = match env::home_dir() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: for loop over `erls`, which is an `Option`. This is more readably written as an `if let` statement.
[INFO] [stderr]   --> src/config.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for s in erls {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::for_loop_over_option)] on by default
[INFO] [stderr]    = help: consider replacing `for s in erls` with `if let Some(s) = erls`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/erl.rs:14:25
[INFO] [stderr]    |
[INFO] [stderr] 14 |       let args2: Vec<_> = args.map(|arg| {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 15 | |         arg.clone()
[INFO] [stderr] 16 | |     }).collect();
[INFO] [stderr]    | |______^ help: Consider calling the dedicated `cloned` method: `args.cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:30:50
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let config_file = matches.value_of("config").unwrap_or(default_config.to_str().unwrap());
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| default_config.to_str().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] error: for loop over `erls`, which is an `Option`. This is more readably written as an `if let` statement.
[INFO] [stderr]   --> src/config.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for s in erls {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::for_loop_over_option)] on by default
[INFO] [stderr]    = help: consider replacing `for s in erls` with `if let Some(s) = erls`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `erls`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/erl.rs:14:25
[INFO] [stderr]    |
[INFO] [stderr] 14 |       let args2: Vec<_> = args.map(|arg| {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 15 | |         arg.clone()
[INFO] [stderr] 16 | |     }).collect();
[INFO] [stderr]    | |______^ help: Consider calling the dedicated `cloned` method: `args.cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:30:50
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let config_file = matches.value_of("config").unwrap_or(default_config.to_str().unwrap());
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| default_config.to_str().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `erls`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "136ec596cc68c92b7a6740d80e392ae26845539e5e4a05c4da6b148a7db36e19"`
[INFO] running `"docker" "rm" "-f" "136ec596cc68c92b7a6740d80e392ae26845539e5e4a05c4da6b148a7db36e19"`
[INFO] [stdout] 136ec596cc68c92b7a6740d80e392ae26845539e5e4a05c4da6b148a7db36e19