[INFO] updating cached repository tslilyai/rustyrb
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tslilyai/rustyrb
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tslilyai/rustyrb" "work/ex/clippy-test-run/sources/stable/gh/tslilyai/rustyrb"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tslilyai/rustyrb'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tslilyai/rustyrb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tslilyai/rustyrb"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tslilyai/rustyrb'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5310109fba877afa137980dad4715e076b1e1124
[INFO] sha for GitHub repo tslilyai/rustyrb: 5310109fba877afa137980dad4715e076b1e1124
[INFO] validating manifest of tslilyai/rustyrb on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tslilyai/rustyrb on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tslilyai/rustyrb
[INFO] finished frobbing tslilyai/rustyrb
[INFO] frobbed toml for tslilyai/rustyrb written to work/ex/clippy-test-run/sources/stable/gh/tslilyai/rustyrb/Cargo.toml
[INFO] started frobbing tslilyai/rustyrb
[INFO] finished frobbing tslilyai/rustyrb
[INFO] frobbed toml for tslilyai/rustyrb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tslilyai/rustyrb/Cargo.toml
[INFO] crate tslilyai/rustyrb has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tslilyai/rustyrb against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tslilyai/rustyrb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dc70897bcb57f45496c6a57042cd78e76287222a775ac656b5f259c77db5e568
[INFO] running `"docker" "start" "-a" "dc70897bcb57f45496c6a57042cd78e76287222a775ac656b5f259c77db5e568"`
[INFO] [stderr]     Checking rustyrbtree v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rbtree.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             key: key,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rbtree.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             val: val,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `val`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rbtree.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             color: color,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `color`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rbtree.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             size: size,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rbtree.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             key: key,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rbtree.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             val: val,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `val`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rbtree.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             color: color,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `color`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rbtree.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             size: size,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rbtree.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return self.color == 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.color == 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rbtree.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         return 0;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 |         return self.size() < size;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size() < size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:145:9
[INFO] [stderr]     |
[INFO] [stderr] 145 |         return hptr;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `hptr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:197:9
[INFO] [stderr]     |
[INFO] [stderr] 197 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:215:9
[INFO] [stderr]     |
[INFO] [stderr] 215 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:221:9
[INFO] [stderr]     |
[INFO] [stderr] 221 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:231:9
[INFO] [stderr]     |
[INFO] [stderr] 231 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:246:9
[INFO] [stderr]     |
[INFO] [stderr] 246 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:310:9
[INFO] [stderr]     |
[INFO] [stderr] 310 |         return r;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `r`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/rbtree.rs:298:9
[INFO] [stderr]     |
[INFO] [stderr] 298 | /         if RBTree::is_node_red(&(*r).right) {
[INFO] [stderr] 299 | |             if !is_put || (is_put && !RBTree::is_node_red(&(*r).left)) {
[INFO] [stderr] 300 | |                 RBTree::rotate_left(&mut r);
[INFO] [stderr] 301 | |             }
[INFO] [stderr] 302 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 298 |         if RBTree::is_node_red(&(*r).right) && (!is_put || (is_put && !RBTree::is_node_red(&(*r).left))) {
[INFO] [stderr] 299 |     RBTree::rotate_left(&mut r);
[INFO] [stderr] 300 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:317:9
[INFO] [stderr]     |
[INFO] [stderr] 317 |         return Node::size(&self.root);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node::size(&self.root)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:325:9
[INFO] [stderr]     |
[INFO] [stderr] 325 |         return self.height_helper(&self.root);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.height_helper(&self.root)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:369:9
[INFO] [stderr]     |
[INFO] [stderr] 369 | /         return self.is_bst() 
[INFO] [stderr] 370 | |             && self.is_size_consistent() 
[INFO] [stderr] 371 | |             && self.is_rank_consistent() 
[INFO] [stderr] 372 | |             && self.is_23() 
[INFO] [stderr] 373 | |             && self.is_balanced();
[INFO] [stderr]     | |__________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 369 |         self.is_bst() 
[INFO] [stderr] 370 |             && self.is_size_consistent() 
[INFO] [stderr] 371 |             && self.is_rank_consistent() 
[INFO] [stderr] 372 |             && self.is_23() 
[INFO] [stderr] 373 |             && self.is_balanced()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:379:9
[INFO] [stderr]     |
[INFO] [stderr] 379 |         return self.is_bst_helper(&self.root, None, None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_bst_helper(&self.root, None, None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:400:9
[INFO] [stderr]     |
[INFO] [stderr] 400 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:404:9
[INFO] [stderr]     |
[INFO] [stderr] 404 |         return self.is_size_consistent_helper(&self.root); 
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_size_consistent_helper(&self.root)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:414:9
[INFO] [stderr]     |
[INFO] [stderr] 414 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:420:9
[INFO] [stderr]     |
[INFO] [stderr] 420 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:426:9
[INFO] [stderr]     |
[INFO] [stderr] 426 |         return self.is_23_helper(&self.root); 
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_23_helper(&self.root)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:443:9
[INFO] [stderr]     |
[INFO] [stderr] 443 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:456:9
[INFO] [stderr]     |
[INFO] [stderr] 456 |         return self.is_balanced_helper(&self.root, black);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_balanced_helper(&self.root, black)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:469:9
[INFO] [stderr]     |
[INFO] [stderr] 469 |         return black == 0;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `black == 0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rbtree.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return self.color == 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.color == 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rbtree.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         return 0;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 |         return self.size() < size;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size() < size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:145:9
[INFO] [stderr]     |
[INFO] [stderr] 145 |         return hptr;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `hptr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:197:9
[INFO] [stderr]     |
[INFO] [stderr] 197 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:215:9
[INFO] [stderr]     |
[INFO] [stderr] 215 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:221:9
[INFO] [stderr]     |
[INFO] [stderr] 221 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:231:9
[INFO] [stderr]     |
[INFO] [stderr] 231 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:246:9
[INFO] [stderr]     |
[INFO] [stderr] 246 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:310:9
[INFO] [stderr]     |
[INFO] [stderr] 310 |         return r;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `r`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/rbtree.rs:298:9
[INFO] [stderr]     |
[INFO] [stderr] 298 | /         if RBTree::is_node_red(&(*r).right) {
[INFO] [stderr] 299 | |             if !is_put || (is_put && !RBTree::is_node_red(&(*r).left)) {
[INFO] [stderr] 300 | |                 RBTree::rotate_left(&mut r);
[INFO] [stderr] 301 | |             }
[INFO] [stderr] 302 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 298 |         if RBTree::is_node_red(&(*r).right) && (!is_put || (is_put && !RBTree::is_node_red(&(*r).left))) {
[INFO] [stderr] 299 |     RBTree::rotate_left(&mut r);
[INFO] [stderr] 300 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:317:9
[INFO] [stderr]     |
[INFO] [stderr] 317 |         return Node::size(&self.root);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node::size(&self.root)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:325:9
[INFO] [stderr]     |
[INFO] [stderr] 325 |         return self.height_helper(&self.root);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.height_helper(&self.root)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:369:9
[INFO] [stderr]     |
[INFO] [stderr] 369 | /         return self.is_bst() 
[INFO] [stderr] 370 | |             && self.is_size_consistent() 
[INFO] [stderr] 371 | |             && self.is_rank_consistent() 
[INFO] [stderr] 372 | |             && self.is_23() 
[INFO] [stderr] 373 | |             && self.is_balanced();
[INFO] [stderr]     | |__________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 369 |         self.is_bst() 
[INFO] [stderr] 370 |             && self.is_size_consistent() 
[INFO] [stderr] 371 |             && self.is_rank_consistent() 
[INFO] [stderr] 372 |             && self.is_23() 
[INFO] [stderr] 373 |             && self.is_balanced()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:379:9
[INFO] [stderr]     |
[INFO] [stderr] 379 |         return self.is_bst_helper(&self.root, None, None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_bst_helper(&self.root, None, None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:400:9
[INFO] [stderr]     |
[INFO] [stderr] 400 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:404:9
[INFO] [stderr]     |
[INFO] [stderr] 404 |         return self.is_size_consistent_helper(&self.root); 
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_size_consistent_helper(&self.root)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:414:9
[INFO] [stderr]     |
[INFO] [stderr] 414 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:420:9
[INFO] [stderr]     |
[INFO] [stderr] 420 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:426:9
[INFO] [stderr]     |
[INFO] [stderr] 426 |         return self.is_23_helper(&self.root); 
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_23_helper(&self.root)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:443:9
[INFO] [stderr]     |
[INFO] [stderr] 443 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:456:9
[INFO] [stderr]     |
[INFO] [stderr] 456 |         return self.is_balanced_helper(&self.root, black);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_balanced_helper(&self.root, black)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rbtree.rs:469:9
[INFO] [stderr]     |
[INFO] [stderr] 469 |         return black == 0;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `black == 0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: private type `rbtree::Node<K, V>` in public interface (error E0446)
[INFO] [stderr]    --> src/rbtree.rs:164:5
[INFO] [stderr]     |
[INFO] [stderr] 164 | /     pub fn delete_helper(&self, hptr: &NodeptrT<K,V>, key: K) -> NodeptrT<K,V> { 
[INFO] [stderr] 165 | |         if let Some(mut h) = hptr.clone() {
[INFO] [stderr] 166 | |             if key < h.key  {
[INFO] [stderr] 167 | |                 if !RBTree::is_node_red(&h.left) && !RBTree::is_child_node_red(&h.left, 0) {
[INFO] [stderr] ...   |
[INFO] [stderr] 197 | |         return None;
[INFO] [stderr] 198 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(private_in_public)] on by default
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
[INFO] [stderr] 
[INFO] [stderr] warning: private type `rbtree::Node<K, V>` in public interface (error E0446)
[INFO] [stderr]    --> src/rbtree.rs:164:5
[INFO] [stderr]     |
[INFO] [stderr] 164 | /     pub fn delete_helper(&self, hptr: &NodeptrT<K,V>, key: K) -> NodeptrT<K,V> { 
[INFO] [stderr] 165 | |         if let Some(mut h) = hptr.clone() {
[INFO] [stderr] 166 | |             if key < h.key  {
[INFO] [stderr] 167 | |                 if !RBTree::is_node_red(&h.left) && !RBTree::is_child_node_red(&h.left, 0) {
[INFO] [stderr] ...   |
[INFO] [stderr] 197 | |         return None;
[INFO] [stderr] 198 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
[INFO] [stderr] 
[INFO] [stderr] warning: private type `rbtree::Node<K, V>` in public interface (error E0446)
[INFO] [stderr]    --> src/rbtree.rs:164:5
[INFO] [stderr]     |
[INFO] [stderr] 164 | /     pub fn delete_helper(&self, hptr: &NodeptrT<K,V>, key: K) -> NodeptrT<K,V> { 
[INFO] [stderr] 165 | |         if let Some(mut h) = hptr.clone() {
[INFO] [stderr] 166 | |             if key < h.key  {
[INFO] [stderr] 167 | |                 if !RBTree::is_node_red(&h.left) && !RBTree::is_child_node_red(&h.left, 0) {
[INFO] [stderr] ...   |
[INFO] [stderr] 197 | |         return None;
[INFO] [stderr] 198 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(private_in_public)] on by default
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
[INFO] [stderr] 
[INFO] [stderr] warning: private type `rbtree::Node<K, V>` in public interface (error E0446)
[INFO] [stderr]    --> src/rbtree.rs:164:5
[INFO] [stderr]     |
[INFO] [stderr] 164 | /     pub fn delete_helper(&self, hptr: &NodeptrT<K,V>, key: K) -> NodeptrT<K,V> { 
[INFO] [stderr] 165 | |         if let Some(mut h) = hptr.clone() {
[INFO] [stderr] 166 | |             if key < h.key  {
[INFO] [stderr] 167 | |                 if !RBTree::is_node_red(&h.left) && !RBTree::is_child_node_red(&h.left, 0) {
[INFO] [stderr] ...   |
[INFO] [stderr] 197 | |         return None;
[INFO] [stderr] 198 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `height`
[INFO] [stderr]    --> src/rbtree.rs:324:5
[INFO] [stderr]     |
[INFO] [stderr] 324 |     pub fn height(&self) -> isize {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `height_helper`
[INFO] [stderr]    --> src/rbtree.rs:327:5
[INFO] [stderr]     |
[INFO] [stderr] 327 |     fn height_helper(&self, xptr: &NodeptrT<K,V>) -> isize {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:121:25
[INFO] [stderr]     |
[INFO] [stderr] 121 |     fn move_red_left(h: &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:133:27
[INFO] [stderr]     |
[INFO] [stderr] 133 |     fn move_red_right(h : &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `height`
[INFO] [stderr]    --> src/rbtree.rs:324:5
[INFO] [stderr]     |
[INFO] [stderr] 324 |     pub fn height(&self) -> isize {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `height_helper`
[INFO] [stderr]    --> src/rbtree.rs:327:5
[INFO] [stderr]     |
[INFO] [stderr] 327 |     fn height_helper(&self, xptr: &NodeptrT<K,V>) -> isize {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/rbtree.rs:176:28
[INFO] [stderr]     |
[INFO] [stderr] 176 |                       if let None = h.right {
[INFO] [stderr]     |  _____________________-      ^^^^
[INFO] [stderr] 177 | |                         return None;
[INFO] [stderr] 178 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if h.right.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/rbtree.rs:187:33
[INFO] [stderr]     |
[INFO] [stderr] 187 |                         h.val = x.val.clone();
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^ help: try removing the `clone` call: `x.val`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rbtree.rs:218:16
[INFO] [stderr]     |
[INFO] [stderr] 218 |           if let Some(_) = self.find(key) {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 219 | |             return true;
[INFO] [stderr] 220 | |         } 
[INFO] [stderr]     | |_________- help: try this: `if self.find(key).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:249:29
[INFO] [stderr]     |
[INFO] [stderr] 249 |     fn rotate_left(nodeptr: &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:264:30
[INFO] [stderr]     |
[INFO] [stderr] 264 |     fn rotate_right(nodeptr: &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:285:29
[INFO] [stderr]     |
[INFO] [stderr] 285 |     fn flip_colors(nodeptr: &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:296:22
[INFO] [stderr]     |
[INFO] [stderr] 296 |     fn balance(rbox: &Box<Node<K,V>>, is_put: bool) -> Box<Node<K,V>> {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^ help: try: `&Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/rbtree.rs:299:16
[INFO] [stderr]     |
[INFO] [stderr] 299 |             if !is_put || (is_put && !RBTree::is_node_red(&(*r).left)) {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 299 |             if !RBTree::is_node_red(&(*r).left) || !is_put {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 299 |             if !(is_put && RBTree::is_node_red(&(*r).left)) {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:121:25
[INFO] [stderr]     |
[INFO] [stderr] 121 |     fn move_red_left(h: &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:133:27
[INFO] [stderr]     |
[INFO] [stderr] 133 |     fn move_red_right(h : &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/rbtree.rs:176:28
[INFO] [stderr]     |
[INFO] [stderr] 176 |                       if let None = h.right {
[INFO] [stderr]     |  _____________________-      ^^^^
[INFO] [stderr] 177 | |                         return None;
[INFO] [stderr] 178 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if h.right.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/rbtree.rs:187:33
[INFO] [stderr]     |
[INFO] [stderr] 187 |                         h.val = x.val.clone();
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^ help: try removing the `clone` call: `x.val`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rbtree.rs:218:16
[INFO] [stderr]     |
[INFO] [stderr] 218 |           if let Some(_) = self.find(key) {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 219 | |             return true;
[INFO] [stderr] 220 | |         } 
[INFO] [stderr]     | |_________- help: try this: `if self.find(key).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:249:29
[INFO] [stderr]     |
[INFO] [stderr] 249 |     fn rotate_left(nodeptr: &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:264:30
[INFO] [stderr]     |
[INFO] [stderr] 264 |     fn rotate_right(nodeptr: &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:285:29
[INFO] [stderr]     |
[INFO] [stderr] 285 |     fn flip_colors(nodeptr: &mut Box<Node<K,V>>) {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^ help: try: `&mut Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/rbtree.rs:296:22
[INFO] [stderr]     |
[INFO] [stderr] 296 |     fn balance(rbox: &Box<Node<K,V>>, is_put: bool) -> Box<Node<K,V>> {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^ help: try: `&Node<K,V>`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/rbtree.rs:299:16
[INFO] [stderr]     |
[INFO] [stderr] 299 |             if !is_put || (is_put && !RBTree::is_node_red(&(*r).left)) {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 299 |             if !RBTree::is_node_red(&(*r).left) || !is_put {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 299 |             if !(is_put && RBTree::is_node_red(&(*r).left)) {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.67s
[INFO] running `"docker" "inspect" "dc70897bcb57f45496c6a57042cd78e76287222a775ac656b5f259c77db5e568"`
[INFO] running `"docker" "rm" "-f" "dc70897bcb57f45496c6a57042cd78e76287222a775ac656b5f259c77db5e568"`
[INFO] [stdout] dc70897bcb57f45496c6a57042cd78e76287222a775ac656b5f259c77db5e568