[INFO] updating cached repository tshepang/rust-syntax-conveniences-prep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tshepang/rust-syntax-conveniences-prep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tshepang/rust-syntax-conveniences-prep" "work/ex/clippy-test-run/sources/stable/gh/tshepang/rust-syntax-conveniences-prep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tshepang/rust-syntax-conveniences-prep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tshepang/rust-syntax-conveniences-prep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tshepang/rust-syntax-conveniences-prep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tshepang/rust-syntax-conveniences-prep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 980f3ca6bdea9f2a19c1400ee1d6dc2912686b3b [INFO] sha for GitHub repo tshepang/rust-syntax-conveniences-prep: 980f3ca6bdea9f2a19c1400ee1d6dc2912686b3b [INFO] validating manifest of tshepang/rust-syntax-conveniences-prep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tshepang/rust-syntax-conveniences-prep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tshepang/rust-syntax-conveniences-prep [INFO] finished frobbing tshepang/rust-syntax-conveniences-prep [INFO] frobbed toml for tshepang/rust-syntax-conveniences-prep written to work/ex/clippy-test-run/sources/stable/gh/tshepang/rust-syntax-conveniences-prep/Cargo.toml [INFO] started frobbing tshepang/rust-syntax-conveniences-prep [INFO] finished frobbing tshepang/rust-syntax-conveniences-prep [INFO] frobbed toml for tshepang/rust-syntax-conveniences-prep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tshepang/rust-syntax-conveniences-prep/Cargo.toml [INFO] crate tshepang/rust-syntax-conveniences-prep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tshepang/rust-syntax-conveniences-prep against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tshepang/rust-syntax-conveniences-prep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36d9ea64a71d7156bb620d42cfae826d116509bb1acea2e1da82dd24ae02944a [INFO] running `"docker" "start" "-a" "36d9ea64a71d7156bb620d42cfae826d116509bb1acea2e1da82dd24ae02944a"` [INFO] [stderr] Checking talk v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | const FOO: &'static str = r#"const "&'static" explicit"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: mistyped literal suffix [INFO] [stderr] --> src/main.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | let foo: i64 = 1_64; [INFO] [stderr] | ^^^^ help: did you mean to write: `1_i64` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mistyped_literal_suffixes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mistyped_literal_suffixes [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:303:19 [INFO] [stderr] | [INFO] [stderr] 303 | if true { return 0; } else { return 1; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:303:38 [INFO] [stderr] | [INFO] [stderr] 303 | if true { return 0; } else { return 1; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | const FOO: &'static str = r#"const "&'static" explicit"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: mistyped literal suffix [INFO] [stderr] --> src/main.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | let foo: i64 = 1_64; [INFO] [stderr] | ^^^^ help: did you mean to write: `1_i64` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mistyped_literal_suffixes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mistyped_literal_suffixes [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:303:19 [INFO] [stderr] | [INFO] [stderr] 303 | if true { return 0; } else { return 1; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:303:38 [INFO] [stderr] | [INFO] [stderr] 303 | if true { return 0; } else { return 1; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `talk`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `talk`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "36d9ea64a71d7156bb620d42cfae826d116509bb1acea2e1da82dd24ae02944a"` [INFO] running `"docker" "rm" "-f" "36d9ea64a71d7156bb620d42cfae826d116509bb1acea2e1da82dd24ae02944a"` [INFO] [stdout] 36d9ea64a71d7156bb620d42cfae826d116509bb1acea2e1da82dd24ae02944a