[INFO] updating cached repository trust-dns/axfrnotify [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/trust-dns/axfrnotify [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/trust-dns/axfrnotify" "work/ex/clippy-test-run/sources/stable/gh/trust-dns/axfrnotify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/trust-dns/axfrnotify'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/trust-dns/axfrnotify" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trust-dns/axfrnotify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trust-dns/axfrnotify'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 86e1634b103d25d1034ae32c3733a19f0134f12f [INFO] sha for GitHub repo trust-dns/axfrnotify: 86e1634b103d25d1034ae32c3733a19f0134f12f [INFO] validating manifest of trust-dns/axfrnotify on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trust-dns/axfrnotify on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trust-dns/axfrnotify [INFO] finished frobbing trust-dns/axfrnotify [INFO] frobbed toml for trust-dns/axfrnotify written to work/ex/clippy-test-run/sources/stable/gh/trust-dns/axfrnotify/Cargo.toml [INFO] started frobbing trust-dns/axfrnotify [INFO] finished frobbing trust-dns/axfrnotify [INFO] frobbed toml for trust-dns/axfrnotify written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trust-dns/axfrnotify/Cargo.toml [INFO] crate trust-dns/axfrnotify has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trust-dns/axfrnotify against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/trust-dns/axfrnotify:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a34317ae72a7d12a9ffc1123b241ca8a83bdb9922f770e8b89552d2ce3b2651 [INFO] running `"docker" "start" "-a" "1a34317ae72a7d12a9ffc1123b241ca8a83bdb9922f770e8b89552d2ce3b2651"` [INFO] [stderr] Compiling error-chain v0.7.2 [INFO] [stderr] Compiling pkg-config v0.3.8 [INFO] [stderr] Compiling toml v0.2.1 [INFO] [stderr] Checking lazycell v0.4.0 [INFO] [stderr] Compiling openssl v0.9.6 [INFO] [stderr] Compiling trust-dns v0.9.3 [INFO] [stderr] Checking untrusted v0.3.2 [INFO] [stderr] Checking data-encoding v1.1.2 [INFO] [stderr] Compiling backtrace-sys v0.1.5 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking futures v0.1.6 [INFO] [stderr] Compiling nix v0.7.0 [INFO] [stderr] Checking clap v2.19.2 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking miow v0.1.3 [INFO] [stderr] Compiling metadeps v1.1.1 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Compiling openssl-sys v0.9.6 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking mio v0.6.1 [INFO] [stderr] Checking tokio-core v0.1.1 [INFO] [stderr] Checking axfrnotify v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | Ok(Config { retries: retries, secondary: secondary.to_string(), port: port, record_type: record_type, domain_name: domain_name.to_string(), verbose: verbose }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `retries` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:69 [INFO] [stderr] | [INFO] [stderr] 148 | Ok(Config { retries: retries, secondary: secondary.to_string(), port: port, record_type: record_type, domain_name: domain_name.to_string(), verbose: verbose }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | Ok(Config { retries: retries, secondary: secondary.to_string(), port: port, record_type: record_type, domain_name: domain_name.to_string(), verbose: verbose }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `retries` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:69 [INFO] [stderr] | [INFO] [stderr] --> src/main.rs:148:81 [INFO] [stderr] 148 | Ok(Config { retries: retries, secondary: secondary.to_string(), port: port, record_type: record_type, domain_name: domain_name.to_string(), verbose: verbose }) [INFO] [stderr] | [INFO] [stderr] 148 | Ok(Config { retries: retries, secondary: secondary.to_string(), port: port, record_type: record_type, domain_name: domain_name.to_string(), verbose: verbose }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/main.rs:148:81 [INFO] [stderr] | [INFO] [stderr] 148 | Ok(Config { retries: retries, secondary: secondary.to_string(), port: port, record_type: record_type, domain_name: domain_name.to_string(), verbose: verbose }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:145 [INFO] [stderr] | [INFO] [stderr] 148 | Ok(Config { retries: retries, secondary: secondary.to_string(), port: port, record_type: record_type, domain_name: domain_name.to_string(), verbose: verbose }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:145 [INFO] [stderr] | [INFO] [stderr] 148 | Ok(Config { retries: retries, secondary: secondary.to_string(), port: port, record_type: record_type, domain_name: domain_name.to_string(), verbose: verbose }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:152:46 [INFO] [stderr] | [INFO] [stderr] 152 | fn print_failure_message(result: &ExitCodes) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:152:46 [INFO] [stderr] | [INFO] [stderr] 152 | fn print_failure_message(result: &ExitCodes) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | for _ in 0..config.retries+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `0..=config.retries` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:176:51 [INFO] [stderr] | [INFO] [stderr] 176 | fn notify(addr: A, record_type: &RecordType, domain_name: &str) -> ExitCodes { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `RecordType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:195:66 [INFO] [stderr] | [INFO] [stderr] 195 | fn send_notify(mut io_loop: Core, addr: SocketAddr, record_type: &RecordType, name: domain::Name) -> ClientResult { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `RecordType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | for _ in 0..config.retries+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `0..=config.retries` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:176:51 [INFO] [stderr] | [INFO] [stderr] 176 | fn notify(addr: A, record_type: &RecordType, domain_name: &str) -> ExitCodes { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `RecordType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:195:66 [INFO] [stderr] | [INFO] [stderr] 195 | fn send_notify(mut io_loop: Core, addr: SocketAddr, record_type: &RecordType, name: domain::Name) -> ClientResult { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `RecordType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.44s [INFO] running `"docker" "inspect" "1a34317ae72a7d12a9ffc1123b241ca8a83bdb9922f770e8b89552d2ce3b2651"` [INFO] running `"docker" "rm" "-f" "1a34317ae72a7d12a9ffc1123b241ca8a83bdb9922f770e8b89552d2ce3b2651"` [INFO] [stdout] 1a34317ae72a7d12a9ffc1123b241ca8a83bdb9922f770e8b89552d2ce3b2651