[INFO] updating cached repository tronje/brownhttpd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tronje/brownhttpd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tronje/brownhttpd" "work/ex/clippy-test-run/sources/stable/gh/tronje/brownhttpd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tronje/brownhttpd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tronje/brownhttpd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tronje/brownhttpd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tronje/brownhttpd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ec1d9ab057a0bc334f3a9d702def41b04241192 [INFO] sha for GitHub repo tronje/brownhttpd: 4ec1d9ab057a0bc334f3a9d702def41b04241192 [INFO] validating manifest of tronje/brownhttpd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tronje/brownhttpd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tronje/brownhttpd [INFO] finished frobbing tronje/brownhttpd [INFO] frobbed toml for tronje/brownhttpd written to work/ex/clippy-test-run/sources/stable/gh/tronje/brownhttpd/Cargo.toml [INFO] started frobbing tronje/brownhttpd [INFO] finished frobbing tronje/brownhttpd [INFO] frobbed toml for tronje/brownhttpd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tronje/brownhttpd/Cargo.toml [INFO] crate tronje/brownhttpd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tronje/brownhttpd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tronje/brownhttpd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 537461afa348b312e7bb83066101579b22b95ce9e46cde9a05751666ae720f30 [INFO] running `"docker" "start" "-a" "537461afa348b312e7bb83066101579b22b95ce9e46cde9a05751666ae720f30"` [INFO] [stderr] Checking daemonize v0.2.3 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking url v0.2.38 [INFO] [stderr] Checking tiny_http v0.5.8 [INFO] [stderr] Checking brownhttpd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:277:25 [INFO] [stderr] | [INFO] [stderr] 277 | "Content-Type".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Content-Type"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:278:25 [INFO] [stderr] | [INFO] [stderr] 278 | "text/html".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"text/html"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | "Content-Type".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Content-Type"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | "text/html".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"text/html"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:331:32 [INFO] [stderr] | [INFO] [stderr] 331 | let dotdot = path.parent().unwrap_or(Path::new(&"..")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new(&".."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:332:23 [INFO] [stderr] | [INFO] [stderr] 332 | let mut listing = String::from( [INFO] [stderr] | _______________________^ [INFO] [stderr] 333 | | format!("\n\ [INFO] [stderr] 334 | | \n\ [INFO] [stderr] 335 | | \n\ [INFO] [stderr] ... | [INFO] [stderr] 346 | | dotdot.display() [INFO] [stderr] 347 | | )); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 332 | let mut listing = format!("\n\ [INFO] [stderr] 333 | \n\ [INFO] [stderr] 334 | \n\ [INFO] [stderr] 335 | {}\n\ [INFO] [stderr] 336 | \n\ [INFO] [stderr] 337 | \n\ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:277:25 [INFO] [stderr] | [INFO] [stderr] 277 | "Content-Type".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Content-Type"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:278:25 [INFO] [stderr] | [INFO] [stderr] 278 | "text/html".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"text/html"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | "Content-Type".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Content-Type"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | "text/html".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"text/html"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:331:32 [INFO] [stderr] | [INFO] [stderr] 331 | let dotdot = path.parent().unwrap_or(Path::new(&"..")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new(&".."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:332:23 [INFO] [stderr] | [INFO] [stderr] 332 | let mut listing = String::from( [INFO] [stderr] | _______________________^ [INFO] [stderr] 333 | | format!("\n\ [INFO] [stderr] 334 | | \n\ [INFO] [stderr] 335 | | \n\ [INFO] [stderr] ... | [INFO] [stderr] 346 | | dotdot.display() [INFO] [stderr] 347 | | )); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 332 | let mut listing = format!("\n\ [INFO] [stderr] 333 | \n\ [INFO] [stderr] 334 | \n\ [INFO] [stderr] 335 | {}\n\ [INFO] [stderr] 336 | \n\ [INFO] [stderr] 337 | \n\ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.20s [INFO] running `"docker" "inspect" "537461afa348b312e7bb83066101579b22b95ce9e46cde9a05751666ae720f30"` [INFO] running `"docker" "rm" "-f" "537461afa348b312e7bb83066101579b22b95ce9e46cde9a05751666ae720f30"` [INFO] [stdout] 537461afa348b312e7bb83066101579b22b95ce9e46cde9a05751666ae720f30