[INFO] updating cached repository troeggla/mandelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/troeggla/mandelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/troeggla/mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/troeggla/mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/troeggla/mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/troeggla/mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/troeggla/mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/troeggla/mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 17aa65f5ca9e9d9bd197d1daf61beb88a4ddb70f [INFO] sha for GitHub repo troeggla/mandelbrot: 17aa65f5ca9e9d9bd197d1daf61beb88a4ddb70f [INFO] validating manifest of troeggla/mandelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of troeggla/mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing troeggla/mandelbrot [INFO] finished frobbing troeggla/mandelbrot [INFO] frobbed toml for troeggla/mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/troeggla/mandelbrot/Cargo.toml [INFO] started frobbing troeggla/mandelbrot [INFO] finished frobbing troeggla/mandelbrot [INFO] frobbed toml for troeggla/mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/troeggla/mandelbrot/Cargo.toml [INFO] crate troeggla/mandelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting troeggla/mandelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/troeggla/mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec89323a0338197df50b0e42a45734949853cd9e15790637b65c14175bcd997f [INFO] running `"docker" "start" "-a" "ec89323a0338197df50b0e42a45734949853cd9e15790637b65c14175bcd997f"` [INFO] [stderr] Compiling rayon-core v1.3.0 [INFO] [stderr] Checking either v1.4.0 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking scoped_threadpool v0.1.8 [INFO] [stderr] Checking argparse v0.2.1 [INFO] [stderr] Checking rand v0.3.18 [INFO] [stderr] Checking num_cpus v1.7.0 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking deflate v0.7.17 [INFO] [stderr] Checking inflate v0.3.3 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking pbr v1.0.0 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking mandelbrot v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | x: x, y: y, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | x: x, y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | x: x, y: y, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | x: x, y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | let color_value = (ratio * 0xFFFFFF as f32) as u32; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | let r = ((color_value & 0xFF0000) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | let g = ((color_value & 0x00FF00) >> 8) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | let b = (color_value & 0x0000FF) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 75 | | if color { [INFO] [stderr] 76 | | get_color_pixel(iterations_taken as f32 / iterations as f32) [INFO] [stderr] 77 | | } else { [INFO] [stderr] 78 | | get_greyscale_pixel(iterations_taken as f32 / iterations as f32) [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 74 | } else if color { [INFO] [stderr] 75 | get_color_pixel(iterations_taken as f32 / iterations as f32) [INFO] [stderr] 76 | } else { [INFO] [stderr] 77 | get_greyscale_pixel(iterations_taken as f32 / iterations as f32) [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | format!("Enable verbose output"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Enable verbose output".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | format!("Generate output image in colour"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Generate output image in colour".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:158:41 [INFO] [stderr] | [INFO] [stderr] 158 | let mut progress = ProgressBar::new((width * height) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(width * height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | let ref mut outfile = File::create(&Path::new(&fname)).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------------------- help: try: `let outfile = &mut File::create(&Path::new(&fname)).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | let color_value = (ratio * 0xFFFFFF as f32) as u32; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | let r = ((color_value & 0xFF0000) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | let g = ((color_value & 0x00FF00) >> 8) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | let b = (color_value & 0x0000FF) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 75 | | if color { [INFO] [stderr] 76 | | get_color_pixel(iterations_taken as f32 / iterations as f32) [INFO] [stderr] 77 | | } else { [INFO] [stderr] 78 | | get_greyscale_pixel(iterations_taken as f32 / iterations as f32) [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 74 | } else if color { [INFO] [stderr] 75 | get_color_pixel(iterations_taken as f32 / iterations as f32) [INFO] [stderr] 76 | } else { [INFO] [stderr] 77 | get_greyscale_pixel(iterations_taken as f32 / iterations as f32) [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | format!("Enable verbose output"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Enable verbose output".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | format!("Generate output image in colour"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Generate output image in colour".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:158:41 [INFO] [stderr] | [INFO] [stderr] 158 | let mut progress = ProgressBar::new((width * height) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(width * height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | let ref mut outfile = File::create(&Path::new(&fname)).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------------------- help: try: `let outfile = &mut File::create(&Path::new(&fname)).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.73s [INFO] running `"docker" "inspect" "ec89323a0338197df50b0e42a45734949853cd9e15790637b65c14175bcd997f"` [INFO] running `"docker" "rm" "-f" "ec89323a0338197df50b0e42a45734949853cd9e15790637b65c14175bcd997f"` [INFO] [stdout] ec89323a0338197df50b0e42a45734949853cd9e15790637b65c14175bcd997f