[INFO] updating cached repository trizko/rbc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/trizko/rbc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/trizko/rbc" "work/ex/clippy-test-run/sources/stable/gh/trizko/rbc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/trizko/rbc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/trizko/rbc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trizko/rbc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trizko/rbc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7faaedeadd5a13d46520275ba909ad36004a8a59
[INFO] sha for GitHub repo trizko/rbc: 7faaedeadd5a13d46520275ba909ad36004a8a59
[INFO] validating manifest of trizko/rbc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of trizko/rbc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing trizko/rbc
[INFO] finished frobbing trizko/rbc
[INFO] frobbed toml for trizko/rbc written to work/ex/clippy-test-run/sources/stable/gh/trizko/rbc/Cargo.toml
[INFO] started frobbing trizko/rbc
[INFO] finished frobbing trizko/rbc
[INFO] frobbed toml for trizko/rbc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trizko/rbc/Cargo.toml
[INFO] crate trizko/rbc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting trizko/rbc against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/trizko/rbc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e0257bda434c86176ca41a6713e640599cca70665922c10afe25504f297b5e79
[INFO] running `"docker" "start" "-a" "e0257bda434c86176ca41a6713e640599cca70665922c10afe25504f297b5e79"`
[INFO] [stderr]    Compiling openssl v0.10.10
[INFO] [stderr]     Checking crypto-hash v0.3.1
[INFO] [stderr]     Checking rbc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let result = hasher2.finish();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/main.rs:36:14
[INFO] [stderr]    |
[INFO] [stderr] 36 |     for i in 0..cmd.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: try replacing the loop by: `result[..cmd.len()].clone_from_slice(&cmd[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:55:25
[INFO] [stderr]    |
[INFO] [stderr] 55 | fn payload_len(payload: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                         ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:71:22
[INFO] [stderr]    |
[INFO] [stderr] 71 |     let user_agent = String::from(hex::encode("/rbc:alpha/"));
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `hex::encode("/rbc:alpha/")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let result = hasher2.finish();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/main.rs:36:14
[INFO] [stderr]    |
[INFO] [stderr] 36 |     for i in 0..cmd.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: try replacing the loop by: `result[..cmd.len()].clone_from_slice(&cmd[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:55:25
[INFO] [stderr]    |
[INFO] [stderr] 55 | fn payload_len(payload: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                         ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:71:22
[INFO] [stderr]    |
[INFO] [stderr] 71 |     let user_agent = String::from(hex::encode("/rbc:alpha/"));
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `hex::encode("/rbc:alpha/")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.74s
[INFO] running `"docker" "inspect" "e0257bda434c86176ca41a6713e640599cca70665922c10afe25504f297b5e79"`
[INFO] running `"docker" "rm" "-f" "e0257bda434c86176ca41a6713e640599cca70665922c10afe25504f297b5e79"`
[INFO] [stdout] e0257bda434c86176ca41a6713e640599cca70665922c10afe25504f297b5e79