[INFO] updating cached repository trishume/dayder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/trishume/dayder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/trishume/dayder" "work/ex/clippy-test-run/sources/stable/gh/trishume/dayder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/trishume/dayder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/trishume/dayder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trishume/dayder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trishume/dayder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 316bcfd440a12049ff849d967f927c76161a02a3 [INFO] sha for GitHub repo trishume/dayder: 316bcfd440a12049ff849d967f927c76161a02a3 [INFO] validating manifest of trishume/dayder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trishume/dayder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trishume/dayder [INFO] finished frobbing trishume/dayder [INFO] frobbed toml for trishume/dayder written to work/ex/clippy-test-run/sources/stable/gh/trishume/dayder/Cargo.toml [INFO] started frobbing trishume/dayder [INFO] finished frobbing trishume/dayder [INFO] frobbed toml for trishume/dayder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trishume/dayder/Cargo.toml [INFO] crate trishume/dayder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trishume/dayder against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/trishume/dayder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c146cde300e79303f1383b7e584392ec275986e93e8d368181d9aa09beb168f [INFO] running `"docker" "start" "-a" "5c146cde300e79303f1383b7e584392ec275986e93e8d368181d9aa09beb168f"` [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Checking either v1.1.0 [INFO] [stderr] Checking scopeguard v0.3.2 [INFO] [stderr] Checking futures v0.1.15 [INFO] [stderr] Checking clock_ticks v0.1.1 [INFO] [stderr] Checking unicode-bidi v0.2.6 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking num_cpus v0.2.13 [INFO] [stderr] Checking hpack v0.2.0 [INFO] [stderr] Checking lru_time_cache v0.2.7 [INFO] [stderr] Checking hprof v0.1.3 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking cookie v0.2.5 [INFO] [stderr] Checking solicit v0.4.4 [INFO] [stderr] Checking uuid v0.2.3 [INFO] [stderr] Checking lazysort v0.1.1 [INFO] [stderr] Checking url v0.5.10 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking hyper v0.8.1 [INFO] [stderr] Checking iron v0.3.1 [INFO] [stderr] Checking mount v0.1.0 [INFO] [stderr] Checking persistent v0.1.0 [INFO] [stderr] Checking staticfile v0.2.0 [INFO] [stderr] Checking dayder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/btsf.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | data.push(Point{t: t, val: d}); [INFO] [stderr] | ^^^^ help: replace it with: `t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/btsf.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/btsf.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | data.push(Point{t: t, val: d}); [INFO] [stderr] | ^^^^ help: replace it with: `t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/btsf.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/btsf.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return Ok(num_records as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(num_records as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/stats.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return final_val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `final_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/stats.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return Some((bs, os)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((bs, os))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/stats.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return (base_data, other_data, sampled_other); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(base_data, other_data, sampled_other)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/correlate.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return correlations; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `correlations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return Ok(Response::with((status::Ok, content_type, response_data))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, content_type, response_data)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return Ok(Response::with((status::Ok, content_type, response_data))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, content_type, response_data)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/btsf.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return Ok(num_records as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(num_records as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/stats.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return final_val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `final_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/stats.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return Some((bs, os)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((bs, os))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/stats.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return (base_data, other_data, sampled_other); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(base_data, other_data, sampled_other)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/correlate.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return correlations; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `correlations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return Ok(Response::with((status::Ok, content_type, response_data))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, content_type, response_data)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return Ok(Response::with((status::Ok, content_type, response_data))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, content_type, response_data)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib/btsf.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | try!(f.seek(SeekFrom::Start(file_header_len as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(file_header_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib/btsf.rs:53:39 [INFO] [stderr] | [INFO] [stderr] 53 | try!(f.seek(SeekFrom::Current((rec_header_len - 8) as i64))); // Skip padding bytes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(rec_header_len - 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib/btsf.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | try!(f.take(name_length as u64).read(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib/btsf.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | try!(f.take(name_length as u64).read(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(name_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib/btsf.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | try!(output.write(&record.name.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib/btsf.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | try!(output.write(&record.name.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/stats.rs:5:44 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn pearson_correlation_coefficient(xs: &Vec, ys: &Vec) -> f64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/stats.rs:5:59 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn pearson_correlation_coefficient(xs: &Vec, ys: &Vec) -> f64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | sum_xy += (xs[i] as f64) * (ys[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(xs[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | sum_xy += (xs[i] as f64) * (ys[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(ys[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | sum_xx += (xs[i] as f64) * (xs[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(xs[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | sum_xx += (xs[i] as f64) * (xs[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(xs[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | sum_yy += (ys[i] as f64) * (ys[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(ys[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:16:36 [INFO] [stderr] | [INFO] [stderr] 16 | sum_yy += (ys[i] as f64) * (ys[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(ys[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | sum_x += xs[i] as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(xs[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | sum_y += ys[i] as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ys[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib/stats.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | assert!(other.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!other.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `lib::caching::CorrelationCache` [INFO] [stderr] --> src/lib/caching.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> CorrelationCache { [INFO] [stderr] 11 | | CorrelationCache {lru: lru_time_cache::LruCache::with_capacity(5) } [INFO] [stderr] 12 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for lib::caching::CorrelationCache { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib/btsf.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | try!(f.seek(SeekFrom::Start(file_header_len as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(file_header_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib/btsf.rs:53:39 [INFO] [stderr] | [INFO] [stderr] 53 | try!(f.seek(SeekFrom::Current((rec_header_len - 8) as i64))); // Skip padding bytes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(rec_header_len - 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib/btsf.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | try!(f.take(name_length as u64).read(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib/btsf.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | try!(f.take(name_length as u64).read(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(name_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib/btsf.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | try!(output.write(&record.name.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:95:102 [INFO] [stderr] | [INFO] [stderr] 95 | .map(|(i,c)| lib::btsf::CorrelatedTimeSeries { series: &DATA_SETS[i], correlation: c.clone()}) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib/btsf.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | try!(output.write(&record.name.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/stats.rs:5:44 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn pearson_correlation_coefficient(xs: &Vec, ys: &Vec) -> f64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/stats.rs:5:59 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn pearson_correlation_coefficient(xs: &Vec, ys: &Vec) -> f64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | sum_xy += (xs[i] as f64) * (ys[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(xs[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | sum_xy += (xs[i] as f64) * (ys[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(ys[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | sum_xx += (xs[i] as f64) * (xs[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(xs[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | sum_xx += (xs[i] as f64) * (xs[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(xs[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | sum_yy += (ys[i] as f64) * (ys[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(ys[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:16:36 [INFO] [stderr] | [INFO] [stderr] 16 | sum_yy += (ys[i] as f64) * (ys[i] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(ys[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | sum_x += xs[i] as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(xs[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/stats.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | sum_y += ys[i] as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ys[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/main.rs:158:63 [INFO] [stderr] | [INFO] [stderr] 158 | let total_size : usize = SET_NAMES.iter().map(|x| x.len()).fold(0, |a,b| a+b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib/stats.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | assert!(other.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!other.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `lib::caching::CorrelationCache` [INFO] [stderr] --> src/lib/caching.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> CorrelationCache { [INFO] [stderr] 11 | | CorrelationCache {lru: lru_time_cache::LruCache::with_capacity(5) } [INFO] [stderr] 12 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for lib::caching::CorrelationCache { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:95:102 [INFO] [stderr] | [INFO] [stderr] 95 | .map(|(i,c)| lib::btsf::CorrelatedTimeSeries { series: &DATA_SETS[i], correlation: c.clone()}) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: Could not compile `dayder`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/main.rs:158:63 [INFO] [stderr] | [INFO] [stderr] 158 | let total_size : usize = SET_NAMES.iter().map(|x| x.len()).fold(0, |a,b| a+b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `dayder`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5c146cde300e79303f1383b7e584392ec275986e93e8d368181d9aa09beb168f"` [INFO] running `"docker" "rm" "-f" "5c146cde300e79303f1383b7e584392ec275986e93e8d368181d9aa09beb168f"` [INFO] [stdout] 5c146cde300e79303f1383b7e584392ec275986e93e8d368181d9aa09beb168f