[INFO] updating cached repository triangle-rustaceans/tokio-hops [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/triangle-rustaceans/tokio-hops [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/triangle-rustaceans/tokio-hops" "work/ex/clippy-test-run/sources/stable/gh/triangle-rustaceans/tokio-hops"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/triangle-rustaceans/tokio-hops'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/triangle-rustaceans/tokio-hops" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/triangle-rustaceans/tokio-hops"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/triangle-rustaceans/tokio-hops'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 808f36192fab92f20d970facd4fc0215fb6ac4ee [INFO] sha for GitHub repo triangle-rustaceans/tokio-hops: 808f36192fab92f20d970facd4fc0215fb6ac4ee [INFO] validating manifest of triangle-rustaceans/tokio-hops on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of triangle-rustaceans/tokio-hops on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing triangle-rustaceans/tokio-hops [INFO] finished frobbing triangle-rustaceans/tokio-hops [INFO] frobbed toml for triangle-rustaceans/tokio-hops written to work/ex/clippy-test-run/sources/stable/gh/triangle-rustaceans/tokio-hops/Cargo.toml [INFO] started frobbing triangle-rustaceans/tokio-hops [INFO] finished frobbing triangle-rustaceans/tokio-hops [INFO] frobbed toml for triangle-rustaceans/tokio-hops written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/triangle-rustaceans/tokio-hops/Cargo.toml [INFO] crate triangle-rustaceans/tokio-hops has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting triangle-rustaceans/tokio-hops against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/triangle-rustaceans/tokio-hops:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 57748f3fc7348bc94c13cf6c68f2dfbdf6cf30e31c1285fcc0c5e6906a365487 [INFO] running `"docker" "start" "-a" "57748f3fc7348bc94c13cf6c68f2dfbdf6cf30e31c1285fcc0c5e6906a365487"` [INFO] [stderr] Checking serde v1.0.50 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Compiling syn v0.13.7 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Compiling serde_derive v1.0.50 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking hops v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | server_task [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:113:23 [INFO] [stderr] | [INFO] [stderr] 113 | let server_task = Delay::new(Instant::now() + Duration::from_secs(1)) [INFO] [stderr] | _______________________^ [INFO] [stderr] 114 | | .then(move |_| udp_tx.send((Msg::Ping(Ping { source: port, hops: 0 }), first_neighbor))) [INFO] [stderr] 115 | | .and_then(move |udp_tx| bouncer(udp_tx)) [INFO] [stderr] 116 | | .map_err(|err| println!("Err: {:?}", err)); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | server_task [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:113:23 [INFO] [stderr] | [INFO] [stderr] 113 | let server_task = Delay::new(Instant::now() + Duration::from_secs(1)) [INFO] [stderr] | _______________________^ [INFO] [stderr] 114 | | .then(move |_| udp_tx.send((Msg::Ping(Ping { source: port, hops: 0 }), first_neighbor))) [INFO] [stderr] 115 | | .and_then(move |udp_tx| bouncer(udp_tx)) [INFO] [stderr] 116 | | .map_err(|err| println!("Err: {:?}", err)); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:77:53 [INFO] [stderr] | [INFO] [stderr] 77 | let neighbors: Vec = neighbor_ports.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:115:19 [INFO] [stderr] | [INFO] [stderr] 115 | .and_then(move |udp_tx| bouncer(udp_tx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `bouncer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:77:53 [INFO] [stderr] | [INFO] [stderr] 77 | let neighbors: Vec = neighbor_ports.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:115:19 [INFO] [stderr] | [INFO] [stderr] 115 | .and_then(move |udp_tx| bouncer(udp_tx)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `bouncer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.56s [INFO] running `"docker" "inspect" "57748f3fc7348bc94c13cf6c68f2dfbdf6cf30e31c1285fcc0c5e6906a365487"` [INFO] running `"docker" "rm" "-f" "57748f3fc7348bc94c13cf6c68f2dfbdf6cf30e31c1285fcc0c5e6906a365487"` [INFO] [stdout] 57748f3fc7348bc94c13cf6c68f2dfbdf6cf30e31c1285fcc0c5e6906a365487