[INFO] updating cached repository trevorwhitney/twentyfour-days-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/trevorwhitney/twentyfour-days-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/trevorwhitney/twentyfour-days-rust" "work/ex/clippy-test-run/sources/stable/gh/trevorwhitney/twentyfour-days-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/trevorwhitney/twentyfour-days-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/trevorwhitney/twentyfour-days-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trevorwhitney/twentyfour-days-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trevorwhitney/twentyfour-days-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 44b22a9e3b13c171e74248270e2890190c4e50ee [INFO] sha for GitHub repo trevorwhitney/twentyfour-days-rust: 44b22a9e3b13c171e74248270e2890190c4e50ee [INFO] validating manifest of trevorwhitney/twentyfour-days-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trevorwhitney/twentyfour-days-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trevorwhitney/twentyfour-days-rust [INFO] finished frobbing trevorwhitney/twentyfour-days-rust [INFO] frobbed toml for trevorwhitney/twentyfour-days-rust written to work/ex/clippy-test-run/sources/stable/gh/trevorwhitney/twentyfour-days-rust/Cargo.toml [INFO] started frobbing trevorwhitney/twentyfour-days-rust [INFO] finished frobbing trevorwhitney/twentyfour-days-rust [INFO] frobbed toml for trevorwhitney/twentyfour-days-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trevorwhitney/twentyfour-days-rust/Cargo.toml [INFO] crate trevorwhitney/twentyfour-days-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trevorwhitney/twentyfour-days-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/trevorwhitney/twentyfour-days-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a89e94c03e7671b2a64444f7fef850e343e4f77e8101bacdeb97f7f5887c70c [INFO] running `"docker" "start" "-a" "7a89e94c03e7671b2a64444f7fef850e343e4f77e8101bacdeb97f7f5887c70c"` [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Checking primal-sieve v0.2.8 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking primal-check v0.2.3 [INFO] [stderr] Checking primal v0.2.3 [INFO] [stderr] Checking twentyfour-days-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:9:10 [INFO] [stderr] | [INFO] [stderr] 9 | .ok_or("Incorrect usage: please specify a day to define which algorithm to run".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Incorrect usage: please specify a day to define which algorithm to run".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | .ok_or("Please provide a number to test if prime".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Please provide a number to test if prime".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .map(|n| day2::find_prime(n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `day2::find_prime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:42:10 [INFO] [stderr] | [INFO] [stderr] 42 | .ok_or("Please provide the number prime you'd like to find".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Please provide the number prime you'd like to find".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:9:10 [INFO] [stderr] | [INFO] [stderr] 9 | .ok_or("Incorrect usage: please specify a day to define which algorithm to run".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Incorrect usage: please specify a day to define which algorithm to run".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | .ok_or("Please provide a number to test if prime".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Please provide a number to test if prime".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .map(|n| day2::find_prime(n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `day2::find_prime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:42:10 [INFO] [stderr] | [INFO] [stderr] 42 | .ok_or("Please provide the number prime you'd like to find".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Please provide the number prime you'd like to find".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.88s [INFO] running `"docker" "inspect" "7a89e94c03e7671b2a64444f7fef850e343e4f77e8101bacdeb97f7f5887c70c"` [INFO] running `"docker" "rm" "-f" "7a89e94c03e7671b2a64444f7fef850e343e4f77e8101bacdeb97f7f5887c70c"` [INFO] [stdout] 7a89e94c03e7671b2a64444f7fef850e343e4f77e8101bacdeb97f7f5887c70c