[INFO] updating cached repository trcm/gameofrust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/trcm/gameofrust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/trcm/gameofrust" "work/ex/clippy-test-run/sources/stable/gh/trcm/gameofrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/trcm/gameofrust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/trcm/gameofrust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trcm/gameofrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trcm/gameofrust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b23969d6731ab2b108db5464d0d8042283617608 [INFO] sha for GitHub repo trcm/gameofrust: b23969d6731ab2b108db5464d0d8042283617608 [INFO] validating manifest of trcm/gameofrust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trcm/gameofrust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trcm/gameofrust [INFO] finished frobbing trcm/gameofrust [INFO] frobbed toml for trcm/gameofrust written to work/ex/clippy-test-run/sources/stable/gh/trcm/gameofrust/Cargo.toml [INFO] started frobbing trcm/gameofrust [INFO] finished frobbing trcm/gameofrust [INFO] frobbed toml for trcm/gameofrust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trcm/gameofrust/Cargo.toml [INFO] crate trcm/gameofrust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trcm/gameofrust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/trcm/gameofrust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2d2b9711081127857a310d43ded766b30fb91ccf399d10ebfca27bcb6c5a2af [INFO] running `"docker" "start" "-a" "b2d2b9711081127857a310d43ded766b30fb91ccf399d10ebfca27bcb6c5a2af"` [INFO] [stderr] Checking dylib v0.0.1 [INFO] [stderr] Compiling minifb v0.9.1 [INFO] [stderr] Checking x11-dl v2.2.1 [INFO] [stderr] Checking gameoflife v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused import: `Rng` [INFO] [stderr] --> src/main.rs:5:12 [INFO] [stderr] | [INFO] [stderr] 5 | use rand::{Rng}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | *item = 0xffffff; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | *item = 0x000000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `valid` [INFO] [stderr] --> src/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let valid: Vec<(u32, u32)> = vec!(); [INFO] [stderr] | ^^^^^ help: consider using `_valid` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `item` [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | for (i, item) in current.iter().enumerate() { [INFO] [stderr] | ^^^^ help: consider using `_item` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | ticks = ticks + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `ticks += 1` [INFO] [stderr] warning: unused import: `Rng` [INFO] [stderr] --> src/main.rs:5:12 [INFO] [stderr] | [INFO] [stderr] 5 | use rand::{Rng}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | *item = 0xffffff; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | *item = 0x000000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `valid` [INFO] [stderr] --> src/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let valid: Vec<(u32, u32)> = vec!(); [INFO] [stderr] | ^^^^^ help: consider using `_valid` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `item` [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | for (i, item) in current.iter().enumerate() { [INFO] [stderr] | ^^^^ help: consider using `_item` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | ticks = ticks + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `ticks += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.00s [INFO] running `"docker" "inspect" "b2d2b9711081127857a310d43ded766b30fb91ccf399d10ebfca27bcb6c5a2af"` [INFO] running `"docker" "rm" "-f" "b2d2b9711081127857a310d43ded766b30fb91ccf399d10ebfca27bcb6c5a2af"` [INFO] [stdout] b2d2b9711081127857a310d43ded766b30fb91ccf399d10ebfca27bcb6c5a2af