[INFO] updating cached repository travismiller/not80 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/travismiller/not80 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/travismiller/not80" "work/ex/clippy-test-run/sources/stable/gh/travismiller/not80"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/travismiller/not80'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/travismiller/not80" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travismiller/not80"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travismiller/not80'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 92b97fd8e0fc1a1cd3a3328dee9afd838d93da6c [INFO] sha for GitHub repo travismiller/not80: 92b97fd8e0fc1a1cd3a3328dee9afd838d93da6c [INFO] validating manifest of travismiller/not80 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of travismiller/not80 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing travismiller/not80 [INFO] finished frobbing travismiller/not80 [INFO] frobbed toml for travismiller/not80 written to work/ex/clippy-test-run/sources/stable/gh/travismiller/not80/Cargo.toml [INFO] started frobbing travismiller/not80 [INFO] finished frobbing travismiller/not80 [INFO] frobbed toml for travismiller/not80 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travismiller/not80/Cargo.toml [INFO] crate travismiller/not80 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting travismiller/not80 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/travismiller/not80:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91669dbb4133fc3ace4cec9c8cdf34ba6ba61dc98c5cdaf562c865ea6a15c303 [INFO] running `"docker" "start" "-a" "91669dbb4133fc3ace4cec9c8cdf34ba6ba61dc98c5cdaf562c865ea6a15c303"` [INFO] [stderr] Compiling either v1.4.0 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Compiling libc v0.2.34 [INFO] [stderr] Checking log v0.4.0 [INFO] [stderr] Checking num_cpus v1.7.0 [INFO] [stderr] Checking rand v0.3.19 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking base64 v0.9.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Checking regex v0.2.3 [INFO] [stderr] Checking futures-cpupool v0.1.7 [INFO] [stderr] Compiling coco v0.1.1 [INFO] [stderr] Checking mime v0.3.5 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking backtrace v0.3.4 [INFO] [stderr] Checking mio v0.6.11 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking tokio-core v0.1.11 [INFO] [stderr] Compiling rayon-core v1.3.0 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Compiling derive-error-chain v0.10.1 [INFO] [stderr] Checking hyper v0.11.10 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] Checking webpki v0.17.0 [INFO] [stderr] Checking sct v0.2.0 [INFO] [stderr] Checking rustls v0.11.0 [INFO] [stderr] Checking not80 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:38:47 [INFO] [stderr] | [INFO] [stderr] 38 | fn content_from_location(&self, location: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | fn http_server(listen: &String) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | Err(_) => panic!("Environment variable LISTEN must be defined."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:38:47 [INFO] [stderr] | [INFO] [stderr] 38 | fn content_from_location(&self, location: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | fn http_server(listen: &String) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | Err(_) => panic!("Environment variable LISTEN must be defined."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.45s [INFO] running `"docker" "inspect" "91669dbb4133fc3ace4cec9c8cdf34ba6ba61dc98c5cdaf562c865ea6a15c303"` [INFO] running `"docker" "rm" "-f" "91669dbb4133fc3ace4cec9c8cdf34ba6ba61dc98c5cdaf562c865ea6a15c303"` [INFO] [stdout] 91669dbb4133fc3ace4cec9c8cdf34ba6ba61dc98c5cdaf562c865ea6a15c303