[INFO] updating cached repository travis-ci/redactor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/travis-ci/redactor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/travis-ci/redactor" "work/ex/clippy-test-run/sources/stable/gh/travis-ci/redactor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/travis-ci/redactor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/travis-ci/redactor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travis-ci/redactor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travis-ci/redactor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 197eee68062f53654c9fe61694615a1b90920a0e [INFO] sha for GitHub repo travis-ci/redactor: 197eee68062f53654c9fe61694615a1b90920a0e [INFO] validating manifest of travis-ci/redactor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of travis-ci/redactor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing travis-ci/redactor [INFO] finished frobbing travis-ci/redactor [INFO] frobbed toml for travis-ci/redactor written to work/ex/clippy-test-run/sources/stable/gh/travis-ci/redactor/Cargo.toml [INFO] started frobbing travis-ci/redactor [INFO] finished frobbing travis-ci/redactor [INFO] frobbed toml for travis-ci/redactor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travis-ci/redactor/Cargo.toml [INFO] crate travis-ci/redactor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting travis-ci/redactor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/travis-ci/redactor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f7288a797a7339293f971aedbebd260c68ff9c0c8e48349080cd519795e2e426 [INFO] running `"docker" "start" "-a" "f7288a797a7339293f971aedbebd260c68ff9c0c8e48349080cd519795e2e426"` [INFO] [stderr] Checking errno v0.1.8 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking pty v0.2.1 [INFO] [stderr] Checking exec v0.2.0 [INFO] [stderr] Checking redactor v0.1.0-pre6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redactor.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/redactor.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | input: input, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redactor.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redactor.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redactor.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redactor.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | secrets: secrets [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `secrets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wrapper.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | cmd: cmd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wrapper.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | tmpdir: tmpdir [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tmpdir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redactor.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redactor.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redactor.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redactor.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | secrets: secrets [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `secrets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wrapper.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | cmd: cmd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wrapper.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | tmpdir: tmpdir [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tmpdir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/redactor.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | const REDACTION_MSG: &'static [u8; 8] = b"[secure]"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/redactor.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | const REDACTION_MSG: &'static [u8; 8] = b"[secure]"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/redactor.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn noop<'a, R, W>(mut input: &'a mut R, mut output: &'a mut W) where R: 'a + Read, W: 'a + Write { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/redactor.rs:142:45 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn noop<'a, R, W>(mut input: &'a mut R, mut output: &'a mut W) where R: 'a + Read, W: 'a + Write { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/redactor.rs:23:81 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn new(input: &'a mut R, output: &'a mut W, buf: &'a mut [u8], secrets: &'a Vec) -> Redactor<'a, R, W> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Secret]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/redactor.rs:138:73 [INFO] [stderr] | [INFO] [stderr] 138 | let mut redactor = Redactor::new(&mut input, &mut output, &mut buf, &mut secrets); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/secret.rs:12:35 [INFO] [stderr] | [INFO] [stderr] 12 | let mut parts = raw.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/secret.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn decode<'a>(raw: &'a str) -> Option { [INFO] [stderr] 42 | | let es = EncodedSecret::new(raw); [INFO] [stderr] 43 | | es.and_then(|e| Some(e.decode())) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / if let Some(mut pty) = fork.is_parent().ok() { [INFO] [stderr] 26 | | if !secrets.is_empty() { [INFO] [stderr] 27 | | // Found secrets, starting to scan input [INFO] [stderr] 28 | | scan(&mut pty, &mut io::stdout(), &mut secrets); [INFO] [stderr] ... | [INFO] [stderr] 39 | | panic!("Command failed: {:?}", wrapper.exec()); [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut pty)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | value.split(",").flat_map(|s| decode(s)).collect::>() [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/redactor.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn noop<'a, R, W>(mut input: &'a mut R, mut output: &'a mut W) where R: 'a + Read, W: 'a + Write { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/redactor.rs:142:45 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn noop<'a, R, W>(mut input: &'a mut R, mut output: &'a mut W) where R: 'a + Read, W: 'a + Write { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/redactor.rs:23:81 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn new(input: &'a mut R, output: &'a mut W, buf: &'a mut [u8], secrets: &'a Vec) -> Redactor<'a, R, W> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Secret]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/redactor.rs:138:73 [INFO] [stderr] | [INFO] [stderr] 138 | let mut redactor = Redactor::new(&mut input, &mut output, &mut buf, &mut secrets); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/secret.rs:12:35 [INFO] [stderr] | [INFO] [stderr] 12 | let mut parts = raw.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/secret.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn decode<'a>(raw: &'a str) -> Option { [INFO] [stderr] 42 | | let es = EncodedSecret::new(raw); [INFO] [stderr] 43 | | es.and_then(|e| Some(e.decode())) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / if let Some(mut pty) = fork.is_parent().ok() { [INFO] [stderr] 26 | | if !secrets.is_empty() { [INFO] [stderr] 27 | | // Found secrets, starting to scan input [INFO] [stderr] 28 | | scan(&mut pty, &mut io::stdout(), &mut secrets); [INFO] [stderr] ... | [INFO] [stderr] 39 | | panic!("Command failed: {:?}", wrapper.exec()); [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut pty)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | value.split(",").flat_map(|s| decode(s)).collect::>() [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.85s [INFO] running `"docker" "inspect" "f7288a797a7339293f971aedbebd260c68ff9c0c8e48349080cd519795e2e426"` [INFO] running `"docker" "rm" "-f" "f7288a797a7339293f971aedbebd260c68ff9c0c8e48349080cd519795e2e426"` [INFO] [stdout] f7288a797a7339293f971aedbebd260c68ff9c0c8e48349080cd519795e2e426