[INFO] updating cached repository travip/RusTicTacToe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/travip/RusTicTacToe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/travip/RusTicTacToe" "work/ex/clippy-test-run/sources/stable/gh/travip/RusTicTacToe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/travip/RusTicTacToe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/travip/RusTicTacToe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travip/RusTicTacToe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travip/RusTicTacToe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8303106d14d76a5b562d1e53882328f855f0c875 [INFO] sha for GitHub repo travip/RusTicTacToe: 8303106d14d76a5b562d1e53882328f855f0c875 [INFO] validating manifest of travip/RusTicTacToe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of travip/RusTicTacToe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing travip/RusTicTacToe [INFO] finished frobbing travip/RusTicTacToe [INFO] frobbed toml for travip/RusTicTacToe written to work/ex/clippy-test-run/sources/stable/gh/travip/RusTicTacToe/Cargo.toml [INFO] started frobbing travip/RusTicTacToe [INFO] finished frobbing travip/RusTicTacToe [INFO] frobbed toml for travip/RusTicTacToe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travip/RusTicTacToe/Cargo.toml [INFO] crate travip/RusTicTacToe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting travip/RusTicTacToe against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/travip/RusTicTacToe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ddd8f1b7214216903ba6650f102d81444c91783f28a74dc9eac049906e557240 [INFO] running `"docker" "start" "-a" "ddd8f1b7214216903ba6650f102d81444c91783f28a74dc9eac049906e557240"` [INFO] [stderr] Compiling libc v0.2.23 [INFO] [stderr] Compiling rayon-core v1.0.2 [INFO] [stderr] Checking deque v0.3.2 [INFO] [stderr] Compiling either v1.1.0 [INFO] [stderr] Compiling khronos_api v1.0.1 [INFO] [stderr] Checking odds v0.2.25 [INFO] [stderr] Checking inflate v0.2.0 [INFO] [stderr] Checking shader_version v0.2.2 [INFO] [stderr] Compiling sdl2-sys v0.30.0 [INFO] [stderr] Checking linked-hash-map v0.0.10 [INFO] [stderr] Checking read_color v0.1.0 [INFO] [stderr] Checking piston-texture v0.5.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking num_cpus v1.5.1 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Checking deflate v0.7.11 [INFO] [stderr] Checking vecmath v0.3.0 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Compiling wayland-scanner v0.8.7 [INFO] [stderr] Compiling gl_generator v0.5.3 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking pistoncore-input v0.18.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking nodrop v0.1.9 [INFO] [stderr] Checking piston2d-graphics v0.21.1 [INFO] [stderr] Checking quaternion v0.3.0 [INFO] [stderr] Compiling wayland-client v0.8.7 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Compiling gl v0.6.2 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.8.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking arrayvec v0.3.23 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking piston3d-cam v0.3.0 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking sdl2 v0.30.0 [INFO] [stderr] Checking pistoncore-window v0.27.0 [INFO] [stderr] Checking piston-ai_behavior v0.20.0 [INFO] [stderr] Checking piston2d-drag_controller v0.19.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking camera_controllers v0.21.0 [INFO] [stderr] Checking pistoncore-event_loop v0.32.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking piston2d-sprite v0.36.0 [INFO] [stderr] Checking gfx_core v0.7.1 [INFO] [stderr] Checking jpeg-decoder v0.1.12 [INFO] [stderr] Checking piston v0.32.0 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking pistoncore-sdl2_window v0.43.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.37.0 [INFO] [stderr] Checking gfx v0.16.0 [INFO] [stderr] Checking gfx_device_gl v0.14.1 [INFO] [stderr] Checking piston-gfx_texture v0.24.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.40.0 [INFO] [stderr] Checking piston_window v0.66.0 [INFO] [stderr] Checking prac v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | fn reset(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | if(total_moves >= 9){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | if (sq < 10){ [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: trait method `getSquare` should have a snake case name such as `get_square` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | fn getSquare(&self, x : f64, y : f64) -> usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | fn CheckForWin(grid : &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[GridSquare]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function `CheckForWin` should have a snake case name such as `check_for_win` [INFO] [stderr] --> src/main.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / fn CheckForWin(grid : &Vec) -> Option { [INFO] [stderr] 57 | | [INFO] [stderr] 58 | | // Construct the magic square [INFO] [stderr] 59 | | let mut win_grid = vec![8, 1, 6, 3, 5, 7, 4, 9, 2]; [INFO] [stderr] ... | [INFO] [stderr] 121 | | Some(Token::Empty) [INFO] [stderr] 122 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | let ref font = assets.join("FiraSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:47 [INFO] [stderr] | [INFO] [stderr] 177 | coords : [(i % 3 * 200 + 5) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(i % 3 * 200 + 5)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:178:47 [INFO] [stderr] | [INFO] [stderr] 178 | (i / 3 * 200 + 5) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(i / 3 * 200 + 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:179:47 [INFO] [stderr] | [INFO] [stderr] 179 | (((i % 3) + 1) * 200 - 5) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(((i % 3) + 1) * 200 - 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:47 [INFO] [stderr] | [INFO] [stderr] 180 | (((i / 3) + 1) * 200 - 5) as f64] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(((i / 3) + 1) * 200 - 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | fn reset(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | if(total_moves >= 9){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | if (sq < 10){ [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: trait method `getSquare` should have a snake case name such as `get_square` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | fn getSquare(&self, x : f64, y : f64) -> usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | fn CheckForWin(grid : &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[GridSquare]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function `CheckForWin` should have a snake case name such as `check_for_win` [INFO] [stderr] --> src/main.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / fn CheckForWin(grid : &Vec) -> Option { [INFO] [stderr] 57 | | [INFO] [stderr] 58 | | // Construct the magic square [INFO] [stderr] 59 | | let mut win_grid = vec![8, 1, 6, 3, 5, 7, 4, 9, 2]; [INFO] [stderr] ... | [INFO] [stderr] 121 | | Some(Token::Empty) [INFO] [stderr] 122 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | let ref font = assets.join("FiraSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:47 [INFO] [stderr] | [INFO] [stderr] 177 | coords : [(i % 3 * 200 + 5) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(i % 3 * 200 + 5)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:178:47 [INFO] [stderr] | [INFO] [stderr] 178 | (i / 3 * 200 + 5) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(i / 3 * 200 + 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:179:47 [INFO] [stderr] | [INFO] [stderr] 179 | (((i % 3) + 1) * 200 - 5) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(((i % 3) + 1) * 200 - 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:47 [INFO] [stderr] | [INFO] [stderr] 180 | (((i / 3) + 1) * 200 - 5) as f64] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(((i / 3) + 1) * 200 - 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 09s [INFO] running `"docker" "inspect" "ddd8f1b7214216903ba6650f102d81444c91783f28a74dc9eac049906e557240"` [INFO] running `"docker" "rm" "-f" "ddd8f1b7214216903ba6650f102d81444c91783f28a74dc9eac049906e557240"` [INFO] [stdout] ddd8f1b7214216903ba6650f102d81444c91783f28a74dc9eac049906e557240