[INFO] updating cached repository trafficland/counter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/trafficland/counter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/trafficland/counter" "work/ex/clippy-test-run/sources/stable/gh/trafficland/counter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/trafficland/counter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/trafficland/counter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trafficland/counter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trafficland/counter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3f30d2583eba4922a72b3ec885c831a2cf558067 [INFO] sha for GitHub repo trafficland/counter: 3f30d2583eba4922a72b3ec885c831a2cf558067 [INFO] validating manifest of trafficland/counter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trafficland/counter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trafficland/counter [INFO] finished frobbing trafficland/counter [INFO] frobbed toml for trafficland/counter written to work/ex/clippy-test-run/sources/stable/gh/trafficland/counter/Cargo.toml [INFO] started frobbing trafficland/counter [INFO] finished frobbing trafficland/counter [INFO] frobbed toml for trafficland/counter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/trafficland/counter/Cargo.toml [INFO] crate trafficland/counter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trafficland/counter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/trafficland/counter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30d4ff1438c3930450741bdff2b035f856fc9fc629dae69bc2574074a718671c [INFO] running `"docker" "start" "-a" "30d4ff1438c3930450741bdff2b035f856fc9fc629dae69bc2574074a718671c"` [INFO] [stderr] Compiling libc v0.2.22 [INFO] [stderr] Checking scopeguard v0.1.2 [INFO] [stderr] Compiling names v0.11.0 [INFO] [stderr] Checking variance v0.1.3 [INFO] [stderr] Checking crossbeam v0.2.10 [INFO] [stderr] Compiling num-integer v0.1.34 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking clap v2.23.3 [INFO] [stderr] Compiling time v0.1.37 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking scoped-pool v1.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking elp v2.0.0 [INFO] [stderr] Compiling counter v1.0.0 (/opt/crater/workdir) [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_handling.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_handling.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_handling.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_handling.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record_handling.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | client_address: client_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aggregation_control.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | file_handling_msg_senders: file_handling_msg_senders, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_handling_msg_senders` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_handling.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_handling.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_handling.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_handling.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record_handling.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | client_address: client_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aggregation_control.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | file_handling_msg_senders: file_handling_msg_senders, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_handling_msg_senders` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/file_handling.rs:72:16 [INFO] [stderr] | [INFO] [stderr] 72 | -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/file_handling.rs:108:52 [INFO] [stderr] | [INFO] [stderr] 108 | fn aggregate_file(&mut self, file_path: &Path) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/record_handling.rs:26:84 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn try_parse_record(possible_record: &str, dst_agg: &mut ELBRecordAggregation) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/record_handling.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/record_handling.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/file_handling.rs:72:16 [INFO] [stderr] | [INFO] [stderr] 72 | -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/file_handling.rs:108:52 [INFO] [stderr] | [INFO] [stderr] 108 | fn aggregate_file(&mut self, file_path: &Path) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/file_handling.rs:316:49 [INFO] [stderr] | [INFO] [stderr] 316 | pub fn run_int_test_in_test_dir(test: T) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file_handling.rs:331:26 [INFO] [stderr] | [INFO] [stderr] 331 | pub const TEST_DIR: &'static str = "./int_tests"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/record_handling.rs:26:84 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn try_parse_record(possible_record: &str, dst_agg: &mut ELBRecordAggregation) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/record_handling.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/record_handling.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/record_handling.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | const GOOD_RECORD0: &'static str = "2015-08-15T23:43:05.302180Z elb-name 172.16.1.6:54814 \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/record_handling.rs:76:26 [INFO] [stderr] | [INFO] [stderr] 76 | const GOOD_RECORD1: &'static str = "2016-08-15T23:43:05.302180Z elb-name 172.16.1.6:54814 \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_common.rs:3:27 [INFO] [stderr] | [INFO] [stderr] 3 | pub const TEST_LOG_FILE: &'static str = "./test_artifacts/test_elb_log_file.log"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/aggregation_control.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn run_aggregation(&mut self, mut filenames: &mut Vec) -> FileAggregation { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:143:26 [INFO] [stderr] | [INFO] [stderr] 143 | RuntimeContext { arg_matches: arg_matches } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arg_matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:152:26 [INFO] [stderr] | [INFO] [stderr] 152 | RuntimeContext { arg_matches: arg_matches } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arg_matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:143:26 [INFO] [stderr] | [INFO] [stderr] 143 | RuntimeContext { arg_matches: arg_matches } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arg_matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:152:26 [INFO] [stderr] | [INFO] [stderr] 152 | RuntimeContext { arg_matches: arg_matches } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arg_matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/file_handling.rs:355:23 [INFO] [stderr] | [INFO] [stderr] 355 | .map(|mut g| g.next().unwrap()) [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/aggregation_control.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn run_aggregation(&mut self, mut filenames: &mut Vec) -> FileAggregation { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/file_handling.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | / .collect::>() [INFO] [stderr] 244 | | .len(); [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/file_handling.rs:297:29 [INFO] [stderr] | [INFO] [stderr] 297 | .write(&"test content".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test content"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/record_handling.rs:148:37 [INFO] [stderr] | [INFO] [stderr] 148 | let value_of_interest = src_agg.get(key_of_interest).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&src_agg[key_of_interest]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/record_handling.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | let key = test_keys.get(idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `test_keys[idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/record_handling.rs:158:32 [INFO] [stderr] | [INFO] [stderr] 158 | let dst_rec_val = *dst_agg.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dst_agg[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/record_handling.rs:159:32 [INFO] [stderr] | [INFO] [stderr] 159 | let src_rec_val = *src_agg.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&src_agg[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/aggregation_control.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | for _ in 0..num_files + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=num_files` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:123:28 [INFO] [stderr] | [INFO] [stderr] 123 | fn shutdown(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:132:26 [INFO] [stderr] | [INFO] [stderr] 132 | const LOG_LOCATION_ARG: &'static str = "log-location"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | const BENCHMARK_ARG: &'static str = "benchmark"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:193:46 [INFO] [stderr] | [INFO] [stderr] 193 | assert_eq!(file_agg.num_raw_records, 838140); [INFO] [stderr] | ^^^^^^ help: consider: `838_140` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:123:28 [INFO] [stderr] | [INFO] [stderr] 123 | fn shutdown(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:132:26 [INFO] [stderr] | [INFO] [stderr] 132 | const LOG_LOCATION_ARG: &'static str = "log-location"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | const BENCHMARK_ARG: &'static str = "benchmark"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:96:52 [INFO] [stderr] | [INFO] [stderr] 96 | fn run(&mut self, num_file_aggregators: usize, mut filenames: &mut Vec) -> counter::FileAggregation { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:96:52 [INFO] [stderr] | [INFO] [stderr] 96 | fn run(&mut self, num_file_aggregators: usize, mut filenames: &mut Vec) -> counter::FileAggregation { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.95s [INFO] running `"docker" "inspect" "30d4ff1438c3930450741bdff2b035f856fc9fc629dae69bc2574074a718671c"` [INFO] running `"docker" "rm" "-f" "30d4ff1438c3930450741bdff2b035f856fc9fc629dae69bc2574074a718671c"` [INFO] [stdout] 30d4ff1438c3930450741bdff2b035f856fc9fc629dae69bc2574074a718671c