[INFO] updating cached repository tperdue321/rust_ownership [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tperdue321/rust_ownership [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tperdue321/rust_ownership" "work/ex/clippy-test-run/sources/stable/gh/tperdue321/rust_ownership"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tperdue321/rust_ownership'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tperdue321/rust_ownership" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tperdue321/rust_ownership"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tperdue321/rust_ownership'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 66673718162c26f2488175f590ac5890d467a7e6 [INFO] sha for GitHub repo tperdue321/rust_ownership: 66673718162c26f2488175f590ac5890d467a7e6 [INFO] validating manifest of tperdue321/rust_ownership on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tperdue321/rust_ownership on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tperdue321/rust_ownership [INFO] finished frobbing tperdue321/rust_ownership [INFO] frobbed toml for tperdue321/rust_ownership written to work/ex/clippy-test-run/sources/stable/gh/tperdue321/rust_ownership/Cargo.toml [INFO] started frobbing tperdue321/rust_ownership [INFO] finished frobbing tperdue321/rust_ownership [INFO] frobbed toml for tperdue321/rust_ownership written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tperdue321/rust_ownership/Cargo.toml [INFO] crate tperdue321/rust_ownership has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tperdue321/rust_ownership against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tperdue321/rust_ownership:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46962254cbd58dd7cb0cf69b7faa11db5443e721714593eed6c8a62af46578d7 [INFO] running `"docker" "start" "-a" "46962254cbd58dd7cb0cf69b7faa11db5443e721714593eed6c8a62af46578d7"` [INFO] [stderr] Checking ownership v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | some_string // some_string is returned and [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | let some_string = String::from("hello"); // some_string comes into scope. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | some_string // some_string is returned and [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | let some_string = String::from("hello"); // some_string comes into scope. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `string` [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let string = "hello"; // string is valid from here forward [INFO] [stderr] | ^^^^^^ help: consider using `_string` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s2` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | let s2 = s1; [INFO] [stderr] | ^^ help: consider using `_s2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s1` [INFO] [stderr] --> src/main.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let s1 = gives_ownership(); // gives_ownership moves its return [INFO] [stderr] | ^^ help: consider using `_s1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r1` [INFO] [stderr] --> src/main.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | let r1 = &mut s2; [INFO] [stderr] | ^^ help: consider using `_r1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r3` [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | let r3 = &mut s3; [INFO] [stderr] | ^^ help: consider using `_r3` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r4` [INFO] [stderr] --> src/main.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | let r4 = &mut s3; [INFO] [stderr] | ^^ help: consider using `_r4` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r1` [INFO] [stderr] --> src/main.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | let r1 = &s; // immutable ref [INFO] [stderr] | ^^ help: consider using `_r1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r2` [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | let r2 = &s; // second because as many refs can read the same data safely [INFO] [stderr] | ^^ help: consider using `_r2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | let slice = &s[0..2]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | let slice = &s[..2]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | let slice = &s[2..len]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | let slice = &s[2..]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | let slice = &s[0..len]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | let slice = &s[..]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | let slice = &a[0..2]; [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `string` [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let string = "hello"; // string is valid from here forward [INFO] [stderr] | ^^^^^^ help: consider using `_string` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s2` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | let s2 = s1; [INFO] [stderr] | ^^ help: consider using `_s2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s1` [INFO] [stderr] --> src/main.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let s1 = gives_ownership(); // gives_ownership moves its return [INFO] [stderr] | ^^ help: consider using `_s1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r1` [INFO] [stderr] --> src/main.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | let r1 = &mut s2; [INFO] [stderr] | ^^ help: consider using `_r1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r3` [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | let r3 = &mut s3; [INFO] [stderr] | ^^ help: consider using `_r3` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r4` [INFO] [stderr] --> src/main.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | let r4 = &mut s3; [INFO] [stderr] | ^^ help: consider using `_r4` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r1` [INFO] [stderr] --> src/main.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | let r1 = &s; // immutable ref [INFO] [stderr] | ^^ help: consider using `_r1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r2` [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | let r2 = &s; // second because as many refs can read the same data safely [INFO] [stderr] | ^^ help: consider using `_r2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | let slice = &s[0..2]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | let slice = &s[..2]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | let slice = &s[2..len]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | let slice = &s[2..]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | let slice = &s[0..len]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | let slice = &s[..]; // same [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slice` [INFO] [stderr] --> src/main.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | let slice = &a[0..2]; [INFO] [stderr] | ^^^^^ help: consider using `_slice` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | let mut s = String::from("hello s"); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | let mut s = String::from("hello s"); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:204:35 [INFO] [stderr] | [INFO] [stderr] 204 | fn calculate_len_with_ref(string: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | if !char_found && !(item == b' ') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!char_found && item != b' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:204:35 [INFO] [stderr] | [INFO] [stderr] 204 | fn calculate_len_with_ref(string: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | if !char_found && !(item == b' ') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!char_found && item != b' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "46962254cbd58dd7cb0cf69b7faa11db5443e721714593eed6c8a62af46578d7"` [INFO] running `"docker" "rm" "-f" "46962254cbd58dd7cb0cf69b7faa11db5443e721714593eed6c8a62af46578d7"` [INFO] [stdout] 46962254cbd58dd7cb0cf69b7faa11db5443e721714593eed6c8a62af46578d7