[INFO] updating cached repository tpbowden/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tpbowden/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tpbowden/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/tpbowden/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tpbowden/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tpbowden/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tpbowden/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tpbowden/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5ce162309107851e31527cdcc24b8842a3d3aa53 [INFO] sha for GitHub repo tpbowden/advent-of-code-2018: 5ce162309107851e31527cdcc24b8842a3d3aa53 [INFO] validating manifest of tpbowden/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tpbowden/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tpbowden/advent-of-code-2018 [INFO] finished frobbing tpbowden/advent-of-code-2018 [INFO] frobbed toml for tpbowden/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/tpbowden/advent-of-code-2018/Cargo.toml [INFO] started frobbing tpbowden/advent-of-code-2018 [INFO] finished frobbing tpbowden/advent-of-code-2018 [INFO] frobbed toml for tpbowden/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tpbowden/advent-of-code-2018/Cargo.toml [INFO] crate tpbowden/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tpbowden/advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tpbowden/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91aeb762006e739c52500f9998d0bf9232df623dafc1c57268ff8887d0928086 [INFO] running `"docker" "start" "-a" "91aeb762006e739c52500f9998d0bf9232df623dafc1c57268ff8887d0928086"` [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Checking memchr v2.1.1 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | / return input [INFO] [stderr] 12 | | .lines() [INFO] [stderr] 13 | | .map(|line| line.parse::().unwrap()) [INFO] [stderr] 14 | | .sum::(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | input [INFO] [stderr] 12 | .lines() [INFO] [stderr] 13 | .map(|line| line.parse::().unwrap()) [INFO] [stderr] 14 | .sum::() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | return acc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | / return word [INFO] [stderr] 12 | | .chars() [INFO] [stderr] 13 | | .fold(0, |acc, c| if c == letter { acc + 1 } else { acc }); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | word [INFO] [stderr] 12 | .chars() [INFO] [stderr] 13 | .fold(0, |acc, c| if c == letter { acc + 1 } else { acc }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | return has_n_duplicates; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `has_n_duplicates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | return result.0 * result.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.0 * result.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return TwosAndThrees(twos, threes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TwosAndThrees(twos, threes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:78:7 [INFO] [stderr] | [INFO] [stderr] 78 | return acc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | return acc + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `acc + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/day3.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | if (winner) { [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | / return input [INFO] [stderr] 12 | | .lines() [INFO] [stderr] 13 | | .map(|line| line.parse::().unwrap()) [INFO] [stderr] 14 | | .sum::(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | input [INFO] [stderr] 12 | .lines() [INFO] [stderr] 13 | .map(|line| line.parse::().unwrap()) [INFO] [stderr] 14 | .sum::() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | return acc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | / return word [INFO] [stderr] 12 | | .chars() [INFO] [stderr] 13 | | .fold(0, |acc, c| if c == letter { acc + 1 } else { acc }); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | word [INFO] [stderr] 12 | .chars() [INFO] [stderr] 13 | .fold(0, |acc, c| if c == letter { acc + 1 } else { acc }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | return has_n_duplicates; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `has_n_duplicates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | return result.0 * result.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.0 * result.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return TwosAndThrees(twos, threes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TwosAndThrees(twos, threes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:78:7 [INFO] [stderr] | [INFO] [stderr] 78 | return acc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | return acc + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `acc + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/day1.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | acc = acc + item; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc += item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/day1.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | acc = acc + item; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc += item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/day3.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | if (winner) { [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/day3.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/day3.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.49s [INFO] running `"docker" "inspect" "91aeb762006e739c52500f9998d0bf9232df623dafc1c57268ff8887d0928086"` [INFO] running `"docker" "rm" "-f" "91aeb762006e739c52500f9998d0bf9232df623dafc1c57268ff8887d0928086"` [INFO] [stdout] 91aeb762006e739c52500f9998d0bf9232df623dafc1c57268ff8887d0928086