[INFO] updating cached repository tov/gsc-client [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tov/gsc-client [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tov/gsc-client" "work/ex/clippy-test-run/sources/stable/gh/tov/gsc-client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tov/gsc-client'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tov/gsc-client" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tov/gsc-client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tov/gsc-client'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ffb631c556cbb8ff17704b7066c3e527617ca01 [INFO] sha for GitHub repo tov/gsc-client: 4ffb631c556cbb8ff17704b7066c3e527617ca01 [INFO] validating manifest of tov/gsc-client on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tov/gsc-client on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tov/gsc-client [INFO] finished frobbing tov/gsc-client [INFO] frobbed toml for tov/gsc-client written to work/ex/clippy-test-run/sources/stable/gh/tov/gsc-client/Cargo.toml [INFO] started frobbing tov/gsc-client [INFO] finished frobbing tov/gsc-client [INFO] frobbed toml for tov/gsc-client written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tov/gsc-client/Cargo.toml [INFO] crate tov/gsc-client has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tov/gsc-client against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tov/gsc-client:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 933f7b57675e7339c7b5bc6fa9928615e3b3899276ff5999346cd3a0022cc97e [INFO] running `"docker" "start" "-a" "933f7b57675e7339c7b5bc6fa9928615e3b3899276ff5999346cd3a0022cc97e"` [INFO] [stderr] Checking lazycell v1.1.0 [INFO] [stderr] Compiling cc v1.0.24 [INFO] [stderr] Compiling serde v1.0.78 [INFO] [stderr] Checking vlog v0.1.4 [INFO] [stderr] Checking thousands v0.1.0 [INFO] [stderr] Checking rpassword v2.0.0 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking encoding_rs v0.8.6 [INFO] [stderr] Checking tokio-executor v0.1.4 [INFO] [stderr] Checking base64 v0.9.2 [INFO] [stderr] Checking tabular v0.1.1 [INFO] [stderr] Checking lock_api v0.1.3 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking tokio-current-thread v0.1.1 [INFO] [stderr] Checking tokio-timer v0.2.6 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling phf_shared v0.7.23 [INFO] [stderr] Checking mime v0.3.9 [INFO] [stderr] Checking libflate v0.1.16 [INFO] [stderr] Compiling syn v0.15.3 [INFO] [stderr] Compiling openssl-sys v0.9.35 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking phf v0.7.23 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling serde_derive v1.0.78 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking serde_yaml v0.8.3 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking gsc-client v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/errors.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | write!(f, " - {}\n", filename)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/errors.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | write!(f, " - {}\n", filename)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Self { [INFO] [stderr] 61 | | let cookie_file = find_dotfile(COOKIEFILE_VAR, COOKIEFILE_NAME); [INFO] [stderr] 62 | | let dotfile = find_dotfile(DOTFILE_VAR, DOTFILE_NAME); [INFO] [stderr] 63 | | [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | impl Default for config::Config { [INFO] [stderr] 60 | fn default() -> Self { [INFO] [stderr] 61 | Self::new() [INFO] [stderr] 62 | } [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Self { [INFO] [stderr] 61 | | let cookie_file = find_dotfile(COOKIEFILE_VAR, COOKIEFILE_NAME); [INFO] [stderr] 62 | | let dotfile = find_dotfile(DOTFILE_VAR, DOTFILE_NAME); [INFO] [stderr] 63 | | [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | impl Default for config::Config { [INFO] [stderr] 60 | fn default() -> Self { [INFO] [stderr] 61 | Self::new() [INFO] [stderr] 62 | } [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/messages.rs:222:15 [INFO] [stderr] | [INFO] [stderr] 222 | fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/messages.rs:234:25 [INFO] [stderr] | [INFO] [stderr] 234 | pub fn is_self_eval(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/messages.rs:251:15 [INFO] [stderr] | [INFO] [stderr] 251 | fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/messages.rs:285:20 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn to_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:497:29 [INFO] [stderr] | [INFO] [stderr] 497 | Err(format!("Could not deauthenticate with server.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Could not deauthenticate with server.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/messages.rs:222:15 [INFO] [stderr] | [INFO] [stderr] 222 | fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/messages.rs:234:25 [INFO] [stderr] | [INFO] [stderr] 234 | pub fn is_self_eval(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/messages.rs:251:15 [INFO] [stderr] | [INFO] [stderr] 251 | fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/messages.rs:285:20 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn to_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:497:29 [INFO] [stderr] | [INFO] [stderr] 497 | Err(format!("Could not deauthenticate with server.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Could not deauthenticate with server.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/bin/gsc.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / fn process(self, config: &mut config::Config) -> Result { [INFO] [stderr] 179 | | let matches = self.0.get_matches(); [INFO] [stderr] 180 | | process_common(&matches, config); [INFO] [stderr] 181 | | [INFO] [stderr] ... | [INFO] [stderr] 368 | | } [INFO] [stderr] 369 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/bin/gsc.rs:577:19 [INFO] [stderr] | [INFO] [stderr] 577 | } else if let Some(_) = spec.find(':') { [INFO] [stderr] | ____________- ^^^^^^^ [INFO] [stderr] 578 | | let rp = parse_hw_file(spec)?; [INFO] [stderr] 579 | | Ok(CpArg::Remote(rp)) [INFO] [stderr] 580 | | } else { [INFO] [stderr] 581 | | Ok(CpArg::Local(spec.into())) [INFO] [stderr] 582 | | } [INFO] [stderr] | |_____- help: try this: `if spec.find(':').is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/bin/gsc.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / fn process(self, config: &mut config::Config) -> Result { [INFO] [stderr] 179 | | let matches = self.0.get_matches(); [INFO] [stderr] 180 | | process_common(&matches, config); [INFO] [stderr] 181 | | [INFO] [stderr] ... | [INFO] [stderr] 368 | | } [INFO] [stderr] 369 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/bin/gsc.rs:577:19 [INFO] [stderr] | [INFO] [stderr] 577 | } else if let Some(_) = spec.find(':') { [INFO] [stderr] | ____________- ^^^^^^^ [INFO] [stderr] 578 | | let rp = parse_hw_file(spec)?; [INFO] [stderr] 579 | | Ok(CpArg::Remote(rp)) [INFO] [stderr] 580 | | } else { [INFO] [stderr] 581 | | Ok(CpArg::Local(spec.into())) [INFO] [stderr] 582 | | } [INFO] [stderr] | |_____- help: try this: `if spec.find(':').is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `"docker" "inspect" "933f7b57675e7339c7b5bc6fa9928615e3b3899276ff5999346cd3a0022cc97e"` [INFO] running `"docker" "rm" "-f" "933f7b57675e7339c7b5bc6fa9928615e3b3899276ff5999346cd3a0022cc97e"` [INFO] [stdout] 933f7b57675e7339c7b5bc6fa9928615e3b3899276ff5999346cd3a0022cc97e