[INFO] updating cached repository totem3/mackerel-plugin-tcp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/totem3/mackerel-plugin-tcp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/totem3/mackerel-plugin-tcp" "work/ex/clippy-test-run/sources/stable/gh/totem3/mackerel-plugin-tcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/totem3/mackerel-plugin-tcp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/totem3/mackerel-plugin-tcp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totem3/mackerel-plugin-tcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totem3/mackerel-plugin-tcp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f7ebaba4b4064229328838b0686bf69340e2dde [INFO] sha for GitHub repo totem3/mackerel-plugin-tcp: 7f7ebaba4b4064229328838b0686bf69340e2dde [INFO] validating manifest of totem3/mackerel-plugin-tcp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of totem3/mackerel-plugin-tcp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing totem3/mackerel-plugin-tcp [INFO] finished frobbing totem3/mackerel-plugin-tcp [INFO] frobbed toml for totem3/mackerel-plugin-tcp written to work/ex/clippy-test-run/sources/stable/gh/totem3/mackerel-plugin-tcp/Cargo.toml [INFO] started frobbing totem3/mackerel-plugin-tcp [INFO] finished frobbing totem3/mackerel-plugin-tcp [INFO] frobbed toml for totem3/mackerel-plugin-tcp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totem3/mackerel-plugin-tcp/Cargo.toml [INFO] crate totem3/mackerel-plugin-tcp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting totem3/mackerel-plugin-tcp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/totem3/mackerel-plugin-tcp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2741b58f6d9df3c649798d014a6b3e1cc2620901b04bc029ef69f46527d2ead1 [INFO] running `"docker" "start" "-a" "2741b58f6d9df3c649798d014a6b3e1cc2620901b04bc029ef69f46527d2ead1"` [INFO] [stderr] Compiling cc v1.0.1 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Checking serde v1.0.15 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Compiling serde_derive v1.0.15 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking serde_json v1.0.4 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking mackerel_plugin v0.2.2 [INFO] [stderr] Checking mackerel-plugin-tcp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | let keys = ss[0][1].split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:55:37 [INFO] [stderr] | [INFO] [stderr] 55 | let values = ss[1][1].split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:64:62 [INFO] [stderr] | [INFO] [stderr] 64 | INITIAL_CAPITAL.replace(k, |caps: &Captures| format!("{}", caps[1].to_lowercase())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `caps[1].to_lowercase().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | let keys = ss[0][1].split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | format!("{}", &caps[1].to_lowercase()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&caps[1].to_lowercase().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | let keys = ss[0][1].split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:55:37 [INFO] [stderr] | [INFO] [stderr] 55 | let values = ss[1][1].split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:64:62 [INFO] [stderr] | [INFO] [stderr] 64 | INITIAL_CAPITAL.replace(k, |caps: &Captures| format!("{}", caps[1].to_lowercase())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `caps[1].to_lowercase().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | let keys = ss[0][1].split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | format!("{}", &caps[1].to_lowercase()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&caps[1].to_lowercase().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.69s [INFO] running `"docker" "inspect" "2741b58f6d9df3c649798d014a6b3e1cc2620901b04bc029ef69f46527d2ead1"` [INFO] running `"docker" "rm" "-f" "2741b58f6d9df3c649798d014a6b3e1cc2620901b04bc029ef69f46527d2ead1"` [INFO] [stdout] 2741b58f6d9df3c649798d014a6b3e1cc2620901b04bc029ef69f46527d2ead1