[INFO] updating cached repository totaki/snowgen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/totaki/snowgen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/totaki/snowgen" "work/ex/clippy-test-run/sources/stable/gh/totaki/snowgen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/totaki/snowgen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/totaki/snowgen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totaki/snowgen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totaki/snowgen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 39d12073951d618f8dd482a857ee4a48bfdb4a7c [INFO] sha for GitHub repo totaki/snowgen: 39d12073951d618f8dd482a857ee4a48bfdb4a7c [INFO] validating manifest of totaki/snowgen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of totaki/snowgen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing totaki/snowgen [INFO] finished frobbing totaki/snowgen [INFO] frobbed toml for totaki/snowgen written to work/ex/clippy-test-run/sources/stable/gh/totaki/snowgen/Cargo.toml [INFO] started frobbing totaki/snowgen [INFO] finished frobbing totaki/snowgen [INFO] frobbed toml for totaki/snowgen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totaki/snowgen/Cargo.toml [INFO] crate totaki/snowgen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting totaki/snowgen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/totaki/snowgen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a33ad5a458551ba4261f355596cb42f7a1ae740d29f60ba72df17953fe51136a [INFO] running `"docker" "start" "-a" "a33ad5a458551ba4261f355596cb42f7a1ae740d29f60ba72df17953fe51136a"` [INFO] [stderr] Checking lazy_static v0.2.9 [INFO] [stderr] Checking unidecode v0.2.0 [INFO] [stderr] Checking humansize v1.0.1 [INFO] [stderr] Checking pest v0.4.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking serde_json v1.0.5 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Checking url v1.6.0 [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking slug v0.1.2 [INFO] [stderr] Checking tera v0.10.10 [INFO] [stderr] Checking snowgen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / let mut can_run = true; [INFO] [stderr] 19 | | [INFO] [stderr] 20 | | if !Path::new(run_args.input.as_str()).exists() { [INFO] [stderr] 21 | | println!("Input file not exists: {}", run_args.input); [INFO] [stderr] 22 | | can_run = false; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let can_run = if !Path::new(run_args.input.as_str()).exists() { ..; false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / let mut can_run = true; [INFO] [stderr] 19 | | [INFO] [stderr] 20 | | if !Path::new(run_args.input.as_str()).exists() { [INFO] [stderr] 21 | | println!("Input file not exists: {}", run_args.input); [INFO] [stderr] 22 | | can_run = false; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let can_run = if !Path::new(run_args.input.as_str()).exists() { ..; false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.10s [INFO] running `"docker" "inspect" "a33ad5a458551ba4261f355596cb42f7a1ae740d29f60ba72df17953fe51136a"` [INFO] running `"docker" "rm" "-f" "a33ad5a458551ba4261f355596cb42f7a1ae740d29f60ba72df17953fe51136a"` [INFO] [stdout] a33ad5a458551ba4261f355596cb42f7a1ae740d29f60ba72df17953fe51136a