[INFO] updating cached repository toshitanian/xcat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/toshitanian/xcat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/toshitanian/xcat" "work/ex/clippy-test-run/sources/stable/gh/toshitanian/xcat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/toshitanian/xcat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/toshitanian/xcat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/toshitanian/xcat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/toshitanian/xcat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ee084199a9df781883ae7059c92e54c552cd7a9 [INFO] sha for GitHub repo toshitanian/xcat: 4ee084199a9df781883ae7059c92e54c552cd7a9 [INFO] validating manifest of toshitanian/xcat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of toshitanian/xcat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing toshitanian/xcat [INFO] finished frobbing toshitanian/xcat [INFO] frobbed toml for toshitanian/xcat written to work/ex/clippy-test-run/sources/stable/gh/toshitanian/xcat/Cargo.toml [INFO] started frobbing toshitanian/xcat [INFO] finished frobbing toshitanian/xcat [INFO] frobbed toml for toshitanian/xcat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/toshitanian/xcat/Cargo.toml [INFO] crate toshitanian/xcat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting toshitanian/xcat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/toshitanian/xcat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11096a74e78e9dc80d5f7952daf5876ce0c6e18739ab2d0586a5a7f15cd9c028 [INFO] running `"docker" "start" "-a" "11096a74e78e9dc80d5f7952daf5876ce0c6e18739ab2d0586a5a7f15cd9c028"` [INFO] [stderr] Compiling gcc v0.3.45 [INFO] [stderr] Compiling backtrace v0.3.0 [INFO] [stderr] Checking podio v0.1.5 [INFO] [stderr] Checking from-ascii v0.0.1 [INFO] [stderr] Checking rustc-serialize v0.3.23 [INFO] [stderr] Checking encoding_rs v0.5.0 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Checking clap v2.23.1 [INFO] [stderr] Compiling backtrace-sys v0.1.10 [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Checking flate2 v0.2.17 [INFO] [stderr] Checking zip v0.2.3 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking quick-xml v0.7.0 [INFO] [stderr] Checking calamine v0.10.2 [INFO] [stderr] Checking xcat v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/reader/csv.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/reader/excel.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | let _ = println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/reader/csv.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/reader/excel.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | let _ = println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader/csv.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | let _ = print!("{}", delimiter); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader/excel.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | / let _ = match *c { [INFO] [stderr] 19 | | calamine::DataType::Empty => print!(""), [INFO] [stderr] 20 | | calamine::DataType::String(ref s) => print!("{}", s), [INFO] [stderr] 21 | | calamine::DataType::Float(ref f) => print!("{}", f), [INFO] [stderr] ... | [INFO] [stderr] 24 | | calamine::DataType::Bool(ref b) => print!("{}", b), [INFO] [stderr] 25 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader/csv.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | let _ = print!("{}", delimiter); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader/excel.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | let _ = print!("{}", delimiter); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader/excel.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let _ = println!(""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader/excel.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | / let _ = match *c { [INFO] [stderr] 19 | | calamine::DataType::Empty => print!(""), [INFO] [stderr] 20 | | calamine::DataType::String(ref s) => print!("{}", s), [INFO] [stderr] 21 | | calamine::DataType::Float(ref f) => print!("{}", f), [INFO] [stderr] ... | [INFO] [stderr] 24 | | calamine::DataType::Bool(ref b) => print!("{}", b), [INFO] [stderr] 25 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader/excel.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | let _ = print!("{}", delimiter); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader/excel.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let _ = println!(""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.82s [INFO] running `"docker" "inspect" "11096a74e78e9dc80d5f7952daf5876ce0c6e18739ab2d0586a5a7f15cd9c028"` [INFO] running `"docker" "rm" "-f" "11096a74e78e9dc80d5f7952daf5876ce0c6e18739ab2d0586a5a7f15cd9c028"` [INFO] [stdout] 11096a74e78e9dc80d5f7952daf5876ce0c6e18739ab2d0586a5a7f15cd9c028