[INFO] updating cached repository toshi0383/cmdshelf
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/toshi0383/cmdshelf
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/toshi0383/cmdshelf" "work/ex/clippy-test-run/sources/stable/gh/toshi0383/cmdshelf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/toshi0383/cmdshelf'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/toshi0383/cmdshelf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/toshi0383/cmdshelf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/toshi0383/cmdshelf'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 27c039248e51fa79f4243242b939222cf7b11af7
[INFO] sha for GitHub repo toshi0383/cmdshelf: 27c039248e51fa79f4243242b939222cf7b11af7
[INFO] validating manifest of toshi0383/cmdshelf on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of toshi0383/cmdshelf on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing toshi0383/cmdshelf
[INFO] finished frobbing toshi0383/cmdshelf
[INFO] frobbed toml for toshi0383/cmdshelf written to work/ex/clippy-test-run/sources/stable/gh/toshi0383/cmdshelf/Cargo.toml
[INFO] started frobbing toshi0383/cmdshelf
[INFO] finished frobbing toshi0383/cmdshelf
[INFO] frobbed toml for toshi0383/cmdshelf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/toshi0383/cmdshelf/Cargo.toml
[INFO] crate toshi0383/cmdshelf has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting toshi0383/cmdshelf against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/toshi0383/cmdshelf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f31dbd41fefe491392e311bfbf686bb64b7f83dc5bceaf1e1419bb31e1262b11
[INFO] running `"docker" "start" "-a" "f31dbd41fefe491392e311bfbf686bb64b7f83dc5bceaf1e1419bb31e1262b11"`
[INFO] [stderr]    Compiling proc-macro2 v0.4.15
[INFO] [stderr]     Checking same-file v1.0.3
[INFO] [stderr]     Checking is_executable v0.1.0
[INFO] [stderr]     Checking toml v0.4.6
[INFO] [stderr]     Checking walkdir v2.2.5
[INFO] [stderr]    Compiling quote v0.6.8
[INFO] [stderr]    Compiling syn v0.14.9
[INFO] [stderr]    Compiling serde_derive v1.0.75
[INFO] [stderr]     Checking cmdshelf v2.0.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/context.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             remote: remote,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `remote`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/context.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             fullpath: fullpath,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `fullpath`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/context.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |             remotes: remotes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `remotes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/context.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             remote: remote,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `remote`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/context.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             fullpath: fullpath,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `fullpath`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/context.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |             remotes: remotes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `remotes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/cat.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         return "cat".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"cat".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/help.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         return "help".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"help".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/commands/list.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return "list".to_owned()
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"list".to_owned()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/commands/remote.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return "remote".to_owned()
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"remote".to_owned()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/remote.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |         return "add".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"add".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/remote.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 |         return "remove".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"remove".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/remote.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         return "list".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"list".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/run.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         return "run".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"run".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/commands/update.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return "update".to_owned()
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"update".to_owned()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/context.rs:159:17
[INFO] [stderr]     |
[INFO] [stderr] 159 |                 return buf
[INFO] [stderr]     |                 ^^^^^^^^^^ help: remove `return` as shown: `buf`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `No`
[INFO] [stderr]    --> src/context.rs:276:1
[INFO] [stderr]     |
[INFO] [stderr] 276 | / enum FileError {
[INFO] [stderr] 277 | |     NotFound(String),
[INFO] [stderr] 278 | |     NotExecutable(String),
[INFO] [stderr] 279 | |     NoHomeDir,
[INFO] [stderr] 280 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]     = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/cat.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         return "cat".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"cat".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/help.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         return "help".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"help".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/commands/list.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return "list".to_owned()
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"list".to_owned()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/commands/remote.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return "remote".to_owned()
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"remote".to_owned()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/remote.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |         return "add".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"add".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/remote.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 |         return "remove".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"remove".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/remote.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         return "list".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"list".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/run.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         return "run".to_owned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"run".to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/commands/update.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return "update".to_owned()
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"update".to_owned()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/context.rs:159:17
[INFO] [stderr]     |
[INFO] [stderr] 159 |                 return buf
[INFO] [stderr]     |                 ^^^^^^^^^^ help: remove `return` as shown: `buf`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `No`
[INFO] [stderr]    --> src/context.rs:276:1
[INFO] [stderr]     |
[INFO] [stderr] 276 | / enum FileError {
[INFO] [stderr] 277 | |     NotFound(String),
[INFO] [stderr] 278 | |     NotExecutable(String),
[INFO] [stderr] 279 | |     NoHomeDir,
[INFO] [stderr] 280 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]     = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/context.rs:307:5
[INFO] [stderr]     |
[INFO] [stderr] 307 |     env::home_dir()
[INFO] [stderr]     |     ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/context.rs:307:5
[INFO] [stderr]     |
[INFO] [stderr] 307 |     env::home_dir()
[INFO] [stderr]     |     ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands/cat.rs:14:12
[INFO] [stderr]    |
[INFO] [stderr] 14 |         if args.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/commands/help.rs:29:16
[INFO] [stderr]    |
[INFO] [stderr] 29 |     fn manpage(&self) -> String {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/commands/help.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |             if args.len() < 1 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/commands/remote.rs:13:12
[INFO] [stderr]    |
[INFO] [stderr] 13 |         if args.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]   --> src/commands/remote.rs:56:43
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 && a.split(MAIN_SEPARATOR).collect::<Vec<&str>>().len() == 2 {
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/remote.rs:59:17
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 format!("{}", a)
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `a.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/commands/remote.rs:78:12
[INFO] [stderr]    |
[INFO] [stderr] 78 |         if args.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands/run.rs:14:12
[INFO] [stderr]    |
[INFO] [stderr] 14 |         if args.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/commands/run.rs:26:50
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 let mut args: Vec<String> = args.into_iter().map(|x| format!("'{}'", x)).collect();
[INFO] [stderr]    |                                                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]   --> src/commands/mod.rs:25:11
[INFO] [stderr]    |
[INFO] [stderr] 25 |     match string.as_ref() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^ help: try this: `string`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `context::Context`
[INFO] [stderr]   --> src/context.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     pub fn new() -> Self {
[INFO] [stderr] 41 | |         let toml = default_toml_path();
[INFO] [stderr] 42 | |         let config = read_or_create_config(toml.as_path());
[INFO] [stderr] 43 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |         }
[INFO] [stderr] 56 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/context.rs:67:40
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let vec: Vec<&str> = arg.split(":").collect();
[INFO] [stderr]    |                                        ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/context.rs:118:45
[INFO] [stderr]     |
[INFO] [stderr] 118 |                      .map(|s| s.starts_with("."))
[INFO] [stderr]     |                                             ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands/cat.rs:14:12
[INFO] [stderr]    |
[INFO] [stderr] 14 |         if args.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/commands/help.rs:29:16
[INFO] [stderr]    |
[INFO] [stderr] 29 |     fn manpage(&self) -> String {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/commands/help.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |             if args.len() < 1 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/commands/remote.rs:13:12
[INFO] [stderr]    |
[INFO] [stderr] 13 |         if args.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]   --> src/commands/remote.rs:56:43
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 && a.split(MAIN_SEPARATOR).collect::<Vec<&str>>().len() == 2 {
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/remote.rs:59:17
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 format!("{}", a)
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `a.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/commands/remote.rs:78:12
[INFO] [stderr]    |
[INFO] [stderr] 78 |         if args.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands/run.rs:14:12
[INFO] [stderr]    |
[INFO] [stderr] 14 |         if args.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/commands/run.rs:26:50
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 let mut args: Vec<String> = args.into_iter().map(|x| format!("'{}'", x)).collect();
[INFO] [stderr]    |                                                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]   --> src/commands/mod.rs:25:11
[INFO] [stderr]    |
[INFO] [stderr] 25 |     match string.as_ref() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^ help: try this: `string`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `context::Context`
[INFO] [stderr]   --> src/context.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     pub fn new() -> Self {
[INFO] [stderr] 41 | |         let toml = default_toml_path();
[INFO] [stderr] 42 | |         let config = read_or_create_config(toml.as_path());
[INFO] [stderr] 43 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |         }
[INFO] [stderr] 56 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/context.rs:67:40
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let vec: Vec<&str> = arg.split(":").collect();
[INFO] [stderr]    |                                        ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/context.rs:118:45
[INFO] [stderr]     |
[INFO] [stderr] 118 |                      .map(|s| s.starts_with("."))
[INFO] [stderr]     |                                             ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 23.97s
[INFO] running `"docker" "inspect" "f31dbd41fefe491392e311bfbf686bb64b7f83dc5bceaf1e1419bb31e1262b11"`
[INFO] running `"docker" "rm" "-f" "f31dbd41fefe491392e311bfbf686bb64b7f83dc5bceaf1e1419bb31e1262b11"`
[INFO] [stdout] f31dbd41fefe491392e311bfbf686bb64b7f83dc5bceaf1e1419bb31e1262b11