[INFO] updating cached repository torkeldanielsson/japanese_commandline_trainer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/torkeldanielsson/japanese_commandline_trainer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/torkeldanielsson/japanese_commandline_trainer" "work/ex/clippy-test-run/sources/stable/gh/torkeldanielsson/japanese_commandline_trainer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/torkeldanielsson/japanese_commandline_trainer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/torkeldanielsson/japanese_commandline_trainer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/torkeldanielsson/japanese_commandline_trainer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/torkeldanielsson/japanese_commandline_trainer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 523966cdecab3bc922f348f65b7d044a0735718a [INFO] sha for GitHub repo torkeldanielsson/japanese_commandline_trainer: 523966cdecab3bc922f348f65b7d044a0735718a [INFO] validating manifest of torkeldanielsson/japanese_commandline_trainer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of torkeldanielsson/japanese_commandline_trainer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing torkeldanielsson/japanese_commandline_trainer [INFO] finished frobbing torkeldanielsson/japanese_commandline_trainer [INFO] frobbed toml for torkeldanielsson/japanese_commandline_trainer written to work/ex/clippy-test-run/sources/stable/gh/torkeldanielsson/japanese_commandline_trainer/Cargo.toml [INFO] started frobbing torkeldanielsson/japanese_commandline_trainer [INFO] finished frobbing torkeldanielsson/japanese_commandline_trainer [INFO] frobbed toml for torkeldanielsson/japanese_commandline_trainer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/torkeldanielsson/japanese_commandline_trainer/Cargo.toml [INFO] crate torkeldanielsson/japanese_commandline_trainer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting torkeldanielsson/japanese_commandline_trainer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/torkeldanielsson/japanese_commandline_trainer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 16716c7ff946889e1754e900993df6d826ccdde1c355731cc4970ea9bbbadfef [INFO] running `"docker" "start" "-a" "16716c7ff946889e1754e900993df6d826ccdde1c355731cc4970ea9bbbadfef"` [INFO] [stderr] Checking hiragana v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:582:23 [INFO] [stderr] | [INFO] [stderr] 582 | for group_size in vec![2, /* 2, 5, 10*/] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:604:12 [INFO] [stderr] | [INFO] [stderr] 604 | if kanas_to_print.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kanas_to_print.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:582:23 [INFO] [stderr] | [INFO] [stderr] 582 | for group_size in vec![2, /* 2, 5, 10*/] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:604:12 [INFO] [stderr] | [INFO] [stderr] 604 | if kanas_to_print.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kanas_to_print.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `"docker" "inspect" "16716c7ff946889e1754e900993df6d826ccdde1c355731cc4970ea9bbbadfef"` [INFO] running `"docker" "rm" "-f" "16716c7ff946889e1754e900993df6d826ccdde1c355731cc4970ea9bbbadfef"` [INFO] [stdout] 16716c7ff946889e1754e900993df6d826ccdde1c355731cc4970ea9bbbadfef