[INFO] updating cached repository topher6345/kafka-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/topher6345/kafka-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/topher6345/kafka-rust" "work/ex/clippy-test-run/sources/stable/gh/topher6345/kafka-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/topher6345/kafka-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/topher6345/kafka-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/topher6345/kafka-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/topher6345/kafka-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 27e582d8e8fb449441d09354cd916885057239f4 [INFO] sha for GitHub repo topher6345/kafka-rust: 27e582d8e8fb449441d09354cd916885057239f4 [INFO] validating manifest of topher6345/kafka-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of topher6345/kafka-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing topher6345/kafka-rust [INFO] finished frobbing topher6345/kafka-rust [INFO] frobbed toml for topher6345/kafka-rust written to work/ex/clippy-test-run/sources/stable/gh/topher6345/kafka-rust/Cargo.toml [INFO] started frobbing topher6345/kafka-rust [INFO] finished frobbing topher6345/kafka-rust [INFO] frobbed toml for topher6345/kafka-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/topher6345/kafka-rust/Cargo.toml [INFO] crate topher6345/kafka-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting topher6345/kafka-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/topher6345/kafka-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15b75fd58807d7b960ff15cac07a646eabec7a5392e9d5758324496064c210bb [INFO] running `"docker" "start" "-a" "15b75fd58807d7b960ff15cac07a646eabec7a5392e9d5758324496064c210bb"` [INFO] [stderr] Checking ref_slice v1.1.1 [INFO] [stderr] Checking getopts v0.2.17 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking humantime v1.1.1 [INFO] [stderr] Checking snap v0.2.4 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking twox-hash v1.1.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking kafka v0.7.0 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking hello_kafka v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hello.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | topic: topic, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `topic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | let _ = write!(buf, "{}:{}@{}:\n", ms.topic(), ms.partition(), m.offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | brokers: brokers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `brokers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | topics: topics, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `topics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | offset_storage: offset_storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset_storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hello.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | topic: topic, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `topic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | let _ = write!(buf, "{}:{}@{}:\n", ms.topic(), ms.partition(), m.offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | brokers: brokers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `brokers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | topics: topics, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `topics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | offset_storage: offset_storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset_storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/hello.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod hello { [INFO] [stderr] 2 | | use kafka::producer::{Producer, Record, RequiredAcks}; [INFO] [stderr] 3 | | use std::time::Duration; [INFO] [stderr] 4 | | use kafka::error::Error as KafkaError; [INFO] [stderr] ... | [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/hello.rs:50:38 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn process_value(value: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/hello.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod hello { [INFO] [stderr] 2 | | use kafka::producer::{Producer, Record, RequiredAcks}; [INFO] [stderr] 3 | | use std::time::Duration; [INFO] [stderr] 4 | | use kafka::error::Error as KafkaError; [INFO] [stderr] ... | [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/hello.rs:50:38 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn process_value(value: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/hello.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn produce_message<'a, 'b>( [INFO] [stderr] 9 | | data: &'a [u8], [INFO] [stderr] 10 | | topic: &'b str, [INFO] [stderr] 11 | | brokers: Vec, [INFO] [stderr] ... | [INFO] [stderr] 47 | | Ok(()) [INFO] [stderr] 48 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:147:54 [INFO] [stderr] | [INFO] [stderr] 147 | group: m.opt_str("group").unwrap_or_else(|| String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/hello.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn produce_message<'a, 'b>( [INFO] [stderr] 9 | | data: &'a [u8], [INFO] [stderr] 10 | | topic: &'b str, [INFO] [stderr] 11 | | brokers: Vec, [INFO] [stderr] ... | [INFO] [stderr] 47 | | Ok(()) [INFO] [stderr] 48 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:147:54 [INFO] [stderr] | [INFO] [stderr] 147 | group: m.opt_str("group").unwrap_or_else(|| String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.44s [INFO] running `"docker" "inspect" "15b75fd58807d7b960ff15cac07a646eabec7a5392e9d5758324496064c210bb"` [INFO] running `"docker" "rm" "-f" "15b75fd58807d7b960ff15cac07a646eabec7a5392e9d5758324496064c210bb"` [INFO] [stdout] 15b75fd58807d7b960ff15cac07a646eabec7a5392e9d5758324496064c210bb