[INFO] updating cached repository tonyfinn/xray [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tonyfinn/xray [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tonyfinn/xray" "work/ex/clippy-test-run/sources/stable/gh/tonyfinn/xray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tonyfinn/xray'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tonyfinn/xray" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tonyfinn/xray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tonyfinn/xray'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd9b5c86de88668b1c7963a7a00d4b51a461d3f3 [INFO] sha for GitHub repo tonyfinn/xray: fd9b5c86de88668b1c7963a7a00d4b51a461d3f3 [INFO] validating manifest of tonyfinn/xray on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tonyfinn/xray on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tonyfinn/xray [INFO] finished frobbing tonyfinn/xray [INFO] frobbed toml for tonyfinn/xray written to work/ex/clippy-test-run/sources/stable/gh/tonyfinn/xray/Cargo.toml [INFO] started frobbing tonyfinn/xray [INFO] finished frobbing tonyfinn/xray [INFO] frobbed toml for tonyfinn/xray written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tonyfinn/xray/Cargo.toml [INFO] crate tonyfinn/xray has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tonyfinn/xray against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tonyfinn/xray:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 68825aa80dfee10dd4196e7f2daba71acf88ddf81405e481b9d51a6f986e4547 [INFO] running `"docker" "start" "-a" "68825aa80dfee10dd4196e7f2daba71acf88ddf81405e481b9d51a6f986e4547"` [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Compiling log v0.4.2 [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking gif v0.10.0 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking xray v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:65:57 [INFO] [stderr] | [INFO] [stderr] 65 | IoError::FailedLoadingReferenceImage => format!("Reference image could not be loaded or parsed") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Reference image could not be loaded or parsed".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:187:48 [INFO] [stderr] | [INFO] [stderr] 187 | let mut file = File::create(&filename).or(Err(XrayError::Io(IoError::FailedWritingScreenshot( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 188 | | filename.to_string_lossy().to_string(), [INFO] [stderr] 189 | | "Could not open file for writing".to_string() [INFO] [stderr] 190 | | ))))?; [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 187 | let mut file = File::create(&filename).or_else(|_| Err(XrayError::Io(IoError::FailedWritingScreenshot( [INFO] [stderr] 188 | filename.to_string_lossy().to_string(), [INFO] [stderr] 189 | "Could not open file for writing".to_string() [INFO] [stderr] 190 | ))))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:201:69 [INFO] [stderr] | [INFO] [stderr] 201 | fs::create_dir_all(&self.output_path.join(&self.test_name)).or( [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 202 | | Err(XrayError::Io(IoError::OutputLocationUnavailable(self.output_path.to_string_lossy().to_string()))) [INFO] [stderr] 203 | | ) [INFO] [stderr] | |_________^ help: try this: `or_else(|_| Err(XrayError::Io(IoError::OutputLocationUnavailable(self.output_path.to_string_lossy().to_string()))))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | return Ok(self.screenshot.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.screenshot.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rbgw` [INFO] [stderr] --> src/lib.rs:435:13 [INFO] [stderr] | [INFO] [stderr] 435 | let rbgw = DynamicImage::ImageRgba8(ImageBuffer::from_vec(2, 2, [INFO] [stderr] | ^^^^ help: consider using `_rbgw` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `expected` [INFO] [stderr] --> src/lib.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | let expected = DynamicImage::ImageRgba8(ImageBuffer::from_vec(2, 2, [INFO] [stderr] | ^^^^^^^^ help: consider using `_expected` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `expected` [INFO] [stderr] --> src/lib.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | let expected = DynamicImage::ImageRgba8(ImageBuffer::from_vec(2, 2, [INFO] [stderr] | ^^^^^^^^ help: consider using `_expected` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/lib.rs:391:33 [INFO] [stderr] | [INFO] [stderr] 391 | fn capture_image(&self, x: i32, y: i32, width: u32, height: u32) -> XrayResult { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/lib.rs:391:41 [INFO] [stderr] | [INFO] [stderr] 391 | fn capture_image(&self, x: i32, y: i32, width: u32, height: u32) -> XrayResult { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `width` [INFO] [stderr] --> src/lib.rs:391:49 [INFO] [stderr] | [INFO] [stderr] 391 | fn capture_image(&self, x: i32, y: i32, width: u32, height: u32) -> XrayResult { [INFO] [stderr] | ^^^^^ help: consider using `_width` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `height` [INFO] [stderr] --> src/lib.rs:391:61 [INFO] [stderr] | [INFO] [stderr] 391 | fn capture_image(&self, x: i32, y: i32, width: u32, height: u32) -> XrayResult { [INFO] [stderr] | ^^^^^^ help: consider using `_height` instead [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:65:57 [INFO] [stderr] | [INFO] [stderr] 65 | IoError::FailedLoadingReferenceImage => format!("Reference image could not be loaded or parsed") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Reference image could not be loaded or parsed".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:187:48 [INFO] [stderr] | [INFO] [stderr] 187 | let mut file = File::create(&filename).or(Err(XrayError::Io(IoError::FailedWritingScreenshot( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 188 | | filename.to_string_lossy().to_string(), [INFO] [stderr] 189 | | "Could not open file for writing".to_string() [INFO] [stderr] 190 | | ))))?; [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 187 | let mut file = File::create(&filename).or_else(|_| Err(XrayError::Io(IoError::FailedWritingScreenshot( [INFO] [stderr] 188 | filename.to_string_lossy().to_string(), [INFO] [stderr] 189 | "Could not open file for writing".to_string() [INFO] [stderr] 190 | ))))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:201:69 [INFO] [stderr] | [INFO] [stderr] 201 | fs::create_dir_all(&self.output_path.join(&self.test_name)).or( [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 202 | | Err(XrayError::Io(IoError::OutputLocationUnavailable(self.output_path.to_string_lossy().to_string()))) [INFO] [stderr] 203 | | ) [INFO] [stderr] | |_________^ help: try this: `or_else(|_| Err(XrayError::Io(IoError::OutputLocationUnavailable(self.output_path.to_string_lossy().to_string()))))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.51s [INFO] running `"docker" "inspect" "68825aa80dfee10dd4196e7f2daba71acf88ddf81405e481b9d51a6f986e4547"` [INFO] running `"docker" "rm" "-f" "68825aa80dfee10dd4196e7f2daba71acf88ddf81405e481b9d51a6f986e4547"` [INFO] [stdout] 68825aa80dfee10dd4196e7f2daba71acf88ddf81405e481b9d51a6f986e4547