[INFO] updating cached repository tomwhoiscontrary/isots [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tomwhoiscontrary/isots [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tomwhoiscontrary/isots" "work/ex/clippy-test-run/sources/stable/gh/tomwhoiscontrary/isots"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomwhoiscontrary/isots'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tomwhoiscontrary/isots" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomwhoiscontrary/isots"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomwhoiscontrary/isots'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 646f593552e1cbb620bc2c92c04e116d2a218e42 [INFO] sha for GitHub repo tomwhoiscontrary/isots: 646f593552e1cbb620bc2c92c04e116d2a218e42 [INFO] validating manifest of tomwhoiscontrary/isots on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tomwhoiscontrary/isots on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tomwhoiscontrary/isots [INFO] finished frobbing tomwhoiscontrary/isots [INFO] frobbed toml for tomwhoiscontrary/isots written to work/ex/clippy-test-run/sources/stable/gh/tomwhoiscontrary/isots/Cargo.toml [INFO] started frobbing tomwhoiscontrary/isots [INFO] finished frobbing tomwhoiscontrary/isots [INFO] frobbed toml for tomwhoiscontrary/isots written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomwhoiscontrary/isots/Cargo.toml [INFO] crate tomwhoiscontrary/isots has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tomwhoiscontrary/isots against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tomwhoiscontrary/isots:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d7e88bf524332d78d9aed811f0b6e3a886fba62e3679c943e33b8ec3df72f01 [INFO] running `"docker" "start" "-a" "7d7e88bf524332d78d9aed811f0b6e3a886fba62e3679c943e33b8ec3df72f01"` [INFO] [stderr] Checking isots v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | buffer.push('1' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:55:35 [INFO] [stderr] | [INFO] [stderr] 55 | emit(&mut stdout, '1' as u8)?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | emit(&mut stdout, '1' as u8)?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:98:35 [INFO] [stderr] | [INFO] [stderr] 98 | emit(&mut stdout, '1' as u8)?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:114:11 [INFO] [stderr] | [INFO] [stderr] 114 | ch >= '0' as u8 && ch <= '9' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:114:30 [INFO] [stderr] | [INFO] [stderr] 114 | ch >= '0' as u8 && ch <= '9' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'9' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:118:11 [INFO] [stderr] | [INFO] [stderr] 118 | ch == '1' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:122:11 [INFO] [stderr] | [INFO] [stderr] 122 | ch == '4' as u8 || ch == '5' as u8 // 2014-05-13 16:53:20 to 2020-09-13 12:26:40 (not inclusive) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'4' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:122:30 [INFO] [stderr] | [INFO] [stderr] 122 | ch == '4' as u8 || ch == '5' as u8 // 2014-05-13 16:53:20 to 2020-09-13 12:26:40 (not inclusive) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'5' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:143:38 [INFO] [stderr] | [INFO] [stderr] 143 | timestamp = timestamp * 10 + (*d - '0' as u8) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(*d - '0' as u8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:143:44 [INFO] [stderr] | [INFO] [stderr] 143 | timestamp = timestamp * 10 + (*d - '0' as u8) as u64; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / write!(out, [INFO] [stderr] 150 | | "{}-{:02}-{:02}T{:02}:{:02}:{:02}Z", [INFO] [stderr] 151 | | time.year(), [INFO] [stderr] 152 | | time.month(), [INFO] [stderr] ... | [INFO] [stderr] 155 | | time.minute(), [INFO] [stderr] 156 | | time.second()); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / write!(out, [INFO] [stderr] 159 | | "{}-{:02}-{:02}T{:02}:{:02}:{:02}.{:0width$}Z", [INFO] [stderr] 160 | | time.year(), [INFO] [stderr] 161 | | time.month(), [INFO] [stderr] ... | [INFO] [stderr] 166 | | time.nanosecond(), [INFO] [stderr] 167 | | width = fractional_seconds_digits); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/main.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | for d in buffer.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | buffer.push('1' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:55:35 [INFO] [stderr] | [INFO] [stderr] 55 | emit(&mut stdout, '1' as u8)?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | emit(&mut stdout, '1' as u8)?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:98:35 [INFO] [stderr] | [INFO] [stderr] 98 | emit(&mut stdout, '1' as u8)?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:114:11 [INFO] [stderr] | [INFO] [stderr] 114 | ch >= '0' as u8 && ch <= '9' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:114:30 [INFO] [stderr] | [INFO] [stderr] 114 | ch >= '0' as u8 && ch <= '9' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'9' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:118:11 [INFO] [stderr] | [INFO] [stderr] 118 | ch == '1' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:122:11 [INFO] [stderr] | [INFO] [stderr] 122 | ch == '4' as u8 || ch == '5' as u8 // 2014-05-13 16:53:20 to 2020-09-13 12:26:40 (not inclusive) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'4' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:122:30 [INFO] [stderr] | [INFO] [stderr] 122 | ch == '4' as u8 || ch == '5' as u8 // 2014-05-13 16:53:20 to 2020-09-13 12:26:40 (not inclusive) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'5' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:143:38 [INFO] [stderr] | [INFO] [stderr] 143 | timestamp = timestamp * 10 + (*d - '0' as u8) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(*d - '0' as u8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:143:44 [INFO] [stderr] | [INFO] [stderr] 143 | timestamp = timestamp * 10 + (*d - '0' as u8) as u64; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / write!(out, [INFO] [stderr] 150 | | "{}-{:02}-{:02}T{:02}:{:02}:{:02}Z", [INFO] [stderr] 151 | | time.year(), [INFO] [stderr] 152 | | time.month(), [INFO] [stderr] ... | [INFO] [stderr] 155 | | time.minute(), [INFO] [stderr] 156 | | time.second()); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / write!(out, [INFO] [stderr] 159 | | "{}-{:02}-{:02}T{:02}:{:02}:{:02}.{:0width$}Z", [INFO] [stderr] 160 | | time.year(), [INFO] [stderr] 161 | | time.month(), [INFO] [stderr] ... | [INFO] [stderr] 166 | | time.nanosecond(), [INFO] [stderr] 167 | | width = fractional_seconds_digits); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/main.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | for d in buffer.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "7d7e88bf524332d78d9aed811f0b6e3a886fba62e3679c943e33b8ec3df72f01"` [INFO] running `"docker" "rm" "-f" "7d7e88bf524332d78d9aed811f0b6e3a886fba62e3679c943e33b8ec3df72f01"` [INFO] [stdout] 7d7e88bf524332d78d9aed811f0b6e3a886fba62e3679c943e33b8ec3df72f01