[INFO] updating cached repository tomvidm/rust-geometry
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tomvidm/rust-geometry
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tomvidm/rust-geometry" "work/ex/clippy-test-run/sources/stable/gh/tomvidm/rust-geometry"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomvidm/rust-geometry'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tomvidm/rust-geometry" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomvidm/rust-geometry"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomvidm/rust-geometry'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 99e761d5556e45c1ff3e98f0c98ac4b1cdcec14d
[INFO] sha for GitHub repo tomvidm/rust-geometry: 99e761d5556e45c1ff3e98f0c98ac4b1cdcec14d
[INFO] validating manifest of tomvidm/rust-geometry on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tomvidm/rust-geometry on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tomvidm/rust-geometry
[INFO] finished frobbing tomvidm/rust-geometry
[INFO] frobbed toml for tomvidm/rust-geometry written to work/ex/clippy-test-run/sources/stable/gh/tomvidm/rust-geometry/Cargo.toml
[INFO] started frobbing tomvidm/rust-geometry
[INFO] finished frobbing tomvidm/rust-geometry
[INFO] frobbed toml for tomvidm/rust-geometry written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomvidm/rust-geometry/Cargo.toml
[INFO] crate tomvidm/rust-geometry has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tomvidm/rust-geometry against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tomvidm/rust-geometry:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5610433a3225b10a69d1d37f4ad21e78adba18be05759b2fbd1f5b0d4e68c766
[INFO] running `"docker" "start" "-a" "5610433a3225b10a69d1d37f4ad21e78adba18be05759b2fbd1f5b0d4e68c766"`
[INFO] [stderr]     Checking mathbox v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:53
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:61
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:69
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:77
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                                             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 9th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:85
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                                                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector2.rs:17:19
[INFO] [stderr]    |
[INFO] [stderr] 17 |         Vector2 { x: x, y: y }
[INFO] [stderr]    |                   ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector2.rs:17:25
[INFO] [stderr]    |
[INFO] [stderr] 17 |         Vector2 { x: x, y: y }
[INFO] [stderr]    |                         ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector3.rs:20:19
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Vector3 { x: x, y: y, z: z }
[INFO] [stderr]    |                   ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector3.rs:20:25
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Vector3 { x: x, y: y, z: z }
[INFO] [stderr]    |                         ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector3.rs:20:31
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Vector3 { x: x, y: y, z: z }
[INFO] [stderr]    |                               ^^^^ help: replace it with: `z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:53
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:61
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:69
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:77
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                                             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 9th binding whose name is just one char
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:85
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr]    |                                                                                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector2.rs:17:19
[INFO] [stderr]    |
[INFO] [stderr] 17 |         Vector2 { x: x, y: y }
[INFO] [stderr]    |                   ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector2.rs:17:25
[INFO] [stderr]    |
[INFO] [stderr] 17 |         Vector2 { x: x, y: y }
[INFO] [stderr]    |                         ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector3.rs:20:19
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Vector3 { x: x, y: y, z: z }
[INFO] [stderr]    |                   ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector3.rs:20:25
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Vector3 { x: x, y: y, z: z }
[INFO] [stderr]    |                         ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math/vector/vector3.rs:20:31
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Vector3 { x: x, y: y, z: z }
[INFO] [stderr]    |                               ^^^^ help: replace it with: `z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix2.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         return mat
[INFO] [stderr]    |         ^^^^^^^^^^ help: remove `return` as shown: `mat`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix2.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         return Vector2::new_from(
[INFO] [stderr] 54 | |             self.data[0][0] * other.x + self.data[0][1] * other.y,
[INFO] [stderr] 55 | |             self.data[1][0] * other.x + self.data[1][1] * other.y
[INFO] [stderr] 56 | |         )
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 53 |         Vector2::new_from(
[INFO] [stderr] 54 |             self.data[0][0] * other.x + self.data[0][1] * other.y,
[INFO] [stderr] 55 |             self.data[1][0] * other.x + self.data[1][1] * other.y
[INFO] [stderr] 56 |         )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 |         return mat
[INFO] [stderr]    |         ^^^^^^^^^^ help: remove `return` as shown: `mat`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return Vector2::new_from(homogenous.x, homogenous.y)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector2::new_from(homogenous.x, homogenous.y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 | /         return Vector3::new_from(
[INFO] [stderr] 65 | |             self.data[0][0] * other.x + self.data[0][1] * other.y + self.data[0][2] * other.z,
[INFO] [stderr] 66 | |             self.data[1][0] * other.x + self.data[1][1] * other.y + self.data[1][2] * other.z,
[INFO] [stderr] 67 | |             self.data[2][0] * other.x + self.data[2][1] * other.y + self.data[2][2] * other.z
[INFO] [stderr] 68 | |         )
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 64 |         Vector3::new_from(
[INFO] [stderr] 65 |             self.data[0][0] * other.x + self.data[0][1] * other.y + self.data[0][2] * other.z,
[INFO] [stderr] 66 |             self.data[1][0] * other.x + self.data[1][1] * other.y + self.data[1][2] * other.z,
[INFO] [stderr] 67 |             self.data[2][0] * other.x + self.data[2][1] * other.y + self.data[2][2] * other.z
[INFO] [stderr] 68 |         )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:98:9
[INFO] [stderr]    |
[INFO] [stderr] 98 |         return det_a - det_b + det_c
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `det_a - det_b + det_c`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is used to index `columns`
[INFO] [stderr]   --> src/math/matrix/matrix2.rs:35:18
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for n in 0..3 {
[INFO] [stderr]    |                  ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for (n, <item>) in columns.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr] 28 | |         Matrix3 {
[INFO] [stderr] 29 | |             data: [
[INFO] [stderr] 30 | |                 [a, b, c],
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is used to index `columns`
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for n in 0..3 {
[INFO] [stderr]    |                  ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for (n, <item>) in columns.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix2.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         return mat
[INFO] [stderr]    |         ^^^^^^^^^^ help: remove `return` as shown: `mat`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix2.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         return Vector2::new_from(
[INFO] [stderr] 54 | |             self.data[0][0] * other.x + self.data[0][1] * other.y,
[INFO] [stderr] 55 | |             self.data[1][0] * other.x + self.data[1][1] * other.y
[INFO] [stderr] 56 | |         )
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 53 |         Vector2::new_from(
[INFO] [stderr] 54 |             self.data[0][0] * other.x + self.data[0][1] * other.y,
[INFO] [stderr] 55 |             self.data[1][0] * other.x + self.data[1][1] * other.y
[INFO] [stderr] 56 |         )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 |         return mat
[INFO] [stderr]    |         ^^^^^^^^^^ help: remove `return` as shown: `mat`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return Vector2::new_from(homogenous.x, homogenous.y)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector2::new_from(homogenous.x, homogenous.y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 | /         return Vector3::new_from(
[INFO] [stderr] 65 | |             self.data[0][0] * other.x + self.data[0][1] * other.y + self.data[0][2] * other.z,
[INFO] [stderr] 66 | |             self.data[1][0] * other.x + self.data[1][1] * other.y + self.data[1][2] * other.z,
[INFO] [stderr] 67 | |             self.data[2][0] * other.x + self.data[2][1] * other.y + self.data[2][2] * other.z
[INFO] [stderr] 68 | |         )
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 64 |         Vector3::new_from(
[INFO] [stderr] 65 |             self.data[0][0] * other.x + self.data[0][1] * other.y + self.data[0][2] * other.z,
[INFO] [stderr] 66 |             self.data[1][0] * other.x + self.data[1][1] * other.y + self.data[1][2] * other.z,
[INFO] [stderr] 67 |             self.data[2][0] * other.x + self.data[2][1] * other.y + self.data[2][2] * other.z
[INFO] [stderr] 68 |         )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:98:9
[INFO] [stderr]    |
[INFO] [stderr] 98 |         return det_a - det_b + det_c
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `det_a - det_b + det_c`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is used to index `columns`
[INFO] [stderr]   --> src/math/matrix/matrix2.rs:35:18
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for n in 0..3 {
[INFO] [stderr]    |                  ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for (n, <item>) in columns.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/math/matrix/matrix2.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     assert_eq!(mat2.determinant(), 3.);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/math/matrix/matrix2.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     assert_eq!(mat2.determinant(), 3.);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new_from(a: f64, b: f64, c: f64, d: f64, e: f64, f: f64, g: f64, h: f64, i: f64) -> Matrix3 {
[INFO] [stderr] 28 | |         Matrix3 {
[INFO] [stderr] 29 | |             data: [
[INFO] [stderr] 30 | |                 [a, b, c],
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is used to index `columns`
[INFO] [stderr]   --> src/math/matrix/matrix3.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for n in 0..3 {
[INFO] [stderr]    |                  ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for (n, <item>) in columns.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math/matrix/matrix3.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     assert_eq!(mat3.determinant(), 4.);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math/matrix/matrix3.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     assert_eq!(mat3.determinant(), 4.);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mathbox`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "5610433a3225b10a69d1d37f4ad21e78adba18be05759b2fbd1f5b0d4e68c766"`
[INFO] running `"docker" "rm" "-f" "5610433a3225b10a69d1d37f4ad21e78adba18be05759b2fbd1f5b0d4e68c766"`
[INFO] [stdout] 5610433a3225b10a69d1d37f4ad21e78adba18be05759b2fbd1f5b0d4e68c766