[INFO] updating cached repository tomo3110/backupfs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tomo3110/backupfs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tomo3110/backupfs" "work/ex/clippy-test-run/sources/stable/gh/tomo3110/backupfs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomo3110/backupfs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tomo3110/backupfs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomo3110/backupfs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomo3110/backupfs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 08e3a5dcf257bb1e6ad1f422ce0c2e29ab499bef [INFO] sha for GitHub repo tomo3110/backupfs: 08e3a5dcf257bb1e6ad1f422ce0c2e29ab499bef [INFO] validating manifest of tomo3110/backupfs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tomo3110/backupfs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tomo3110/backupfs [INFO] finished frobbing tomo3110/backupfs [INFO] frobbed toml for tomo3110/backupfs written to work/ex/clippy-test-run/sources/stable/gh/tomo3110/backupfs/Cargo.toml [INFO] started frobbing tomo3110/backupfs [INFO] finished frobbing tomo3110/backupfs [INFO] frobbed toml for tomo3110/backupfs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomo3110/backupfs/Cargo.toml [INFO] crate tomo3110/backupfs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tomo3110/backupfs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tomo3110/backupfs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d29cef24d47e786d2862b3648161c2d57de63d1dde27391ca027a6c9daf512be [INFO] running `"docker" "start" "-a" "d29cef24d47e786d2862b3648161c2d57de63d1dde27391ca027a6c9daf512be"` [INFO] [stderr] Compiling serde v1.0.78 [INFO] [stderr] Checking podio v0.1.6 [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.3 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Checking miniz_oxide v0.1.3 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking ctrlc v3.1.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling serde_derive v1.0.78 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking filedb v0.1.1 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking backupfs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hash/mod.rs:34:57 [INFO] [stderr] | [INFO] [stderr] 34 | let created: DateTime = info.created().unwrap_or(SystemTime::now()).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| SystemTime::now())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hash/mod.rs:35:59 [INFO] [stderr] | [INFO] [stderr] 35 | let modified: DateTime = info.modified().unwrap_or(SystemTime::now()).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| SystemTime::now())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/result.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / fn description<'a>(&'a self) -> &'a str { [INFO] [stderr] 49 | | match *self { [INFO] [stderr] 50 | | Error::FileDB(_) => "", [INFO] [stderr] 51 | | Error::Io(ref err) => err.description(), [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hash/mod.rs:34:57 [INFO] [stderr] | [INFO] [stderr] 34 | let created: DateTime = info.created().unwrap_or(SystemTime::now()).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| SystemTime::now())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hash/mod.rs:35:59 [INFO] [stderr] | [INFO] [stderr] 35 | let modified: DateTime = info.modified().unwrap_or(SystemTime::now()).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| SystemTime::now())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/result.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / fn description<'a>(&'a self) -> &'a str { [INFO] [stderr] 49 | | match *self { [INFO] [stderr] 50 | | Error::FileDB(_) => "", [INFO] [stderr] 51 | | Error::Io(ref err) => err.description(), [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: field is never used: `config_path` [INFO] [stderr] --> src/bin/client.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | config_path: PathBuf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/bin/client.rs:118:29 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn to_absolute_path(current_dir: PathBuf, some_path: PathBuf) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/client.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | .map(|s| PathBuf::from(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: field is never used: `args` [INFO] [stderr] --> src/bin/deamon.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | args: ArgMatches<'static>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: field is never used: `config_path` [INFO] [stderr] --> src/bin/client.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | config_path: PathBuf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/deamon.rs:97:46 [INFO] [stderr] | [INFO] [stderr] 97 | cmap.entry(path_item.path()).or_insert(path_item.hash()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| path_item.hash())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/bin/client.rs:118:29 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn to_absolute_path(current_dir: PathBuf, some_path: PathBuf) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/client.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | .map(|s| PathBuf::from(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/deamon.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match res { [INFO] [stderr] 158 | | Err(err) => error!("{:?}", err), [INFO] [stderr] 159 | | _ => {} [INFO] [stderr] 160 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = res { error!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bin/deamon.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | if let Ok(_) = exit_receiver.try_recv() { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 174 | | return self.save(); [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____________- help: try this: `if exit_receiver.try_recv().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: field is never used: `args` [INFO] [stderr] --> src/bin/deamon.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | args: ArgMatches<'static>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/deamon.rs:97:46 [INFO] [stderr] | [INFO] [stderr] 97 | cmap.entry(path_item.path()).or_insert(path_item.hash()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| path_item.hash())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/deamon.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match res { [INFO] [stderr] 158 | | Err(err) => error!("{:?}", err), [INFO] [stderr] 159 | | _ => {} [INFO] [stderr] 160 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = res { error!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bin/deamon.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | if let Ok(_) = exit_receiver.try_recv() { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 174 | | return self.save(); [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____________- help: try this: `if exit_receiver.try_recv().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 59.36s [INFO] running `"docker" "inspect" "d29cef24d47e786d2862b3648161c2d57de63d1dde27391ca027a6c9daf512be"` [INFO] running `"docker" "rm" "-f" "d29cef24d47e786d2862b3648161c2d57de63d1dde27391ca027a6c9daf512be"` [INFO] [stdout] d29cef24d47e786d2862b3648161c2d57de63d1dde27391ca027a6c9daf512be