[INFO] updating cached repository tomhosking/MarkovTrump [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tomhosking/MarkovTrump [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tomhosking/MarkovTrump" "work/ex/clippy-test-run/sources/stable/gh/tomhosking/MarkovTrump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomhosking/MarkovTrump'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tomhosking/MarkovTrump" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomhosking/MarkovTrump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomhosking/MarkovTrump'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 768c8f21f6edbc9a2ef3e0b1ab88a1041a2805f5 [INFO] sha for GitHub repo tomhosking/MarkovTrump: 768c8f21f6edbc9a2ef3e0b1ab88a1041a2805f5 [INFO] validating manifest of tomhosking/MarkovTrump on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tomhosking/MarkovTrump on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tomhosking/MarkovTrump [INFO] finished frobbing tomhosking/MarkovTrump [INFO] frobbed toml for tomhosking/MarkovTrump written to work/ex/clippy-test-run/sources/stable/gh/tomhosking/MarkovTrump/Cargo.toml [INFO] started frobbing tomhosking/MarkovTrump [INFO] finished frobbing tomhosking/MarkovTrump [INFO] frobbed toml for tomhosking/MarkovTrump written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomhosking/MarkovTrump/Cargo.toml [INFO] crate tomhosking/MarkovTrump has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tomhosking/MarkovTrump against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tomhosking/MarkovTrump:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1589e06d4428e66b9b9a8272b53d4f67cc40581697e89a250662f055f801ebf7 [INFO] running `"docker" "start" "-a" "1589e06d4428e66b9b9a8272b53d4f67cc40581697e89a250662f055f801ebf7"` [INFO] [stderr] Checking serde v1.0.11 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking generator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return tweet; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `tweet` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return tweet; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `tweet` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:34:46 [INFO] [stderr] | [INFO] [stderr] 34 | fn learn(probs: &mut TransferMatrix, tweets: &TweetData) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:34:46 [INFO] [stderr] | [INFO] [stderr] 34 | fn learn(probs: &mut TransferMatrix, tweets: &TweetData) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | sentences.push(s.into()); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:64:30 [INFO] [stderr] | [INFO] [stderr] 64 | for (i,w) in s.split(" ").enumerate() [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | let total_count = result_count.get(&key.0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result_count[&key.0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/main.rs:122:50 [INFO] [stderr] | [INFO] [stderr] 122 | .map(|name: &String | name.len()) [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 123 | | .fold(0, |acc, len| acc + len ); [INFO] [stderr] | |______________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | sentences.push(s.into()); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:64:30 [INFO] [stderr] | [INFO] [stderr] 64 | for (i,w) in s.split(" ").enumerate() [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | let total_count = result_count.get(&key.0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result_count[&key.0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/main.rs:122:50 [INFO] [stderr] | [INFO] [stderr] 122 | .map(|name: &String | name.len()) [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 123 | | .fold(0, |acc, len| acc + len ); [INFO] [stderr] | |______________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.72s [INFO] running `"docker" "inspect" "1589e06d4428e66b9b9a8272b53d4f67cc40581697e89a250662f055f801ebf7"` [INFO] running `"docker" "rm" "-f" "1589e06d4428e66b9b9a8272b53d4f67cc40581697e89a250662f055f801ebf7"` [INFO] [stdout] 1589e06d4428e66b9b9a8272b53d4f67cc40581697e89a250662f055f801ebf7