[INFO] updating cached repository tomc1998/rust-lmc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tomc1998/rust-lmc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tomc1998/rust-lmc" "work/ex/clippy-test-run/sources/stable/gh/tomc1998/rust-lmc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomc1998/rust-lmc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tomc1998/rust-lmc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomc1998/rust-lmc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomc1998/rust-lmc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1827800f48ac1edaac36c7b39df35029b129508a
[INFO] sha for GitHub repo tomc1998/rust-lmc: 1827800f48ac1edaac36c7b39df35029b129508a
[INFO] validating manifest of tomc1998/rust-lmc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tomc1998/rust-lmc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tomc1998/rust-lmc
[INFO] finished frobbing tomc1998/rust-lmc
[INFO] frobbed toml for tomc1998/rust-lmc written to work/ex/clippy-test-run/sources/stable/gh/tomc1998/rust-lmc/Cargo.toml
[INFO] started frobbing tomc1998/rust-lmc
[INFO] finished frobbing tomc1998/rust-lmc
[INFO] frobbed toml for tomc1998/rust-lmc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomc1998/rust-lmc/Cargo.toml
[INFO] crate tomc1998/rust-lmc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tomc1998/rust-lmc against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tomc1998/rust-lmc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] af2dace2db5e82ad9fd0acf0536814b931feb6161c07398529bc6e4574d0ecae
[INFO] running `"docker" "start" "-a" "af2dace2db5e82ad9fd0acf0536814b931feb6161c07398529bc6e4574d0ecae"`
[INFO] [stderr]     Checking lmc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assembler/lexer.rs:40:58
[INFO] [stderr]    |
[INFO] [stderr] 40 |   src_line = SrcLine{op: "", operand: None, label: None, lnum: lnum};
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: replace it with: `lnum`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assembler/parser.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         loc: loc,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `loc`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]  --> src/main.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     println!("");
[INFO] [stderr]   |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assembler/lexer.rs:40:58
[INFO] [stderr]    |
[INFO] [stderr] 40 |   src_line = SrcLine{op: "", operand: None, label: None, lnum: lnum};
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: replace it with: `lnum`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assembler/parser.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         loc: loc,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `loc`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]  --> src/main.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     println!("");
[INFO] [stderr]   |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lmc.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lmc.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 |     return self.execute();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.execute()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/io.rs:8:3
[INFO] [stderr]   |
[INFO] [stderr] 8 |   return Ok(buffer);
[INFO] [stderr]   |   ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/assembler/lexer.rs:14:19
[INFO] [stderr]    |
[INFO] [stderr] 14 | const OP_CODES: [&'static str; 10] = ["ADD", "SUB", "LDA", "STO", "BR", "BRZ", "BRP", "IN", "OUT", "HLT"];
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/lexer.rs:23:3
[INFO] [stderr]    |
[INFO] [stderr] 23 |   return false;
[INFO] [stderr]    |   ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/lexer.rs:63:3
[INFO] [stderr]    |
[INFO] [stderr] 63 |   return Ok(Some(src_line));
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(src_line))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/lexer.rs:89:3
[INFO] [stderr]    |
[INFO] [stderr] 89 |   return Ok(token_list);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(token_list)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/parser.rs:26:3
[INFO] [stderr]    |
[INFO] [stderr] 26 |   return labels;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `labels`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/parser.rs:98:3
[INFO] [stderr]    |
[INFO] [stderr] 98 |   return Ok(operations);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(operations)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/assembler/parser.rs:107:3
[INFO] [stderr]     |
[INFO] [stderr] 107 |   return ops;
[INFO] [stderr]     |   ^^^^^^^^^^^ help: remove `return` as shown: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/mod.rs:28:3
[INFO] [stderr]    |
[INFO] [stderr] 28 |   return true;
[INFO] [stderr]    |   ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lmc.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lmc.rs:61:11
[INFO] [stderr]    |
[INFO] [stderr] 61 |           self.acc = self.acc % 1000;
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.acc %= 1000`
[INFO] [stderr]    |
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lmc.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 |     return self.execute();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.execute()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/io.rs:8:3
[INFO] [stderr]   |
[INFO] [stderr] 8 |   return Ok(buffer);
[INFO] [stderr]   |   ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)`
[INFO] [stderr]   |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/assembler/lexer.rs:14:19
[INFO] [stderr]    |
[INFO] [stderr] 14 | const OP_CODES: [&'static str; 10] = ["ADD", "SUB", "LDA", "STO", "BR", "BRZ", "BRP", "IN", "OUT", "HLT"];
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/lexer.rs:23:3
[INFO] [stderr]    |
[INFO] [stderr] 23 |   return false;
[INFO] [stderr]    |   ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/lexer.rs:63:3
[INFO] [stderr]    |
[INFO] [stderr] 63 |   return Ok(Some(src_line));
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(src_line))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/lexer.rs:89:3
[INFO] [stderr]    |
[INFO] [stderr] 89 |   return Ok(token_list);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(token_list)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/parser.rs:26:3
[INFO] [stderr]    |
[INFO] [stderr] 26 |   return labels;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `labels`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/parser.rs:98:3
[INFO] [stderr]    |
[INFO] [stderr] 98 |   return Ok(operations);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(operations)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/assembler/parser.rs:107:3
[INFO] [stderr]     |
[INFO] [stderr] 107 |   return ops;
[INFO] [stderr]     |   ^^^^^^^^^^^ help: remove `return` as shown: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/mod.rs:28:3
[INFO] [stderr]    |
[INFO] [stderr] 28 |   return true;
[INFO] [stderr]    |   ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/io.rs:23:8
[INFO] [stderr]    |
[INFO] [stderr] 23 |     if !res.is_ok() {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/assembler/lexer.rs:29:45
[INFO] [stderr]    |
[INFO] [stderr] 29 |   let comment_split: Vec<&str> = line.split("#").collect();
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/assembler/lexer.rs:33:6
[INFO] [stderr]    |
[INFO] [stderr] 33 |   if lexemes.len() == 0 {
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lexemes.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/assembler/lexer.rs:77:8
[INFO] [stderr]    |
[INFO] [stderr] 77 |     if !line_lex_res.is_ok() {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^ help: try: `line_lex_res.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `line_num` is used as a loop counter. Consider using `for (line_num, item) in source.lines().enumerate()` or similar iterators
[INFO] [stderr]   --> src/assembler/lexer.rs:73:15
[INFO] [stderr]    |
[INFO] [stderr] 73 |   for line in source.lines() {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `loc` is used as a loop counter. Consider using `for (loc, item) in &(token_list.tokens).enumerate()` or similar iterators
[INFO] [stderr]   --> src/assembler/parser.rs:17:12
[INFO] [stderr]    |
[INFO] [stderr] 17 |   for t in &(token_list.tokens) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/parser.rs:32:51
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn op_pass(token_list: &lexer::TokenList, labels: &Vec<Label>) -> Result<Vec<Operation>, String> {
[INFO] [stderr]    |                                                   ^^^^^^^^^^^ help: change this to: `&[Label]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/assembler/parser.rs:88:29
[INFO] [stderr]    |
[INFO] [stderr] 88 |           curr_op.operand = l.loc as u16;
[INFO] [stderr]    |                             ^^^^^^^^^^^^ help: try: `u16::from(l.loc)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/assembler/code_gen.rs:4:24
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn gen(operations: &Vec<parser::Operation>, lmc: &mut lmc::LMC) {
[INFO] [stderr]   |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[parser::Operation]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/assembler/code_gen.rs:13:11
[INFO] [stderr]    |
[INFO] [stderr] 13 |     val = (o.op_code as u16)*100 + o.operand as u16;
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(o.op_code)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/assembler/mod.rs:14:6
[INFO] [stderr]    |
[INFO] [stderr] 14 |   if !token_list_res.is_ok() {
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `token_list_res.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/assembler/mod.rs:21:6
[INFO] [stderr]    |
[INFO] [stderr] 21 |   if !operations_res.is_ok() {
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operations_res.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/assembler/mod.rs:15:41
[INFO] [stderr]    |
[INFO] [stderr] 15 |     println!("{}", token_list_res.err().unwrap_or("".to_string()));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/assembler/mod.rs:22:41
[INFO] [stderr]    |
[INFO] [stderr] 22 |     println!("{}", operations_res.err().unwrap_or("".to_string()));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lmc.rs:61:11
[INFO] [stderr]    |
[INFO] [stderr] 61 |           self.acc = self.acc % 1000;
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.acc %= 1000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/io.rs:23:8
[INFO] [stderr]    |
[INFO] [stderr] 23 |     if !res.is_ok() {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/assembler/lexer.rs:29:45
[INFO] [stderr]    |
[INFO] [stderr] 29 |   let comment_split: Vec<&str> = line.split("#").collect();
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/assembler/lexer.rs:33:6
[INFO] [stderr]    |
[INFO] [stderr] 33 |   if lexemes.len() == 0 {
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lexemes.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/assembler/lexer.rs:77:8
[INFO] [stderr]    |
[INFO] [stderr] 77 |     if !line_lex_res.is_ok() {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^ help: try: `line_lex_res.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `line_num` is used as a loop counter. Consider using `for (line_num, item) in source.lines().enumerate()` or similar iterators
[INFO] [stderr]   --> src/assembler/lexer.rs:73:15
[INFO] [stderr]    |
[INFO] [stderr] 73 |   for line in source.lines() {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `loc` is used as a loop counter. Consider using `for (loc, item) in &(token_list.tokens).enumerate()` or similar iterators
[INFO] [stderr]   --> src/assembler/parser.rs:17:12
[INFO] [stderr]    |
[INFO] [stderr] 17 |   for t in &(token_list.tokens) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/parser.rs:32:51
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn op_pass(token_list: &lexer::TokenList, labels: &Vec<Label>) -> Result<Vec<Operation>, String> {
[INFO] [stderr]    |                                                   ^^^^^^^^^^^ help: change this to: `&[Label]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/assembler/parser.rs:88:29
[INFO] [stderr]    |
[INFO] [stderr] 88 |           curr_op.operand = l.loc as u16;
[INFO] [stderr]    |                             ^^^^^^^^^^^^ help: try: `u16::from(l.loc)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/assembler/code_gen.rs:4:24
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn gen(operations: &Vec<parser::Operation>, lmc: &mut lmc::LMC) {
[INFO] [stderr]   |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[parser::Operation]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/assembler/code_gen.rs:13:11
[INFO] [stderr]    |
[INFO] [stderr] 13 |     val = (o.op_code as u16)*100 + o.operand as u16;
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(o.op_code)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/assembler/mod.rs:14:6
[INFO] [stderr]    |
[INFO] [stderr] 14 |   if !token_list_res.is_ok() {
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `token_list_res.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/assembler/mod.rs:21:6
[INFO] [stderr]    |
[INFO] [stderr] 21 |   if !operations_res.is_ok() {
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operations_res.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/assembler/mod.rs:15:41
[INFO] [stderr]    |
[INFO] [stderr] 15 |     println!("{}", token_list_res.err().unwrap_or("".to_string()));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/assembler/mod.rs:22:41
[INFO] [stderr]    |
[INFO] [stderr] 22 |     println!("{}", operations_res.err().unwrap_or("".to_string()));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.88s
[INFO] running `"docker" "inspect" "af2dace2db5e82ad9fd0acf0536814b931feb6161c07398529bc6e4574d0ecae"`
[INFO] running `"docker" "rm" "-f" "af2dace2db5e82ad9fd0acf0536814b931feb6161c07398529bc6e4574d0ecae"`
[INFO] [stdout] af2dace2db5e82ad9fd0acf0536814b931feb6161c07398529bc6e4574d0ecae