[INFO] updating cached repository tomarrell/rust-cli-table
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tomarrell/rust-cli-table
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tomarrell/rust-cli-table" "work/ex/clippy-test-run/sources/stable/gh/tomarrell/rust-cli-table"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomarrell/rust-cli-table'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tomarrell/rust-cli-table" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomarrell/rust-cli-table"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomarrell/rust-cli-table'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 67321d9a1a1f03c22b7bddc107caf6d2dc8d578d
[INFO] sha for GitHub repo tomarrell/rust-cli-table: 67321d9a1a1f03c22b7bddc107caf6d2dc8d578d
[INFO] validating manifest of tomarrell/rust-cli-table on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tomarrell/rust-cli-table on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tomarrell/rust-cli-table
[INFO] finished frobbing tomarrell/rust-cli-table
[INFO] frobbed toml for tomarrell/rust-cli-table written to work/ex/clippy-test-run/sources/stable/gh/tomarrell/rust-cli-table/Cargo.toml
[INFO] started frobbing tomarrell/rust-cli-table
[INFO] finished frobbing tomarrell/rust-cli-table
[INFO] frobbed toml for tomarrell/rust-cli-table written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomarrell/rust-cli-table/Cargo.toml
[INFO] crate tomarrell/rust-cli-table has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tomarrell/rust-cli-table against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tomarrell/rust-cli-table:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dbee4b9f204ce3e2f9d60e95f0762ac51a44c72b38aa41fda7d879697fd7acf0
[INFO] running `"docker" "start" "-a" "dbee4b9f204ce3e2f9d60e95f0762ac51a44c72b38aa41fda7d879697fd7acf0"`
[INFO] [stderr]     Checking cli-table v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/csv.rs:5:1
[INFO] [stderr]    |
[INFO] [stderr] 5  | / pub fn parse<'a>(input: &'a str) -> Result<CsvType, Box<Error>> {
[INFO] [stderr] 6  | |     let lines = input.trim().split("\n");
[INFO] [stderr] 7  | |
[INFO] [stderr] 8  | |     let csv: Vec<Vec<&str>> = lines
[INFO] [stderr] ...  |
[INFO] [stderr] 12 | |     Ok(csv)
[INFO] [stderr] 13 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/csv.rs:6:36
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let lines = input.trim().split("\n");
[INFO] [stderr]   |                                    ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/render.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 |         .split("\n")
[INFO] [stderr]    |                ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match line {
[INFO] [stderr] 24 | |             Ok(x) => {
[INFO] [stderr] 25 | |                 buffer.push_str(&format!("{}\n", &x));
[INFO] [stderr] 26 | |             }
[INFO] [stderr] 27 | |             // Add better error handling
[INFO] [stderr] 28 | |             Err(_) => (),
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 |         if let Ok(x) = line {
[INFO] [stderr] 24 |     buffer.push_str(&format!("{}\n", &x));
[INFO] [stderr] 25 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         Err(_) => panic!("Failed to parse stdin CSV"),
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/main.rs:53:21
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn max_column_width<'a>(table: CsvType) -> Vec<usize> {
[INFO] [stderr]    |                     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/main.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |             if curr_max_width < &mut item.len() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^---------------
[INFO] [stderr]    |                                 |
[INFO] [stderr]    |                                 help: use the right value directly: `item.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/csv.rs:5:1
[INFO] [stderr]    |
[INFO] [stderr] 5  | / pub fn parse<'a>(input: &'a str) -> Result<CsvType, Box<Error>> {
[INFO] [stderr] 6  | |     let lines = input.trim().split("\n");
[INFO] [stderr] 7  | |
[INFO] [stderr] 8  | |     let csv: Vec<Vec<&str>> = lines
[INFO] [stderr] ...  |
[INFO] [stderr] 12 | |     Ok(csv)
[INFO] [stderr] 13 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/csv.rs:6:36
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let lines = input.trim().split("\n");
[INFO] [stderr]   |                                    ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/render.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 |         .split("\n")
[INFO] [stderr]    |                ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match line {
[INFO] [stderr] 24 | |             Ok(x) => {
[INFO] [stderr] 25 | |                 buffer.push_str(&format!("{}\n", &x));
[INFO] [stderr] 26 | |             }
[INFO] [stderr] 27 | |             // Add better error handling
[INFO] [stderr] 28 | |             Err(_) => (),
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 |         if let Ok(x) = line {
[INFO] [stderr] 24 |     buffer.push_str(&format!("{}\n", &x));
[INFO] [stderr] 25 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         Err(_) => panic!("Failed to parse stdin CSV"),
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/main.rs:53:21
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn max_column_width<'a>(table: CsvType) -> Vec<usize> {
[INFO] [stderr]    |                     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/main.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |             if curr_max_width < &mut item.len() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^---------------
[INFO] [stderr]    |                                 |
[INFO] [stderr]    |                                 help: use the right value directly: `item.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.16s
[INFO] running `"docker" "inspect" "dbee4b9f204ce3e2f9d60e95f0762ac51a44c72b38aa41fda7d879697fd7acf0"`
[INFO] running `"docker" "rm" "-f" "dbee4b9f204ce3e2f9d60e95f0762ac51a44c72b38aa41fda7d879697fd7acf0"`
[INFO] [stdout] dbee4b9f204ce3e2f9d60e95f0762ac51a44c72b38aa41fda7d879697fd7acf0