[INFO] updating cached repository tomaon/ei [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tomaon/ei [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tomaon/ei" "work/ex/clippy-test-run/sources/stable/gh/tomaon/ei"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomaon/ei'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tomaon/ei" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomaon/ei"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomaon/ei'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0fc80b0bc7be3c3504c8321655f022e25b7e24a2 [INFO] sha for GitHub repo tomaon/ei: 0fc80b0bc7be3c3504c8321655f022e25b7e24a2 [INFO] validating manifest of tomaon/ei on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tomaon/ei on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tomaon/ei [INFO] finished frobbing tomaon/ei [INFO] frobbed toml for tomaon/ei written to work/ex/clippy-test-run/sources/stable/gh/tomaon/ei/Cargo.toml [INFO] started frobbing tomaon/ei [INFO] finished frobbing tomaon/ei [INFO] frobbed toml for tomaon/ei written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomaon/ei/Cargo.toml [INFO] crate tomaon/ei has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tomaon/ei against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tomaon/ei:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 38c3f5a65cc16865a437d6015cf5ca2604cfeca09630d16bfa9ee8a8456c7c08 [INFO] running `"docker" "start" "-a" "38c3f5a65cc16865a437d6015cf5ca2604cfeca09630d16bfa9ee8a8456c7c08"` [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking ei v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:13:30 [INFO] [stderr] | [INFO] [stderr] 13 | T::decode(&mut Decoder { r: r }) [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:412:20 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(term::Ref { len: len, node: node, creation: creation, n: n }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:412:30 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(term::Ref { len: len, node: node, creation: creation, n: n }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:412:42 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(term::Ref { len: len, node: node, creation: creation, n: n }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `creation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:412:62 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(term::Ref { len: len, node: node, creation: creation, n: n }) [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | t.encode(&mut Encoder { w: w }) [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:13:30 [INFO] [stderr] | [INFO] [stderr] 13 | T::decode(&mut Decoder { r: r }) [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:412:20 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(term::Ref { len: len, node: node, creation: creation, n: n }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:412:30 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(term::Ref { len: len, node: node, creation: creation, n: n }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:412:42 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(term::Ref { len: len, node: node, creation: creation, n: n }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `creation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:412:62 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(term::Ref { len: len, node: node, creation: creation, n: n }) [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | t.encode(&mut Encoder { w: w }) [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:372:35 [INFO] [stderr] | [INFO] [stderr] 372 | num: try!(r.read_u32()) & 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:373:38 [INFO] [stderr] | [INFO] [stderr] 373 | serial: try!(r.read_u32()) & 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:388:34 [INFO] [stderr] | [INFO] [stderr] 388 | id: try!(r.read_u32()) & 0x0fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:338:30 [INFO] [stderr] | [INFO] [stderr] 338 | try!(w.write_u32(v.num & 0x00007fff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:340:33 [INFO] [stderr] | [INFO] [stderr] 340 | try!(w.write_u32(v.serial & 0x00001fff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:359:29 [INFO] [stderr] | [INFO] [stderr] 359 | try!(w.write_u32(v.id & 0x0fffffff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/fs.rs:6:29 [INFO] [stderr] | [INFO] [stderr] 6 | if let Some(mut path) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:372:35 [INFO] [stderr] | [INFO] [stderr] 372 | num: try!(r.read_u32()) & 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:373:38 [INFO] [stderr] | [INFO] [stderr] 373 | serial: try!(r.read_u32()) & 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:388:34 [INFO] [stderr] | [INFO] [stderr] 388 | id: try!(r.read_u32()) & 0x0fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:483:25 [INFO] [stderr] | [INFO] [stderr] 483 | ( 134217727 as u64, vec![0x62, 0x07,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_727` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:484:25 [INFO] [stderr] | [INFO] [stderr] 484 | ( 134217728 as u64, vec![0x6e, 0x04, 0x00, 0x00,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:485:14 [INFO] [stderr] | [INFO] [stderr] 485 | (18446744073709551615 as u64, vec![0x6e, 0x08, 0x00, 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:503:15 [INFO] [stderr] | [INFO] [stderr] 503 | ( 134217727 as u32, vec![0x62, 0x07,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_727` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:504:15 [INFO] [stderr] | [INFO] [stderr] 504 | ( 134217728 as u32, vec![0x6e, 0x04, 0x00, 0x00,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:505:14 [INFO] [stderr] | [INFO] [stderr] 505 | (4294967295 as u32, vec![0x6e, 0x04, 0x00, 0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:553:15 [INFO] [stderr] | [INFO] [stderr] 553 | (-9223372036854775807 as i64, vec![0x6e, 0x08, 0x01, 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0x7f]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:554:25 [INFO] [stderr] | [INFO] [stderr] 554 | ( -134217729 as i64, vec![0x6e, 0x04, 0x01, 0x01,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_729` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:555:25 [INFO] [stderr] | [INFO] [stderr] 555 | ( -134217728 as i64, vec![0x62, 0xf8,0x00,0x00,0x00]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:561:25 [INFO] [stderr] | [INFO] [stderr] 561 | ( 134217727 as i64, vec![0x62, 0x07,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_727` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:562:25 [INFO] [stderr] | [INFO] [stderr] 562 | ( 134217728 as i64, vec![0x6e, 0x04, 0x00, 0x00,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:563:15 [INFO] [stderr] | [INFO] [stderr] 563 | ( 9223372036854775807 as i64, vec![0x6e, 0x08, 0x00, 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0x7f]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:579:15 [INFO] [stderr] | [INFO] [stderr] 579 | (-2147483647 as i32, vec![0x6e, 0x04, 0x01, 0xff,0xff,0xff,0x7f]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:580:16 [INFO] [stderr] | [INFO] [stderr] 580 | ( -134217729 as i32, vec![0x6e, 0x04, 0x01, 0x01,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_729` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:581:16 [INFO] [stderr] | [INFO] [stderr] 581 | ( -134217728 as i32, vec![0x62, 0xf8,0x00,0x00,0x00]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:587:16 [INFO] [stderr] | [INFO] [stderr] 587 | ( 134217727 as i32, vec![0x62, 0x07,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_727` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:588:16 [INFO] [stderr] | [INFO] [stderr] 588 | ( 134217728 as i32, vec![0x6e, 0x04, 0x00, 0x00,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:589:15 [INFO] [stderr] | [INFO] [stderr] 589 | ( 2147483647 as i32, vec![0x6e, 0x04, 0x00, 0xff,0xff,0xff,0x7f]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:737:30 [INFO] [stderr] | [INFO] [stderr] 737 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:738:33 [INFO] [stderr] | [INFO] [stderr] 738 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:739:35 [INFO] [stderr] | [INFO] [stderr] 739 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:752:30 [INFO] [stderr] | [INFO] [stderr] 752 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:753:33 [INFO] [stderr] | [INFO] [stderr] 753 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:754:35 [INFO] [stderr] | [INFO] [stderr] 754 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:780:30 [INFO] [stderr] | [INFO] [stderr] 780 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:781:33 [INFO] [stderr] | [INFO] [stderr] 781 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:782:35 [INFO] [stderr] | [INFO] [stderr] 782 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:797:30 [INFO] [stderr] | [INFO] [stderr] 797 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:798:33 [INFO] [stderr] | [INFO] [stderr] 798 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:799:35 [INFO] [stderr] | [INFO] [stderr] 799 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:828:30 [INFO] [stderr] | [INFO] [stderr] 828 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:829:33 [INFO] [stderr] | [INFO] [stderr] 829 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:830:35 [INFO] [stderr] | [INFO] [stderr] 830 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:834:30 [INFO] [stderr] | [INFO] [stderr] 834 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:835:33 [INFO] [stderr] | [INFO] [stderr] 835 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:836:35 [INFO] [stderr] | [INFO] [stderr] 836 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:850:30 [INFO] [stderr] | [INFO] [stderr] 850 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:851:33 [INFO] [stderr] | [INFO] [stderr] 851 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:852:35 [INFO] [stderr] | [INFO] [stderr] 852 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:856:30 [INFO] [stderr] | [INFO] [stderr] 856 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:857:33 [INFO] [stderr] | [INFO] [stderr] 857 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:858:35 [INFO] [stderr] | [INFO] [stderr] 858 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:893:26 [INFO] [stderr] | [INFO] [stderr] 893 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:894:29 [INFO] [stderr] | [INFO] [stderr] 894 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:895:31 [INFO] [stderr] | [INFO] [stderr] 895 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:906:26 [INFO] [stderr] | [INFO] [stderr] 906 | num: 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:907:29 [INFO] [stderr] | [INFO] [stderr] 907 | serial: 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:908:31 [INFO] [stderr] | [INFO] [stderr] 908 | creation: 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:927:25 [INFO] [stderr] | [INFO] [stderr] 927 | id: 0x0fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:928:31 [INFO] [stderr] | [INFO] [stderr] 928 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:938:25 [INFO] [stderr] | [INFO] [stderr] 938 | id: 0x0fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:939:31 [INFO] [stderr] | [INFO] [stderr] 939 | creation: 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:338:30 [INFO] [stderr] | [INFO] [stderr] 338 | try!(w.write_u32(v.num & 0x00007fff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:340:33 [INFO] [stderr] | [INFO] [stderr] 340 | try!(w.write_u32(v.serial & 0x00001fff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:359:29 [INFO] [stderr] | [INFO] [stderr] 359 | try!(w.write_u32(v.id & 0x0fffffff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:460:25 [INFO] [stderr] | [INFO] [stderr] 460 | ( 134217727 as u64, vec![0x62, 0x07,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_727` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:461:25 [INFO] [stderr] | [INFO] [stderr] 461 | ( 134217728 as u64, vec![0x6e, 0x04, 0x00, 0x00,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:462:14 [INFO] [stderr] | [INFO] [stderr] 462 | (18446744073709551615 as u64, vec![0x6e, 0x08, 0x00, 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:476:15 [INFO] [stderr] | [INFO] [stderr] 476 | ( 134217727 as u32, vec![0x62, 0x07,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_727` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:477:15 [INFO] [stderr] | [INFO] [stderr] 477 | ( 134217728 as u32, vec![0x6e, 0x04, 0x00, 0x00,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:478:14 [INFO] [stderr] | [INFO] [stderr] 478 | (4294967295 as u32, vec![0x6e, 0x04, 0x00, 0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:514:15 [INFO] [stderr] | [INFO] [stderr] 514 | (-9223372036854775807 as i64, vec![0x6e, 0x08, 0x01, 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0x7f]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:515:25 [INFO] [stderr] | [INFO] [stderr] 515 | ( -134217729 as i64, vec![0x6e, 0x04, 0x01, 0x01,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_729` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | ( -134217728 as i64, vec![0x62, 0xf8,0x00,0x00,0x00]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:522:25 [INFO] [stderr] | [INFO] [stderr] 522 | ( 134217727 as i64, vec![0x62, 0x07,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_727` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:523:25 [INFO] [stderr] | [INFO] [stderr] 523 | ( 134217728 as i64, vec![0x6e, 0x04, 0x00, 0x00,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:524:15 [INFO] [stderr] | [INFO] [stderr] 524 | ( 9223372036854775807 as i64, vec![0x6e, 0x08, 0x00, 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0x7f]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:530:15 [INFO] [stderr] | [INFO] [stderr] 530 | (-9223372036854775808 as i64, vec![0x6e, 0x08, 0x01, 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x80]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:540:15 [INFO] [stderr] | [INFO] [stderr] 540 | (-2147483647 as i32, vec![0x6e, 0x04, 0x01, 0xff,0xff,0xff,0x7f]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:541:16 [INFO] [stderr] | [INFO] [stderr] 541 | ( -134217729 as i32, vec![0x6e, 0x04, 0x01, 0x01,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_729` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:542:16 [INFO] [stderr] | [INFO] [stderr] 542 | ( -134217728 as i32, vec![0x62, 0xf8,0x00,0x00,0x00]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:548:16 [INFO] [stderr] | [INFO] [stderr] 548 | ( 134217727 as i32, vec![0x62, 0x07,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_727` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:549:16 [INFO] [stderr] | [INFO] [stderr] 549 | ( 134217728 as i32, vec![0x6e, 0x04, 0x00, 0x00,0x00,0x00,0x08]), [INFO] [stderr] | ^^^^^^^^^ help: consider: `134_217_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:550:15 [INFO] [stderr] | [INFO] [stderr] 550 | ( 2147483647 as i32, vec![0x6e, 0x04, 0x00, 0xff,0xff,0xff,0x7f]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:556:15 [INFO] [stderr] | [INFO] [stderr] 556 | (-2147483648 as i32, vec![0x6e, 0x04, 0x01, 0x00,0x00,0x00,0x80]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:705:30 [INFO] [stderr] | [INFO] [stderr] 705 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:706:33 [INFO] [stderr] | [INFO] [stderr] 706 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:707:35 [INFO] [stderr] | [INFO] [stderr] 707 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:720:30 [INFO] [stderr] | [INFO] [stderr] 720 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:721:33 [INFO] [stderr] | [INFO] [stderr] 721 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:722:35 [INFO] [stderr] | [INFO] [stderr] 722 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:748:30 [INFO] [stderr] | [INFO] [stderr] 748 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:749:33 [INFO] [stderr] | [INFO] [stderr] 749 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:750:35 [INFO] [stderr] | [INFO] [stderr] 750 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:765:30 [INFO] [stderr] | [INFO] [stderr] 765 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:766:33 [INFO] [stderr] | [INFO] [stderr] 766 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:767:35 [INFO] [stderr] | [INFO] [stderr] 767 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:796:30 [INFO] [stderr] | [INFO] [stderr] 796 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:797:33 [INFO] [stderr] | [INFO] [stderr] 797 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:798:35 [INFO] [stderr] | [INFO] [stderr] 798 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:802:30 [INFO] [stderr] | [INFO] [stderr] 802 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:803:33 [INFO] [stderr] | [INFO] [stderr] 803 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:804:35 [INFO] [stderr] | [INFO] [stderr] 804 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:818:30 [INFO] [stderr] | [INFO] [stderr] 818 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:819:33 [INFO] [stderr] | [INFO] [stderr] 819 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:820:35 [INFO] [stderr] | [INFO] [stderr] 820 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:824:30 [INFO] [stderr] | [INFO] [stderr] 824 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:825:33 [INFO] [stderr] | [INFO] [stderr] 825 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:826:35 [INFO] [stderr] | [INFO] [stderr] 826 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:862:26 [INFO] [stderr] | [INFO] [stderr] 862 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:863:29 [INFO] [stderr] | [INFO] [stderr] 863 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:864:31 [INFO] [stderr] | [INFO] [stderr] 864 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:875:26 [INFO] [stderr] | [INFO] [stderr] 875 | num: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:876:29 [INFO] [stderr] | [INFO] [stderr] 876 | serial: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:877:31 [INFO] [stderr] | [INFO] [stderr] 877 | creation: 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:897:25 [INFO] [stderr] | [INFO] [stderr] 897 | id: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:898:31 [INFO] [stderr] | [INFO] [stderr] 898 | creation: 0x00000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:908:25 [INFO] [stderr] | [INFO] [stderr] 908 | id: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:909:31 [INFO] [stderr] | [INFO] [stderr] 909 | creation: 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | (18446744073709551615 as u64, vec![0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:203:18 [INFO] [stderr] | [INFO] [stderr] 203 | (4294967295 as u32, vec![0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | (-9223372036854775808 as i64, vec![0x80,0x00,0x00,0x00,0x00,0x00,0x00,0x00]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:238:19 [INFO] [stderr] | [INFO] [stderr] 238 | ( 9223372036854775807 as i64, vec![0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:247:19 [INFO] [stderr] | [INFO] [stderr] 247 | (-2147483648 as i32, vec![0x80,0x00,0x00,0x00]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:251:19 [INFO] [stderr] | [INFO] [stderr] 251 | ( 2147483647 as i32, vec![0x7f,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:321:18 [INFO] [stderr] | [INFO] [stderr] 321 | (18446744073709551615 as u64, vec![0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:333:18 [INFO] [stderr] | [INFO] [stderr] 333 | (4294967295 as u32, vec![0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:367:19 [INFO] [stderr] | [INFO] [stderr] 367 | (-9223372036854775808 as i64, vec![0x80,0x00,0x00,0x00,0x00,0x00,0x00,0x00]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:371:19 [INFO] [stderr] | [INFO] [stderr] 371 | ( 9223372036854775807 as i64, vec![0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:381:19 [INFO] [stderr] | [INFO] [stderr] 381 | (-2147483648 as i32, vec![0x80,0x00,0x00,0x00]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net.rs:385:19 [INFO] [stderr] | [INFO] [stderr] 385 | ( 2147483647 as i32, vec![0x7f,0xff,0xff,0xff]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/fs.rs:6:29 [INFO] [stderr] | [INFO] [stderr] 6 | if let Some(mut path) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/connect.rs:9:54 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn accept(stream: &mut net::TcpStream, nodename: &String, cookie: &String) -> Result<(), error::Error>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/connect.rs:9:71 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn accept(stream: &mut net::TcpStream, nodename: &String, cookie: &String) -> Result<(), error::Error>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/connect.rs:15:43 [INFO] [stderr] | [INFO] [stderr] 15 | let our_challenge = md5::digest_u32(&["challenge".as_bytes()]); // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"challenge"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/connect.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for e in vec![ [INFO] [stderr] | ______________^ [INFO] [stderr] 70 | | DFLAG_EXTENDED_REFERENCES, [INFO] [stderr] 71 | | DFLAG_EXTENDED_PIDS_PORTS, [INFO] [stderr] 72 | | ] { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `DFLAG_EXTENDED_REFERENCES` [INFO] [stderr] --> src/connect.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | buf.write_u32(0 [INFO] [stderr] | ___________________^ [INFO] [stderr] 90 | | | DFLAG_EXTENDED_REFERENCES [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:40:72 [INFO] [stderr] | [INFO] [stderr] 40 | Num::U8(u) => Ok(u as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(u)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:49:72 [INFO] [stderr] | [INFO] [stderr] 49 | Num::U8(u) => Ok(u as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | Num::U64(u, 0) if range!(u, u32::MIN, u32::MAX, u64) => Ok(u as u32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | Num::U64(u, 0) if range!(u, u32::MIN, u32::MAX, u64) => Ok(u as u32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:58:72 [INFO] [stderr] | [INFO] [stderr] 58 | Num::U8(u) => Ok(u as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(u16::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | Num::I27(i) if range!(i, u16::MIN, u16::MAX, i32) => Ok(i as u16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(u16::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | Num::I27(i) if range!(i, u16::MIN, u16::MAX, i32) => Ok(i as u16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u16::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:60:31 [INFO] [stderr] | [INFO] [stderr] 60 | Num::U64(u, 0) if range!(u, u16::MIN, u16::MAX, u64) => Ok(u as u16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u16::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:60:31 [INFO] [stderr] | [INFO] [stderr] 60 | Num::U64(u, 0) if range!(u, u16::MIN, u16::MAX, u64) => Ok(u as u16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:78:72 [INFO] [stderr] | [INFO] [stderr] 78 | Num::U8(u) => Ok(u as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:79:72 [INFO] [stderr] | [INFO] [stderr] 79 | Num::I27(i) => Ok(i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/decoder.rs:81:72 [INFO] [stderr] | [INFO] [stderr] 81 | Num::U64(u, 1) if range!(u, u64::MIN, i64::MAX, u64) => Ok(u as i64 * -1), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:88:72 [INFO] [stderr] | [INFO] [stderr] 88 | Num::U8(u) => Ok(u as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | Num::U64(u, 0) if range!(u, u32::MIN, i32::MAX, u64) => Ok(u as i32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | Num::U64(u, 1) if range!(u, u32::MIN, i32::MAX, u64) => Ok(u as i32 * -1), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/decoder.rs:91:72 [INFO] [stderr] | [INFO] [stderr] 91 | Num::U64(u, 1) if range!(u, u32::MIN, i32::MAX, u64) => Ok(u as i32 * -1), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:98:72 [INFO] [stderr] | [INFO] [stderr] 98 | Num::U8(u) => Ok(u as i16), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:99:31 [INFO] [stderr] | [INFO] [stderr] 99 | Num::I27(i) if range!(i, i16::MIN, i16::MAX, i32) => Ok(i as i16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:99:31 [INFO] [stderr] | [INFO] [stderr] 99 | Num::I27(i) if range!(i, i16::MIN, i16::MAX, i32) => Ok(i as i16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u16::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:100:31 [INFO] [stderr] | [INFO] [stderr] 100 | Num::U64(u, 0) if range!(u, u16::MIN, i16::MAX, u64) => Ok(u as i16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | Num::I27(i) if range!(i, i8::MIN, i8::MAX, i32) => Ok(i as i8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(i8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | Num::I27(i) if range!(i, i8::MIN, i8::MAX, i32) => Ok(i as i8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | Num::U64(u, 0) if range!(u, u8::MIN, i8::MAX, u64) => Ok(u as i8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:279:70 [INFO] [stderr] | [INFO] [stderr] 279 | Ok(v.iter().enumerate().fold(0u64, |a,(i,e)| a | (*e as u64) << (i as u32 * 8))) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:374:54 [INFO] [stderr] | [INFO] [stderr] 374 | creation: if t { try!(r.read_u32()) } else { try!(r.read_u8()) as u32 & 0x03 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 374 | creation: if t { try!(r.read_u32()) } else { u32::from(match $ expr { [INFO] [stderr] 375 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 376 | :: Err ( err ) => { [INFO] [stderr] 377 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 378 | $ crate :: convert :: From :: from ( err ) ) } }) & 0x03 }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:389:54 [INFO] [stderr] | [INFO] [stderr] 389 | creation: if t { try!(r.read_u32()) } else { try!(r.read_u8()) as u32 & 0x03 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 389 | creation: if t { try!(r.read_u32()) } else { u32::from(match $ expr { [INFO] [stderr] 390 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 391 | :: Err ( err ) => { [INFO] [stderr] 392 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 393 | $ crate :: convert :: From :: from ( err ) ) } }) & 0x03 }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:405:55 [INFO] [stderr] | [INFO] [stderr] 405 | let creation = if t { try!(r.read_u32()) } else { try!(r.read_u8()) as u32 & 0x03 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 405 | let creation = if t { try!(r.read_u32()) } else { u32::from(match $ expr { [INFO] [stderr] 406 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 407 | :: Err ( err ) => { [INFO] [stderr] 408 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 409 | $ crate :: convert :: From :: from ( err ) ) } }) & 0x03 }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `n`. [INFO] [stderr] --> src/decoder.rs:408:14 [INFO] [stderr] | [INFO] [stderr] 408 | for i in 0 .. len as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 408 | for in n.iter_mut().take(len as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/decoder.rs:422:53 [INFO] [stderr] | [INFO] [stderr] 422 | let decoder: &'a mut Decoder<'a> = unsafe { mem::transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut T as *mut decoder::Decoder<'a>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | u if range!(u, u8::MIN, u8::MAX, u64) => write_u8(self.w, u as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | u if range!(u, u8::MIN, u8::MAX, u64) => write_u8(self.w, u as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | u if range!(u, u32::MIN, i27::MAX, u64) => write_i27(self.w, u as i32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u32::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | u if range!(u, u8::MIN, u8::MAX, u32) => write_u8(self.w, u as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u32::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | u if range!(u, u8::MIN, u8::MAX, u32) => write_u8(self.w, u as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:45:83 [INFO] [stderr] | [INFO] [stderr] 45 | u => write_small_big(self.w, 0, u as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u16::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | u if range!(u, u8::MIN, u8::MAX, u16) => write_u8(self.w, u as u8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u16::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | u if range!(u, u8::MIN, u8::MAX, u16) => write_u8(self.w, u as u8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:52:72 [INFO] [stderr] | [INFO] [stderr] 52 | u => write_i27(self.w, u as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i64::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | i if range!(i, u8::MIN, u8::MAX, i64) => write_u8(self.w, i as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i64::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | i if range!(i, u8::MIN, u8::MAX, i64) => write_u8(self.w, i as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i64::from(i27::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | i if range!(i, i27::MIN, i27::MAX, i64) => write_i27(self.w, i as i32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i64::from(i27::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | i if range!(i, i27::MIN, i27::MAX, i64) => write_i27(self.w, i as i32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | i if range!(i, u8::MIN, u8::MAX, i32) => write_u8(self.w, i as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | i if range!(i, u8::MIN, u8::MAX, i32) => write_u8(self.w, i as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i16::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | i if range!(i, u8::MIN, u8::MAX, i16) => write_u8(self.w, i as u8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i16::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | i if range!(i, u8::MIN, u8::MAX, i16) => write_u8(self.w, i as u8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:87:72 [INFO] [stderr] | [INFO] [stderr] 87 | i => write_i27(self.w, i as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:94:71 [INFO] [stderr] | [INFO] [stderr] 94 | i => write_i27(self.w, i as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/encoder.rs:400:53 [INFO] [stderr] | [INFO] [stderr] 400 | let encoder: &'a mut Encoder<'a> = unsafe { mem::transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut T as *mut encoder::Encoder<'a>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/fs.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | if let Ok(_) = f.read_to_string(&mut buf) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 11 | | return buf; [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____________- help: try this: `if f.read_to_string(&mut buf).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/net.rs:95:50 [INFO] [stderr] | [INFO] [stderr] 95 | self.read_u64().and_then(|u| Ok(unsafe { mem::transmute(u) })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(u)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/net.rs:99:50 [INFO] [stderr] | [INFO] [stderr] 99 | self.read_u32().and_then(|u| Ok(unsafe { mem::transmute(u) })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/handle.rs:13:57 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn handle(stream: &mut net::TcpStream, nodename: &String, mut f: F) -> Result<(), error::Error> [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> examples/calc_pi.rs:10:8 [INFO] [stderr] | [INFO] [stderr] 10 | if num_threads <= 0 || num_threads > MAX_THREADS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using num_threads == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> examples/calc_pi.rs:10:8 [INFO] [stderr] | [INFO] [stderr] 10 | if num_threads <= 0 || num_threads > MAX_THREADS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using num_threads == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/calc_pi.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | let pi: f64 = results.into_iter().fold(0.0, |acc, p| { acc + p }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `results` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/calc_pi.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | let w = 1.0 / (n as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/calc_pi.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let x = (i as f64) * w; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/calc_pi.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | let pi: f64 = results.into_iter().fold(0.0, |acc, p| { acc + p }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `results` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/calc_pi.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | let w = 1.0 / (n as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/calc_pi.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let x = (i as f64) * w; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ei`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ei`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> examples/calc_pi.rs:10:8 [INFO] [stderr] | [INFO] [stderr] 10 | if num_threads <= 0 || num_threads > MAX_THREADS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using num_threads == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/calc_pi.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | let pi: f64 = results.into_iter().fold(0.0, |acc, p| { acc + p }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `results` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/calc_pi.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | let w = 1.0 / (n as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/calc_pi.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let x = (i as f64) * w; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> examples/port.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / loop { [INFO] [stderr] 20 | | match receiver.recv() { [INFO] [stderr] 21 | | Ok(vec) => if let Err(e) = ei::send(&mut io::stdout(), vec.as_slice()) { [INFO] [stderr] 22 | | panic!("{:?}", e); [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(vec) = receiver.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/port.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | Err(_) => unimplemented!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ei`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/connect.rs:9:54 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn accept(stream: &mut net::TcpStream, nodename: &String, cookie: &String) -> Result<(), error::Error>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/connect.rs:9:71 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn accept(stream: &mut net::TcpStream, nodename: &String, cookie: &String) -> Result<(), error::Error>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/connect.rs:15:43 [INFO] [stderr] | [INFO] [stderr] 15 | let our_challenge = md5::digest_u32(&["challenge".as_bytes()]); // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"challenge"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/connect.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for e in vec![ [INFO] [stderr] | ______________^ [INFO] [stderr] 70 | | DFLAG_EXTENDED_REFERENCES, [INFO] [stderr] 71 | | DFLAG_EXTENDED_PIDS_PORTS, [INFO] [stderr] 72 | | ] { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `DFLAG_EXTENDED_REFERENCES` [INFO] [stderr] --> src/connect.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | buf.write_u32(0 [INFO] [stderr] | ___________________^ [INFO] [stderr] 90 | | | DFLAG_EXTENDED_REFERENCES [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:40:72 [INFO] [stderr] | [INFO] [stderr] 40 | Num::U8(u) => Ok(u as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(u)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:49:72 [INFO] [stderr] | [INFO] [stderr] 49 | Num::U8(u) => Ok(u as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | Num::U64(u, 0) if range!(u, u32::MIN, u32::MAX, u64) => Ok(u as u32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | Num::U64(u, 0) if range!(u, u32::MIN, u32::MAX, u64) => Ok(u as u32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:58:72 [INFO] [stderr] | [INFO] [stderr] 58 | Num::U8(u) => Ok(u as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(u16::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | Num::I27(i) if range!(i, u16::MIN, u16::MAX, i32) => Ok(i as u16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(u16::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | Num::I27(i) if range!(i, u16::MIN, u16::MAX, i32) => Ok(i as u16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u16::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:60:31 [INFO] [stderr] | [INFO] [stderr] 60 | Num::U64(u, 0) if range!(u, u16::MIN, u16::MAX, u64) => Ok(u as u16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u16::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:60:31 [INFO] [stderr] | [INFO] [stderr] 60 | Num::U64(u, 0) if range!(u, u16::MIN, u16::MAX, u64) => Ok(u as u16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:78:72 [INFO] [stderr] | [INFO] [stderr] 78 | Num::U8(u) => Ok(u as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:79:72 [INFO] [stderr] | [INFO] [stderr] 79 | Num::I27(i) => Ok(i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/decoder.rs:81:72 [INFO] [stderr] | [INFO] [stderr] 81 | Num::U64(u, 1) if range!(u, u64::MIN, i64::MAX, u64) => Ok(u as i64 * -1), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:88:72 [INFO] [stderr] | [INFO] [stderr] 88 | Num::U8(u) => Ok(u as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | Num::U64(u, 0) if range!(u, u32::MIN, i32::MAX, u64) => Ok(u as i32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | Num::U64(u, 1) if range!(u, u32::MIN, i32::MAX, u64) => Ok(u as i32 * -1), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/decoder.rs:91:72 [INFO] [stderr] | [INFO] [stderr] 91 | Num::U64(u, 1) if range!(u, u32::MIN, i32::MAX, u64) => Ok(u as i32 * -1), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:98:72 [INFO] [stderr] | [INFO] [stderr] 98 | Num::U8(u) => Ok(u as i16), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:99:31 [INFO] [stderr] | [INFO] [stderr] 99 | Num::I27(i) if range!(i, i16::MIN, i16::MAX, i32) => Ok(i as i16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:99:31 [INFO] [stderr] | [INFO] [stderr] 99 | Num::I27(i) if range!(i, i16::MIN, i16::MAX, i32) => Ok(i as i16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u16::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:100:31 [INFO] [stderr] | [INFO] [stderr] 100 | Num::U64(u, 0) if range!(u, u16::MIN, i16::MAX, u64) => Ok(u as i16), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | Num::I27(i) if range!(i, i8::MIN, i8::MAX, i32) => Ok(i as i8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(i8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | Num::I27(i) if range!(i, i8::MIN, i8::MAX, i32) => Ok(i as i8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/decoder.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | Num::U64(u, 0) if range!(u, u8::MIN, i8::MAX, u64) => Ok(u as i8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:279:70 [INFO] [stderr] | [INFO] [stderr] 279 | Ok(v.iter().enumerate().fold(0u64, |a,(i,e)| a | (*e as u64) << (i as u32 * 8))) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:374:54 [INFO] [stderr] | [INFO] [stderr] 374 | creation: if t { try!(r.read_u32()) } else { try!(r.read_u8()) as u32 & 0x03 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 374 | creation: if t { try!(r.read_u32()) } else { u32::from(match $ expr { [INFO] [stderr] 375 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 376 | :: Err ( err ) => { [INFO] [stderr] 377 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 378 | $ crate :: convert :: From :: from ( err ) ) } }) & 0x03 }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:389:54 [INFO] [stderr] | [INFO] [stderr] 389 | creation: if t { try!(r.read_u32()) } else { try!(r.read_u8()) as u32 & 0x03 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 389 | creation: if t { try!(r.read_u32()) } else { u32::from(match $ expr { [INFO] [stderr] 390 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 391 | :: Err ( err ) => { [INFO] [stderr] 392 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 393 | $ crate :: convert :: From :: from ( err ) ) } }) & 0x03 }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:405:55 [INFO] [stderr] | [INFO] [stderr] 405 | let creation = if t { try!(r.read_u32()) } else { try!(r.read_u8()) as u32 & 0x03 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 405 | let creation = if t { try!(r.read_u32()) } else { u32::from(match $ expr { [INFO] [stderr] 406 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 407 | :: Err ( err ) => { [INFO] [stderr] 408 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 409 | $ crate :: convert :: From :: from ( err ) ) } }) & 0x03 }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `n`. [INFO] [stderr] --> src/decoder.rs:408:14 [INFO] [stderr] | [INFO] [stderr] 408 | for i in 0 .. len as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 408 | for in n.iter_mut().take(len as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/decoder.rs:422:53 [INFO] [stderr] | [INFO] [stderr] 422 | let decoder: &'a mut Decoder<'a> = unsafe { mem::transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut T as *mut decoder::Decoder<'a>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/decoder.rs:660:13 [INFO] [stderr] | [INFO] [stderr] 660 | assert_eq!(expected, test!(input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/decoder.rs:660:13 [INFO] [stderr] | [INFO] [stderr] 660 | assert_eq!(expected, test!(input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | u if range!(u, u8::MIN, u8::MAX, u64) => write_u8(self.w, u as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | u if range!(u, u8::MIN, u8::MAX, u64) => write_u8(self.w, u as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u64::from(u32::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | u if range!(u, u32::MIN, i27::MAX, u64) => write_i27(self.w, u as i32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u32::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | u if range!(u, u8::MIN, u8::MAX, u32) => write_u8(self.w, u as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u32::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | u if range!(u, u8::MIN, u8::MAX, u32) => write_u8(self.w, u as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:45:83 [INFO] [stderr] | [INFO] [stderr] 45 | u => write_small_big(self.w, 0, u as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u16::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | u if range!(u, u8::MIN, u8::MAX, u16) => write_u8(self.w, u as u8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `u16::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | u if range!(u, u8::MIN, u8::MAX, u16) => write_u8(self.w, u as u8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:52:72 [INFO] [stderr] | [INFO] [stderr] 52 | u => write_i27(self.w, u as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i64::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | i if range!(i, u8::MIN, u8::MAX, i64) => write_u8(self.w, i as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i64::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | i if range!(i, u8::MIN, u8::MAX, i64) => write_u8(self.w, i as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i64::from(i27::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | i if range!(i, i27::MIN, i27::MAX, i64) => write_i27(self.w, i as i32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i64::from(i27::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | i if range!(i, i27::MIN, i27::MAX, i64) => write_i27(self.w, i as i32), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | i if range!(i, u8::MIN, u8::MAX, i32) => write_u8(self.w, i as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i32::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | i if range!(i, u8::MIN, u8::MAX, i32) => write_u8(self.w, i as u8), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:59 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i16::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | i if range!(i, u8::MIN, u8::MAX, i16) => write_u8(self.w, i as u8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:2:83 [INFO] [stderr] | [INFO] [stderr] 2 | ($e: expr, $f: expr, $t: expr, $c:ty) => ($e as $c >= $f as $c && $e as $c <= $t as $c); [INFO] [stderr] | ^^ help: try: `i16::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] ::: src/encoder.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | i if range!(i, u8::MIN, u8::MAX, i16) => write_u8(self.w, i as u8), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:87:72 [INFO] [stderr] | [INFO] [stderr] 87 | i => write_i27(self.w, i as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:94:71 [INFO] [stderr] | [INFO] [stderr] 94 | i => write_i27(self.w, i as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/encoder.rs:400:53 [INFO] [stderr] | [INFO] [stderr] 400 | let encoder: &'a mut Encoder<'a> = unsafe { mem::transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut T as *mut encoder::Encoder<'a>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:465:40 [INFO] [stderr] | [INFO] [stderr] 465 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:481:40 [INFO] [stderr] | [INFO] [stderr] 481 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:495:40 [INFO] [stderr] | [INFO] [stderr] 495 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:507:40 [INFO] [stderr] | [INFO] [stderr] 507 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:527:40 [INFO] [stderr] | [INFO] [stderr] 527 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:533:27 [INFO] [stderr] | [INFO] [stderr] 533 | assert!(test!(&mut output, input).is_err(), expected); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:553:40 [INFO] [stderr] | [INFO] [stderr] 553 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:559:27 [INFO] [stderr] | [INFO] [stderr] 559 | assert!(test!(&mut output, input).is_err(), expected); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:575:40 [INFO] [stderr] | [INFO] [stderr] 575 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:589:40 [INFO] [stderr] | [INFO] [stderr] 589 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:600:40 [INFO] [stderr] | [INFO] [stderr] 600 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:613:40 [INFO] [stderr] | [INFO] [stderr] 613 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:624:40 [INFO] [stderr] | [INFO] [stderr] 624 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:634:34 [INFO] [stderr] | [INFO] [stderr] 634 | assert_eq!([0x6a], test!(&mut output, ()).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:637:51 [INFO] [stderr] | [INFO] [stderr] 637 | assert_eq!([0x68, 0x01, 0x61,0x01], test!(&mut output, (1,)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:640:87 [INFO] [stderr] | [INFO] [stderr] 640 | assert_eq!([0x68, 0x02, 0x61,0x01, 0x64,0x00,0x04,0x74,0x72,0x75,0x65], test!(&mut output, (1,true)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:650:40 [INFO] [stderr] | [INFO] [stderr] 650 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:663:55 [INFO] [stderr] | [INFO] [stderr] 663 | assert_eq!([0x74, 0x00,0x00,0x00,0x00], test!(&mut output, &map).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:668:77 [INFO] [stderr] | [INFO] [stderr] 668 | assert_eq!([0x74, 0x00,0x00,0x00,0x01, 0x61,0x01, 0x61,0x02], test!(&mut output, &map).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:693:40 [INFO] [stderr] | [INFO] [stderr] 693 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:852:40 [INFO] [stderr] | [INFO] [stderr] 852 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:887:40 [INFO] [stderr] | [INFO] [stderr] 887 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:918:40 [INFO] [stderr] | [INFO] [stderr] 918 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:977:40 [INFO] [stderr] | [INFO] [stderr] 977 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/encoder.rs:1010:40 [INFO] [stderr] | [INFO] [stderr] 1010 | assert_eq!(expected, test!(&mut output, input).unwrap(), "{:?}", input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/fs.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | if let Ok(_) = f.read_to_string(&mut buf) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 11 | | return buf; [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____________- help: try this: `if f.read_to_string(&mut buf).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/net.rs:95:50 [INFO] [stderr] | [INFO] [stderr] 95 | self.read_u64().and_then(|u| Ok(unsafe { mem::transmute(u) })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(u)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/net.rs:99:50 [INFO] [stderr] | [INFO] [stderr] 99 | self.read_u32().and_then(|u| Ok(unsafe { mem::transmute(u) })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/net.rs:291:17 [INFO] [stderr] | [INFO] [stderr] 291 | assert_eq!(expected, test!(input, read_f64).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/net.rs:291:17 [INFO] [stderr] | [INFO] [stderr] 291 | assert_eq!(expected, test!(input, read_f64).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/net.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | assert_eq!(expected, test!(input, read_f32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/net.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | assert_eq!(expected, test!(input, read_f32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:324:44 [INFO] [stderr] | [INFO] [stderr] 324 | assert_eq!(expected, test!(&mut output, input, write_u64).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:336:44 [INFO] [stderr] | [INFO] [stderr] 336 | assert_eq!(expected, test!(&mut output, input, write_u32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:348:44 [INFO] [stderr] | [INFO] [stderr] 348 | assert_eq!(expected, test!(&mut output, input, write_u16).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:360:44 [INFO] [stderr] | [INFO] [stderr] 360 | assert_eq!(expected, test!(&mut output, input, write_u8).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:374:44 [INFO] [stderr] | [INFO] [stderr] 374 | assert_eq!(expected, test!(&mut output, input, write_i64).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:388:44 [INFO] [stderr] | [INFO] [stderr] 388 | assert_eq!(expected, test!(&mut output, input, write_i32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:402:44 [INFO] [stderr] | [INFO] [stderr] 402 | assert_eq!(expected, test!(&mut output, input, write_i16).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:416:44 [INFO] [stderr] | [INFO] [stderr] 416 | assert_eq!(expected, test!(&mut output, input, write_i8).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:429:44 [INFO] [stderr] | [INFO] [stderr] 429 | assert_eq!(expected, test!(&mut output, input, write_f64).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `as_slice` doesn't need a mutable reference [INFO] [stderr] --> src/net.rs:442:44 [INFO] [stderr] | [INFO] [stderr] 442 | assert_eq!(expected, test!(&mut output, input, write_f32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/handle.rs:13:57 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn handle(stream: &mut net::TcpStream, nodename: &String, mut f: F) -> Result<(), error::Error> [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ei`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "38c3f5a65cc16865a437d6015cf5ca2604cfeca09630d16bfa9ee8a8456c7c08"` [INFO] running `"docker" "rm" "-f" "38c3f5a65cc16865a437d6015cf5ca2604cfeca09630d16bfa9ee8a8456c7c08"` [INFO] [stdout] 38c3f5a65cc16865a437d6015cf5ca2604cfeca09630d16bfa9ee8a8456c7c08