[INFO] updating cached repository tollyx/plankboat-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tollyx/plankboat-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tollyx/plankboat-rs" "work/ex/clippy-test-run/sources/stable/gh/tollyx/plankboat-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tollyx/plankboat-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tollyx/plankboat-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tollyx/plankboat-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tollyx/plankboat-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 26fcc9a58ee7ff913842b6f5623e15df6a7aae54
[INFO] sha for GitHub repo tollyx/plankboat-rs: 26fcc9a58ee7ff913842b6f5623e15df6a7aae54
[INFO] validating manifest of tollyx/plankboat-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tollyx/plankboat-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tollyx/plankboat-rs
[INFO] finished frobbing tollyx/plankboat-rs
[INFO] frobbed toml for tollyx/plankboat-rs written to work/ex/clippy-test-run/sources/stable/gh/tollyx/plankboat-rs/Cargo.toml
[INFO] started frobbing tollyx/plankboat-rs
[INFO] finished frobbing tollyx/plankboat-rs
[INFO] frobbed toml for tollyx/plankboat-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tollyx/plankboat-rs/Cargo.toml
[INFO] crate tollyx/plankboat-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tollyx/plankboat-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tollyx/plankboat-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a053ddc3aa927ac9aab180c0d7d4aa4bdb7534d246910c066739ead9ade36de7
[INFO] running `"docker" "start" "-a" "a053ddc3aa927ac9aab180c0d7d4aa4bdb7534d246910c066739ead9ade36de7"`
[INFO] [stderr]    Compiling libc v0.2.39
[INFO] [stderr]     Checking num-traits v0.2.1
[INFO] [stderr]    Compiling build_const v0.2.0
[INFO] [stderr]     Checking encoding_rs v0.7.2
[INFO] [stderr]     Checking iovec v0.1.2
[INFO] [stderr]     Checking net2 v0.2.32
[INFO] [stderr]     Checking num_cpus v1.8.0
[INFO] [stderr]     Checking time v0.1.39
[INFO] [stderr]     Checking atty v0.2.6
[INFO] [stderr]     Checking colored v1.6.0
[INFO] [stderr]     Checking tokio-executor v0.1.0
[INFO] [stderr]     Checking tokio-service v0.1.0
[INFO] [stderr]     Checking relay v0.1.1
[INFO] [stderr]    Compiling backtrace-sys v0.1.16
[INFO] [stderr]    Compiling miniz-sys v0.1.10
[INFO] [stderr]    Compiling libsqlite3-sys v0.8.1
[INFO] [stderr]     Checking base64 v0.8.0
[INFO] [stderr]     Checking parking_lot_core v0.2.13
[INFO] [stderr]     Checking futures-cpupool v0.1.8
[INFO] [stderr]     Checking threadpool v1.7.1
[INFO] [stderr]     Checking bytes v0.4.6
[INFO] [stderr]     Checking crossbeam-epoch v0.4.0
[INFO] [stderr]     Checking mio v0.6.14
[INFO] [stderr]    Compiling crc v1.7.0
[INFO] [stderr]     Checking fern v0.5.4
[INFO] [stderr]    Compiling rand v0.4.2
[INFO] [stderr]     Checking clap v2.31.1
[INFO] [stderr]     Checking uuid v0.5.1
[INFO] [stderr]     Checking parking_lot v0.5.4
[INFO] [stderr]     Checking num-integer v0.1.36
[INFO] [stderr]     Checking serde_json v1.0.10
[INFO] [stderr]     Checking openssl-sys v0.9.27
[INFO] [stderr]     Checking regex v0.2.6
[INFO] [stderr]     Checking crossbeam-deque v0.3.0
[INFO] [stderr]     Checking tokio-io v0.1.6
[INFO] [stderr]     Checking num-iter v0.1.35
[INFO] [stderr]     Checking openssl v0.9.24
[INFO] [stderr]     Checking remove_dir_all v0.3.0
[INFO] [stderr]     Checking hyper v0.10.13
[INFO] [stderr]     Checking serde_urlencoded v0.5.1
[INFO] [stderr]    Compiling rand v0.3.22
[INFO] [stderr]     Checking tokio-threadpool v0.1.0
[INFO] [stderr]     Checking tokio-reactor v0.1.0
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking flate2 v1.0.1
[INFO] [stderr]     Checking tempdir v0.3.6
[INFO] [stderr]    Compiling phf_generator v0.7.21
[INFO] [stderr]     Checking libflate v0.1.14
[INFO] [stderr]     Checking chrono v0.4.0
[INFO] [stderr]     Checking tokio v0.1.3
[INFO] [stderr]    Compiling phf_codegen v0.7.21
[INFO] [stderr]    Compiling mime_guess v1.8.4
[INFO] [stderr]    Compiling mime_guess v2.0.0-alpha.4
[INFO] [stderr]     Checking tokio-core v0.1.15
[INFO] [stderr]     Checking native-tls v0.1.5
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking evzht9h3nznqzwl v0.0.3
[INFO] [stderr]     Checking hyper-native-tls v0.2.4
[INFO] [stderr]     Checking multipart v0.13.6
[INFO] [stderr]     Checking serenity v0.5.1
[INFO] [stderr]     Checking hyper v0.11.22
[INFO] [stderr]     Checking backtrace v0.3.5
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]     Checking quick-xml v0.12.1
[INFO] [stderr]     Checking hyper-tls v0.1.2
[INFO] [stderr]     Checking reqwest v0.8.5
[INFO] [stderr]     Checking rusqlite v0.11.0
[INFO] [stderr]     Checking plankboat v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/framework.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         fw
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/framework.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |           let fw = PlankFramework {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 23 | |             command_prefix: "^",
[INFO] [stderr] 24 | |             commands: HashMap::new(),
[INFO] [stderr] 25 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/framework.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         fw
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/framework.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |           let fw = PlankFramework {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 23 | |             command_prefix: "^",
[INFO] [stderr] 24 | |             commands: HashMap::new(),
[INFO] [stderr] 25 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/framework.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |             if cmd.len() > 0 && !cmd.chars().next().unwrap().is_whitespace() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cmd.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/framework.rs:46:42
[INFO] [stderr]    |
[INFO] [stderr] 46 |                         if s.starts_with("'") {
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `'''`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/framework.rs:49:47
[INFO] [stderr]    |
[INFO] [stderr] 49 |                         else if s.starts_with("\"") {
[INFO] [stderr]    |                                               ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/framework.rs:56:20
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 if args.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/commands/mod.rs:70:66
[INFO] [stderr]    |
[INFO] [stderr] 70 |     fn execute(&self, _ctx: &mut Context, _msg: &Message, _args: &Vec<String>) -> CommandResult;
[INFO] [stderr]    |                                                                  ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/framework.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |             if cmd.len() > 0 && !cmd.chars().next().unwrap().is_whitespace() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cmd.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/framework.rs:46:42
[INFO] [stderr]    |
[INFO] [stderr] 46 |                         if s.starts_with("'") {
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `'''`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/framework.rs:49:47
[INFO] [stderr]    |
[INFO] [stderr] 49 |                         else if s.starts_with("\"") {
[INFO] [stderr]    |                                               ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/framework.rs:56:20
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 if args.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/commands/mod.rs:70:66
[INFO] [stderr]    |
[INFO] [stderr] 70 |     fn execute(&self, _ctx: &mut Context, _msg: &Message, _args: &Vec<String>) -> CommandResult;
[INFO] [stderr]    |                                                                  ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 57.68s
[INFO] running `"docker" "inspect" "a053ddc3aa927ac9aab180c0d7d4aa4bdb7534d246910c066739ead9ade36de7"`
[INFO] running `"docker" "rm" "-f" "a053ddc3aa927ac9aab180c0d7d4aa4bdb7534d246910c066739ead9ade36de7"`
[INFO] [stdout] a053ddc3aa927ac9aab180c0d7d4aa4bdb7534d246910c066739ead9ade36de7