[INFO] updating cached repository tokio-hacknight/spiro-client [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tokio-hacknight/spiro-client [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tokio-hacknight/spiro-client" "work/ex/clippy-test-run/sources/stable/gh/tokio-hacknight/spiro-client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tokio-hacknight/spiro-client'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tokio-hacknight/spiro-client" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tokio-hacknight/spiro-client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tokio-hacknight/spiro-client'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f5ee951c866a23fa7a04457de1c246ebed144989 [INFO] sha for GitHub repo tokio-hacknight/spiro-client: f5ee951c866a23fa7a04457de1c246ebed144989 [INFO] validating manifest of tokio-hacknight/spiro-client on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-hacknight/spiro-client on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-hacknight/spiro-client [INFO] finished frobbing tokio-hacknight/spiro-client [INFO] frobbed toml for tokio-hacknight/spiro-client written to work/ex/clippy-test-run/sources/stable/gh/tokio-hacknight/spiro-client/Cargo.toml [INFO] started frobbing tokio-hacknight/spiro-client [INFO] finished frobbing tokio-hacknight/spiro-client [INFO] frobbed toml for tokio-hacknight/spiro-client written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tokio-hacknight/spiro-client/Cargo.toml [INFO] crate tokio-hacknight/spiro-client has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-hacknight/spiro-client against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tokio-hacknight/spiro-client:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d62b7b60ec0ff1ea4b9375481fbb51c245f76703974801235b59ec47d0d464f7 [INFO] running `"docker" "start" "-a" "d62b7b60ec0ff1ea4b9375481fbb51c245f76703974801235b59ec47d0d464f7"` [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking futures v0.1.3 [INFO] [stderr] Compiling nix v0.6.0 [INFO] [stderr] Checking mio v0.6.0 [INFO] [stderr] Checking tokio-core v0.1.0 [INFO] [stderr] Checking spiro-client v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | writer: writer [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | writer: writer [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / loop { [INFO] [stderr] 31 | | match (self.socket.poll_write(), &mut self.buffer) { [INFO] [stderr] 32 | | (Async::Ready(_), some_buffer @ &mut Some(_)) => { [INFO] [stderr] 33 | | { [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:79:40 [INFO] [stderr] | [INFO] [stderr] 79 | let addr = unsafe { CStr::from_ptr(addr).to_string_lossy().into_owned() }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:86:33 [INFO] [stderr] | [INFO] [stderr] 86 | let client = unsafe { &mut *client }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `spiro-client`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / loop { [INFO] [stderr] 31 | | match (self.socket.poll_write(), &mut self.buffer) { [INFO] [stderr] 32 | | (Async::Ready(_), some_buffer @ &mut Some(_)) => { [INFO] [stderr] 33 | | { [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:79:40 [INFO] [stderr] | [INFO] [stderr] 79 | let addr = unsafe { CStr::from_ptr(addr).to_string_lossy().into_owned() }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:86:33 [INFO] [stderr] | [INFO] [stderr] 86 | let client = unsafe { &mut *client }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `spiro-client`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d62b7b60ec0ff1ea4b9375481fbb51c245f76703974801235b59ec47d0d464f7"` [INFO] running `"docker" "rm" "-f" "d62b7b60ec0ff1ea4b9375481fbb51c245f76703974801235b59ec47d0d464f7"` [INFO] [stdout] d62b7b60ec0ff1ea4b9375481fbb51c245f76703974801235b59ec47d0d464f7