[INFO] updating cached repository toddWannaCode/io-project [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/toddWannaCode/io-project [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/toddWannaCode/io-project" "work/ex/clippy-test-run/sources/stable/gh/toddWannaCode/io-project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/toddWannaCode/io-project'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/toddWannaCode/io-project" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/toddWannaCode/io-project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/toddWannaCode/io-project'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2fcb0dc38864ccfad578d2e259bddb8fe5758186 [INFO] sha for GitHub repo toddWannaCode/io-project: 2fcb0dc38864ccfad578d2e259bddb8fe5758186 [INFO] validating manifest of toddWannaCode/io-project on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of toddWannaCode/io-project on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing toddWannaCode/io-project [INFO] finished frobbing toddWannaCode/io-project [INFO] frobbed toml for toddWannaCode/io-project written to work/ex/clippy-test-run/sources/stable/gh/toddWannaCode/io-project/Cargo.toml [INFO] started frobbing toddWannaCode/io-project [INFO] finished frobbing toddWannaCode/io-project [INFO] frobbed toml for toddWannaCode/io-project written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/toddWannaCode/io-project/Cargo.toml [INFO] crate toddWannaCode/io-project has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting toddWannaCode/io-project against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/toddWannaCode/io-project:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1fedf8419f5935e653c64fe9eef7a6d4891abfe4b04dee076300fb43ee067b3 [INFO] running `"docker" "start" "-a" "f1fedf8419f5935e653c64fe9eef7a6d4891abfe4b04dee076300fb43ee067b3"` [INFO] [stderr] Checking io_project v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new(args: &[T]) -> Result, &'static str> { [INFO] [stderr] 14 | | if args.len() < 2 { [INFO] [stderr] 15 | | return Err("Not enough args"); [INFO] [stderr] 16 | | } [INFO] [stderr] ... | [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:38:65 [INFO] [stderr] | [INFO] [stderr] 38 | fn search<'a>(query: &str, contents: &'a str, case_insensitive: &bool) -> Vec<&'a str> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new(args: &[T]) -> Result, &'static str> { [INFO] [stderr] 14 | | if args.len() < 2 { [INFO] [stderr] 15 | | return Err("Not enough args"); [INFO] [stderr] 16 | | } [INFO] [stderr] ... | [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:38:65 [INFO] [stderr] | [INFO] [stderr] 38 | fn search<'a>(query: &str, contents: &'a str, case_insensitive: &bool) -> Vec<&'a str> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match io_project::run(config) { [INFO] [stderr] 16 | | Err(e) => { [INFO] [stderr] 17 | | writeln!(stderr, "There was an error: {}", e).expect("Couldn't write to stderr"); [INFO] [stderr] 18 | | process::exit(1); [INFO] [stderr] 19 | | }, [INFO] [stderr] 20 | | _ => () [INFO] [stderr] 21 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | if let Err(e) = io_project::run(config) { [INFO] [stderr] 16 | writeln!(stderr, "There was an error: {}", e).expect("Couldn't write to stderr"); [INFO] [stderr] 17 | process::exit(1); [INFO] [stderr] 18 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match io_project::run(config) { [INFO] [stderr] 16 | | Err(e) => { [INFO] [stderr] 17 | | writeln!(stderr, "There was an error: {}", e).expect("Couldn't write to stderr"); [INFO] [stderr] 18 | | process::exit(1); [INFO] [stderr] 19 | | }, [INFO] [stderr] 20 | | _ => () [INFO] [stderr] 21 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | if let Err(e) = io_project::run(config) { [INFO] [stderr] 16 | writeln!(stderr, "There was an error: {}", e).expect("Couldn't write to stderr"); [INFO] [stderr] 17 | process::exit(1); [INFO] [stderr] 18 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "f1fedf8419f5935e653c64fe9eef7a6d4891abfe4b04dee076300fb43ee067b3"` [INFO] running `"docker" "rm" "-f" "f1fedf8419f5935e653c64fe9eef7a6d4891abfe4b04dee076300fb43ee067b3"` [INFO] [stdout] f1fedf8419f5935e653c64fe9eef7a6d4891abfe4b04dee076300fb43ee067b3