[INFO] updating cached repository tock/elf2tab [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tock/elf2tab [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tock/elf2tab" "work/ex/clippy-test-run/sources/stable/gh/tock/elf2tab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tock/elf2tab'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tock/elf2tab" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tock/elf2tab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tock/elf2tab'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b84127a2b7cf2babb75b09284c8c9ce010300521 [INFO] sha for GitHub repo tock/elf2tab: b84127a2b7cf2babb75b09284c8c9ce010300521 [INFO] validating manifest of tock/elf2tab on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tock/elf2tab on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tock/elf2tab [INFO] finished frobbing tock/elf2tab [INFO] frobbed toml for tock/elf2tab written to work/ex/clippy-test-run/sources/stable/gh/tock/elf2tab/Cargo.toml [INFO] started frobbing tock/elf2tab [INFO] finished frobbing tock/elf2tab [INFO] frobbed toml for tock/elf2tab written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tock/elf2tab/Cargo.toml [INFO] crate tock/elf2tab has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tock/elf2tab against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tock/elf2tab:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c806735046da8be4440efa67a60d94daf2c0a4c550879c55dcbf4a65b47bb794 [INFO] running `"docker" "start" "-a" "c806735046da8be4440efa67a60d94daf2c0a4c550879c55dcbf4a65b47bb794"` [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking xattr v0.2.1 [INFO] [stderr] Checking filetime v0.2.1 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking elf v0.0.10 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking tar v0.4.15 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking elf2tab v0.4.0-dev (/opt/crater/workdir) [INFO] [stderr] warning: All variants have the same prefix: `TbfHeader` [INFO] [stderr] --> src/header.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / enum TbfHeaderTypes { [INFO] [stderr] 15 | | TbfHeaderMain = 1, [INFO] [stderr] 16 | | TbfHeaderWriteableFlashRegions = 2, [INFO] [stderr] 17 | | TbfHeaderPackageName = 3, [INFO] [stderr] 18 | | TbfHeaderPicOption1 = 4, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | let flags = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `TbfHeader` [INFO] [stderr] --> src/header.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / enum TbfHeaderTypes { [INFO] [stderr] 15 | | TbfHeaderMain = 1, [INFO] [stderr] 16 | | TbfHeaderWriteableFlashRegions = 2, [INFO] [stderr] 17 | | TbfHeaderPackageName = 3, [INFO] [stderr] 18 | | TbfHeaderPicOption1 = 4, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | let flags = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / pub unsafe fn as_byte_slice<'a, T: Copy>(input: &'a T) -> &'a [u8] { [INFO] [stderr] 41 | | slice::from_raw_parts(input as *const T as *const u8, mem::size_of::()) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/header.rs:164:36 [INFO] [stderr] | [INFO] [stderr] 164 | self.package_name_pad = if package_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!package_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/header.rs:189:12 [INFO] [stderr] | [INFO] [stderr] 189 | if self.package_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.package_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/header.rs:241:12 [INFO] [stderr] | [INFO] [stderr] 241 | if self.package_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.package_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `wordbuf` [INFO] [stderr] --> src/header.rs:273:22 [INFO] [stderr] | [INFO] [stderr] 273 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 273 | for (i, ) in wordbuf.iter().enumerate().take(count) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:274:25 [INFO] [stderr] | [INFO] [stderr] 274 | word |= (wordbuf[i] as u32) << (8 * i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(wordbuf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `checksum` [INFO] [stderr] --> src/header.rs:285:23 [INFO] [stderr] | [INFO] [stderr] 285 | wordbuf[0] = ((checksum >> 0) & 0xFF) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | header_buf.write(&wordbuf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | opt.package_name.clone().unwrap_or(String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.package_name.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | let package_name = package_name.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `package_name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:270:23 [INFO] [stderr] | [INFO] [stderr] 270 | if verbose && rel_data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rel_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:279:12 [INFO] [stderr] | [INFO] [stderr] 279 | if rel_data.len() > 0 && align4needed!(binary_index) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rel_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `elf2tab`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / pub unsafe fn as_byte_slice<'a, T: Copy>(input: &'a T) -> &'a [u8] { [INFO] [stderr] 41 | | slice::from_raw_parts(input as *const T as *const u8, mem::size_of::()) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/header.rs:164:36 [INFO] [stderr] | [INFO] [stderr] 164 | self.package_name_pad = if package_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!package_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/header.rs:189:12 [INFO] [stderr] | [INFO] [stderr] 189 | if self.package_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.package_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/header.rs:241:12 [INFO] [stderr] | [INFO] [stderr] 241 | if self.package_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.package_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `wordbuf` [INFO] [stderr] --> src/header.rs:273:22 [INFO] [stderr] | [INFO] [stderr] 273 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 273 | for (i, ) in wordbuf.iter().enumerate().take(count) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:274:25 [INFO] [stderr] | [INFO] [stderr] 274 | word |= (wordbuf[i] as u32) << (8 * i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(wordbuf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `checksum` [INFO] [stderr] --> src/header.rs:285:23 [INFO] [stderr] | [INFO] [stderr] 285 | wordbuf[0] = ((checksum >> 0) & 0xFF) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | header_buf.write(&wordbuf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | opt.package_name.clone().unwrap_or(String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.package_name.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | let package_name = package_name.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `package_name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:270:23 [INFO] [stderr] | [INFO] [stderr] 270 | if verbose && rel_data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rel_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:279:12 [INFO] [stderr] | [INFO] [stderr] 279 | if rel_data.len() > 0 && align4needed!(binary_index) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rel_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `elf2tab`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c806735046da8be4440efa67a60d94daf2c0a4c550879c55dcbf4a65b47bb794"` [INFO] running `"docker" "rm" "-f" "c806735046da8be4440efa67a60d94daf2c0a4c550879c55dcbf4a65b47bb794"` [INFO] [stdout] c806735046da8be4440efa67a60d94daf2c0a4c550879c55dcbf4a65b47bb794