[INFO] updating cached repository tmorgansl/integrator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tmorgansl/integrator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tmorgansl/integrator" "work/ex/clippy-test-run/sources/stable/gh/tmorgansl/integrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tmorgansl/integrator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tmorgansl/integrator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmorgansl/integrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmorgansl/integrator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 620f93ec4f0a783daa5df07556fd94c3aaded993 [INFO] sha for GitHub repo tmorgansl/integrator: 620f93ec4f0a783daa5df07556fd94c3aaded993 [INFO] validating manifest of tmorgansl/integrator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tmorgansl/integrator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tmorgansl/integrator [INFO] finished frobbing tmorgansl/integrator [INFO] frobbed toml for tmorgansl/integrator written to work/ex/clippy-test-run/sources/stable/gh/tmorgansl/integrator/Cargo.toml [INFO] started frobbing tmorgansl/integrator [INFO] finished frobbing tmorgansl/integrator [INFO] frobbed toml for tmorgansl/integrator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmorgansl/integrator/Cargo.toml [INFO] crate tmorgansl/integrator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tmorgansl/integrator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tmorgansl/integrator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 92288753af8883d0cf42ef8b51cb5b0f8cf09249440334e44267b68c9ff35480 [INFO] running `"docker" "start" "-a" "92288753af8883d0cf42ef8b51cb5b0f8cf09249440334e44267b68c9ff35480"` [INFO] [stderr] Checking libc v0.2.31 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking integrator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | let num_throws:i32 = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `x`. [INFO] [stderr] --> src/main.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 22 | for in &mut x { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | let pi: f64 = 4.0 * (sum / num_throws as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_throws)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | let num_throws:i32 = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `x`. [INFO] [stderr] --> src/main.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 22 | for in &mut x { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | let pi: f64 = 4.0 * (sum / num_throws as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_throws)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.31s [INFO] running `"docker" "inspect" "92288753af8883d0cf42ef8b51cb5b0f8cf09249440334e44267b68c9ff35480"` [INFO] running `"docker" "rm" "-f" "92288753af8883d0cf42ef8b51cb5b0f8cf09249440334e44267b68c9ff35480"` [INFO] [stdout] 92288753af8883d0cf42ef8b51cb5b0f8cf09249440334e44267b68c9ff35480