[INFO] updating cached repository tmmcguire/fasthashmap
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tmmcguire/fasthashmap
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tmmcguire/fasthashmap" "work/ex/clippy-test-run/sources/stable/gh/tmmcguire/fasthashmap"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tmmcguire/fasthashmap'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tmmcguire/fasthashmap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmmcguire/fasthashmap"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmmcguire/fasthashmap'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cb62dc211ea156ccc3bd232fdf1517a4d560d81f
[INFO] sha for GitHub repo tmmcguire/fasthashmap: cb62dc211ea156ccc3bd232fdf1517a4d560d81f
[INFO] validating manifest of tmmcguire/fasthashmap on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tmmcguire/fasthashmap on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tmmcguire/fasthashmap
[INFO] finished frobbing tmmcguire/fasthashmap
[INFO] frobbed toml for tmmcguire/fasthashmap written to work/ex/clippy-test-run/sources/stable/gh/tmmcguire/fasthashmap/Cargo.toml
[INFO] started frobbing tmmcguire/fasthashmap
[INFO] finished frobbing tmmcguire/fasthashmap
[INFO] frobbed toml for tmmcguire/fasthashmap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmmcguire/fasthashmap/Cargo.toml
[INFO] crate tmmcguire/fasthashmap has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tmmcguire/fasthashmap against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tmmcguire/fasthashmap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cf3f3f0b91647140ccfb198aeec9174b6ee166d1f4686152f5b97364d8a39a27
[INFO] running `"docker" "start" "-a" "cf3f3f0b91647140ccfb198aeec9174b6ee166d1f4686152f5b97364d8a39a27"`
[INFO] [stderr]     Checking fasthashmap v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:131:13
[INFO] [stderr]     |
[INFO] [stderr] 131 |             table   : table,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `table`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             capacity: capacity,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:131:13
[INFO] [stderr]     |
[INFO] [stderr] 131 |             table   : table,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `table`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             capacity: capacity,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:386:9
[INFO] [stderr]     |
[INFO] [stderr] 386 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:397:9
[INFO] [stderr]     |
[INFO] [stderr] 397 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 |         let mut elt = &mut self.table[i];
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:282:13
[INFO] [stderr]     |
[INFO] [stderr] 282 |         let mut elt = &mut self.table[i];
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DJBHasher`
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn new() -> DJBHasher {
[INFO] [stderr] 22 | |         DJBHasher { hash: 5381u64 }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`.
[INFO] [stderr]   --> src/lib.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for i in 0..bytes.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for <item> in &bytes {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:33:47
[INFO] [stderr]    |
[INFO] [stderr] 33 |             self.hash = (33u64 * self.hash) ^ bytes[i] as u64
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:102:5
[INFO] [stderr]     |
[INFO] [stderr] 102 | /     pub fn value<'l>(&'l self) -> Option<&'l V> {
[INFO] [stderr] 103 | |         match *self {
[INFO] [stderr] 104 | |             Entry::Full(_,ref v,_) => Some(v),
[INFO] [stderr] 105 | |             _ => None
[INFO] [stderr] 106 | |         }
[INFO] [stderr] 107 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: item `HashMap<K, V>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:118:1
[INFO] [stderr]     |
[INFO] [stderr] 118 | / impl<K,V> HashMap<K,V> where K: Hash + Eq {
[INFO] [stderr] 119 | |
[INFO] [stderr] 120 | |     #[inline]
[INFO] [stderr] 121 | |     pub fn new() -> HashMap<K,V> {
[INFO] [stderr] ...   |
[INFO] [stderr] 299 | |     }
[INFO] [stderr] 300 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HashMap<K, V>`
[INFO] [stderr]    --> src/lib.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 | /     pub fn new() -> HashMap<K,V> {
[INFO] [stderr] 122 | |         HashMap::with_capacity(8)
[INFO] [stderr] 123 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 110 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:118:11
[INFO] [stderr]     |
[INFO] [stderr] 118 | impl<K,V> HashMap<K,V> where K: Hash + Eq {
[INFO] [stderr]     |           ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 118 | impl<K,V, S: ::std::hash::BuildHasher + Default> HashMap<K, V, S> where K: Hash + Eq {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: ...and use generic constructor
[INFO] [stderr]     |
[INFO] [stderr] 122 |         HashMap::with_capacity_and_hasher(8, Default::default())
[INFO] [stderr] 123 |     }
[INFO] [stderr] 124 | 
[INFO] [stderr] 125 |     #[inline]
[INFO] [stderr] 126 |     pub fn with_capacity(sz: usize) -> HashMap<K,V> {
[INFO] [stderr] 127 |         let capacity = usize::next_power_of_two(sz);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:386:9
[INFO] [stderr]     |
[INFO] [stderr] 386 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:397:9
[INFO] [stderr]     |
[INFO] [stderr] 397 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:153:13
[INFO] [stderr]     |
[INFO] [stderr] 153 |             shifted_hash = shifted_hash >> PERTURB_SHIFT;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shifted_hash >>= PERTURB_SHIFT`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:170:13
[INFO] [stderr]     |
[INFO] [stderr] 170 |             shifted_hash = shifted_hash >> PERTURB_SHIFT;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shifted_hash >>= PERTURB_SHIFT`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:184:9
[INFO] [stderr]     |
[INFO] [stderr] 184 | /         match elt {
[INFO] [stderr] 185 | |             &mut Entry::Empty => {
[INFO] [stderr] 186 | |                 let f = Entry::Full(key,value,hash);
[INFO] [stderr] 187 | |                 std::mem::replace(elt, f);
[INFO] [stderr] ...   |
[INFO] [stderr] 200 | |             },
[INFO] [stderr] 201 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 184 |         match *elt {
[INFO] [stderr] 185 |             Entry::Empty => {
[INFO] [stderr] 186 |                 let f = Entry::Full(key,value,hash);
[INFO] [stderr] 187 |                 std::mem::replace(elt, f);
[INFO] [stderr] 188 |                 self.length += 1;
[INFO] [stderr] 189 |                 None
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:245:9
[INFO] [stderr]     |
[INFO] [stderr] 245 | /         match &self.table[i] {
[INFO] [stderr] 246 | |             &Entry::Empty | &Entry::Ghost(..) => None,
[INFO] [stderr] 247 | |             &Entry::Full(_, ref val, _)       => Some(val),
[INFO] [stderr] 248 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 245 |         match self.table[i] {
[INFO] [stderr] 246 |             Entry::Empty | Entry::Ghost(..) => None,
[INFO] [stderr] 247 |             Entry::Full(_, ref val, _)       => Some(val),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:283:9
[INFO] [stderr]     |
[INFO] [stderr] 283 | /         match elt {
[INFO] [stderr] 284 | |             &mut Entry::Empty | &mut Entry::Ghost(..) => None,
[INFO] [stderr] 285 | |             &mut Entry::Full(_,ref mut v, _) => Some(v),
[INFO] [stderr] 286 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 283 |         match *elt {
[INFO] [stderr] 284 |             Entry::Empty | Entry::Ghost(..) => None,
[INFO] [stderr] 285 |             Entry::Full(_,ref mut v, _) => Some(v),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: item `HashSet<T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:348:1
[INFO] [stderr]     |
[INFO] [stderr] 348 | / impl<T> HashSet<T> where T: Hash + Eq {
[INFO] [stderr] 349 | |
[INFO] [stderr] 350 | |     #[inline]
[INFO] [stderr] 351 | |     pub fn new() -> HashSet<T> {
[INFO] [stderr] ...   |
[INFO] [stderr] 401 | |     pub fn is_superset(&self, other: &HashSet<T>) -> bool { other.is_subset(self) }
[INFO] [stderr] 402 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `HashSet<T>`
[INFO] [stderr]    --> src/lib.rs:351:5
[INFO] [stderr]     |
[INFO] [stderr] 351 | /     pub fn new() -> HashSet<T> {
[INFO] [stderr] 352 | |         HashSet { map: HashMap::new() }
[INFO] [stderr] 353 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 348 | impl Default for HashSet<T> {
[INFO] [stderr] 349 |     fn default() -> Self {
[INFO] [stderr] 350 |         Self::new()
[INFO] [stderr] 351 |     }
[INFO] [stderr] 352 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:348:9
[INFO] [stderr]     |
[INFO] [stderr] 348 | impl<T> HashSet<T> where T: Hash + Eq {
[INFO] [stderr]     |         ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 348 | impl<T, S: ::std::hash::BuildHasher> HashSet<T, S> where T: Hash + Eq {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/lib.rs:357:9
[INFO] [stderr]     |
[INFO] [stderr] 357 | /         match self.map.insert(v, ()) {
[INFO] [stderr] 358 | |             Some(_) => false,
[INFO] [stderr] 359 | |             None    => true,
[INFO] [stderr] 360 | |         }
[INFO] [stderr]     | |_________^ help: try this: `self.map.insert(v, ()).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:381:13
[INFO] [stderr]     |
[INFO] [stderr] 381 | /             match *elt {
[INFO] [stderr] 382 | |                 Entry::Full(ref k,_,_) => { if other.contains(k) { return false; } },
[INFO] [stderr] 383 | |                 _ => { },
[INFO] [stderr] 384 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Entry::Full(ref k,_,_) = *elt { if other.contains(k) { return false; } }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:392:13
[INFO] [stderr]     |
[INFO] [stderr] 392 | /             match *elt {
[INFO] [stderr] 393 | |                 Entry::Full(ref k,_,_) => { if !other.contains(k) { return false; } },
[INFO] [stderr] 394 | |                 _ => { },
[INFO] [stderr] 395 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Entry::Full(ref k,_,_) = *elt { if !other.contains(k) { return false; } }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 |         let mut elt = &mut self.table[i];
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:282:13
[INFO] [stderr]     |
[INFO] [stderr] 282 |         let mut elt = &mut self.table[i];
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DJBHasher`
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn new() -> DJBHasher {
[INFO] [stderr] 22 | |         DJBHasher { hash: 5381u64 }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`.
[INFO] [stderr]   --> src/lib.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for i in 0..bytes.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for <item> in &bytes {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:33:47
[INFO] [stderr]    |
[INFO] [stderr] 33 |             self.hash = (33u64 * self.hash) ^ bytes[i] as u64
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:102:5
[INFO] [stderr]     |
[INFO] [stderr] 102 | /     pub fn value<'l>(&'l self) -> Option<&'l V> {
[INFO] [stderr] 103 | |         match *self {
[INFO] [stderr] 104 | |             Entry::Full(_,ref v,_) => Some(v),
[INFO] [stderr] 105 | |             _ => None
[INFO] [stderr] 106 | |         }
[INFO] [stderr] 107 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: item `HashMap<K, V>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:118:1
[INFO] [stderr]     |
[INFO] [stderr] 118 | / impl<K,V> HashMap<K,V> where K: Hash + Eq {
[INFO] [stderr] 119 | |
[INFO] [stderr] 120 | |     #[inline]
[INFO] [stderr] 121 | |     pub fn new() -> HashMap<K,V> {
[INFO] [stderr] ...   |
[INFO] [stderr] 299 | |     }
[INFO] [stderr] 300 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HashMap<K, V>`
[INFO] [stderr]    --> src/lib.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 | /     pub fn new() -> HashMap<K,V> {
[INFO] [stderr] 122 | |         HashMap::with_capacity(8)
[INFO] [stderr] 123 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 110 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:118:11
[INFO] [stderr]     |
[INFO] [stderr] 118 | impl<K,V> HashMap<K,V> where K: Hash + Eq {
[INFO] [stderr]     |           ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 118 | impl<K,V, S: ::std::hash::BuildHasher + Default> HashMap<K, V, S> where K: Hash + Eq {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: ...and use generic constructor
[INFO] [stderr]     |
[INFO] [stderr] 122 |         HashMap::with_capacity_and_hasher(8, Default::default())
[INFO] [stderr] 123 |     }
[INFO] [stderr] 124 | 
[INFO] [stderr] 125 |     #[inline]
[INFO] [stderr] 126 |     pub fn with_capacity(sz: usize) -> HashMap<K,V> {
[INFO] [stderr] 127 |         let capacity = usize::next_power_of_two(sz);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:153:13
[INFO] [stderr]     |
[INFO] [stderr] 153 |             shifted_hash = shifted_hash >> PERTURB_SHIFT;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shifted_hash >>= PERTURB_SHIFT`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:170:13
[INFO] [stderr]     |
[INFO] [stderr] 170 |             shifted_hash = shifted_hash >> PERTURB_SHIFT;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shifted_hash >>= PERTURB_SHIFT`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:184:9
[INFO] [stderr]     |
[INFO] [stderr] 184 | /         match elt {
[INFO] [stderr] 185 | |             &mut Entry::Empty => {
[INFO] [stderr] 186 | |                 let f = Entry::Full(key,value,hash);
[INFO] [stderr] 187 | |                 std::mem::replace(elt, f);
[INFO] [stderr] ...   |
[INFO] [stderr] 200 | |             },
[INFO] [stderr] 201 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 184 |         match *elt {
[INFO] [stderr] 185 |             Entry::Empty => {
[INFO] [stderr] 186 |                 let f = Entry::Full(key,value,hash);
[INFO] [stderr] 187 |                 std::mem::replace(elt, f);
[INFO] [stderr] 188 |                 self.length += 1;
[INFO] [stderr] 189 |                 None
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:245:9
[INFO] [stderr]     |
[INFO] [stderr] 245 | /         match &self.table[i] {
[INFO] [stderr] 246 | |             &Entry::Empty | &Entry::Ghost(..) => None,
[INFO] [stderr] 247 | |             &Entry::Full(_, ref val, _)       => Some(val),
[INFO] [stderr] 248 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 245 |         match self.table[i] {
[INFO] [stderr] 246 |             Entry::Empty | Entry::Ghost(..) => None,
[INFO] [stderr] 247 |             Entry::Full(_, ref val, _)       => Some(val),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:283:9
[INFO] [stderr]     |
[INFO] [stderr] 283 | /         match elt {
[INFO] [stderr] 284 | |             &mut Entry::Empty | &mut Entry::Ghost(..) => None,
[INFO] [stderr] 285 | |             &mut Entry::Full(_,ref mut v, _) => Some(v),
[INFO] [stderr] 286 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 283 |         match *elt {
[INFO] [stderr] 284 |             Entry::Empty | Entry::Ghost(..) => None,
[INFO] [stderr] 285 |             Entry::Full(_,ref mut v, _) => Some(v),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: item `HashSet<T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:348:1
[INFO] [stderr]     |
[INFO] [stderr] 348 | / impl<T> HashSet<T> where T: Hash + Eq {
[INFO] [stderr] 349 | |
[INFO] [stderr] 350 | |     #[inline]
[INFO] [stderr] 351 | |     pub fn new() -> HashSet<T> {
[INFO] [stderr] ...   |
[INFO] [stderr] 401 | |     pub fn is_superset(&self, other: &HashSet<T>) -> bool { other.is_subset(self) }
[INFO] [stderr] 402 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `HashSet<T>`
[INFO] [stderr]    --> src/lib.rs:351:5
[INFO] [stderr]     |
[INFO] [stderr] 351 | /     pub fn new() -> HashSet<T> {
[INFO] [stderr] 352 | |         HashSet { map: HashMap::new() }
[INFO] [stderr] 353 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 348 | impl Default for HashSet<T> {
[INFO] [stderr] 349 |     fn default() -> Self {
[INFO] [stderr] 350 |         Self::new()
[INFO] [stderr] 351 |     }
[INFO] [stderr] 352 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:348:9
[INFO] [stderr]     |
[INFO] [stderr] 348 | impl<T> HashSet<T> where T: Hash + Eq {
[INFO] [stderr]     |         ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 348 | impl<T, S: ::std::hash::BuildHasher> HashSet<T, S> where T: Hash + Eq {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/lib.rs:357:9
[INFO] [stderr]     |
[INFO] [stderr] 357 | /         match self.map.insert(v, ()) {
[INFO] [stderr] 358 | |             Some(_) => false,
[INFO] [stderr] 359 | |             None    => true,
[INFO] [stderr] 360 | |         }
[INFO] [stderr]     | |_________^ help: try this: `self.map.insert(v, ()).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:381:13
[INFO] [stderr]     |
[INFO] [stderr] 381 | /             match *elt {
[INFO] [stderr] 382 | |                 Entry::Full(ref k,_,_) => { if other.contains(k) { return false; } },
[INFO] [stderr] 383 | |                 _ => { },
[INFO] [stderr] 384 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Entry::Full(ref k,_,_) = *elt { if other.contains(k) { return false; } }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:392:13
[INFO] [stderr]     |
[INFO] [stderr] 392 | /             match *elt {
[INFO] [stderr] 393 | |                 Entry::Full(ref k,_,_) => { if !other.contains(k) { return false; } },
[INFO] [stderr] 394 | |                 _ => { },
[INFO] [stderr] 395 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Entry::Full(ref k,_,_) = *elt { if !other.contains(k) { return false; } }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.80s
[INFO] running `"docker" "inspect" "cf3f3f0b91647140ccfb198aeec9174b6ee166d1f4686152f5b97364d8a39a27"`
[INFO] running `"docker" "rm" "-f" "cf3f3f0b91647140ccfb198aeec9174b6ee166d1f4686152f5b97364d8a39a27"`
[INFO] [stdout] cf3f3f0b91647140ccfb198aeec9174b6ee166d1f4686152f5b97364d8a39a27